From c9644a3d6fa880cb443ad68e083180785f790954 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Tue, 2 Feb 2021 18:37:57 -0800 Subject: [PATCH 1/3] Only sign when in release branch --- azure-pipelines.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 3d7c13238..9b4f3ec41 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -12,7 +12,9 @@ pool: variables: ${{ if not(startswith(variables['Build.SourceBranchName'], 'release' )) }}: buildNumberTemp: $(Build.BuildNumber) + isReleaseTemp: true buildNumber: $[variables.buildNumberTemp] + isRelease: $[variables.isReleaseTemp] solution: '**/*.sln' buildPlatform: 'Any CPU' buildConfiguration: 'Release' @@ -38,6 +40,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'Sdk: ESRP CodeSigning - Authenticode' + condition: eq(variables.isRelease, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'sdk\sdk\bin\Release' @@ -69,6 +72,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'MetadataLoader: ESRP CodeSigning - Authenticode' + condition: eq(variables.isRelease, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'sdk\FunctionMetadataLoaderExtension\bin\Release' @@ -100,6 +104,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'DotnetWorker: ESRP CodeSigning - Authenticode' + condition: eq(variables.isRelease, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'src\DotNetWorker\bin\Release' @@ -130,6 +135,7 @@ steps: ] - task: DeleteFiles@1 displayName: 'Delete CodeSignSummary files' + condition: eq(variables.isRelease, true) inputs: contents: '**\CodeSignSummary-*.md' @@ -145,6 +151,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'ESRP CodeSigning: Nupkg' + condition: eq(variables.isRelease, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'packages' @@ -169,6 +176,7 @@ steps: ] - task: DeleteFiles@1 displayName: 'Delete CodeSignSummary files' + condition: eq(variables.isRelease, true) inputs: contents: '**\CodeSignSummary-*.md' From 534f9b4586943f3cbb5cfc8e1dc12f74d5ecc748 Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Tue, 2 Feb 2021 18:54:41 -0800 Subject: [PATCH 2/3] fix: reverse conditional --- azure-pipelines.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 9b4f3ec41..79f265d42 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -12,9 +12,9 @@ pool: variables: ${{ if not(startswith(variables['Build.SourceBranchName'], 'release' )) }}: buildNumberTemp: $(Build.BuildNumber) - isReleaseTemp: true + isDevBuildTemp: true buildNumber: $[variables.buildNumberTemp] - isRelease: $[variables.isReleaseTemp] + isDevBuild: $[variables.isDevBuildTemp] solution: '**/*.sln' buildPlatform: 'Any CPU' buildConfiguration: 'Release' @@ -40,7 +40,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'Sdk: ESRP CodeSigning - Authenticode' - condition: eq(variables.isRelease, true) + condition: ne(variables.isDevBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'sdk\sdk\bin\Release' @@ -72,7 +72,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'MetadataLoader: ESRP CodeSigning - Authenticode' - condition: eq(variables.isRelease, true) + condition: ne(variables.isDevBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'sdk\FunctionMetadataLoaderExtension\bin\Release' @@ -104,7 +104,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'DotnetWorker: ESRP CodeSigning - Authenticode' - condition: eq(variables.isRelease, true) + condition: ne(variables.isDevBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'src\DotNetWorker\bin\Release' @@ -135,7 +135,7 @@ steps: ] - task: DeleteFiles@1 displayName: 'Delete CodeSignSummary files' - condition: eq(variables.isRelease, true) + condition: ne(variables.isDevBuild, true) inputs: contents: '**\CodeSignSummary-*.md' @@ -151,7 +151,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'ESRP CodeSigning: Nupkg' - condition: eq(variables.isRelease, true) + condition: ne(variables.isDevBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'packages' @@ -176,7 +176,7 @@ steps: ] - task: DeleteFiles@1 displayName: 'Delete CodeSignSummary files' - condition: eq(variables.isRelease, true) + condition: ne(variables.isDevBuild, true) inputs: contents: '**\CodeSignSummary-*.md' From c1739e7067b2b1b4c3accf2dde27342f04137edb Mon Sep 17 00:00:00 2001 From: Ankit Kumar Date: Wed, 3 Feb 2021 11:24:56 -0800 Subject: [PATCH 3/3] Update azure-pipelines.yml --- azure-pipelines.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 79f265d42..2bd09b5fe 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -12,9 +12,10 @@ pool: variables: ${{ if not(startswith(variables['Build.SourceBranchName'], 'release' )) }}: buildNumberTemp: $(Build.BuildNumber) - isDevBuildTemp: true + ${{ if startswith(variables['Build.SourceBranchName'], 'release' ) }}: + isReleaseBuildTemp: true buildNumber: $[variables.buildNumberTemp] - isDevBuild: $[variables.isDevBuildTemp] + isReleaseBuild: $[variables.isReleaseBuildTemp] solution: '**/*.sln' buildPlatform: 'Any CPU' buildConfiguration: 'Release' @@ -40,7 +41,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'Sdk: ESRP CodeSigning - Authenticode' - condition: ne(variables.isDevBuild, true) + condition: eq(variables.isReleaseBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'sdk\sdk\bin\Release' @@ -72,7 +73,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'MetadataLoader: ESRP CodeSigning - Authenticode' - condition: ne(variables.isDevBuild, true) + condition: eq(variables.isReleaseBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'sdk\FunctionMetadataLoaderExtension\bin\Release' @@ -104,7 +105,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'DotnetWorker: ESRP CodeSigning - Authenticode' - condition: ne(variables.isDevBuild, true) + condition: eq(variables.isReleaseBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'src\DotNetWorker\bin\Release' @@ -135,7 +136,7 @@ steps: ] - task: DeleteFiles@1 displayName: 'Delete CodeSignSummary files' - condition: ne(variables.isDevBuild, true) + condition: eq(variables.isReleaseBuild, true) inputs: contents: '**\CodeSignSummary-*.md' @@ -151,7 +152,7 @@ steps: - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 displayName: 'ESRP CodeSigning: Nupkg' - condition: ne(variables.isDevBuild, true) + condition: eq(variables.isReleaseBuild, true) inputs: ConnectedServiceName: 'ESRP Service' FolderPath: 'packages' @@ -176,7 +177,7 @@ steps: ] - task: DeleteFiles@1 displayName: 'Delete CodeSignSummary files' - condition: ne(variables.isDevBuild, true) + condition: eq(variables.isReleaseBuild, true) inputs: contents: '**\CodeSignSummary-*.md'