Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update appservice.bicep with App Insights env var #4491

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pamelafox
Copy link
Member

Per https://learn.microsoft.com/en-us/azure/azure-monitor/app/codeless-app-service?tabs=python#automate-monitoring , an additional environment variable is required for application monitoring in App Service.

I'm adding the same var to azure-search-openai-demo in this PR:
https://github.com/Azure-Samples/azure-search-openai-demo/pull/2083/files
And testing the deploy now.

@vhvb1989
Copy link
Member

Thanks @pamelafox
I think we are not taking any more changes to bicep core modules as we are almost there with AVMs here: #3976

common/infra/bicep/app/web-appservice.bicep is becoming: /web-appservice-avm.bicep here: https://github.com/Azure/azure-dev/pull/3976/files#diff-c1aa701cf6c1c9590e75f3b45869a2b31013a8435ceac00fe13da4778bc37bb8R1

@pamelafox
Copy link
Member Author

Okay I'll comment on that PR. I did a quick look through avm source code for the string and didnt see it, but maybe the modules are in multiple repos.

@@ -92,6 +92,7 @@ module configAppSettings 'appservice-appsettings.bicep' = {
{
SCM_DO_BUILD_DURING_DEPLOYMENT: string(scmDoBuildDuringDeployment)
ENABLE_ORYX_BUILD: string(enableOryxBuild)
ApplicationInsightsAgent_EXTENSION_VERSION: contains(kind, 'linux') ? '~3' : '~2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be screaming caps to match env var naming convention.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pamelafox
Copy link
Member Author

FYI, I haven't gotten this to successfully deploy yet, and apparently its not 3.12 compatible yet, only 3.11, so maybe its not ready for primetime. I'm working with the eng team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants