This repository was archived by the owner on Jan 28, 2022. It is now read-only.
DevContainer move to single dockerfile from compose #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonTheDeveloper
suggested changes
Nov 1, 2019
Contributor
Azadehkhojandi
left a comment
Azadehkhojandi
left a comment
There was a problem hiding this comment.
Thanks for taking time and sending pr, I really appreciate it. looking forward to meeting you in person at one week and working with you.
lawrencegripper
commented
Nov 5, 2019
Contributor
Author
lawrencegripper
left a comment
lawrencegripper
left a comment
There was a problem hiding this comment.
Hi,
I've been playing more and added a few more bits.
- Caching the
/go/pkgfolder into a docker volume so builds are quicker when after restarting the container as go mod packages are presisted - Caching the
vscode-serverinto a docker volume so startup is quicker as extensions aren't re-installed each time. - Persist the container's bash history in a docker volume so between sessions the command history is saved (this has been super useful for my dev flow)
- Add in missing
.envfile mounting
Contributor
Author
|
@Azadehkhojandi Thanks for the review, I've fixed those ones up now. Sorry for the delayed response my daughter has been unwell so I've been away. |
Azadehkhojandi
previously approved these changes
Dec 3, 2019
lawrencegripper
force-pushed
the
lg/devcontainerlinux
branch
from
fcebad0 to
1fd82ba
Compare
lawrencegripper
force-pushed
the
lg/devcontainerlinux
branch
from
1fd82ba to
c2a9e84
Compare
JasonTheDeveloper
approved these changes
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a quick set of tweaks to make the devcontainer a bit more friendly and easy to get started with on different platforms (linux, mac etc).
Some of them are quite opinionated so feel free to push back on changes if they don't fit general workflow the team is currently using.
Changes