ReadThroughputAsync: Adds XML comment to Database.ReadThroughputAsync definition #3496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hput and null as request options
…rovisionedThroughput
…oughput' of https://github.com/Azure/azure-cosmos-dotnet-v3 into users/nalutripician/ReadThroughputAsyncNoProvisionedThroughput
NaluTripician
commented
Oct 10, 2022
ealsur
reviewed
Oct 10, 2022
ealsur
requested changes
Oct 10, 2022
Member
ealsur
left a comment
ealsur
left a comment
There was a problem hiding this comment.
Let's think about the potential options that would not generate breaking changes
ealsur
reviewed
Oct 18, 2022
Co-authored-by: Matias Quaranta <[email protected]>
NaluTripician
requested review from
FabianMeiswinkel,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
ealsur
reviewed
Oct 19, 2022
ealsur
reviewed
Oct 19, 2022
ealsur
reviewed
Oct 19, 2022
ealsur
reviewed
Oct 19, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosThroughputTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Oct 19, 2022
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosThroughputTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Matias Quaranta <[email protected]>
ealsur
reviewed
Oct 19, 2022
ealsur
reviewed
Oct 19, 2022
ealsur
reviewed
Oct 19, 2022
Microsoft.Azure.Cosmos/src/Resource/Database/DatabaseInlineCore.cs
Outdated
Show resolved
Hide resolved
ealsur
approved these changes
Oct 21, 2022
Member
ealsur
left a comment
ealsur
left a comment
There was a problem hiding this comment.
Please update the PR title reflecting what the PR now has
NaluTripician
changed the title
…rovisionedThroughput
ealsur
deleted the
users/nalutripician/ReadThroughputAsyncNoProvisionedThroughput
branch
Contributor
|
@NaluTripician @ealsur would have been good to remove the following remark from that API documentation to reduce confusion along with adding the exception details: /// |
Member
|
@abhijitpai Missed it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The
database.ReadThroughputAsyncoverload that takesRequestOptionsaCosmosExceptionwhen the database doesn't have throughput provisioned. Updated XML comment to describe this error and why it occurs.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #2959