Skip to content

Commit 98e3af6

Browse files
committed
Removing SecondaryNICInfor fro EPInfo.
1 parent b2b54dd commit 98e3af6

File tree

2 files changed

+13
-22
lines changed

2 files changed

+13
-22
lines changed

network/endpoint.go

-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ type EndpointInfo struct {
9393
SkipDefaultRoutes bool
9494
HNSEndpointID string
9595
HostIfName string
96-
SecondaryInterfaces map[string]*InterfaceInfo
9796
}
9897

9998
// RouteInfo contains information about an IP route.

network/manager.go

+13-21
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ type EndpointClient interface {
7171

7272
// NetworkManager manages the set of container networking resources.
7373
type networkManager struct {
74-
StatelessCniMode bool
74+
statelessCniMode bool
7575
CnsClient *cnsclient.Client
7676
Version string
7777
TimeStamp time.Time
@@ -150,7 +150,7 @@ func (nm *networkManager) Uninitialize() {
150150

151151
// SetStatelessCNIMode enable the statelessCNI falg and inititlizes a CNSClient
152152
func (nm *networkManager) SetStatelessCNIMode() error {
153-
nm.StatelessCniMode = true
153+
nm.statelessCniMode = true
154154
// Create CNS client
155155
client, err := cnsclient.New(cnsBaseURL, cnsReqTimeout)
156156
if err != nil {
@@ -162,7 +162,7 @@ func (nm *networkManager) SetStatelessCNIMode() error {
162162

163163
// IsStatelessCNIMode checks if the Stateless CNI mode has been enabled or not
164164
func (nm *networkManager) IsStatelessCNIMode() bool {
165-
return nm.StatelessCniMode
165+
return nm.statelessCniMode
166166
}
167167

168168
// Restore reads network manager state from persistent store.
@@ -500,7 +500,6 @@ func (nm *networkManager) DeleteEndpointState(networkID string, epInfo *Endpoint
500500
EnableSnatOnHost: false,
501501
EnableMultitenancy: false,
502502
NetworkContainerID: epInfo.Id,
503-
SecondaryInterfaces: epInfo.SecondaryInterfaces,
504503
}
505504
logger.Info("Deleting endpoint with", zap.String("Endpoint Info: ", epInfo.PrettyString()), zap.String("HNISID : ", ep.HnsId))
506505
return nw.deleteEndpointImpl(netlink.NewNetlink(), platform.NewExecClient(logger), nil, nil, nil, nil, ep)
@@ -690,30 +689,23 @@ func (nm *networkManager) GetEndpointID(containerID, ifName string) string {
690689

691690
func cnsEndpointInfotoCNIEpInfo(endpointInfo restserver.EndpointInfo, endpointID string) *EndpointInfo {
692691
epInfo := &EndpointInfo{
693-
Id: endpointID,
694-
IfIndex: EndpointIfIndex, // Azure CNI supports only one interface
695-
ContainerID: endpointID,
696-
PODName: endpointInfo.PodName,
697-
PODNameSpace: endpointInfo.PodNamespace,
698-
NetworkContainerID: endpointID,
699-
SecondaryInterfaces: make(map[string]*InterfaceInfo),
700-
}
701-
// filling out the InfraNIC from the state
692+
Id: endpointID,
693+
IfIndex: EndpointIfIndex, // Azure CNI supports only one interface
694+
ContainerID: endpointID,
695+
PODName: endpointInfo.PodName,
696+
PODNameSpace: endpointInfo.PodNamespace,
697+
NetworkContainerID: endpointID,
698+
}
699+
702700
for ifName, ipInfo := range endpointInfo.IfnameToIPMap {
703-
if ifName == InfraInterfaceName {
701+
if ifName == InfraInterfaceName { // filling out the InfraNIC from the state
704702
epInfo.IPAddresses = ipInfo.IPv4
705703
epInfo.IPAddresses = append(epInfo.IPAddresses, ipInfo.IPv6...)
706704
epInfo.IfName = ifName
707705
epInfo.HostIfName = ipInfo.HostVethName
708706
epInfo.HNSEndpointID = ipInfo.HnsEndpointID
709-
} else { // filling out the SecondaryNICs from the state
710-
interfaceInfo := &InterfaceInfo{
711-
Name: ifName,
712-
IPConfigs: generateIPConfigfromState(ipInfo),
713-
NICType: ipInfo.NICType,
714-
}
715-
epInfo.SecondaryInterfaces[ifName] = interfaceInfo
716707
}
708+
// TODO: filling out the SecondaryNICs from the state for Swift 2.0
717709
}
718710
return epInfo
719711
}

0 commit comments

Comments
 (0)