[Keyvault] BREAKING CHANGE: `az keyvault secret/certificate`: Migrate to track2 SDK, breaking changes to service response #26242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

calvinhzy merged 72 commits into Azure:dev from calvinhzy:keyvault-migrate-track2

May 17, 2023

src/azure-cli-core/azure/cli/core/profiles/_shared.py

-Original file line number
+Diff line change
@@ Expand Up @@
         MGMT_MONITOR = ('azure.mgmt.monitor', 'MonitorManagementClient')
         MGMT_MSI = ('azure.mgmt.msi', 'ManagedServiceIdentityClient')
         DATA_KEYVAULT = ('azure.keyvault', 'KeyVaultClient')
+        DATA_KEYVAULT_CERTIFICATES = ('azure.keyvault.certificates', 'CertificateClient')
         DATA_KEYVAULT_KEYS = ('azure.keyvault.keys', 'KeyClient')
+        DATA_KEYVAULT_SECRETS = ('azure.keyvault.secrets', 'SecretClient')
         DATA_PRIVATE_KEYVAULT = ('azure.cli.command_modules.keyvault.vendored_sdks.azure_keyvault_t1', 'KeyVaultClient')
         DATA_KEYVAULT_ADMINISTRATION_BACKUP = ('azure.keyvault.administration', 'KeyVaultBackupClient')
         DATA_KEYVAULT_ADMINISTRATION_ACCESS_CONTROL = ('azure.keyvault.administration', 'KeyVaultAccessControlClient')
@@ Expand Down Expand Up / @@ -199,7 +201,9 @@ def default_api_version(self): @@
             }),
             # The order does make things different.
             # Please keep ResourceType.DATA_KEYVAULT_KEYS before ResourceType.DATA_KEYVAULT
+            ResourceType.DATA_KEYVAULT_CERTIFICATES: None,
             ResourceType.DATA_KEYVAULT_KEYS: None,
+            ResourceType.DATA_KEYVAULT_SECRETS: None,
             ResourceType.DATA_KEYVAULT_ADMINISTRATION_SETTING: None,
             ResourceType.DATA_KEYVAULT: '7.0',
             ResourceType.DATA_PRIVATE_KEYVAULT: '7.2',
@@ Expand Down Expand Up / @@ -293,7 +297,9 @@ def default_api_version(self): @@
             }),
             # The order does make things different.
             # Please keep ResourceType.DATA_KEYVAULT_KEYS before ResourceType.DATA_KEYVAULT
+            ResourceType.DATA_KEYVAULT_CERTIFICATES: None,
             ResourceType.DATA_KEYVAULT_KEYS: None,
+            ResourceType.DATA_KEYVAULT_SECRETS: None,
             ResourceType.DATA_KEYVAULT: '2016-10-01',
             ResourceType.DATA_STORAGE: '2018-11-09',
             ResourceType.DATA_STORAGE_BLOB: '2019-07-07',
@@ Expand Down Expand Up / @@ -338,7 +344,9 @@ def default_api_version(self): @@
             }),
             # The order does make things different.
             # Please keep ResourceType.DATA_KEYVAULT_KEYS before ResourceType.DATA_KEYVAULT
+            ResourceType.DATA_KEYVAULT_CERTIFICATES: None,
             ResourceType.DATA_KEYVAULT_KEYS: None,
+            ResourceType.DATA_KEYVAULT_SECRETS: None,
             ResourceType.DATA_KEYVAULT: '2016-10-01',
             ResourceType.DATA_STORAGE: '2017-11-09',
             ResourceType.DATA_STORAGE_BLOB: '2017-11-09',
@@ Expand Down Expand Up / @@ -375,7 +383,9 @@ def default_api_version(self): @@
             }),
             # The order does make things different.
             # Please keep ResourceType.DATA_KEYVAULT_KEYS before ResourceType.DATA_KEYVAULT
+            ResourceType.DATA_KEYVAULT_CERTIFICATES: None,
             ResourceType.DATA_KEYVAULT_KEYS: None,
+            ResourceType.DATA_KEYVAULT_SECRETS: None,
             ResourceType.DATA_KEYVAULT: '2016-10-01',
             ResourceType.DATA_STORAGE: '2017-04-17',
             ResourceType.DATA_STORAGE_BLOB: '2017-04-17',
@@ Expand Down Expand Up / @@ -404,7 +414,9 @@ def default_api_version(self): @@
             }),
             # The order does make things different.
             # Please keep ResourceType.DATA_KEYVAULT_KEYS before ResourceType.DATA_KEYVAULT
+            ResourceType.DATA_KEYVAULT_CERTIFICATES: None,
             ResourceType.DATA_KEYVAULT_KEYS: None,
+            ResourceType.DATA_KEYVAULT_SECRETS: None,
             ResourceType.DATA_KEYVAULT: '2016-10-01',
             ResourceType.DATA_STORAGE: '2015-04-05',
             ResourceType.DATA_STORAGE_BLOB: '2015-04-05',
@@ Expand Down @@

src/azure-cli-testsdk/azure/cli/testsdk/preparers.py

-Original file line number
+Diff line change
@@ Expand Up / @@ -176,13 +176,15 @@ def _get_resource_group(self, **kwargs): @@
     class KeyVaultPreparer(NoTrafficRecordingPreparer, SingleValueReplacer):
         def __init__(self, name_prefix='clitest', sku='standard', location='westus',
                      parameter_name='key_vault', resource_group_parameter_name='resource_group', skip_delete=False,
+                     skip_purge=False,
                      dev_setting_name='AZURE_CLI_TEST_DEV_KEY_VAULT_NAME', key='kv', name_len=24, additional_params=None):
             super(KeyVaultPreparer, self).__init__(name_prefix, name_len)
             self.cli_ctx = get_dummy_cli()
             self.location = location
             self.sku = sku
             self.resource_group_parameter_name = resource_group_parameter_name
             self.skip_delete = skip_delete
+            self.skip_purge = skip_purge
             self.parameter_name = parameter_name
             self.key = key
             self.additional_params = additional_params
@@ Expand All / @@ -208,6 +210,8 @@ def remove_resource(self, name, **kwargs): @@
                 group = self._get_resource_group(**kwargs)
                 self.live_only_execute(self.cli_ctx, 'az keyvault delete -n {} -g {}'.format(name, group))
                 from azure.core.exceptions import HttpResponseError
+                if self.skip_purge:
+                    return
                 try:
                     self.live_only_execute(self.cli_ctx, 'az keyvault purge -n {} -l {}'.format(name, self.location))
                 except HttpResponseError:
@@ Expand Down @@

...zure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_image_import.yaml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -18,7 +18,7 @@ interactions:
  
          accept-language:

          - en-US

        method: GET

        uri: https://cliimportkv73021.vault.azure.net/secrets/SPusername/?api-version=7.0

        uri: https://cliimportkv73021.vault.azure.net/secrets/SPusername/?api-version=7.4

      response:

        body:

          string: '{"error":{"code":"Unauthorized","message":"AKV10000: Request is missing

    @@ -71,7 +71,7 @@ interactions:
  
          accept-language:

          - en-US

        method: GET

        uri: https://cliimportkv73021.vault.azure.net/secrets/SPusername/?api-version=7.0

        uri: https://cliimportkv73021.vault.azure.net/secrets/SPusername/?api-version=7.4

      response:

        body:

          string: '{"value":"48f3eac9-fc0f-4a89-8ceb-1bcf16318a46","id":"https://cliimportkv73021.vault.azure.net/secrets/SPusername/a10cceb994ca428d8e8489358473b82c","attributes":{"enabled":true,"created":1627689801,"updated":1627689801,"recoveryLevel":"Recoverable+Purgeable"}}'

    @@ -118,7 +118,7 @@ interactions:
  
          accept-language:

          - en-US

        method: GET

        uri: https://cliimportkv73021.vault.azure.net/secrets/SPpassword/?api-version=7.0

        uri: https://cliimportkv73021.vault.azure.net/secrets/SPpassword/?api-version=7.4

      response:

        body:

          string: '{"value":"93qegDf7Q.OQ~-lttx6TQp7Xeb_7cD8fIP","id":"https://cliimportkv73021.vault.azure.net/secrets/SPpassword/a444beb8c32644b5a9a44448a192b12b","attributes":{"enabled":true,"created":1627689824,"updated":1627689824,"recoveryLevel":"Recoverable+Purgeable"}}'

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keyvault] BREAKING CHANGE: `az keyvault secret/certificate`: Migrate to track2 SDK, breaking changes to service response #26242

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

[Keyvault] BREAKING CHANGE: az keyvault secret/certificate: Migrate to track2 SDK, breaking changes to service response #26242

Uh oh!

[Keyvault] BREAKING CHANGE: az keyvault secret/certificate: Migrate to track2 SDK, breaking changes to service response #26242

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

[Keyvault] BREAKING CHANGE: `az keyvault secret/certificate`: Migrate to track2 SDK, breaking changes to service response #26242

[Keyvault] BREAKING CHANGE: `az keyvault secret/certificate`: Migrate to track2 SDK, breaking changes to service response #26242