From 77c99fcc017237b467b26d95e225c59519067af6 Mon Sep 17 00:00:00 2001 From: jiasli <4003950+jiasli@users.noreply.github.com> Date: Thu, 2 Feb 2023 15:41:53 +0800 Subject: [PATCH 1/2] feedback --- src/azure-cli/azure/cli/command_modules/feedback/custom.py | 5 ++--- .../command_modules/feedback/tests/latest/test_feedback.py | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/azure-cli/azure/cli/command_modules/feedback/custom.py b/src/azure-cli/azure/cli/command_modules/feedback/custom.py index f3459f275e9..c5974fc5af7 100644 --- a/src/azure-cli/azure/cli/command_modules/feedback/custom.py +++ b/src/azure-cli/azure/cli/command_modules/feedback/custom.py @@ -68,7 +68,8 @@ **Errors:** ``` -{errors_string} +Insert here the error message you have received. Make sure to remove all sensitive information, +such as user name, password, credential, subscription ID, etc. ``` ## To Reproduce: @@ -352,7 +353,6 @@ def _build_issue_info_tup(command_log_file=None): format_dict["command_name"] = command_name if command_log_file.command_data_dict: - errors_list = command_log_file.command_data_dict.get("errors", []) executed_command = command_log_file.command_data_dict.get("command_args", "") extension_name = command_log_file.command_data_dict.get("extension_name", "") extension_version = command_log_file.command_data_dict.get("extension_version", "") @@ -363,7 +363,6 @@ def _build_issue_info_tup(command_log_file=None): is_ext = True ext_name = extension_name - format_dict["errors_string"] = ''.join(errors_list) format_dict["executed_command"] = "az " + executed_command if executed_command else executed_command format_dict["command_name"] += extension_info diff --git a/src/azure-cli/azure/cli/command_modules/feedback/tests/latest/test_feedback.py b/src/azure-cli/azure/cli/command_modules/feedback/tests/latest/test_feedback.py index 5885513171e..09336861e41 100644 --- a/src/azure-cli/azure/cli/command_modules/feedback/tests/latest/test_feedback.py +++ b/src/azure-cli/azure/cli/command_modules/feedback/tests/latest/test_feedback.py @@ -182,7 +182,6 @@ def _helper_test_build_issue_info(self): for log_file, original_issue_body in items: self.assertTrue(log_file.get_command_name_str() in original_issue_body) self.assertTrue(log_file.command_data_dict["command_args"] in original_issue_body) - self.assertTrue(log_file.command_data_dict["errors"][0] in original_issue_body) @staticmethod def _ext_installed(ext): From 84ccd2ba77be34593134470a7bd99865288bc4c6 Mon Sep 17 00:00:00 2001 From: Jiashuo Li <4003950+jiasli@users.noreply.github.com> Date: Fri, 3 Feb 2023 10:16:02 +0800 Subject: [PATCH 2/2] Update src/azure-cli/azure/cli/command_modules/feedback/custom.py --- src/azure-cli/azure/cli/command_modules/feedback/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/azure-cli/azure/cli/command_modules/feedback/custom.py b/src/azure-cli/azure/cli/command_modules/feedback/custom.py index c5974fc5af7..7a41c8ba85e 100644 --- a/src/azure-cli/azure/cli/command_modules/feedback/custom.py +++ b/src/azure-cli/azure/cli/command_modules/feedback/custom.py @@ -68,7 +68,7 @@ **Errors:** ``` -Insert here the error message you have received. Make sure to remove all sensitive information, +Paste here the error message you have received. Make sure to remove all sensitive information, such as user name, password, credential, subscription ID, etc. ```