feat: add load-balancer-backend-pool-type to create and update api #5355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FumingZhang
reviewed
Sep 15, 2022
src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_abort.yaml
Outdated
Show resolved
Hide resolved
Collaborator
|
AKS |
Member
Author
|
It looks like the integration tests are failed because it hits the route table quota limit. |
FumingZhang
reviewed
Sep 16, 2022
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
nilo19
force-pushed
the
feat/ip-lb
branch
4 times, most recently
from
446b5b9 to
00c79ca
Compare
FumingZhang
reviewed
Sep 16, 2022
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
The PR looks good to me.
Please left a description about this change in HISTORY.rst under the Pending section if you don't want to release a new version immediately. Otherwise, please choose a new version number and also update VERSION in setup.py.
FumingZhang
approved these changes
Sep 16, 2022
Member
Author
|
@FumingZhang can we merge this? |
zhoxing-ms
approved these changes
Sep 23, 2022
Collaborator
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1870277&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.