[ Microsoft.SCVMM ] Requesting vmmserver credentials until non-empty #4863
Conversation
|
connectedvmware |
Co-authored-by: ZelinWang <[email protected]>
|
@zhoxing-ms , could you merge the PR if everything looks fine? |
src/scvmm/HISTORY.rst
Outdated
| 0.1.5 | ||
| +++ | ||
| * Requesting VMMServer credentials from the user until they are non-empty. | ||
| * Removing default value for port. Asking for the input. If input is empty, setting port to 8100. |
There was a problem hiding this comment.
Removing the default value will cause breaking change, right? If so, please add [BREAKING CHANGE] as the prefix
| * Removing default value for port. Asking for the input. If input is empty, setting port to 8100. | |
| * [BREAKING CHANGE] Removing default value for port. Asking for the input. If input is empty, setting port to 8100. |
src/scvmm/HISTORY.rst
Outdated
|
|
||
| 0.1.5 | ||
| +++ | ||
| * Requesting VMMServer credentials from the user until they are non-empty. | ||
| * Removing default value for port. Asking for the input. If input is empty, setting port to 8100. |
There was a problem hiding this comment.
In addition, the history notes of new version should be written at the top, history notes should be arranged from new to old from top to bottom
| while not creds['port']: | ||
| print('Please provide vmmserver port (Default: 8100): ', end='') | ||
| try: | ||
| creds['port'] = input() | ||
| if not creds['port']: | ||
| creds['port'] = DEFAULT_VMMSERVER_PORT | ||
| creds['port'] = int(creds['port']) | ||
| except ValueError: | ||
| print('Port must be a number, please try again') | ||
| creds['port'] = None |
There was a problem hiding this comment.
For the automation scenario, if the CLI script does not pass in the creds['port'] parameter, the process of CLI script will get stuck. Is this in line with expectations?
There was a problem hiding this comment.
Yes, this is in line with the expectations. We will add modify the command by adding the new param to our automation pipelines.
4 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.