Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@FumingZhang FumingZhang changed the title Add a live test pipeline for aks-preview PR check-in [AKS] Add a live test pipeline for aks-preview PR check-in Apr 23, 2021
@yungezz
Copy link
Member

yungezz commented Apr 23, 2021

hi @fengzhou-msft @qwordy could you pls help to have a look? thanks

@yungezz yungezz added AKS Service Attention This issue is responsible by Azure service team. and removed Service Attention This issue is responsible by Azure service team. labels Apr 23, 2021
@FumingZhang
Copy link
Member Author

Hello @zqingqing1 @gtracer , could you please help approve and merge this pr?

Copy link
Member

@zqingqing1 zqingqing1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andyliuliming andyliuliming removed the request for review from gtracer May 17, 2021 02:27
@fengzhou-msft fengzhou-msft merged commit 8989634 into Azure:master May 17, 2021
@FumingZhang FumingZhang deleted the new-aks-pipeline branch May 24, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants