Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMG: fix issue with dashboard json validation #8373

Merged
merged 4 commits into from
Jan 7, 2025
Merged

AMG: fix issue with dashboard json validation #8373

merged 4 commits into from
Jan 7, 2025
+4,490 −4,520

Conversation

ABZhang0
Copy link
Contributor

Related command

az grafana dashboard import

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Fixes #8299

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 17, 2024 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 17, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions GitHub Actions
Copy link

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Dec 17, 2024
@github-actions GitHub Actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions GitHub Actions
Copy link

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

Hi @ABZhang0,

The git hooks are available for the azure-cli-extensions repo. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@kairu-ms kairu-ms merged commit f739bdb into Azure:main Jan 7, 2025
24 of 25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jan 7, 2025

[Release] Update index.json for extension [ amg ] : https://dev.azure.com/msazure/One/_build/results?buildId=111853570&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@jsntcy jsntcy Awaiting requested review from jsntcy

Assignees

@AllyW AllyW

@kairu-ms kairu-ms

Labels
Auto-Assign Auto assign by bot extension/grafana az grafana
Projects
None yet
Milestone
January 2025 (2025-01-14)
Development

Successfully merging this pull request may close these issues.

Unable to import Grafana dashboard with Azure CLI extension
5 participants
@ABZhang0 @yonzhan @kairu-ms @azclibot @AllyW