[fleet] sdk version upgrade and fixed strings (#5413)

* match swagger summary

* upgrade sdk version to 2022-07-02-preview

* use snake style

* update tests

* new release version

* fix location help text

* fix test

Co-authored-by: Pankil Daru <[email protected]>

Author: pdaru

src/fleet/HISTORY.rst

@@ -5,4 +5,9 @@ Release History
 
 0.1.0
 ++++++
-* Initial release.
+* Initial release.
+
+0.1.1
+++++++
+* Upgrade SDK version to 2022-07-02-preview
+* Bug fixes

src/fleet/azext_fleet/__init__.py

@@ -15,7 +15,7 @@ def register_fleet_resource_type():
     register_resource_type(
         "latest",
         CUSTOM_MGMT_FLEET,
-        SDKProfile("2022-06-02-preview", {"container_services": "2017-07-01"}),
+        SDKProfile("2022-07-02-preview", {"container_services": "2017-07-01"}),
     )
 
 

src/fleet/azext_fleet/_help.py

@@ -14,7 +14,7 @@
 
 helps['fleet create'] = """
     type: command
-    short-summary: Create a new fleet.
+    short-summary: Creates or updates a Fleet.
     parameters:
         - name: --tags
           type: string
@@ -27,7 +27,7 @@
 
 helps['fleet update'] = """
     type: command
-    short-summary: Update an existing fleet.
+    short-summary: Patches a fleet resource.
     parameters:
         - name: --tags
           type: string
@@ -36,22 +36,22 @@
 
 helps['fleet show'] = """
     type: command
-    short-summary: Get an existing fleet.
+    short-summary: Gets a Fleet.
 """
 
 helps['fleet list'] = """
     type: command
-    short-summary: List fleet by resource group & subscription id.
+    short-summary: Lists fleets in the specified subscription and resource group.
 """
 
 helps['fleet delete'] = """
     type: command
-    short-summary: Delete an existing fleet.
+    short-summary: Deletes a Fleet.
 """
 
 helps['fleet get-credentials'] = """
     type: command
-    short-summary: List fleet kubeconfig credentials
+    short-summary: Lists the user credentials of a Fleet.
     parameters:
     - name: --overwrite-existing
       type: bool
@@ -74,7 +74,7 @@
 
 helps['fleet member create'] = """
     type: command
-    short-summary: Join member cluster to a fleet.
+    short-summary: Creates or updates a fleet member.
     parameters:
         - name: --member-cluster-id
           type: string
@@ -83,17 +83,17 @@
 
 helps['fleet member list'] = """
     type: command
-    short-summary: List member cluster(s) of a fleet.
+    short-summary: Lists the members of a fleet.
 """
 
 helps['fleet member show'] = """
     type: command
-    short-summary: Get member cluster of a fleet.
+    short-summary: Gets a Fleet member.
 """
 
 helps['fleet member delete'] = """
     type: command
-    short-summary: Remove member cluster from a fleet
+    short-summary: Deletes a fleet member.
 """
 
 helps['fleet member wait'] = """

src/fleet/azext_fleet/_params.py

@@ -19,7 +19,7 @@ def load_arguments(self, _):
 
     with self.argument_context('fleet') as c:
         c.argument('name', options_list=['--name', '-n'], help='Specify the fleet name.')
-        c.argument('location', get_location_type(self.cli_ctx), validator=get_default_location_from_resource_group, help='aaa')
+        c.argument('location', get_location_type(self.cli_ctx), validator=get_default_location_from_resource_group)
 
     with self.argument_context('fleet create') as c:
         c.argument('tags', tags_type)

src/fleet/azext_fleet/custom.py

@@ -23,12 +23,12 @@ def create_fleet(cmd,
                  location=None,
                  tags=None,
                  no_wait=False):
-    FleetHubProfile = cmd.get_models(
+    fleet_hub_profile_model = cmd.get_models(
         "FleetHubProfile",
         resource_type=CUSTOM_MGMT_FLEET,
         operation_group="fleets"
     )
-    Fleet = cmd.get_models(
+    fleet_model = cmd.get_models(
         "Fleet",
         resource_type=CUSTOM_MGMT_FLEET,
         operation_group="fleets"
@@ -42,11 +42,11 @@ def create_fleet(cmd,
         resource_group_part = re.sub('[^A-Za-z0-9-]', '', resource_group_name)[0:16]
         dns_name_prefix = f'{name_part}-{resource_group_part}-{subscription_id[0:6]}'
 
-    fleetHubProfile = FleetHubProfile(dns_prefix=dns_name_prefix)
-    fleet = Fleet(
+    fleet_hub_profile = fleet_hub_profile_model(dns_prefix=dns_name_prefix)
+    fleet = fleet_model(
         location=location,
         tags=tags,
-        hub_profile=fleetHubProfile
+        hub_profile=fleet_hub_profile
     )
 
     return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, name, fleet)
@@ -57,13 +57,13 @@ def update_fleet(cmd,
                  resource_group_name,
                  name,
                  tags=None):
-    FleetPatch = cmd.get_models(
+    fleet_patch_model = cmd.get_models(
         "FleetPatch",
         resource_type=CUSTOM_MGMT_FLEET,
         operation_group="fleets"
     )
-    fleetPatch = FleetPatch(tags=tags)
-    return client.update(resource_group_name, name, None, fleetPatch)
+    fleet_patch = fleet_patch_model(tags=tags)
+    return client.update(resource_group_name, name, None, fleet_patch)
 
 
 def show_fleet(cmd,  # pylint: disable=unused-argument
@@ -97,12 +97,12 @@ def get_credentials(cmd,  # pylint: disable=unused-argument
                         '~'), '.kube', 'config'),
                     overwrite_existing=False,
                     context_name=None):
-    credentialResults = client.list_credentials(resource_group_name, name)
-    if not credentialResults:
+    credential_results = client.list_credentials(resource_group_name, name)
+    if not credential_results:
         raise CLIError("No Kubernetes credentials found.")
 
     try:
-        kubeconfig = credentialResults.kubeconfigs[0].value.decode(
+        kubeconfig = credential_results.kubeconfigs[0].value.decode(
             encoding='UTF-8')
         print_or_merge_credentials(
             path, kubeconfig, overwrite_existing, context_name)
@@ -117,13 +117,13 @@ def create_fleet_member(cmd,
                         fleet_name,
                         member_cluster_id,
                         no_wait=False):
-    FleetMember = cmd.get_models(
+    fleet_member_model = cmd.get_models(
         "FleetMember",
         resource_type=CUSTOM_MGMT_FLEET,
         operation_group="fleet_members"
     )
-    fleetMember = FleetMember(cluster_resource_id=member_cluster_id)
-    return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, fleet_name, name, fleetMember)
+    fleet_member = fleet_member_model(cluster_resource_id=member_cluster_id)
+    return sdk_no_wait(no_wait, client.begin_create_or_update, resource_group_name, fleet_name, name, fleet_member)
 
 
 def list_fleet_member(cmd,  # pylint: disable=unused-argument