Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark objects as binary if specified as file #3714

Closed
iscai-msft opened this issue Dec 1, 2020 · 0 comments · Fixed by Azure/autorest.modelerfour#363
Closed

mark objects as binary if specified as file #3714

iscai-msft opened this issue Dec 1, 2020 · 0 comments · Fixed by Azure/autorest.modelerfour#363
Assignees
@daviwil @timotheeguerin
Labels
AutoRest v3 Related to AutoRest v3 Core P0 - Critical Critical Issue - blocking

Comments

@iscai-msft
Copy link
Contributor

iscai-msft commented Dec 1, 2020 •
edited
Loading

If someone marks something as a file, regardless of content type in consumes / produces, we should just mark it as binary.

Currently semi-blocking @tasherif-msft (there can be temp swagger changes / change the generated code, but ideally would be fixed in autorest)

m4 output:
image
@iscai-msft iscai-msft added P0 - Critical Critical Issue - blocking AutoRest v3 Related to AutoRest v3 Core labels Dec 1, 2020
@iscai-msft iscai-msft changed the title mark objects as binary if specified as. file mark objects as binary if specified as file Dec 1, 2020
@timotheeguerin timotheeguerin mentioned this issue Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviwil daviwil

@timotheeguerin timotheeguerin

Labels
AutoRest v3 Related to AutoRest v3 Core P0 - Critical Critical Issue - blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow binary files with json content type Azure/autorest.modelerfour
3 participants
@daviwil @timotheeguerin @iscai-msft