Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Documentation for readonly properties and don't send them over the wire #2545

Closed
mcardosos opened this issue Aug 18, 2017 · 2 comments
Closed

[Go] Documentation for readonly properties and don't send them over the wire #2545

mcardosos opened this issue Aug 18, 2017 · 2 comments
Assignees
@jhendrixMSFT
Labels
Go

Comments

@mcardosos
Copy link
Contributor

Thinking about this issue again Azure/go-autorest#112 . Now we don't check for nil readonly properties, but a little documentation for them wouldn't hurt. It would be cool to add a comment after their JSON tag on the models file, // read only.
@mcardosos mcardosos added the Go label Aug 18, 2017
@jhendrixMSFT jhendrixMSFT changed the title [Go] Documentation for readonly properties [Go] Documentation for readonly properties and don't send them over the wire Apr 11, 2019
@jhendrixMSFT
Copy link
Member

Upcoming RPaS will likely require that R/O properties are not sent across the wire. We should update codegen to include a comment and in the preparer nil out all R/O props.

@jhendrixMSFT jhendrixMSFT mentioned this issue Apr 15, 2019
Merged
@jhendrixMSFT
Copy link
Member

Fixed in 2.1.129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhendrixMSFT jhendrixMSFT

Labels
Go
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhendrixMSFT @mcardosos