Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip lint script and format script for mgmt package with modular generation #2649

Open
kazrael2119 opened this issue Jul 5, 2024 · 3 comments

Comments

@kazrael2119
Copy link
Contributor

Shall we update the lint script and the format script as echo skipped for mgmt package with modular generation?

@qiaozha
Copy link
Member

qiaozha commented Jul 9, 2024

@qiaozha
Copy link
Member

qiaozha commented Jul 9, 2024

If we choose to skip it, we will probably need to skip it for both data plane and mgmt plane as Modular will be used in data plane in the future as well.

@qiaozha
Copy link
Member

qiaozha commented Jul 10, 2024

Comments from @joheredi

  • Missing return type on function - We should fix
  • 'p' is already declared in the upper scope on line - Not sure where this happen need to look the code
  • _ prefixes. I think I will fix this in my current PR, I'm removing the _ and tracking internal files differently
  • ts-doc issues - We should fix
  • Don't use Function as a type - I think we'll have to ignore this
  • the file does not have a correct copyright header - We should fix
  • 'item' is never reassigned. Use 'const' instead - We should fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants