Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TCGC's Model Types #2410

Closed
Tracked by #606
iscai-msft opened this issue Apr 5, 2024 · 2 comments
Closed
Tracked by #606

Implement TCGC's Model Types #2410

iscai-msft opened this issue Apr 5, 2024 · 2 comments
Assignees

Comments

@iscai-msft
Copy link
Contributor

Language emitters should work to move entirely to TCGC's new ecosystem. I've created a separate issue if people want to first move to the SdkModelType and SdkEnumType. To access these types, you can access and on the type

@joheredi
Copy link
Member

joheredi commented Apr 24, 2024

The TypeScript emitter already consumes getAllModels which gives us access to SdkModelType and SdkEnumType

const allModels = getAllModels(dpgContext);
for (const model of allModels) {
getType(dpgContext, model.__raw!, { usage: model.usage as UsageFlags });
}

@lmazuel
Copy link
Member

lmazuel commented Jul 30, 2024

Was discussing with @lirenhe , closing this issue, as the primary purpose was to be sure getAllModels is called, which is the case. Please create a separate issue if you wish to track raw improvements.

@lmazuel lmazuel closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants