Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPG] Bandit ci check reporting issue in the _deserialize_xml method #2825

Closed
catalinaperalta opened this issue Sep 9, 2024 · 2 comments · Fixed by #2829
Closed

[DPG] Bandit ci check reporting issue in the _deserialize_xml method #2825

catalinaperalta opened this issue Sep 9, 2024 · 2 comments · Fixed by #2829
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.

Comments

@catalinaperalta
Copy link
Member

catalinaperalta commented Sep 9, 2024

The bandit check in ci reported an issue with the deserialize_xml method that we ship as part of the _model_base.py file. We should fix this asap:

Bandit reported issue:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=4120920&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=f3c2469e-6935-5949-b282-5aba94ff7e0d&l=653

Generated code with the issue:
https://github.com/Azure/azure-sdk-for-python/blob/d43e14e708bec677daa6d757ae2360e561c93a8d/sdk/healthinsights/azure-healthinsights-radiologyinsights/azure/healthinsights/radiologyinsights/_model_base.py#L1129-L1134

cc @iscai-msft @msyyc

@catalinaperalta catalinaperalta added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Sep 9, 2024
@catalinaperalta
Copy link
Member Author

This is blocking a Health Insights PR from getting merged in, we'd appreciate a fix that would unblock their PR. Could the emitter revert this change meanwhile we find a better design for this method?

@msyyc
Copy link
Member

msyyc commented Sep 10, 2024

fix PR #2829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants