Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eng] Fake warning about changelog in nightly pipeline #2669

Closed
msyyc opened this issue Jul 1, 2024 · 1 comment · Fixed by #2675
Closed

[eng] Fake warning about changelog in nightly pipeline #2669

msyyc opened this issue Jul 1, 2024 · 1 comment · Fixed by #2675
Assignees
Labels
engsys This issue is impacting the engineering system.

Comments

@msyyc msyyc added the engsys This issue is impacting the engineering system. label Jul 1, 2024
@tadelesh
Copy link
Member

tadelesh commented Jul 2, 2024

i think we could just remove this part:

const github = getOctokit(process.env.GITHUB_TOKEN ?? "");
const prs = await github.rest.pulls.list({
...context.repo,
head: `${context.repo.owner}:${branchName}`,
base: "main",
state: "open",
});
console.log(
"Found those prs",
prs.url,
prs.data.map((x) => x.head.ref),
);
const existing = prs.data[0];
if (existing) {
console.log("Existing, updating pr", existing.number);
await github.rest.pulls.update({
...context.repo,
pull_number: existing.number,
body: changeStatus,
});
} else {
await github.rest.pulls.create({
...context.repo,
title: "Release changes",
head: branchName,
base: "main",
body: changeStatus,
});
}
} else {
console.log("No changes to publish");
}
. The error is from create the pr or overwrite the pr.

@msyyc msyyc self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engsys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants