Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong return type for LRO delete of generated SDK with TypeSpec #2531

Closed
msyyc opened this issue Apr 18, 2024 · 2 comments
Closed

wrong return type for LRO delete of generated SDK with TypeSpec #2531

msyyc opened this issue Apr 18, 2024 · 2 comments
Assignees
@msyyc
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. mgmt This issue is related to a management-plane library.

Comments

@msyyc
Copy link
Member

msyyc commented Apr 18, 2024 •
edited
Loading

Here is Mgmt SDK azure-mgmt-deviceregistry generated from Typespec: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/deviceregistry/DeviceRegistry.Management
Its begin_delete shall return None instead of other type:

image
@msyyc msyyc added bug This issue requires a change to an existing behavior in the product in order to be resolved. mgmt This issue is related to a management-plane library. labels Apr 18, 2024
@msyyc msyyc self-assigned this Apr 18, 2024
@msyyc
Copy link
Member Author

msyyc commented Apr 18, 2024

TCGC use logicalResult returned by getLroMetadata. however it is not void :
image

This was referenced Apr 18, 2024
Closed
Open
@msyyc
Copy link
Member Author

msyyc commented Apr 29, 2024

fixed in latest emitter

@msyyc msyyc closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msyyc msyyc

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msyyc