Skip to content

Change the way that we recognize a package as preview #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 3 commits into from
Sep 25, 2020
Merged

Change the way that we recognize a package as preview #484

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76c5486
Change the way that we recognize a package as preview
ArcturusZhang Sep 15, 2020
099d243
Merge branch 'master' into flip-preview-check
jhendrixMSFT Sep 17, 2020
0cb0068
Add an additional check for the data plane preview swaggers
ArcturusZhang Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CodeGeneratorGo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ private void PreviewCheck(string folder)

private static bool IsPreviewPackage(string[] files)
{
// only evaluate composite builds if all swaggers are preview as we don't have a well-defined model for mixed preview/stable swaggers
return files.All(file => file.IndexOf(previewSubDir) >= 0);
// from the breaking change perspective, we should regard a composite package as a preview package when at least one of the swagger is preview, since preview swagger files may receive breaking changes frequently
return files.Any(file => file.IndexOf(previewSubDir) >= 0);
}
}
}