Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example generation for typespec #1399

Merged
merged 20 commits into from
Aug 1, 2024
Merged

example generation for typespec #1399

merged 20 commits into from
Aug 1, 2024

Conversation

tadelesh
Copy link
Member

resolve: #1358

basic design concept:

  1. add example in go code model
  2. map tcgc example model into go code model, do the mapping in the same code generator adapter
  3. use go code model to generate example files, do the generation in the same code generator processor
  4. TODO: need to migrate swagger go test generator logic, adapt swagger test modeler example model to go code model, but currently low priority.

@tadelesh tadelesh marked this pull request as draft July 29, 2024 10:30
@tadelesh tadelesh marked this pull request as ready for review July 30, 2024 04:01
@tadelesh tadelesh force-pushed the example_generation branch 2 times, most recently from 629cdb4 to 31985ab Compare July 31, 2024 15:23
@tadelesh
Copy link
Member Author

@jhendrixMSFT do you have further concern for this pr?

@jhendrixMSFT
Copy link
Member

I had a few questions that were never answered (see above).

@tadelesh
Copy link
Member Author

tadelesh commented Aug 1, 2024

I had a few questions that were never answered (see above).

oh, i just changed the code according to the comment and resolved the comment directly. added comment.

@tadelesh tadelesh merged commit 6c46701 into main Aug 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@lirenhe lirenhe Awaiting requested review from lirenhe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example generation should support TypeSpec
3 participants
@tadelesh @jhendrixMSFT @ArcturusZhang