Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should armId types be emitted as azcore/arm.ResourceID #1119

Open
jhendrixMSFT opened this issue Jan 23, 2024 · 4 comments
Open

should armId types be emitted as azcore/arm.ResourceID #1119

jhendrixMSFT opened this issue Jan 23, 2024 · 4 comments

Comments

@jhendrixMSFT
Copy link
Member

It's currently emitted as a string for back-compat with OpenAPI.
@jhendrixMSFT
Copy link
Member Author

@tadelesh do you know how the OpenAPI->tsp converted will handle converting arm-id?

@jhendrixMSFT
Copy link
Member Author

Related: #914

@tadelesh
Copy link
Member

tadelesh commented Feb 5, 2024 •
edited
Loading

For m4 "arm-id" type, converter will convert it to ResourceIdentifier

@jhendrixMSFT jhendrixMSFT changed the title tsp: should armId types be emitted as azcore/arm.ResourceID should armId types be emitted as azcore/arm.ResourceID Apr 26, 2024
@jhendrixMSFT
Copy link
Member Author

We could add a switch to generate using arm.ResourceID instead of *string. It has to be opt-in in order to not introduce breaking changes.

@jhendrixMSFT jhendrixMSFT mentioned this issue Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tadelesh @jhendrixMSFT