Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From non-pageable to pageable, the current operation will be removed when adding operationName #1060

Open
Alancere opened this issue Oct 19, 2023 · 3 comments
Assignees

Comments

@Alancere
Copy link
Member

Alancere commented Oct 19, 2023

CHANGELOG:
actual:

+	Function `*LocalRulestacksClient.ListAppIDs` has been removed
+	Function `*LocalRulestacksClient.ListCountries` has been removed
+	Function `*LocalRulestacksClient.ListPredefinedURLCategories` has been remove

expected:

- Operation `*LocalRulestacksClient.ListAppIDs` has supported pagination, use `*LocalRulestacksClient.NewListAppIDsPager` instead.
- Operation `*LocalRulestacksClient.ListCountries` has supported pagination, use `*LocalRulestacksClient.NewListCountriesPager` instead.
- Operation `*LocalRulestacksClient.ListPredefinedURLCategories` has supported pagination, use `*LocalRulestacksClient.NewListPredefinedURLCategoriesPager` instead.

Swagger definition: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/paloaltonetworks/resource-manager/PaloAltoNetworks.Cloudngfw/preview/2023-09-01-preview/PaloAltoNetworks.Cloudngfw.json#L3685

        "operationId": "LocalRulestacks_listCountries",
        "description": "List of countries for Rulestack",
        ..........................................
        "x-ms-pageable": {
          "nextLinkName": "nextLink",
          "operationName": "LocalRulestacks_listCountries"
        }
@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Oct 23, 2023

@Alancere while there is a codegen bug here, can you please confirm with the swagger owner to understand how this is supposed to work? E.g. the returned nextLink isn't used as a parameter to the operation so it's unclear how the returned nextLink is actually used.

@tadelesh
Copy link
Member

Explanation from Mike: Azure/autorest#4454 (comment)

@tadelesh
Copy link
Member

@Alancere please follow .NET's directive to unblock current release.
@jhendrixMSFT I believe the only thing needed for codegen is to raise an error is next operation is not correct instead of omit the generation. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants