get the value from literal #4903
Conversation
chunyu3
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
| if (contentTypeParameter.Type.Value as string) | ||
| mediaTypes.push(contentTypeParameter.Type.Value as string); |
There was a problem hiding this comment.
the as in typescript does not work in this way.
If this value is not undefined, even it is a number, this check is true.
We should do:
if (typeof contentTypeParameter.Type.Value === "string")
to check if the value is string.
Or if you just want to put in whatever value it has, we could just do mediaTypes.push without the if.
There was a problem hiding this comment.
Given the context in #4898
the abuse of as is the root cause of we are having null inside arrays, because as just skips the compiler type static check, and in runtime, it will just give anything into the list.
There was a problem hiding this comment.
#4898 is just a trigger of the issue. It passed Union as array with null value, but also when we handle InputLiteralType, we use the DefaultValue to get the value of an literal which is not correct, we should use InputLiteralType.Value.
I will close this PR, and file another PR in MGC emitter to resolve this.
Description
Fix #4898
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?