Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @clientName and @encodedName in dotnet CodeGen #4168

Closed
lirenhe opened this issue Jan 30, 2024 · 4 comments · Fixed by #4292
Closed

Support @clientName and @encodedName in dotnet CodeGen #4168

lirenhe opened this issue Jan 30, 2024 · 4 comments · Fixed by #4292
Assignees
Labels
DPG/RLC v2.1 Post Gallium work DPG v3 Version 3 of AutoRest C# generator.

Comments

@lirenhe
Copy link
Member

lirenhe commented Jan 30, 2024

As encodedName is introduced in 0.52 of TypeSpec.

model Widget {
  @key id: string;

  @encodedName("application/json", "WidgetWeight")
  weight: int32;
  
  color: "red" | "blue";
  @added(Versions.v2) name: string;
}

And @clientName is introduced in this PR https://github.com/Azure/typespec-azure/pull/127/files.

Please support them in the CodeGen.

@lirenhe lirenhe added v3 Version 3 of AutoRest C# generator. DPG labels Jan 30, 2024
@timotheeguerin
Copy link
Member

Tcgc abstract that away from you and should have just worked. Call getLibraryName

@lirenhe
Copy link
Member Author

lirenhe commented Feb 16, 2024

The adoption of TCGC is still in progress. #4185
We may implement that separately to unblock customer and then move to using TCGC. cc @m-nash

@timotheeguerin
Copy link
Member

any progress on this? are we still blocked on doing this migration?

@pshao25
Copy link
Member

pshao25 commented Feb 23, 2024

any progress on this? are we still blocked on doing this migration?

I'm blocked by #4212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPG/RLC v2.1 Post Gallium work DPG v3 Version 3 of AutoRest C# generator.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants