Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md uses incorrect variable names #5

Closed
ncthbrt opened this issue Nov 2, 2019 · 4 comments
Closed

README.md uses incorrect variable names #5

ncthbrt opened this issue Nov 2, 2019 · 4 comments

Comments

@ncthbrt
Copy link
Contributor

ncthbrt commented Nov 2, 2019

From the source code, resourceGroupName should actually be resource-group,
while clusterName should actually be cluster-name

@benc-uk
Copy link

benc-uk commented Nov 6, 2019

Just found the same :(

@ncthbrt
Copy link
Contributor Author

ncthbrt commented Nov 10, 2019

Pinging @DS-MS, who seems to be the main contributor to the this repo:
This Github action is likely numbered one of the first that Azure Aks users evaluating Github actions is going to try out, at least it was for me, so it kind of feels like a bad look that the example given doesn't actually work.

@thesattiraju
Copy link
Contributor

Thanks for the PR. I missed updating the readme with some last minute changes we did.

I've merged it. I'll update this in the marketplace as well.

@ncthbrt
Copy link
Contributor Author

ncthbrt commented Nov 10, 2019

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants