Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add dep check to CI/CD cycle #3702

Closed
tariq1890 opened this issue Aug 17, 2018 · 0 comments · Fixed by #3709
Closed

Add dep check to CI/CD cycle #3702

tariq1890 opened this issue Aug 17, 2018 · 0 comments · Fixed by #3709
Assignees
Labels

Comments

@tariq1890
Copy link
Contributor

tariq1890 commented Aug 17, 2018

As per the latest go-dev docker image, we are using the latest release of dep which includes the check feature.

dep check essentially ensures that vendor directories, source imports, and the toml files are in sync. It works fast and it is much better than calling dep ensure and performing a diff.

Possible scenarios when this could be useful

I) When a developer adds a new dependency but forgets to check in the vendor files.
ii) When a dev adds new imports and it only compiles in their local machine (because of their local gopath) but forgets to add the corresponding the dep stuff. dep check will detect this loss of sync immediately.
iii) Inconsistencies caused due to conflicting transitive dependencies.

If you are okay with this, I can proceed with the required changes, :). More details over here

golang/dep#1932

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant