Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1073 - Update Private DNS Zones for Private Link #1141

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix #1073 - Update Private DNS Zones for Private Link #1141

merged 3 commits into from
Nov 28, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Nov 28, 2022 •
edited
Loading

Overview/Summary

Fix #1073 - Update Private DNS Zones for Private Link

This PR fixes/adds/changes/removes

  1. Fix Review and update private DNS zones for private endpoint #1073

Breaking Changes

None

Testing Evidence

Linting and tests will suffice

Testing URLs

Azure Public

Deploy To Azure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@jtracey93 jtracey93 requested a review from a team as a code owner November 28, 2022 16:30
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Nov 28, 2022
@jtracey93 jtracey93 added enhancement New feature or request engineering engineering work and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 28, 2022
@jtracey93 jtracey93 temporarily deployed to csu-rw November 28, 2022 17:35 Inactive
krowlandson
krowlandson approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@krowlandson krowlandson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 364d1d1 into Azure:main Nov 28, 2022
@jtracey93 jtracey93 deleted the update-dns-zones branch November 28, 2022 18:38
@pkorolo pkorolo mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krowlandson krowlandson krowlandson approved these changes

Assignees
No one assigned
Labels
engineering engineering work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and update private DNS zones for private endpoint
2 participants
@jtracey93 @krowlandson