Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultValue for PrivateDnsZoneId parameters #1133

Merged
merged 7 commits into from
Nov 23, 2022
Merged

Add defaultValue for PrivateDnsZoneId parameters #1133

merged 7 commits into from
Nov 23, 2022

Conversation

krowlandson
Copy link
Contributor

Update formatting for consistency

Overview/Summary

This PR updates the `` policy initiative to ensure all PrivateDnsZoneId parameters have a `defaultValue` to allow in-place updates.

This PR fixes/adds/changes/removes

  1. Fixes the following error (discovered whilst testing in TF module):
    error
  2. Also updates formatting for consistency

Breaking Changes

none

Testing Evidence

The following shows Terraform successfully updating the initiative with the proposed updates:

success

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

Kevin Rowlandson added 2 commits November 23, 2022 21:46
@krowlandson krowlandson added the bug Something isn't working label Nov 23, 2022
@krowlandson krowlandson self-assigned this Nov 23, 2022
@github-actions github-actions bot requested a review from a team as a code owner November 23, 2022 21:54
@krowlandson krowlandson marked this pull request as draft November 23, 2022 21:57
@krowlandson krowlandson marked this pull request as ready for review November 23, 2022 21:57
@krowlandson krowlandson temporarily deployed to csu-rw November 23, 2022 21:57 Inactive
@krowlandson krowlandson merged commit f303a6e into Azure:main Nov 23, 2022
@krowlandson krowlandson deleted the patch-dns-policy branch November 23, 2022 22:27
@pkorolo pkorolo mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@krowlandson krowlandson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krowlandson @jtracey93