Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in policies DINE policies for DNSZoneGroup registration missing #725

Closed
pkorolo opened this issue Aug 3, 2021 · 9 comments · Fixed by #1109
Closed

Built-in policies DINE policies for DNSZoneGroup registration missing #725

pkorolo opened this issue Aug 3, 2021 · 9 comments · Fixed by #1109
Labels
engineering engineering work enhancement New feature or request policy

Comments

@pkorolo
Copy link
Contributor

pkorolo commented Aug 3, 2021

Describe the bug

Custom ESLZ "Configure Azure PaaS services to use private DNS zones" does not work as expected; tested with storage account, although it does configure the private endpoint with the appropriate private DNS zone, it does NOT also automatically create the respective A record for the private endpoint

Steps to reproduce

  1. Deploy ESLZ
  2. create a storage account with private endpoint, and do not pre-configure it with private DNS, since the policy is supposed to do so

Screenshots

@pkorolo pkorolo added the bug Something isn't working label Aug 3, 2021
@krnese krnese added the triage label Aug 3, 2021
@krnese
Copy link
Contributor

krnese commented Aug 10, 2021

@victorar /@daltondhcp - can you have a look at this when back? :-)

@jtracey93 jtracey93 added the waiting for response Maintainers have replied and are awaiting a response from the bug/issue/feature creator label Aug 26, 2021
@jtracey93
Copy link
Collaborator

@pkorolo - as per our chat this afternoon, could you please provide the information you shared with me this afternoon 👍

@pkorolo
Copy link
Contributor Author

pkorolo commented Aug 26, 2021

further details:

  1. the problematic Policy (actually Initiative) is the "Configure Azure PaaS services to use private DNS zones"; I tested only with storage accounts, not other PaaS Services, but the outcome was the following:
  • private endpoint is properly configured with the correct (respective) private DNS zone, BUT
  • the respective A record is never created within that DNS zone

In previous versions, where we relied on custom (per PaaS type) ESLZ Policies (afaik we do not have them anymore in the latest ESLZ), the functionality was 100% OK (both private endpoint configuration and A record creation was functioning properly)

@jtracey93 jtracey93 added engineering engineering work policy and removed waiting for response Maintainers have replied and are awaiting a response from the bug/issue/feature creator labels Aug 26, 2021
@jtracey93
Copy link
Collaborator

Looping in @sitarant, @krowlandson to this issue as I understand they have also seen similar when implementing these policies with the Terraform module.

@daltondhcp
Copy link
Contributor

daltondhcp commented Aug 26, 2021

@pkorolo - I have done some investigation and this is related to the shift to built-in policies for this that was done in our July update, where blob is not yet included. (See what's new below)
image
https://github.com/Azure/Enterprise-Scale/wiki/Whats-new#policy-1

I will follow-up with the eng. team to get an ETA on when we can expect it to be available.

In the meantime, as a workaround, you can create a custom policy based on this doc and add it to the "Configure Azure PaaS services to use private DNS zones" initiative.

Apologies for the inconvenience.

@daltondhcp daltondhcp changed the title Bug Report - Policy not functioning as expected Built-in policies DINE policies for DNSZoneGroup registration missing Aug 30, 2021
@daltondhcp daltondhcp added enhancement New feature or request and removed bug Something isn't working triage labels Aug 30, 2021
@jtracey93
Copy link
Collaborator

Trigger ADO Sync 1

@jtracey93
Copy link
Collaborator

Trigger ADO Sync 2

@jtracey93
Copy link
Collaborator

Hey @pkorolo,

Just picking this back up and re-triaging. Is this effectively saying that the Deploy-Private-DNS-Zones ALZ Custom Policy Initiative does not contain a policy for configuring blob storage private DNS zone groups?

It doesn't look like there is a built-in so we would have to work with the storage PG to get one published or create a custom one. I checked here for all the latest built-ins https://www.azadvertizer.net/azpolicyadvertizer_all.html#%7B%22col_3%22%3A%7B%22flt%22%3A%22private%20DNS%20zones%22%7D%2C%22col_0%22%3A%7B%7D%2C%22col_8%22%3A%7B%7D%2C%22page_length%22%3A100%7D

We have also already done some gap analysis of private link supported services and whether there is a built-in private DNS zone group DINE policy.

Let us know

@pkorolo
Copy link
Contributor Author

pkorolo commented Oct 10, 2022

Hello @jtracey93

Indeed, some months back when I was doing some testing, the custom initiative then called "Configure Azure PaaS services to use private DNS zones" (definition: /providers/Microsoft.Management/managementGroups/<alz_root_mg>/providers/Microsoft.Authorization/policySetDefinitions/Deploy-Private-DNS-Zones ), which was a bundle of individual build-in policies (per-PaaS Service), did not include the respective DINE policy for (blob) storage.

Now it has been a while since then (I haven't re-deployed and tested in the interim), and maybe this is not the case anymore.
For sure back then, it was, hence if you see the thread above, Johan proposed (as interim resolution), to edit the initiative and add the missing DINE policies from the (previously existing) custom ones (as per existing documentation).

If you have a relatively recent deployment, you can check if the respective initiative now does include DINE policies for storage services' private DNS zone groups or not.
If you don't have something handy, I will redeploy myself rather soon (by the end of the week that is), and check for myself (and let you know of course).

Hope this helps!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering engineering work enhancement New feature or request policy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants