Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/ptn/azd/ml-hub-dependencies #1227

Closed
2 tasks done
Menghua1 opened this issue Jul 24, 2024 · 6 comments · Fixed by Azure/bicep-registry-modules#3241
Closed
2 tasks done

[Module Proposal]: avm/ptn/azd/ml-hub-dependencies #1227

Menghua1 opened this issue Jul 24, 2024 · 6 comments · Fixed by Azure/bicep-registry-modules#3241
Assignees
Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@Menghua1
Copy link
Member

Menghua1 commented Jul 24, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/azd/ml-hub-dependencies

Module Details

Please add a Pattern Module named avm/ptn/azd/ml-hub-dependencies, this module will create the following seven resources:

  1. Key Vault.
  2. Storage Account.
  3. Log Analytics Workspace.
  4. Application Insights instance.
  5. Azure Container Registry (ACR).
  6. Cognitive Service.
  7. Search Service.

For details, please refer to azd:
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/ai/hub-dependencies.bicep

CC: @jongio

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

jongio

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@Menghua1 Menghua1 added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jul 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Jul 24, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Pattern Module 📦 This is a pattern module labels Aug 2, 2024
@matebarabas
Copy link
Contributor

@Menghua1, thank you for proposing this module and thank you for your patience on triaging it! Many of us on the AVM core team have been OOF in the last couple of weeks, but we're back now! 😊

As this is categorized as a pattern module, its approval will require a more thorough assessment. We'll reach out to @jongio internally for more context and details as this proposal may require some adjustments to fit AVM's pattern definition and intent. The AVM core team will get back to you soon. Thank you for your patience!

@matebarabas matebarabas added the AZD 🧑‍💻 These modules are requested/used by the AZD team. label Aug 7, 2024
@Menghua1 Menghua1 changed the title [Module Proposal]: avm/ptn/machine-learning-services/hub-dependencies [Module Proposal]: avm/ptn/azd/ml-hub-dependencies Aug 22, 2024
@matebarabas
Copy link
Contributor

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Status: No Recent Activity 💤 When an issue/PR has not been modified for X amount of days labels Aug 22, 2024
@matebarabas matebarabas removed the Status: No Recent Activity 💤 When an issue/PR has not been modified for X amount of days label Aug 27, 2024
@jongio
Copy link
Member

jongio commented Aug 28, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Aug 28, 2024
@matebarabas
Copy link
Contributor

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Status: Owners Identified 🤘 This module has its owners identified labels Aug 28, 2024
@matebarabas matebarabas removed Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Needs: Triage 🔍 Maintainers need to triage still Status: Owners Identified 🤘 This module has its owners identified Needs: Module Owner 📣 This module needs an owner to develop or maintain it Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels Aug 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Aug 28, 2024

Important

@jongio, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Sep 23, 2024
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.
  • Issue template file updated.

Thank you for your work, @Menghua1! The module index will be updated with this information.

@matebarabas matebarabas added Status: Module Available 🟢 The module is published and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

Successfully merging a pull request may close this issue.

3 participants