Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm-res-network-applicationgatewaywebapplicationfirewallpolicy #1088

Open
2 tasks done
PmeshramPM opened this issue Jun 17, 2024 · 18 comments
Open
2 tasks done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Status: Owners Identified 🤘 This module has its owners identified Status: Repository Created This module has had it's repository created and configured ready for owner contribution (Terraform) Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@PmeshramPM
Copy link
Contributor

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Terraform

Module Classification?

Resource Module

Module Name

avm-res-network-applicationgatewaywebapplicationfirewallpolicy

Module Details

AVM Resource Module for Application Gateway Web Application Firewall (WAF) Policy

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

No response

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@PmeshramPM PmeshramPM added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jun 17, 2024
@matebarabas matebarabas added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it Class: Resource Module 📦 This is a resource module labels Jun 17, 2024
@matebarabas matebarabas moved this from Proposed to Looking for owners in AVM - Module Triage Jun 18, 2024
@cshea-msft
Copy link

cshea-msft commented Sep 5, 2024

@PmeshramPM Is this just adding the waf policy to app gw?

@prjelesi
Copy link
Contributor

prjelesi commented Sep 6, 2024

@cshea-msft
Copy link

@prjelesi ok so it's just creating a Web Application Firewall. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/web_application_firewall_policy

@mofaizal is the owner of the appgw module, so he might want to own this.

@matt-FFFFFF
Copy link
Member

This module doesn't make sense. The firewall policy is a dedicated resource that's shared with other resources.

The output of the waf policy module will be used in the existing appgw module

@prjelesi
Copy link
Contributor

We are good to go to move this module to dev. @cshea-msft @mofaizal Who is raising hand to own it?

@sihbher
Copy link

sihbher commented Sep 12, 2024

Just in case no one could own this module, I would like to own it.

@prjelesi
Copy link
Contributor

Just in case no one could own this module, I would like to own it.

Let's wait @cshea-msft and @mofaizal to reply.

@cshea-msft
Copy link

@prjelesi i don't need to own it

@prjelesi
Copy link
Contributor

@mofaizal

@prjelesi
Copy link
Contributor

@mofaizal

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 18, 2024
@mofaizal
Copy link

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 18, 2024
@kewalaka
Copy link
Contributor

kewalaka commented Oct 31, 2024

@mofaizal
Copy link

mofaizal commented Nov 2, 2024

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Owners Identified 🤘 This module has its owners identified label Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Looking for owners to Done in AVM - Module Triage Nov 7, 2024
@mbilalamjad mbilalamjad reopened this Nov 7, 2024

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

3 similar comments

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

Important

@mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module.

Tip

To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label.

@terrymandin terrymandin moved this from In Review to Done in AVM - Module Triage Feb 28, 2025
@jaredfholgate jaredfholgate added the Status: Repository Created This module has had it's repository created and configured ready for owner contribution (Terraform) label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Status: Owners Identified 🤘 This module has its owners identified Status: Repository Created This module has had it's repository created and configured ready for owner contribution (Terraform) Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

No branches or pull requests

10 participants