-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module Proposal]: avm-res-network-applicationgatewaywebapplicationfirewallpolicy
#1088
Comments
@PmeshramPM Is this just adding the waf policy to app gw? |
@cshea-msft this should create waf policy using this rp https://learn.microsoft.com/en-us/azure/templates/microsoft.network/applicationgatewaywebapplicationfirewallpolicies?pivots=deployment-language-arm-template |
@prjelesi ok so it's just creating a Web Application Firewall. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/web_application_firewall_policy @mofaizal is the owner of the appgw module, so he might want to own this. |
This module doesn't make sense. The firewall policy is a dedicated resource that's shared with other resources. The output of the waf policy module will be used in the existing appgw module |
We are good to go to move this module to dev. @cshea-msft @mofaizal Who is raising hand to own it? |
Just in case no one could own this module, I would like to own it. |
Let's wait @cshea-msft and @mofaizal to reply. |
@prjelesi i don't need to own it |
Thanks for requesting/proposing to be an AVM module owner! We just want to confirm you agree to the below pages that define what module ownership means: Any questions or clarifications needed, let us know! If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍): "I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" Thanks, The AVM Core Team #RR |
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER" |
here's a sample here that passes static code checks (tflint, grept etc) |
@kewalaka Thanks for your support, here is the Repo link to PR https://github.com/Azure/avm-res-network-applicationgatewaywebapplicationfirewallpolicy |
Important @mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
Important @mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
3 similar comments
Important @mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
Important @mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
Important @mofaizal, this issue has not had any activity in the last 3 weeks. Please feel free to reach out to the AVM core team should you have any questions or need any help with the development of this module. Tip To silence this notification, provide an update every 3 weeks on the Module Proposal issue, or add the "Status: Long Term ⏳" label. |
Check for previous/existing GitHub issues/module proposals
Check this module doesn't already exist in the module indexes
Bicep or Terraform?
Terraform
Module Classification?
Resource Module
Module Name
avm-res-network-applicationgatewaywebapplicationfirewallpolicy
Module Details
AVM Resource Module for Application Gateway Web Application Firewall (WAF) Policy
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response
The text was updated successfully, but these errors were encountered: