Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @azure/msal-browser related dependencies #745

Merged

Conversation

mattgotteiner
Copy link
Collaborator

Purpose

Attempt to resolve #671. Underlying error appears to be caused by an error in our npm dependencies

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

azd up should not result in packaging errors

@pamelafox
Copy link
Collaborator

I'm trying to understand why I can't manage to replicate the error, even in Codespaces. What is it thats different across envs?

@mattgotteiner
Copy link
Collaborator Author

I'm trying to understand why I can't manage to replicate the error, even in Codespaces. What is it thats different across envs?

My best guess is that there’s a globally installed version of the package that’s impacted by this issue which is getting picked up.

@mattgotteiner mattgotteiner merged commit 3c75230 into Azure-Samples:main Oct 6, 2023
HughRunyan pushed a commit to RMI/RMI_chatbot that referenced this pull request Mar 26, 2024
vuculescu pushed a commit to vuculescu/azure-search-openai-demo that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants