From 1cf62dcdde636104d8e555b17d59206927815931 Mon Sep 17 00:00:00 2001 From: codygunton Date: Sat, 1 Apr 2023 18:14:17 +0000 Subject: [PATCH 1/5] Move composer type from plonk to bonk. --- .../dsl/acir_proofs/acir_proofs.cpp | 2 +- .../standard_honk_composer_helper.cpp | 9 +++---- .../honk/composer/standard_honk_composer.hpp | 2 +- .../honk/proof_system/prover_library.test.cpp | 6 ++--- .../honk/proof_system/verifier.test.cpp | 2 +- .../proofs/compute_circuit_data.hpp | 22 ++++++++-------- .../plonk/composer/composer_base.cpp | 2 +- .../plonk/composer/composer_base.hpp | 2 +- .../standard_plonk_composer_helper.cpp | 2 +- .../turbo_plonk_composer_helper.cpp | 7 ++--- .../turbo_plonk_composer_helper.hpp | 2 +- .../splitting_tmp/standard_plonk_composer.hpp | 2 +- .../splitting_tmp/turbo_plonk_composer.hpp | 2 +- .../plonk/composer/standard_composer.hpp | 2 +- .../plonk/composer/turbo_composer.hpp | 2 +- .../plonk/composer/ultra_composer.hpp | 2 +- .../commitment_scheme.test.cpp | 4 +-- .../plonk/proof_system/constants.hpp | 11 ++------ .../plonk/proof_system/prover/c_bind.cpp | 8 +++--- .../proof_system/prover/c_bind_unrolled.cpp | 3 ++- .../plonk/proof_system/prover/prover.test.cpp | 3 ++- .../proof_system/verifier/verifier.test.cpp | 2 +- .../standard_circuit_constructor.hpp | 2 +- .../turbo_circuit_constructor.hpp | 2 +- .../composer/composer_helper_lib.cpp | 4 +-- .../composer/composer_helper_lib.hpp | 2 +- .../proof_system/proving_key/proving_key.cpp | 9 ++++--- .../proof_system/proving_key/proving_key.hpp | 2 +- .../proof_system/types/composer_type.hpp | 11 ++++++++ .../types/polynomial_manifest.hpp | 8 +++--- .../proof_system/verification_key/sol_gen.hpp | 8 +++--- .../verification_key.test.cpp | 4 +-- .../stdlib/encryption/ecdsa/ecdsa_impl.hpp | 2 +- .../stdlib/hash/blake2s/blake2s.cpp | 2 +- .../stdlib/hash/blake3s/blake3s.cpp | 2 +- .../stdlib/hash/pedersen/pedersen.cpp | 4 +-- .../stdlib/hash/pedersen/pedersen_gates.hpp | 8 +++--- .../stdlib/hash/sha256/sha256.cpp | 2 +- .../bigfield/bigfield_all.fuzzer.cpp | 2 +- .../primitives/bigfield/bigfield_impl.hpp | 26 +++++++++---------- .../bigfield/bigfield_standard.fuzzer.cpp | 2 +- .../bigfield/bigfield_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/biggroup/biggroup.hpp | 21 ++++++++------- .../primitives/biggroup/biggroup.test.cpp | 2 +- .../biggroup/biggroup_batch_mul.hpp | 2 +- .../primitives/biggroup/biggroup_bn254.hpp | 2 +- .../biggroup/biggroup_secp256k1.hpp | 2 +- .../bit_array/bit_array_all.fuzzer.cpp | 2 +- .../bit_array/bit_array_standard.fuzzer.cpp | 2 +- .../bit_array/bit_array_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/bool/bool.test.cpp | 2 +- .../primitives/bool/bool_all.fuzzer.cpp | 2 +- .../primitives/bool/bool_standard.fuzzer.cpp | 2 +- .../primitives/bool/bool_turbo.fuzzer.cpp | 2 +- .../primitives/byte_array/byte_array.cpp | 2 +- .../byte_array/byte_array_all.fuzzer.cpp | 2 +- .../byte_array/byte_array_standard.fuzzer.cpp | 2 +- .../byte_array/byte_array_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/field/field.cpp | 6 ++--- .../stdlib/primitives/field/field.test.cpp | 4 +-- .../primitives/field/field_all.fuzzer.cpp | 2 +- .../field/field_standard.fuzzer.cpp | 2 +- .../primitives/field/field_turbo.fuzzer.cpp | 2 +- .../primitives/memory/dynamic_array.cpp | 2 +- .../stdlib/primitives/memory/ram_table.cpp | 4 +-- .../stdlib/primitives/memory/rom_table.cpp | 2 +- .../primitives/memory/twin_rom_table.cpp | 2 +- .../safe_uint/safe_uint_all.fuzzer.cpp | 2 +- .../safe_uint/safe_uint_standard.fuzzer.cpp | 2 +- .../safe_uint/safe_uint_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/uint/uint.cpp | 4 +-- .../stdlib/primitives/uint/uint.hpp | 8 +++--- .../stdlib/primitives/uint/uint.test.cpp | 2 +- .../primitives/uint/uint_all.fuzzer.cpp | 2 +- .../primitives/uint/uint_standard.fuzzer.cpp | 2 +- .../primitives/uint/uint_turbo.fuzzer.cpp | 2 +- .../recursion/transcript/transcript.hpp | 2 +- .../verification_key/verification_key.hpp | 10 +++---- cpp/src/barretenberg/stdlib/types/types.hpp | 22 ++++++++-------- 79 files changed, 173 insertions(+), 167 deletions(-) create mode 100644 cpp/src/barretenberg/proof_system/types/composer_type.hpp diff --git a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp index ef70c7af1e..6d81b0c732 100644 --- a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp +++ b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp @@ -83,7 +83,7 @@ size_t init_verification_key(void* pippenger, uint8_t const* g2x, uint8_t const* // The composer_type has not yet been set. We need to set the composer_type for when we later read in and // construct the verification key so that we have the correct polynomial manifest - verification_key->composer_type = ComposerType::PLOOKUP; + verification_key->composer_type = bonk::ComposerType::PLOOKUP; auto buffer = to_buffer(*verification_key); auto raw_buf = (uint8_t*)malloc(buffer.size()); diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp index 4117dbcdd2..e45440050c 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp @@ -28,11 +28,8 @@ std::shared_ptr StandardHonkComposerHelper StandardHonkComposerHelper(circuit_constructor, diff --git a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp index 52d4579fd5..d9ca6145c3 100644 --- a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp +++ b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp @@ -15,7 +15,7 @@ namespace honk { */ class StandardHonkComposer { public: - static constexpr plonk::ComposerType type = plonk::ComposerType::STANDARD_HONK; + static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD_HONK; static constexpr size_t UINT_LOG2_BASE = 2; // An instantiation of the circuit constructor that only depends on arithmetization, not on the proof system diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp index 205d249581..df9c2ee880 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp @@ -51,7 +51,7 @@ template class ProverLibraryTests : public testing::Test { // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. auto proving_key = std::make_shared( - num_gates, num_public_inputs, reference_string, plonk::ComposerType::STANDARD_HONK); + num_gates, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); // static const size_t program_width = StandardProver::settings_::program_width; @@ -160,7 +160,7 @@ template class ProverLibraryTests : public testing::Test { // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. auto proving_key = std::make_shared( - circuit_size, num_public_inputs, reference_string, plonk::ComposerType::STANDARD_HONK); + circuit_size, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); // Construct mock wire and permutation polynomials. // Note: for the purpose of checking the consistency between two methods of computing z_perm, these polynomials @@ -287,7 +287,7 @@ template class ProverLibraryTests : public testing::Test { static const size_t num_public_inputs = 0; auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); auto proving_key = std::make_shared( - circuit_size, num_public_inputs, reference_string, plonk::ComposerType::STANDARD_HONK); + circuit_size, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); // Get random challenge eta auto eta = FF::random_element(); diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp index 42689b9282..27abc34a52 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp @@ -83,7 +83,7 @@ template class VerifierTests : public testing::Test { auto crs = std::make_shared(n + 1, "../srs_db/ignition"); std::shared_ptr proving_key = - std::make_shared(n, 0, crs, plonk::STANDARD_HONK); + std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD_HONK); polynomial w_l(n); polynomial w_r(n); diff --git a/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp index f50bb31eba..34929840b6 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp @@ -70,12 +70,12 @@ circuit_data get_circuit_data(std::string const& name, Timer timer; build_circuit(composer); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Build time", timer.toString()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Gates", @@ -86,7 +86,7 @@ circuit_data get_circuit_data(std::string const& name, auto public_inputs = composer.get_public_inputs(); mock::mock_circuit(mock_proof_composer, public_inputs); info(name, ": Mock circuit size: ", mock_proof_composer.get_num_gates()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Mock Gates", @@ -113,7 +113,7 @@ circuit_data get_circuit_data(std::string const& name, std::make_shared(std::move(pk_data), srs->get_prover_crs(pk_data.circuit_size + 1)); data.num_gates = pk_data.circuit_size; info(name, ": Circuit size 2^n: ", data.num_gates); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Gates 2^n", @@ -127,7 +127,7 @@ circuit_data get_circuit_data(std::string const& name, data.proving_key = composer.compute_proving_key(); info(name, ": Circuit size 2^n: ", data.proving_key->circuit_size); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Gates 2^n", @@ -136,7 +136,7 @@ circuit_data get_circuit_data(std::string const& name, data.num_gates = mock_proof_composer.get_num_gates(); data.proving_key = mock_proof_composer.compute_proving_key(); info(name, ": Mock circuit size 2^n: ", data.proving_key->circuit_size); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Mock Gates 2^n", @@ -145,7 +145,7 @@ circuit_data get_circuit_data(std::string const& name, info(name, ": Proving key computed in ", timer.toString(), "s"); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Proving key computed in", @@ -175,7 +175,7 @@ circuit_data get_circuit_data(std::string const& name, data.verification_key = std::make_shared(std::move(vk_data), data.srs->get_verifier_crs()); info(name, ": Verification key hash: ", data.verification_key->sha256_hash()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Verification key hash", @@ -191,13 +191,13 @@ circuit_data get_circuit_data(std::string const& name, } info(name, ": Computed verification key in ", timer.toString(), "s"); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Verification key computed in", timer.toString()); info(name, ": Verification key hash: ", data.verification_key->sha256_hash()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Verification key hash", @@ -246,7 +246,7 @@ circuit_data get_circuit_data(std::string const& name, info(name, ": Padding verified: ", verifier.verify_proof(proof)); } info(name, ": Padding proof computed in ", timer.toString(), "s"); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", name + name_suffix_for_benchmarks, "Padding proof computed in", diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.cpp b/cpp/src/barretenberg/plonk/composer/composer_base.cpp index 1dde96b0db..19ab5364c4 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.cpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.cpp @@ -231,7 +231,7 @@ template void ComposerBase::compute_sigma * @param num_reserved_gates The number of reserved gates. * @return Pointer to the initialized proving key updated with selector polynomials. * */ -std::shared_ptr ComposerBase::compute_proving_key_base(const ComposerType composer_type, +std::shared_ptr ComposerBase::compute_proving_key_base(const bonk::ComposerType composer_type, const size_t minimum_circuit_size, const size_t num_reserved_gates) { diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.hpp b/cpp/src/barretenberg/plonk/composer/composer_base.hpp index 6f2c356510..daf4871700 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.hpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.hpp @@ -110,7 +110,7 @@ class ComposerBase { virtual size_t get_total_circuit_size() const = 0; virtual void print_num_gates() const { std::cout << num_gates << std::endl; } virtual size_t get_num_variables() const { return variables.size(); } - virtual std::shared_ptr compute_proving_key_base(const ComposerType type = STANDARD, + virtual std::shared_ptr compute_proving_key_base(const bonk::ComposerType type = STANDARD, const size_t minimum_ciricut_size = 0, const size_t num_reserved_gates = NUM_RESERVED_GATES); // This needs to be static as it may be used only to compute the selector commitments. diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp index 6205c0d9b1..edc71bb286 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp @@ -66,7 +66,7 @@ std::shared_ptr StandardPlonkComposerHelper TurboPlonkComposerHelper: const size_t num_randomized_gates = NUM_RANDOMIZED_GATES; // Initialize circuit_proving_key // TODO(#229)(Kesha): replace composer types. - circuit_proving_key = initialize_proving_key(circuit_constructor, - crs_factory_.get(), - minimum_circuit_size, - num_randomized_gates, - plonk::ComposerType::TURBO); + circuit_proving_key = initialize_proving_key( + circuit_constructor, crs_factory_.get(), minimum_circuit_size, num_randomized_gates, bonk::ComposerType::TURBO); construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp index 94920b2046..ce374bc263 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp @@ -11,7 +11,7 @@ template class TurboPlonkComposerHelper { public: static constexpr size_t NUM_RANDOMIZED_GATES = 2; // equal to the number of multilinear evaluations leaked static constexpr size_t program_width = CircuitConstructor::program_width; - static constexpr ComposerType type = ComposerType::TURBO; + static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; std::shared_ptr circuit_proving_key; diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp index 083ac264dc..57d00325fc 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp @@ -16,7 +16,7 @@ namespace plonk { */ class StandardPlonkComposer { public: - static constexpr plonk::ComposerType type = plonk::ComposerType::STANDARD; + static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD; static constexpr size_t UINT_LOG2_BASE = 2; // An instantiation of the circuit constructor that only depends on arithmetization, not on the proof system diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp index 985e5529e2..c01e365f55 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp @@ -12,7 +12,7 @@ namespace plonk { */ class TurboPlonkComposer { public: - static constexpr plonk::ComposerType type = plonk::ComposerType::STANDARD; + static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD; static constexpr size_t UINT_LOG2_BASE = 2; diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.hpp b/cpp/src/barretenberg/plonk/composer/standard_composer.hpp index 0a7015767f..8b75b5476e 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.hpp @@ -17,7 +17,7 @@ inline std::vector standard_selector_propertie class StandardComposer : public ComposerBase { public: - static constexpr ComposerType type = ComposerType::STANDARD; + static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; diff --git a/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp b/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp index ab71116a85..e49b7fe3c7 100644 --- a/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp @@ -6,7 +6,7 @@ using namespace bonk; namespace plonk { class TurboComposer : public ComposerBase { public: - static constexpr ComposerType type = ComposerType::TURBO; + static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; enum TurboSelectors { QM, QC, Q1, Q2, Q3, Q4, Q5, QARITH, QFIXED, QRANGE, QLOGIC, NUM }; diff --git a/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp b/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp index 769ec09a34..cbd35d18da 100644 --- a/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp @@ -10,7 +10,7 @@ namespace plonk { class UltraComposer : public ComposerBase { public: - static constexpr ComposerType type = ComposerType::PLOOKUP; + static constexpr bonk::ComposerType type = bonk::ComposerType::PLOOKUP; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::LOOKUP_PEDERSEN; static constexpr size_t NUM_RESERVED_GATES = 4; // This must be >= num_roots_cut_out_of_vanishing_polynomial // See the comment in plonk/proof_system/prover/prover.cpp diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp index 200e44a281..d342a47e4d 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp @@ -38,7 +38,7 @@ TEST(commitment_scheme, kate_open) // std::shared_ptr crs_factory = (new FileReferenceStringFactory("../srs_db/ignition")); auto file_crs = std::make_shared("../srs_db/ignition"); auto crs = file_crs->get_prover_crs(n); - auto circuit_proving_key = std::make_shared(n, 0, crs, plonk::STANDARD); + auto circuit_proving_key = std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD); work_queue queue(circuit_proving_key.get(), &inp_tx); newKate.commit(&coeffs[0], "F_COMM", 0, queue); @@ -95,7 +95,7 @@ TEST(commitment_scheme, kate_batch_open) auto file_crs = std::make_shared("../srs_db/ignition"); auto crs = file_crs->get_prover_crs(n); - auto circuit_proving_key = std::make_shared(n, 0, crs, plonk::STANDARD); + auto circuit_proving_key = std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD); work_queue queue(circuit_proving_key.get(), &inp_tx); // commit to individual polynomials diff --git a/cpp/src/barretenberg/plonk/proof_system/constants.hpp b/cpp/src/barretenberg/plonk/proof_system/constants.hpp index f919f636cf..7a444943c1 100644 --- a/cpp/src/barretenberg/plonk/proof_system/constants.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/constants.hpp @@ -1,22 +1,15 @@ #pragma once #include - +#include "barretenberg/proof_system/types/composer_type.hpp" namespace plonk { -enum ComposerType { - STANDARD, - TURBO, - PLOOKUP, - STANDARD_HONK, // Todo(Arijit): We should replace STANDARD_HONK outside plonk or the namespace should be bonk -}; - // This variable sets the composer (TURBO or ULTRA) of the entire stdlib and rollup modules. // To switch to using a new composer, only changing this variable should activate the new composer // throughout the stdlib and circuits. #ifdef USE_TURBO static constexpr uint32_t SYSTEM_COMPOSER = ComposerType::TURBO; #else -static constexpr uint32_t SYSTEM_COMPOSER = ComposerType::PLOOKUP; +static constexpr uint32_t SYSTEM_COMPOSER = bonk::ComposerType::PLOOKUP; #endif enum MerkleHashType { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp index 633c4562c1..08bfd8755f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp @@ -1,6 +1,7 @@ #include "prover.hpp" #include "barretenberg/env/data_store.hpp" #include "barretenberg/env/crs.hpp" +#include "barretenberg/proof_system/types/composer_type.hpp" #define WASM_EXPORT __attribute__((visibility("default"))) @@ -31,7 +32,7 @@ WASM_EXPORT void* test_async_func(size_t size, int val) } } /** - * @brief Simple wrapper for env_load_verifier_crs. + * @brief Simple wrapper for env_load_verifier_crs. * @return The CRS. */ WASM_EXPORT void* test_env_load_verifier_crs() @@ -39,7 +40,7 @@ WASM_EXPORT void* test_env_load_verifier_crs() return env_load_verifier_crs(); } /** - * @brief Simple wrapper for env_load_verifier_crs. + * @brief Simple wrapper for env_load_verifier_crs. * @param The number of points to load of the prover CRS. * @return The CRS. */ @@ -47,7 +48,8 @@ WASM_EXPORT void* test_env_load_prover_crs(size_t num_points) { return env_load_prover_crs(num_points); } -typedef std::conditional_t WasmProver; +typedef std::conditional_t + WasmProver; WASM_EXPORT void prover_process_queue(WasmProver* prover) { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp index 2a7fe494ab..533e07e813 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp @@ -1,4 +1,5 @@ #include "prover.hpp" +#include "barretenberg/proof_system/types/composer_type.hpp" #define WASM_EXPORT __attribute__((visibility("default"))) @@ -7,7 +8,7 @@ using namespace barretenberg; extern "C" { // TODO(Cody): Removed "unrolled" here when the time comes, if it does. -typedef std::conditional_t +typedef std::conditional_t WasmUnrolledProver; WASM_EXPORT void unrolled_prover_process_queue(WasmUnrolledProver* prover) diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp index bdcbad74e5..7eb4f323dc 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp @@ -113,7 +113,8 @@ plonk::Prover generate_test_data(const size_t n) // even indices = mul gates, odd incides = add gates auto reference_string = std::make_shared(n + 1, "../srs_db/ignition"); - std::shared_ptr key = std::make_shared(n, 0, reference_string, plonk::STANDARD); + std::shared_ptr key = + std::make_shared(n, 0, reference_string, bonk::ComposerType::STANDARD); polynomial w_l(n); polynomial w_r(n); diff --git a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp index 79be2fab2e..3046639e6a 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp @@ -77,7 +77,7 @@ plonk::Prover generate_test_data(const size_t n) // even indices = mul gates, odd incides = add gates auto crs = std::make_shared(n + 1, "../srs_db/ignition"); - std::shared_ptr key = std::make_shared(n, 0, crs, plonk::STANDARD); + std::shared_ptr key = std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD); polynomial w_l(n); polynomial w_r(n); diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp index b1e03f89b3..3aba1aec3c 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp @@ -23,7 +23,7 @@ class StandardCircuitConstructor : public CircuitConstructorBase& q_3 = std::get<3>(selectors); std::vector& q_c = std::get<4>(selectors); - static constexpr plonk::ComposerType type = plonk::ComposerType::STANDARD_HONK; // TODO(Cody): Get rid of this. + static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD_HONK; // TODO(Cody): Get rid of this. static constexpr size_t UINT_LOG2_BASE = 2; // These are variables that we have used a gate on, to enforce that they are diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp index 1a982d86ce..642ec2adb1 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp @@ -32,7 +32,7 @@ class TurboCircuitConstructor : public CircuitConstructorBase& q_range = std::get<9>(selectors); std::vector& q_logic = std::get<10>(selectors); - static constexpr plonk::ComposerType type = plonk::ComposerType::TURBO; + static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; static constexpr size_t UINT_LOG2_BASE = 2; TurboCircuitConstructor(const size_t size_hint = 0); diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp index 0ea9320ccd..7c2e20c7d6 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp @@ -26,7 +26,7 @@ std::shared_ptr initialize_proving_key(const CircuitConstruct bonk::ReferenceStringFactory* crs_factory, const size_t minimum_circuit_size, const size_t num_randomized_gates, - plonk::ComposerType composer_type) + bonk::ComposerType composer_type) { const size_t num_gates = circuit_constructor.num_gates; std::span public_inputs = circuit_constructor.public_inputs; @@ -225,7 +225,7 @@ std::shared_ptr compute_verification_key_common( // Ensure we compile all versions so that there are no issues during linkage #define COMPILE_FOR_CIRCUIT_CONSTRUCTOR(circuit_constructor) \ template std::shared_ptr initialize_proving_key( \ - const circuit_constructor&, bonk::ReferenceStringFactory*, const size_t, const size_t, plonk::ComposerType); \ + const circuit_constructor&, bonk::ReferenceStringFactory*, const size_t, const size_t, bonk::ComposerType); \ template void construct_lagrange_selector_forms(const circuit_constructor&, \ bonk::proving_key*); \ template std::vector compute_witness_base( \ diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp index 7387270fb5..080cbc4ee7 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp @@ -24,7 +24,7 @@ std::shared_ptr initialize_proving_key(const CircuitConstruct bonk::ReferenceStringFactory* crs_factory, const size_t minimum_circuit_size, const size_t num_randomized_gates, - plonk::ComposerType composer_type); + bonk::ComposerType composer_type); /** * @brief Construct lagrange selector polynomials from circuit selector information and put into polynomial cache diff --git a/cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp b/cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp index ad66e30fa0..0802a6a342 100644 --- a/cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp +++ b/cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp @@ -21,10 +21,11 @@ namespace bonk { * * Delegates to proving_key::init * */ -proving_key::proving_key(const size_t num_gates, - const size_t num_inputs, - std::shared_ptr const& crs, - plonk::ComposerType type = plonk::STANDARD) // TODO(Cody): Don't use default for Honk +proving_key::proving_key( + const size_t num_gates, + const size_t num_inputs, + std::shared_ptr const& crs, + bonk::ComposerType type = bonk::ComposerType::STANDARD) // TODO(Cody): Don't use default for Honk : composer_type(type) , circuit_size(num_gates) , log_circuit_size(numeric::get_msb(num_gates)) diff --git a/cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp b/cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp index 7df19d2e64..7e4c371e11 100644 --- a/cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp +++ b/cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp @@ -36,7 +36,7 @@ struct proving_key { proving_key(const size_t num_gates, const size_t num_inputs, std::shared_ptr const& crs, - plonk::ComposerType type); + bonk::ComposerType type); proving_key(std::ostream& is, std::string const& crs_path); diff --git a/cpp/src/barretenberg/proof_system/types/composer_type.hpp b/cpp/src/barretenberg/proof_system/types/composer_type.hpp new file mode 100644 index 0000000000..66e79810d4 --- /dev/null +++ b/cpp/src/barretenberg/proof_system/types/composer_type.hpp @@ -0,0 +1,11 @@ +#pragma once + +namespace bonk { +// This will go away, but we move it here has a temporary measure to make proof_system not depend on honk or plonk. +enum ComposerType { + STANDARD, + TURBO, + PLOOKUP, + STANDARD_HONK, // Todo(Arijit): We should replace STANDARD_HONK outside plonk or the namespace should be bonk +}; +} // namespace bonk \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp b/cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp index 4052d4ebff..5c511ac5be 100644 --- a/cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp +++ b/cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp @@ -176,19 +176,19 @@ class PolynomialManifest { PolynomialManifest(uint32_t composer_type) { switch (composer_type) { - case plonk::ComposerType::STANDARD: { + case bonk::ComposerType::STANDARD: { std::copy(standard_polynomial_manifest, standard_polynomial_manifest + STANDARD_MANIFEST_SIZE, std::back_inserter(manifest)); break; }; - case plonk::ComposerType::TURBO: { + case bonk::ComposerType::TURBO: { std::copy(turbo_polynomial_manifest, turbo_polynomial_manifest + TURBO_MANIFEST_SIZE, std::back_inserter(manifest)); break; }; - case plonk::ComposerType::PLOOKUP: { + case bonk::ComposerType::PLOOKUP: { std::copy(ultra_polynomial_manifest, ultra_polynomial_manifest + ULTRA_MANIFEST_SIZE, std::back_inserter(manifest)); @@ -236,7 +236,7 @@ class PrecomputedPolyList { precomputed_poly_ids.emplace_back(label); precomputed_poly_ids.emplace_back(label + "_fft"); // Store all lagrange forms of selector polynomials for ultra - if (composer_type == plonk::ComposerType::PLOOKUP) { + if (composer_type == bonk::ComposerType::PLOOKUP) { precomputed_poly_ids.emplace_back(label + "_lagrange"); } break; diff --git a/cpp/src/barretenberg/proof_system/verification_key/sol_gen.hpp b/cpp/src/barretenberg/proof_system/verification_key/sol_gen.hpp index 29fd773f0b..d41e60cb11 100644 --- a/cpp/src/barretenberg/proof_system/verification_key/sol_gen.hpp +++ b/cpp/src/barretenberg/proof_system/verification_key/sol_gen.hpp @@ -143,17 +143,17 @@ inline void output_vk_sol_ultra(std::ostream& os, std::shared_ptr const& key, std::string const& class_name) { - plonk::ComposerType composer_type = static_cast(key->composer_type); + bonk::ComposerType composer_type = static_cast(key->composer_type); switch (composer_type) { - case plonk::ComposerType::STANDARD: { + case bonk::ComposerType::STANDARD: { return output_vk_sol_standard(os, key, class_name); break; } - // case plonk::ComposerType::TURBO: { + // case bonk::ComposerType::TURBO: { // return output_vk_sol_turbo(os, key, class_name); // break; // } - case plonk::ComposerType::PLOOKUP: { + case bonk::ComposerType::PLOOKUP: { return output_vk_sol_ultra(os, key, class_name); break; } diff --git a/cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp b/cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp index 8f74d875d6..8faaca2a02 100644 --- a/cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp +++ b/cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp @@ -8,7 +8,7 @@ using namespace bonk; TEST(verification_key, buffer_serialization) { verification_key_data key; - key.composer_type = static_cast(plonk::ComposerType::STANDARD); + key.composer_type = static_cast(bonk::ComposerType::STANDARD); key.circuit_size = 1234; key.num_public_inputs = 10; key.commitments["test1"] = g1::element::random_element(); @@ -25,7 +25,7 @@ TEST(verification_key, buffer_serialization) TEST(verification_key, stream_serialization) { verification_key_data key; - key.composer_type = static_cast(plonk::ComposerType::STANDARD); + key.composer_type = static_cast(bonk::ComposerType::STANDARD); key.circuit_size = 1234; key.num_public_inputs = 10; key.commitments["test1"] = g1::element::random_element(); diff --git a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp index 882a4b083a..8048b56d07 100644 --- a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp +++ b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp @@ -33,7 +33,7 @@ bool_t verify_signature(const stdlib::byte_array& message, Fr u2 = r / s; G1 result; - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { ASSERT(Curve::type == bonk::CurveType::SECP256K1); public_key.validate_on_curve(); result = G1::secp256k1_ecdsa_mul(public_key, u1, u2); diff --git a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp index d2a20d8137..33c7687be2 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp @@ -119,7 +119,7 @@ template void blake2s(blake2s_state& S, byte_array template byte_array blake2s(const byte_array& input) { - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { return blake2s_plookup::blake2s(input); } diff --git a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp index f8af0692ac..5d2a7b1517 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp @@ -246,7 +246,7 @@ using namespace blake3_internal; template byte_array blake3s(const byte_array& input) { - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { return blake3s_plookup::blake3s(input); } diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp index 5db83ffca1..3933d85893 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp @@ -225,7 +225,7 @@ point pedersen::hash_single(const field_t& in, if (i > 0) { gates.create_fixed_group_add_gate(round_quad); } else { - if constexpr (C::type == plonk::PLOOKUP && + if constexpr (C::type == bonk::ComposerType::PLOOKUP && C::merkle_hash_type == plonk::MerkleHashType::FIXED_BASE_PEDERSEN) { /* In TurboComposer, the selector q_5 is used to show that w_1 and w_2 are properly initialized to the * coordinates of P_s = (-s + 4^n)[g]. In UltraPlonK, we have removed q_5 for overall efficiency (it @@ -463,7 +463,7 @@ template void pedersen::validate_wnaf_is_in_field(C* ctx, const field_t y_lo = (-reconstructed_input).add_two(high_limb_with_skew * shift + (r_lo + shift), is_even); field_t y_overlap; - if constexpr (C::type == ComposerType::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { // carve out the 2 high bits from y_lo and instantiate as y_overlap const uint256_t y_lo_value = y_lo.get_value(); const uint256_t y_overlap_value = y_lo_value >> 126; diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp index 6d708abee1..9c1ca282ae 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp @@ -25,7 +25,7 @@ template class pedersen_gates { using fixed_group_add_quad = bonk::fixed_group_add_quad; using fixed_group_init_quad = bonk::fixed_group_init_quad; using add_quad = bonk::add_quad; - using ComposerType = plonk::ComposerType; + using ComposerType = bonk::ComposerType; Composer* context; fixed_group_add_quad previous_add_quad; @@ -36,7 +36,7 @@ template class pedersen_gates { void create_fixed_group_add_gate(const fixed_group_add_quad& in) { - if constexpr (Composer::type == ComposerType::TURBO) { + if constexpr (Composer::type == bonk::ComposerType::TURBO) { context->create_fixed_group_add_gate(in); } else { @@ -229,7 +229,7 @@ template class pedersen_gates { void create_fixed_group_add_gate_with_init(const fixed_group_add_quad& in, const fixed_group_init_quad& init) { - if constexpr (Composer::type == ComposerType::TURBO) { + if constexpr (Composer::type == bonk::ComposerType::TURBO) { context->create_fixed_group_add_gate_with_init(in, init); } else { uint32_t x_0_idx = in.a; @@ -295,7 +295,7 @@ template class pedersen_gates { void create_fixed_group_add_gate_final(const add_quad& in) { - if constexpr (Composer::type == ComposerType::TURBO) { + if constexpr (Composer::type == bonk::ComposerType::TURBO) { context->create_fixed_group_add_gate_final(in); } else { diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp index 150f91b636..e936fd26be 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp @@ -139,7 +139,7 @@ template byte_array sha256_block(const byte_array< template packed_byte_array sha256(const packed_byte_array& input) { - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { return sha256_plookup::sha256(input); } typedef field_t field_pt; diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp index 17c7879e0c..2b974913c0 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp index e7bbcf34ec..b070a6910e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp @@ -56,7 +56,7 @@ bigfield::bigfield(const field_t& low_bits_in, field_t limb_3(context); if (low_bits_in.witness_index != IS_CONSTANT) { std::vector low_accumulator; - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { // MERGE NOTE: this was the if constexpr block introduced in ecebe7643 const auto limb_witnesses = context->decompose_non_native_field_double_width_limb(low_bits_in.normalize().witness_index); @@ -107,7 +107,7 @@ bigfield::bigfield(const field_t& low_bits_in, if (high_bits_in.witness_index != IS_CONSTANT) { std::vector high_accumulator; - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { const auto limb_witnesses = context->decompose_non_native_field_double_width_limb( high_bits_in.normalize().witness_index, (size_t)num_high_limb_bits); limb_2.witness_index = limb_witnesses[0]; @@ -187,7 +187,7 @@ bigfield bigfield::create_from_u512_as_witness(C* ctx, limbs[2] = value.slice(NUM_LIMB_BITS * 2, NUM_LIMB_BITS * 3).lo; limbs[3] = value.slice(NUM_LIMB_BITS * 3, NUM_LIMB_BITS * 4).lo; - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { field_t limb_0(ctx); field_t limb_1(ctx); field_t limb_2(ctx); @@ -384,7 +384,7 @@ template bigfield bigfield::operator+(const result.binary_basis_limbs[3].maximum_value = binary_basis_limbs[3].maximum_value + other.binary_basis_limbs[3].maximum_value; - if constexpr (C::type == ComposerType::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { if (prime_basis_limb.multiplicative_constant == 1 && other.prime_basis_limb.multiplicative_constant == 1 && !is_constant() && !other.is_constant()) { bool limbconst = binary_basis_limbs[0].element.is_constant(); @@ -592,7 +592,7 @@ template bigfield bigfield::operator-(const result.binary_basis_limbs[2].element = binary_basis_limbs[2].element + barretenberg::fr(to_add_2); result.binary_basis_limbs[3].element = binary_basis_limbs[3].element + barretenberg::fr(to_add_3); - if constexpr (C::type == ComposerType::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { if (result.prime_basis_limb.multiplicative_constant == 1 && other.prime_basis_limb.multiplicative_constant == 1 && !result.is_constant() && !other.is_constant()) { bool limbconst = result.binary_basis_limbs[0].element.is_constant(); @@ -1645,7 +1645,7 @@ template void bigfield::assert_is_in_field() cons r1 = r1.normalize(); r2 = r2.normalize(); r3 = r3.normalize(); - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { context->decompose_into_default_range(r0.witness_index, static_cast(NUM_LIMB_BITS)); context->decompose_into_default_range(r1.witness_index, static_cast(NUM_LIMB_BITS)); context->decompose_into_default_range(r2.witness_index, static_cast(NUM_LIMB_BITS)); @@ -1778,7 +1778,7 @@ template void bigfield::self_reduce() const // TODO: implicit assumption here - NUM_LIMB_BITS large enough for all the quotient uint32_t quotient_limb_index = context->add_variable(barretenberg::fr(quotient_value.lo)); field_t quotient_limb = field_t::from_witness_index(context, quotient_limb_index); - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { context->decompose_into_default_range(quotient_limb.witness_index, static_cast(maximum_quotient_bits)); } else { context->decompose_into_base4_accumulators(quotient_limb.witness_index, @@ -1880,7 +1880,7 @@ void bigfield::unsafe_evaluate_multiply_add(const bigfield& input_left, ++max_hi_bits; } - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { // The plookup custom bigfield gate requires inputs are witnesses. // If we're using constant values, instantiate them as circuit variables const auto convert_constant_to_witness = [ctx](const bigfield& input) { @@ -2238,7 +2238,7 @@ void bigfield::unsafe_evaluate_multiple_multiply_add(const std::vector::unsafe_evaluate_multiple_multiply_add(const std::vectordecompose_into_default_range(lo.normalize().witness_index, carry_lo_msb); } /* NOTE TO AUDITOR: An extraneous block - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { carry_lo = carry_lo.normalize(); carry_hi = carry_hi.normalize(); ctx->decompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2604,7 +2604,7 @@ void bigfield::unsafe_evaluate_multiple_multiply_add(const std::vectordecompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2643,7 +2643,7 @@ void bigfield::unsafe_evaluate_square_add(const bigfield& left, const bigfield& quotient, const bigfield& remainder) { - if (C::type == plonk::PLOOKUP) { + if (C::type == bonk::ComposerType::PLOOKUP) { unsafe_evaluate_multiply_add(left, left, to_add, quotient, { remainder }); return; } @@ -2764,7 +2764,7 @@ void bigfield::unsafe_evaluate_square_add(const bigfield& left, const uint64_t carry_hi_msb = max_hi_bits - (2 * NUM_LIMB_BITS); const barretenberg::fr carry_lo_shift(uint256_t(uint256_t(1) << carry_lo_msb)); - if constexpr (C::type == plonk::PLOOKUP) { + if constexpr (C::type == bonk::ComposerType::PLOOKUP) { carry_lo = carry_lo.normalize(); carry_hi = carry_hi.normalize(); ctx->decompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp index 58cb089452..e3166bc0a6 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp index 246321c8f9..c1494d6267 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp index a031f45dd0..aeec29d4d6 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp @@ -393,14 +393,17 @@ template class element { std::array, 5> coordinates; }; - using twin_lookup_table = typename std:: - conditional, lookup_table_base<2>>::type; + using twin_lookup_table = typename std::conditional, + lookup_table_base<2>>::type; - using triple_lookup_table = typename std:: - conditional, lookup_table_base<3>>::type; + using triple_lookup_table = typename std::conditional, + lookup_table_base<3>>::type; - using quad_lookup_table = typename std:: - conditional, lookup_table_base<4>>::type; + using quad_lookup_table = typename std::conditional, + lookup_table_base<4>>::type; /** * Creates a pair of 4-bit lookup tables, the former corresponding to 4 input points, @@ -413,7 +416,7 @@ template class element { quad_lookup_table endo_table; uint256_t beta_val = barretenberg::field::cube_root_of_unity(); Fq beta(barretenberg::fr(beta_val.slice(0, 136)), barretenberg::fr(beta_val.slice(136, 256)), false); - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { for (size_t i = 0; i < 8; ++i) { endo_table.element_table[i + 8].x = base_table[7 - i].x * beta; endo_table.element_table[i + 8].y = base_table[7 - i].y; @@ -446,7 +449,7 @@ template class element { lookup_table_plookup<5> endo_table; uint256_t beta_val = barretenberg::field::cube_root_of_unity(); Fq beta(barretenberg::fr(beta_val.slice(0, 136)), barretenberg::fr(beta_val.slice(136, 256)), false); - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { for (size_t i = 0; i < 16; ++i) { endo_table.element_table[i + 16].x = base_table[15 - i].x * beta; endo_table.element_table[i + 16].y = base_table[15 - i].y; @@ -935,7 +938,7 @@ template class element { bool has_singleton; }; - using batch_lookup_table = typename std::conditional, batch_lookup_table_base>::type; }; diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp index f16233e08f..d3ce8aaceb 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp @@ -913,7 +913,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, compute_naf) /* These tests only work for UltraComposer */ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_mul) { - if constexpr (TypeParam::Curve::Composer::type == plonk::ComposerType::PLOOKUP) { + if constexpr (TypeParam::Curve::Composer::type == bonk::ComposerType::PLOOKUP) { TestFixture::test_compute_wnaf(); } else { GTEST_SKIP(); diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp index ac732ae22c..0e6a060304 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp @@ -15,7 +15,7 @@ element element::wnaf_batch_mul(const std::vector element::bn254_endo_batch_mul_with_generator break; } } - if constexpr (C::type != ComposerType::PLOOKUP) { + if constexpr (C::type != bonk::ComposerType::PLOOKUP) { // MERGENOTE: these four lines don't have an equivalent in d-b-p std::vector modified_big_points = big_points; std::vector modified_big_scalars = big_scalars; diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp index 0b7ff33f0b..96bbbd9d7f 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp @@ -12,7 +12,7 @@ template template element element::secp256k1_ecdsa_mul(const element& pubkey, const Fr& u1, const Fr& u2) { - if constexpr (C::type != ComposerType::PLOOKUP) { + if constexpr (C::type != bonk::ComposerType::PLOOKUP) { C* ctx = pubkey.get_context(); return batch_mul({ element::one(ctx), pubkey }, { u1, u2 }); } diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp index b0c2dea8de..1f05fa7138 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp index ff0629b20c..80efa2b4ce 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp index a2bb62031e..3551217b7b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp index 4e481d93af..015e7d5e87 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp @@ -26,7 +26,7 @@ TEST(stdlib_bool, test_basic_operations) bool_t f = e ^ b; // f = 0 d = (!f) & a; // d = 1 auto prover = composer.create_prover(); - // if constexpr (Composer::type == plonk::ComposerType::STANDARD_HONK) { + // if constexpr (Composer::type == bonk::ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[0][3], fr(1)); EXPECT_EQ(prover.wire_polynomials[1][3], fr(1)); EXPECT_EQ(prover.wire_polynomials[2][3], fr(1)); diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp index a4f7758fe3..c60eda71bd 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp index 98c247431f..866efbe050 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp index 800fd1059c..9493733b5d 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp index d500c251f5..5fdd63f342 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp @@ -129,7 +129,7 @@ template byte_array::byte_array(const field_t y_lo = (-validator) + (s_lo + shift); field_t y_overlap; - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { // carve out the 2 high bits from (y_lo + shifted_high_limb) and instantiate as y_overlap const uint256_t y_lo_value = y_lo.get_value() + shifted_high_limb.get_value(); const uint256_t y_overlap_value = y_lo_value >> 128; diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp index 6795867726..24cf051f52 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp index c0e04755bc..49aeb4eab4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp index b24568ea12..45657a00f6 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field.cpp index 918aaff424..eab866fee9 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.cpp @@ -739,7 +739,7 @@ void field_t::create_range_constraint(const size_t num_bits, st if (is_constant()) { ASSERT(uint256_t(get_value()).get_msb() < num_bits); } else { - if constexpr (ComposerContext::type == ComposerType::PLOOKUP) { + if constexpr (ComposerContext::type == bonk::ComposerType::PLOOKUP) { context->decompose_into_default_range( normalize().get_witness_index(), num_bits, plonk::UltraComposer::DEFAULT_PLOOKUP_RANGE_BITNUM, msg); } else { @@ -981,7 +981,7 @@ field_t field_t::accumulate(const std::vector< * * If num elements is not a multiple of 3, the final gate will be padded with zero_idx wires **/ - if constexpr (ComposerContext::type == plonk::PLOOKUP) { + if constexpr (ComposerContext::type == bonk::ComposerType::PLOOKUP) { ComposerContext* ctx = nullptr; std::vector accumulator; field_t constant_term = 0; @@ -1039,7 +1039,7 @@ field_t field_t::accumulate(const std::vector< accumulating_total = witness_t(ctx, new_total); } return total.normalize(); - } else if constexpr (ComposerContext::type == plonk::TURBO) { + } else if constexpr (ComposerContext::type == bonk::ComposerType::TURBO) { field_t total(0); bool odd_number = (input.size() & 0x01UL) == 0x01ULL; diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp index 071ffc8a56..7fafb7d91b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp @@ -192,7 +192,7 @@ template class stdlib_field : public testing::Test { uint64_t expected = fidget(composer); auto prover = composer.create_prover(); - if constexpr (Composer::type == plonk::ComposerType::STANDARD_HONK) { + if constexpr (Composer::type == bonk::ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[2][20], fr(expected)); } else { EXPECT_EQ(prover.key->polynomial_store.get("w_3_lagrange")[18], fr(expected)); @@ -249,7 +249,7 @@ template class stdlib_field : public testing::Test { auto prover = composer.create_prover(); - if constexpr (Composer::type == plonk::ComposerType::STANDARD_HONK) { + if constexpr (Composer::type == bonk::ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[2][19], fr(4181)); } else { EXPECT_EQ(prover.key->polynomial_store.get("w_3_lagrange")[17], fr(4181)); diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp index e38059c90e..abc7eee1a4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp index 16c0b9a117..5fda2c405a 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp index 47952895f8..49dc443813 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp index 94ab20d074..ef561311c7 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp @@ -25,7 +25,7 @@ DynamicArray::DynamicArray(Composer* composer, const size_t maximum_si , _max_size(maximum_size) , _length(0) { - static_assert(Composer::type == plonk::ComposerType::PLOOKUP); + static_assert(Composer::type == bonk::ComposerType::PLOOKUP); ASSERT(_context != nullptr); _inner_table = ram_table(_context, maximum_size); // Initialize the ram table with all zeroes diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp index d7a3e1ac16..c046ee81dc 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp @@ -13,7 +13,7 @@ namespace stdlib { */ template ram_table::ram_table(Composer* composer, const size_t table_size) { - static_assert(Composer::type == plonk::ComposerType::PLOOKUP); + static_assert(Composer::type == bonk::ComposerType::PLOOKUP); _context = composer; _length = table_size; _index_initialized.resize(table_size); @@ -35,7 +35,7 @@ template ram_table::ram_table(Composer* composer, */ template ram_table::ram_table(const std::vector& table_entries) { - static_assert(Composer::type == plonk::ComposerType::PLOOKUP); + static_assert(Composer::type == bonk::ComposerType::PLOOKUP); // get the composer _context for (const auto& entry : table_entries) { if (entry.get_context() != nullptr) { diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp index d1330e804f..ac680f5990 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp @@ -9,7 +9,7 @@ namespace stdlib { template rom_table::rom_table(const std::vector& table_entries) { - static_assert(Composer::type == ComposerType::PLOOKUP); + static_assert(Composer::type == bonk::ComposerType::PLOOKUP); // get the composer context for (const auto& entry : table_entries) { if (entry.get_context() != nullptr) { diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp index 5c6b914cdb..343b188405 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp @@ -10,7 +10,7 @@ namespace stdlib { template twin_rom_table::twin_rom_table(const std::vector>& table_entries) { - static_assert(Composer::type == ComposerType::PLOOKUP); + static_assert(Composer::type == bonk::ComposerType::PLOOKUP); // get the composer context for (const auto& entry : table_entries) { if (entry[0].get_context() != nullptr) { diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp index d2f2ece246..d041e08e38 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp index 8e1bd615f6..7adce9d0a4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp index 1ff91bdcee..d4b7e85a1f 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp index 6aefd17b10..c628138caa 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp @@ -16,7 +16,7 @@ std::vector uint::constrain_accumulators(Composer* c const size_t num_bits, std::string const& msg) const { - if constexpr (Composer::type == plonk::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { // TODO: manage higher bit ranges const auto sequence = plookup_read::get_lookup_accumulators(plookup::MultiTableId::UINT32_XOR, @@ -317,7 +317,7 @@ template bool_t uintget_variable(right_idx)) - uint256_t(context->get_variable(left_idx)) * uint256_t(4); - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { uint256_t lo_bit = quad & 1; uint256_t hi_bit = (quad & 2) >> 1; // difference in quads = 0, 1, 2, 3 = delta diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp index 1747d12599..e7eccf30dd 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp @@ -194,19 +194,19 @@ template inline std::ostream& operator<<(std::ostream& } template -using uint8 = typename std::conditional, uint>::type; template -using uint16 = typename std::conditional, uint>::type; template -using uint32 = typename std::conditional, uint>::type; template -using uint64 = typename std::conditional, uint>::type; diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp index 8ce1326a9a..025e8b8763 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp @@ -76,7 +76,7 @@ uint_native rotate(uint_native value, size_t rotation) : value; } template class stdlib_uint : public testing::Test { - typedef typename std::conditional, stdlib::uint>::type uint_ct; typedef stdlib::bool_t bool_ct; diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp index 4c8f6a70bc..b1cc5137e1 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp index 2326494030..a0bdec7827 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp index c5a59d827e..586631fb2b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp b/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp index fd5352f78d..87d5375f95 100644 --- a/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp @@ -246,7 +246,7 @@ template class Transcript { } field_pt T0; - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { T0 = stdlib::pedersen_plookup::compress(compression_buffer); } else { T0 = stdlib::pedersen::compress(compression_buffer); diff --git a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp index b5b448bde9..fb0de97603 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp @@ -54,7 +54,7 @@ template struct evaluation_domain { field_t compress() const { - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { field_t out = pedersen_plookup::compress({ root, domain, @@ -74,7 +74,7 @@ template struct evaluation_domain { static barretenberg::fr compress_native(const barretenberg::evaluation_domain& input) { barretenberg::fr out; - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { out = crypto::pedersen::lookup::compress_native({ input.root, input.domain, @@ -155,7 +155,7 @@ template struct verification_key { const auto circuit_key_compressed = compress(); bool found = false; // if we're using Plookup, use a ROM table to index the keys - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { field_t key_index(witness_t(context, 0)); std::vector> compressed_keys; for (size_t i = 0; i < keys_in_set.size(); ++i) { @@ -205,7 +205,7 @@ template struct verification_key { } field_t compressed_key; - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { compressed_key = pedersen_plookup::compress(key_witnesses); } else { compressed_key = pedersen::compress(key_witnesses); @@ -245,7 +245,7 @@ template struct verification_key { key_witnesses.push_back(y_limbs[3]); } barretenberg::fr compressed_key; - if constexpr (Composer::type == ComposerType::PLOOKUP) { + if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { compressed_key = crypto::pedersen::lookup::compress_native(key_witnesses); } else { compressed_key = crypto::pedersen::compress_native(key_witnesses); diff --git a/cpp/src/barretenberg/stdlib/types/types.hpp b/cpp/src/barretenberg/stdlib/types/types.hpp index 4fdc71e1c0..61f08b0c73 100644 --- a/cpp/src/barretenberg/stdlib/types/types.hpp +++ b/cpp/src/barretenberg/stdlib/types/types.hpp @@ -31,31 +31,31 @@ using namespace plonk; static constexpr size_t SYSTEM_COMPOSER = plonk::SYSTEM_COMPOSER; typedef std::conditional_t< - SYSTEM_COMPOSER == plonk::STANDARD, + SYSTEM_COMPOSER == bonk::STANDARD, plonk::StandardComposer, - std::conditional_t> + std::conditional_t> Composer; -typedef std::conditional_t> + std::conditional_t> Prover; typedef std::conditional_t< - SYSTEM_COMPOSER == plonk::STANDARD, + SYSTEM_COMPOSER == bonk::STANDARD, plonk::Verifier, - std::conditional_t> + std::conditional_t> Verifier; -typedef std::conditional_t> + std::conditional_t> Prover; typedef std::conditional_t< - SYSTEM_COMPOSER == plonk::STANDARD, + SYSTEM_COMPOSER == bonk::STANDARD, plonk::Verifier, - std::conditional_t> + std::conditional_t> Verifier; typedef stdlib::witness_t witness_ct; @@ -90,7 +90,7 @@ typedef stdlib::schnorr::signature_bits signature_bits; // Ultra-composer specific types typedef stdlib::rom_table rom_table_ct; -typedef std::conditional_t, recursion::recursive_ultra_verifier_settings> recursive_inner_verifier_settings; From bbf42237f7abb2db664bff44df7c3dbcb1fe8fa2 Mon Sep 17 00:00:00 2001 From: codygunton Date: Sun, 2 Apr 2023 01:01:36 +0000 Subject: [PATCH 2/5] Move pk & vk into plonk. --- .../dsl/acir_proofs/acir_proofs.cpp | 12 +- .../standard_honk_composer_helper.cpp | 12 +- .../standard_honk_composer_helper.hpp | 21 +-- .../honk/composer/standard_honk_composer.hpp | 8 +- .../barretenberg/honk/proof_system/prover.cpp | 2 +- .../barretenberg/honk/proof_system/prover.hpp | 6 +- .../honk/proof_system/prover_library.cpp | 10 +- .../honk/proof_system/prover_library.hpp | 8 +- .../honk/proof_system/prover_library.test.cpp | 6 +- .../honk/proof_system/verifier.cpp | 2 +- .../honk/proof_system/verifier.hpp | 6 +- .../honk/proof_system/verifier.test.cpp | 17 +- .../proofs/compute_circuit_data.hpp | 14 +- .../proofs/join_split/c_bind.cpp | 6 +- .../proofs/join_split/join_split.cpp | 16 +- .../proofs/join_split/join_split.hpp | 8 +- .../proofs/join_split/join_split.test.cpp | 2 +- .../join_split/join_split_js_parity.test.cpp | 2 +- .../join_split_example/proofs/verify.hpp | 2 +- .../plonk/composer/composer_base.cpp | 2 +- .../composer_helper/composer_helper_lib.cpp | 77 ++++++++++ .../composer_helper/composer_helper_lib.hpp | 29 ++++ .../standard_plonk_composer_helper.cpp | 23 +-- .../standard_plonk_composer_helper.hpp | 21 ++- .../turbo_plonk_composer_helper.cpp | 13 +- .../turbo_plonk_composer_helper.hpp | 11 +- .../splitting_tmp/standard_plonk_composer.hpp | 8 +- .../standard_plonk_composer.test.cpp | 10 +- .../splitting_tmp/turbo_plonk_composer.hpp | 8 +- .../turbo_plonk_composer.test.cpp | 13 +- .../plonk/composer/standard_composer.test.cpp | 10 +- .../plonk/composer/turbo_composer.test.cpp | 10 +- .../commitment_scheme/commitment_scheme.hpp | 6 +- .../kate_commitment_scheme.cpp | 9 +- .../kate_commitment_scheme.hpp | 6 +- .../plonk/proof_system/prover/prover.hpp | 4 +- .../proof_system/proving_key/proving_key.cpp | 9 +- .../proof_system/proving_key/proving_key.hpp | 16 +- .../proving_key/proving_key.test.cpp | 22 +-- .../proof_system/proving_key/serialize.hpp | 4 +- .../types/polynomial_manifest.hpp | 6 +- .../proof_system/verification_key/sol_gen.hpp | 0 .../verification_key/verification_key.cpp | 11 +- .../verification_key/verification_key.hpp | 12 +- .../verification_key.test.cpp | 5 +- .../proof_system/verifier/verifier.test.cpp | 2 +- .../permutation_widget_impl.hpp | 2 +- .../random_widgets/plookup_widget_impl.hpp | 2 +- .../widgets/random_widgets/random_widget.hpp | 4 +- .../transition_widgets/arithmetic_widget.hpp | 27 ++-- .../transition_widgets/elliptic_widget.hpp | 33 ++-- .../transition_widgets/fixed_base_widget.hpp | 11 +- .../genperm_sort_widget.hpp | 20 +-- .../plookup_arithmetic_widget.hpp | 38 +++-- .../plookup_auxiliary_widget.hpp | 44 +++--- .../transition_widgets/transition_widget.hpp | 5 +- .../turbo_arithmetic_widget.hpp | 46 +++--- .../transition_widgets/turbo_logic_widget.hpp | 28 ++-- .../transition_widgets/turbo_range_widget.hpp | 26 ++-- .../composer/composer_helper_lib.cpp | 145 +++++++++--------- .../composer/composer_helper_lib.hpp | 58 ++++--- .../composer/permutation_helper.hpp | 14 +- .../polynomial_store/polynomial_store.hpp | 2 + .../polynomial_store.test.cpp | 12 +- .../proof_system/work_queue/work_queue.cpp | 2 +- .../proof_system/work_queue/work_queue.hpp | 7 +- .../verification_key/verification_key.hpp | 14 +- .../stdlib/recursion/verifier/verifier.hpp | 8 +- .../recursion/verifier/verifier.test.cpp | 2 +- .../verifier/verifier_turbo.test.cpp | 2 +- .../barretenberg/transcript/transcript.hpp | 4 +- 71 files changed, 588 insertions(+), 475 deletions(-) create mode 100644 cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp create mode 100644 cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp rename cpp/src/barretenberg/{ => plonk}/proof_system/proving_key/proving_key.cpp (96%) rename cpp/src/barretenberg/{ => plonk}/proof_system/proving_key/proving_key.hpp (81%) rename cpp/src/barretenberg/{ => plonk}/proof_system/proving_key/proving_key.test.cpp (88%) rename cpp/src/barretenberg/{ => plonk}/proof_system/proving_key/serialize.hpp (99%) rename cpp/src/barretenberg/{ => plonk}/proof_system/types/polynomial_manifest.hpp (99%) rename cpp/src/barretenberg/{ => plonk}/proof_system/verification_key/sol_gen.hpp (100%) rename cpp/src/barretenberg/{ => plonk}/proof_system/verification_key/verification_key.cpp (92%) rename cpp/src/barretenberg/{ => plonk}/proof_system/verification_key/verification_key.hpp (90%) rename cpp/src/barretenberg/{ => plonk}/proof_system/verification_key/verification_key.test.cpp (92%) diff --git a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp index 6d81b0c732..d6e673eca9 100644 --- a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp +++ b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp @@ -69,9 +69,9 @@ size_t init_proving_key(uint8_t const* constraint_system_buf, uint8_t const** pk size_t init_verification_key(void* pippenger, uint8_t const* g2x, uint8_t const* pk_buf, uint8_t const** vk_buf) { std::shared_ptr crs; - bonk::proving_key_data pk_data; + plonk::proving_key_data pk_data; read(pk_buf, pk_data); - auto proving_key = std::make_shared(std::move(pk_data), crs); + auto proving_key = std::make_shared(std::move(pk_data), crs); auto crs_factory = std::make_unique( reinterpret_cast(pippenger), g2x); @@ -103,9 +103,9 @@ size_t new_proof(void* pippenger, auto constraint_system = from_buffer(constraint_system_buf); std::shared_ptr crs; - bonk::proving_key_data pk_data; + plonk::proving_key_data pk_data; read(pk_buf, pk_data); - auto proving_key = std::make_shared(std::move(pk_data), crs); + auto proving_key = std::make_shared(std::move(pk_data), crs); auto witness = from_buffer>(witness_buf); @@ -136,9 +136,9 @@ bool verify_proof( #endif auto constraint_system = from_buffer(constraint_system_buf); auto crs = std::make_shared(g2x); - bonk::verification_key_data vk_data; + plonk::verification_key_data vk_data; read(vk_buf, vk_data); - auto verification_key = std::make_shared(std::move(vk_data), crs); + auto verification_key = std::make_shared(std::move(vk_data), crs); Composer composer(nullptr, verification_key); create_circuit(composer, constraint_system); diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp index e45440050c..7d878d9fd5 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp @@ -23,7 +23,7 @@ namespace honk { * @return Pointer to the initialized proving key updated with selector polynomials. * */ template -std::shared_ptr StandardHonkComposerHelper::compute_proving_key_base( +std::shared_ptr StandardHonkComposerHelper::compute_proving_key_base( const CircuitConstructor& constructor, const size_t minimum_circuit_size, const size_t num_randomized_gates) { // Initialize circuit_proving_key @@ -43,10 +43,10 @@ std::shared_ptr StandardHonkComposerHelper -std::shared_ptr StandardHonkComposerHelper::compute_verification_key_base( - std::shared_ptr const& proving_key, std::shared_ptr const& vrs) +std::shared_ptr StandardHonkComposerHelper::compute_verification_key_base( + std::shared_ptr const& proving_key, std::shared_ptr const& vrs) { - auto key = std::make_shared( + auto key = std::make_shared( proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc auto commitment_key = pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); @@ -98,7 +98,7 @@ void StandardHonkComposerHelper::compute_witness(const Circu * */ template -std::shared_ptr StandardHonkComposerHelper::compute_proving_key( +std::shared_ptr StandardHonkComposerHelper::compute_proving_key( const CircuitConstructor& circuit_constructor) { if (circuit_proving_key) { @@ -123,7 +123,7 @@ std::shared_ptr StandardHonkComposerHelper -std::shared_ptr StandardHonkComposerHelper::compute_verification_key( +std::shared_ptr StandardHonkComposerHelper::compute_verification_key( const CircuitConstructor& circuit_constructor) { if (circuit_verification_key) { diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp index 80e48a5eeb..8c6d56ccc0 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp @@ -2,12 +2,12 @@ #include "barretenberg/polynomials/polynomial.hpp" #include "barretenberg/srs/reference_string/file_reference_string.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/honk/proof_system/prover.hpp" #include "barretenberg/honk/proof_system/verifier.hpp" #include "barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp" #include "barretenberg/honk/pcs/commitment_key.hpp" -#include "barretenberg/proof_system/verification_key/verification_key.hpp" +#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" #include "barretenberg/proof_system/arithmetization/gate_data.hpp" #include "barretenberg/proof_system/composer/composer_helper_lib.hpp" @@ -22,9 +22,9 @@ template class StandardHonkComposerHelper { public: static constexpr size_t NUM_RANDOMIZED_GATES = 2; // equal to the number of multilinear evaluations leaked static constexpr size_t num_wires = CircuitConstructor::num_wires; - std::shared_ptr circuit_proving_key; + std::shared_ptr circuit_proving_key; std::vector wire_polynomials; - std::shared_ptr circuit_verification_key; + std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all std::shared_ptr crs_factory_; @@ -40,7 +40,8 @@ template class StandardHonkComposerHelper { StandardHonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} - StandardHonkComposerHelper(std::shared_ptr p_key, std::shared_ptr v_key) + StandardHonkComposerHelper(std::shared_ptr p_key, + std::shared_ptr v_key) : circuit_proving_key(std::move(p_key)) , circuit_verification_key(std::move(v_key)) {} @@ -50,8 +51,8 @@ template class StandardHonkComposerHelper { StandardHonkComposerHelper& operator=(const StandardHonkComposerHelper& other) = delete; ~StandardHonkComposerHelper() = default; - std::shared_ptr compute_proving_key(const CircuitConstructor& circuit_constructor); - std::shared_ptr compute_verification_key(const CircuitConstructor& circuit_constructor); + std::shared_ptr compute_proving_key(const CircuitConstructor& circuit_constructor); + std::shared_ptr compute_verification_key(const CircuitConstructor& circuit_constructor); StandardVerifier create_verifier(const CircuitConstructor& circuit_constructor); @@ -59,14 +60,14 @@ template class StandardHonkComposerHelper { // TODO(#216)(Adrian): Seems error prone to provide the number of randomized gates // Cody: Where should this go? In the flavor (or whatever that becomes)? - std::shared_ptr compute_proving_key_base( + std::shared_ptr compute_proving_key_base( const CircuitConstructor& circuit_constructor, const size_t minimum_ciricut_size = 0, const size_t num_randomized_gates = NUM_RANDOMIZED_GATES); // This needs to be static as it may be used only to compute the selector commitments. - static std::shared_ptr compute_verification_key_base( - std::shared_ptr const& proving_key, + static std::shared_ptr compute_verification_key_base( + std::shared_ptr const& proving_key, std::shared_ptr const& vrs); void compute_witness(const CircuitConstructor& circuit_constructor, const size_t minimum_circuit_size = 0); diff --git a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp index d9ca6145c3..c918ed117d 100644 --- a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp +++ b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp @@ -57,8 +57,8 @@ class StandardHonkComposer { {} - StandardHonkComposer(std::shared_ptr const& p_key, - std::shared_ptr const& v_key, + StandardHonkComposer(std::shared_ptr const& p_key, + std::shared_ptr const& v_key, size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(p_key, v_key) @@ -161,12 +161,12 @@ class StandardHonkComposer { /**Proof and verification-related methods*/ - std::shared_ptr compute_proving_key() + std::shared_ptr compute_proving_key() { return composer_helper.compute_proving_key(circuit_constructor); } - std::shared_ptr compute_verification_key() + std::shared_ptr compute_verification_key() { return composer_helper.compute_verification_key(circuit_constructor); } diff --git a/cpp/src/barretenberg/honk/proof_system/prover.cpp b/cpp/src/barretenberg/honk/proof_system/prover.cpp index e0c580099f..73b4aa9711 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover.cpp @@ -39,7 +39,7 @@ using POLYNOMIAL = honk::StandardArithmetization::POLYNOMIAL; * */ template Prover::Prover(std::vector&& wire_polys, - std::shared_ptr input_key) + std::shared_ptr input_key) : wire_polynomials(wire_polys) , key(input_key) , commitment_key(std::make_unique( diff --git a/cpp/src/barretenberg/honk/proof_system/prover.hpp b/cpp/src/barretenberg/honk/proof_system/prover.hpp index 5c9aa39ad8..f3111efcf0 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover.hpp +++ b/cpp/src/barretenberg/honk/proof_system/prover.hpp @@ -4,7 +4,7 @@ #include "barretenberg/polynomials/polynomial.hpp" #include "barretenberg/honk/flavor/flavor.hpp" #include -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/honk/pcs/commitment_key.hpp" #include "barretenberg/plonk/proof_system/types/proof.hpp" #include "barretenberg/plonk/proof_system/types/program_settings.hpp" @@ -33,7 +33,7 @@ using Polynomial = Polynomial; template class Prover { public: - Prover(std::vector&& wire_polys, std::shared_ptr input_key = nullptr); + Prover(std::vector&& wire_polys, std::shared_ptr input_key = nullptr); void execute_preamble_round(); void execute_wire_commitments_round(); @@ -61,7 +61,7 @@ template class Prover { std::vector wire_polynomials; barretenberg::polynomial z_permutation; - std::shared_ptr key; + std::shared_ptr key; std::shared_ptr commitment_key; diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.cpp b/cpp/src/barretenberg/honk/proof_system/prover_library.cpp index fe102bcd2c..5e96419ded 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.cpp @@ -35,7 +35,7 @@ using Polynomial = barretenberg::Polynomial; */ // TODO(#222)(luke): Parallelize template -Polynomial compute_permutation_grand_product(std::shared_ptr& key, +Polynomial compute_permutation_grand_product(std::shared_ptr& key, std::vector& wire_polynomials, Fr beta, Fr gamma) @@ -181,7 +181,7 @@ Polynomial compute_permutation_grand_product(std::shared_ptr& * @param gamma * @return Polynomial */ -Polynomial compute_lookup_grand_product(std::shared_ptr& key, +Polynomial compute_lookup_grand_product(std::shared_ptr& key, std::vector& wire_polynomials, Polynomial& sorted_list_accumulator, Fr eta, @@ -327,7 +327,7 @@ Polynomial compute_lookup_grand_product(std::shared_ptr& key, * @param eta random challenge * @return Polynomial */ -Polynomial compute_sorted_list_accumulator(std::shared_ptr& key, +Polynomial compute_sorted_list_accumulator(std::shared_ptr& key, std::vector& sorted_list_polynomials, Fr eta) { @@ -353,8 +353,8 @@ Polynomial compute_sorted_list_accumulator(std::shared_ptr& k } template Polynomial compute_permutation_grand_product( - std::shared_ptr&, std::vector&, Fr, Fr); + std::shared_ptr&, std::vector&, Fr, Fr); template Polynomial compute_permutation_grand_product( - std::shared_ptr&, std::vector&, Fr, Fr); + std::shared_ptr&, std::vector&, Fr, Fr); } // namespace honk::prover_library diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.hpp b/cpp/src/barretenberg/honk/proof_system/prover_library.hpp index 0fc6d1662f..33f5f36bbd 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.hpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.hpp @@ -1,7 +1,7 @@ #pragma once #include "barretenberg/ecc/curves/bn254/fr.hpp" #include "barretenberg/polynomials/polynomial.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/types/proof.hpp" #include "barretenberg/plonk/proof_system/types/program_settings.hpp" @@ -11,19 +11,19 @@ using Fr = barretenberg::fr; using Polynomial = barretenberg::Polynomial; template -Polynomial compute_permutation_grand_product(std::shared_ptr& key, +Polynomial compute_permutation_grand_product(std::shared_ptr& key, std::vector& wire_polynomials, Fr beta, Fr gamma); -Polynomial compute_lookup_grand_product(std::shared_ptr& key, +Polynomial compute_lookup_grand_product(std::shared_ptr& key, std::vector& wire_polynomials, Polynomial& sorted_list_accumulator, Fr eta, Fr beta, Fr gamma); -Polynomial compute_sorted_list_accumulator(std::shared_ptr& key, +Polynomial compute_sorted_list_accumulator(std::shared_ptr& key, std::vector& sorted_list_polynomials, Fr eta); diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp index df9c2ee880..aca4083440 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp @@ -50,7 +50,7 @@ template class ProverLibraryTests : public testing::Test { auto reference_string = std::make_shared(num_gates + 1, "../srs_db/ignition"); // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. - auto proving_key = std::make_shared( + auto proving_key = std::make_shared( num_gates, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); // static const size_t program_width = StandardProver::settings_::program_width; @@ -159,7 +159,7 @@ template class ProverLibraryTests : public testing::Test { auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. - auto proving_key = std::make_shared( + auto proving_key = std::make_shared( circuit_size, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); // Construct mock wire and permutation polynomials. @@ -286,7 +286,7 @@ template class ProverLibraryTests : public testing::Test { static const size_t circuit_size = 8; static const size_t num_public_inputs = 0; auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); - auto proving_key = std::make_shared( + auto proving_key = std::make_shared( circuit_size, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); // Get random challenge eta diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.cpp index 4eae6955d3..36f3ff3cf7 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.cpp @@ -30,7 +30,7 @@ using namespace honk::sumcheck; namespace honk { template -Verifier::Verifier(std::shared_ptr verifier_key) +Verifier::Verifier(std::shared_ptr verifier_key) : key(verifier_key) {} diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.hpp b/cpp/src/barretenberg/honk/proof_system/verifier.hpp index e4ef74d667..180fe9ddf3 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.hpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.hpp @@ -1,7 +1,7 @@ #pragma once #include "barretenberg/plonk/proof_system/types/proof.hpp" #include "./program_settings.hpp" -#include "barretenberg/proof_system/verification_key/verification_key.hpp" +#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" #include "barretenberg/transcript/manifest.hpp" #include "barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp" #include "../sumcheck/sumcheck.hpp" @@ -16,7 +16,7 @@ namespace honk { template class Verifier { public: - Verifier(std::shared_ptr verifier_key = nullptr); + Verifier(std::shared_ptr verifier_key = nullptr); Verifier(Verifier&& other); Verifier(const Verifier& other) = delete; Verifier& operator=(const Verifier& other) = delete; @@ -24,7 +24,7 @@ template class Verifier { bool verify_proof(const plonk::proof& proof); - std::shared_ptr key; + std::shared_ptr key; std::map kate_g1_elements; std::map kate_fr_elements; std::shared_ptr kate_verification_key; diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp index 27abc34a52..3efc21d46f 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp @@ -3,7 +3,7 @@ #include "barretenberg/polynomials/polynomial.hpp" #include "barretenberg/honk/flavor/flavor.hpp" #include "prover.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/transcript/transcript.hpp" #include "verifier.hpp" #include "barretenberg/ecc/curves/bn254/scalar_multiplication/scalar_multiplication.hpp" @@ -26,7 +26,7 @@ template class VerifierTests : public testing::Test { return honk::StandardHonk::create_manifest(num_public_inputs, num_sumcheck_rounds); } - static StandardVerifier generate_verifier(std::shared_ptr circuit_proving_key) + static StandardVerifier generate_verifier(std::shared_ptr circuit_proving_key) { std::array poly_coefficients; poly_coefficients[0] = circuit_proving_key->polynomial_store.get("q_1_lagrange").get_coefficients(); @@ -51,10 +51,11 @@ template class VerifierTests : public testing::Test { } auto crs = std::make_shared("../srs_db/ignition"); - auto circuit_verification_key = std::make_shared(circuit_proving_key->circuit_size, - circuit_proving_key->num_public_inputs, - crs, - circuit_proving_key->composer_type); + auto circuit_verification_key = + std::make_shared(circuit_proving_key->circuit_size, + circuit_proving_key->num_public_inputs, + crs, + circuit_proving_key->composer_type); circuit_verification_key->commitments.insert({ "Q_1", commitments[0] }); circuit_verification_key->commitments.insert({ "Q_2", commitments[1] }); @@ -82,8 +83,8 @@ template class VerifierTests : public testing::Test { // even indices = mul gates, odd incides = add gates auto crs = std::make_shared(n + 1, "../srs_db/ignition"); - std::shared_ptr proving_key = - std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD_HONK); + std::shared_ptr proving_key = + std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD_HONK); polynomial w_l(n); polynomial w_r(n); diff --git a/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp index 34929840b6..c40bd4894a 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp @@ -5,7 +5,7 @@ #include #include #include "barretenberg/common/timer.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #ifndef __wasm__ #include @@ -20,8 +20,8 @@ struct circuit_data { {} std::shared_ptr srs; - std::shared_ptr proving_key; - std::shared_ptr verification_key; + std::shared_ptr proving_key; + std::shared_ptr verification_key; size_t num_gates; std::vector padding_proof; bool mock; @@ -107,10 +107,10 @@ circuit_data get_circuit_data(std::string const& name, if (exists(pk_path) && load) { info(name, ": Loading proving key: ", pk_path); auto pk_stream = std::ifstream(pk_path); - bonk::proving_key_data pk_data; + plonk::proving_key_data pk_data; read_mmap(pk_stream, pk_dir, pk_data); data.proving_key = - std::make_shared(std::move(pk_data), srs->get_prover_crs(pk_data.circuit_size + 1)); + std::make_shared(std::move(pk_data), srs->get_prover_crs(pk_data.circuit_size + 1)); data.num_gates = pk_data.circuit_size; info(name, ": Circuit size 2^n: ", data.num_gates); benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), @@ -170,10 +170,10 @@ circuit_data get_circuit_data(std::string const& name, if (exists(vk_path) && load) { info(name, ": Loading verification key from: ", vk_path); auto vk_stream = std::ifstream(vk_path); - bonk::verification_key_data vk_data; + plonk::verification_key_data vk_data; read(vk_stream, vk_data); data.verification_key = - std::make_shared(std::move(vk_data), data.srs->get_verifier_crs()); + std::make_shared(std::move(vk_data), data.srs->get_verifier_crs()); info(name, ": Verification key hash: ", data.verification_key->sha256_hash()); benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), "Core", diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp index 88ffa3bf80..e46a34307f 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp @@ -8,7 +8,7 @@ #include #include "barretenberg/ecc/curves/grumpkin/grumpkin.hpp" #include "barretenberg/srs/reference_string/pippenger_reference_string.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #include using namespace barretenberg; @@ -30,7 +30,7 @@ WASM_EXPORT void join_split__init_proving_key(bool mock) WASM_EXPORT void join_split__init_proving_key_from_buffer(uint8_t const* pk_buf) { std::shared_ptr crs; - bonk::proving_key_data pk_data; + plonk::proving_key_data pk_data; read(pk_buf, pk_data); init_proving_key(crs, std::move(pk_data)); } @@ -78,7 +78,7 @@ WASM_EXPORT void join_split__init_verification_key(void* pippenger, uint8_t cons WASM_EXPORT void join_split__init_verification_key_from_buffer(uint8_t const* vk_buf, uint8_t const* g2x) { auto crs = std::make_shared(g2x); - bonk::verification_key_data vk_data; + plonk::verification_key_data vk_data; read(vk_buf, vk_data); init_verification_key(crs, std::move(vk_data)); } diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp index 213628a18f..a9ba1033d7 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp @@ -10,8 +10,8 @@ namespace join_split { using namespace plonk; using namespace plonk::stdlib::merkle_tree; -static std::shared_ptr proving_key; -static std::shared_ptr verification_key; +static std::shared_ptr proving_key; +static std::shared_ptr verification_key; void init_proving_key(std::shared_ptr const& crs_factory, bool mock) { @@ -35,10 +35,10 @@ void init_proving_key(std::shared_ptr const& crs_f } } -void init_proving_key(std::shared_ptr const& crs, bonk::proving_key_data&& pk_data) +void init_proving_key(std::shared_ptr const& crs, plonk::proving_key_data&& pk_data) { release_key(); - proving_key = std::make_shared(std::move(pk_data), crs); + proving_key = std::make_shared(std::move(pk_data), crs); } void release_key() @@ -59,9 +59,9 @@ void init_verification_key(std::unique_ptr&& crs_f } void init_verification_key(std::shared_ptr const& crs, - bonk::verification_key_data&& vk_data) + plonk::verification_key_data&& vk_data) { - verification_key = std::make_shared(std::move(vk_data), crs); + verification_key = std::make_shared(std::move(vk_data), crs); } stdlib::types::Prover new_join_split_prover(join_split_tx const& tx, bool mock) @@ -104,12 +104,12 @@ bool verify_proof(plonk::proof const& proof) return verifier.verify_proof(proof); } -std::shared_ptr get_proving_key() +std::shared_ptr get_proving_key() { return proving_key; } -std::shared_ptr get_verification_key() +std::shared_ptr get_verification_key() { return verification_key; } diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp index e4fe781700..001ac4e2df 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp @@ -12,22 +12,22 @@ using namespace plonk::stdlib::types; void init_proving_key(std::shared_ptr const& crs_factory, bool mock); -void init_proving_key(std::shared_ptr const& crs, bonk::proving_key_data&& pk_data); +void init_proving_key(std::shared_ptr const& crs, plonk::proving_key_data&& pk_data); void release_key(); void init_verification_key(std::unique_ptr&& crs_factory); void init_verification_key(std::shared_ptr const& crs, - bonk::verification_key_data&& vk_data); + plonk::verification_key_data&& vk_data); stdlib::types::Prover new_join_split_prover(join_split_tx const& tx, bool mock); bool verify_proof(plonk::proof const& proof); -std::shared_ptr get_proving_key(); +std::shared_ptr get_proving_key(); -std::shared_ptr get_verification_key(); +std::shared_ptr get_verification_key(); } // namespace join_split } // namespace proofs diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp index e7564dc63a..3b4ad79e04 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp @@ -6,7 +6,7 @@ #include "barretenberg/common/streams.hpp" #include "barretenberg/common/test.hpp" #include -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #include "barretenberg/stdlib/merkle_tree/index.hpp" namespace join_split_example::proofs::join_split { diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp index e470b98f88..8917fdd60b 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp @@ -4,7 +4,7 @@ #include "../notes/native/index.hpp" #include "barretenberg/common/streams.hpp" #include "barretenberg/common/test.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #include "barretenberg/stdlib/merkle_tree/index.hpp" #include "barretenberg/crypto/sha256/sha256.hpp" diff --git a/cpp/src/barretenberg/join_split_example/proofs/verify.hpp b/cpp/src/barretenberg/join_split_example/proofs/verify.hpp index 140203f0c9..f706adf0ca 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/verify.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/verify.hpp @@ -20,7 +20,7 @@ template struct verify_result { std::vector proof_data; bool verified; - std::shared_ptr verification_key; + std::shared_ptr verification_key; size_t number_of_gates; }; diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.cpp b/cpp/src/barretenberg/plonk/composer/composer_base.cpp index 19ab5364c4..1f62fe5c8a 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.cpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.cpp @@ -1,5 +1,5 @@ #include "composer_base.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/utils/permutation.hpp" namespace plonk { diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp new file mode 100644 index 0000000000..457a42511e --- /dev/null +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp @@ -0,0 +1,77 @@ +/** + * @file composer_helper_lib.cpp + * @brief Contains implementations of some of the functions used both by Honk and Plonk-style composers (excluding + * permutation functions) + * + */ +#include "composer_helper_lib.hpp" +#include "barretenberg/honk/pcs/commitment_key.hpp" + +namespace plonk { + +/** + * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into + * cache + * + * @param key Pointer to the proving key + * @param selector_properties Names of selectors + */ +void compute_monomial_and_coset_selector_forms(plonk::proving_key* circuit_proving_key, + std::vector selector_properties) +{ + for (size_t i = 0; i < selector_properties.size(); i++) { + // Compute monomial form of selector polynomial + auto& selector_poly_lagrange = + circuit_proving_key->polynomial_store.get(selector_properties[i].name + "_lagrange"); + barretenberg::polynomial selector_poly(circuit_proving_key->circuit_size); + barretenberg::polynomial_arithmetic::ifft( + &selector_poly_lagrange[0], &selector_poly[0], circuit_proving_key->small_domain); + + // Compute coset FFT of selector polynomial + barretenberg::polynomial selector_poly_fft(selector_poly, circuit_proving_key->circuit_size * 4 + 4); + selector_poly_fft.coset_fft(circuit_proving_key->large_domain); + + // TODO(luke): For Standard/Turbo, the lagrange polynomials can be removed from the store at this point but this + // is not the case for Ultra. Implement? + circuit_proving_key->polynomial_store.put(selector_properties[i].name, std::move(selector_poly)); + circuit_proving_key->polynomial_store.put(selector_properties[i].name + "_fft", std::move(selector_poly_fft)); + } +} + +/** + * @brief Computes the verification key by computing the: + * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, + * (2) sets the polynomial manifest using the data from proving key. + */ +std::shared_ptr compute_verification_key_common( + std::shared_ptr const& proving_key, std::shared_ptr const& vrs) +{ + auto circuit_verification_key = std::make_shared( + proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); + // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc + auto commitment_key = honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); + + for (size_t i = 0; i < proving_key->polynomial_manifest.size(); ++i) { + const auto& poly_info = proving_key->polynomial_manifest[i]; + + const std::string poly_label(poly_info.polynomial_label); + const std::string selector_commitment_label(poly_info.commitment_label); + + if (poly_info.source == PolynomialSource::SELECTOR || poly_info.source == PolynomialSource::PERMUTATION || + poly_info.source == PolynomialSource::OTHER) { + // Fetch the polynomial in its vector form. + + // Commit to the constraint selector polynomial and insert the commitment in the verification key. + + auto poly_commitment = commitment_key.commit(proving_key->polynomial_store.get(poly_label)); + circuit_verification_key->commitments.insert({ selector_commitment_label, poly_commitment }); + } + } + + // Set the polynomial manifest in verification key. + circuit_verification_key->polynomial_manifest = plonk::PolynomialManifest(proving_key->composer_type); + + return circuit_verification_key; +} + +} // namespace plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp new file mode 100644 index 0000000000..5e374486f6 --- /dev/null +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp @@ -0,0 +1,29 @@ +#pragma once +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" + +namespace plonk { +struct SelectorProperties { + std::string name; + bool requires_lagrange_base_polynomial = false; // does the prover need the raw lagrange-base selector values? +}; + +/** + * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into + * cache + * + * @param key Pointer to the proving key + * @param selector_properties Names of selectors + */ +void compute_monomial_and_coset_selector_forms(plonk::proving_key* key, + std::vector selector_properties); + +/** + * @brief Computes the verification key by computing the: + * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, + * (2) sets the polynomial manifest using the data from proving key. + */ +std::shared_ptr compute_verification_key_common( + std::shared_ptr const& proving_key, std::shared_ptr const& vrs); + +} // namespace plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp index edc71bb286..c6c87d973e 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp @@ -5,6 +5,8 @@ #include "barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp" #include "barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget.hpp" #include "barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp" +#include "barretenberg/proof_system/composer/composer_helper_lib.hpp" +#include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" #include #include @@ -52,7 +54,7 @@ void StandardPlonkComposerHelper::compute_witness(const Circ * @return Pointer to the initialized proving key updated with selector polynomials. * */ template -std::shared_ptr StandardPlonkComposerHelper::compute_proving_key( +std::shared_ptr StandardPlonkComposerHelper::compute_proving_key( const CircuitConstructor& circuit_constructor) { if (circuit_proving_key) { @@ -62,15 +64,15 @@ std::shared_ptr StandardPlonkComposerHelper StandardPlonkComposerHelper -std::shared_ptr StandardPlonkComposerHelper::compute_verification_key( +std::shared_ptr StandardPlonkComposerHelper::compute_verification_key( const CircuitConstructor& circuit_constructor) { if (circuit_verification_key) { @@ -101,7 +103,8 @@ std::shared_ptr StandardPlonkComposerHelperget_verifier_crs()); + circuit_verification_key = + plonk::compute_verification_key_common(circuit_proving_key, crs_factory_->get_verifier_crs()); circuit_verification_key->composer_type = circuit_proving_key->composer_type; circuit_verification_key->recursive_proof_public_input_indices = std::vector(recursive_proof_public_input_indices.begin(), recursive_proof_public_input_indices.end()); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp index 976290b1bc..5b045ebec9 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp @@ -1,16 +1,15 @@ #pragma once #include "barretenberg/srs/reference_string/file_reference_string.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/prover/prover.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" #include "barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp" #include "barretenberg/honk/pcs/commitment_key.hpp" -#include "barretenberg/proof_system/verification_key/verification_key.hpp" +#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" -#include "barretenberg/proof_system/composer/composer_helper_lib.hpp" #include "barretenberg/proof_system/composer/permutation_helper.hpp" - +#include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" #include namespace plonk { @@ -20,8 +19,8 @@ template class StandardPlonkComposerHelper { public: static constexpr size_t NUM_RANDOMIZED_GATES = 2; // equal to the number of multilinear evaluations leaked static constexpr size_t program_width = CircuitConstructor::program_width; - std::shared_ptr circuit_proving_key; - std::shared_ptr circuit_verification_key; + std::shared_ptr circuit_proving_key; + std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all std::shared_ptr crs_factory_; @@ -42,8 +41,8 @@ template class StandardPlonkComposerHelper { StandardPlonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} - - StandardPlonkComposerHelper(std::shared_ptr p_key, std::shared_ptr v_key) + StandardPlonkComposerHelper(std::shared_ptr p_key, + std::shared_ptr v_key) : circuit_proving_key(std::move(p_key)) , circuit_verification_key(std::move(v_key)) {} @@ -54,7 +53,7 @@ template class StandardPlonkComposerHelper { StandardPlonkComposerHelper& operator=(const StandardPlonkComposerHelper& other) = delete; ~StandardPlonkComposerHelper() = default; - inline std::vector standard_selector_properties() + inline std::vector standard_selector_properties() { std::vector result{ { "q_m", false }, { "q_c", false }, { "q_1", false }, { "q_2", false }, { "q_3", false }, @@ -75,8 +74,8 @@ template class StandardPlonkComposerHelper { recursive_proof_public_input_indices.push_back((uint32_t)(circuit_constructor.public_inputs.size() - 1)); } } - std::shared_ptr compute_proving_key(const CircuitConstructor& circuit_constructor); - std::shared_ptr compute_verification_key(const CircuitConstructor& circuit_constructor); + std::shared_ptr compute_proving_key(const CircuitConstructor& circuit_constructor); + std::shared_ptr compute_verification_key(const CircuitConstructor& circuit_constructor); plonk::Verifier create_verifier(const CircuitConstructor& circuit_constructor); plonk::Prover create_prover(const CircuitConstructor& circuit_constructor); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp index b5173cc101..24af0e92a0 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp @@ -27,7 +27,7 @@ namespace plonk { * @return Pointer to the initialized proving key updated with selector polynomials. * */ template -std::shared_ptr TurboPlonkComposerHelper::compute_proving_key( +std::shared_ptr TurboPlonkComposerHelper::compute_proving_key( const CircuitConstructor& circuit_constructor) { if (circuit_proving_key) { @@ -37,12 +37,12 @@ std::shared_ptr TurboPlonkComposerHelper: const size_t num_randomized_gates = NUM_RANDOMIZED_GATES; // Initialize circuit_proving_key // TODO(#229)(Kesha): replace composer types. - circuit_proving_key = initialize_proving_key( + circuit_proving_key = bonk::initialize_proving_key( circuit_constructor, crs_factory_.get(), minimum_circuit_size, num_randomized_gates, bonk::ComposerType::TURBO); - construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); + bonk::construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); - enforce_nonzero_polynomial_selectors(circuit_constructor, circuit_proving_key.get()); + bonk::enforce_nonzero_polynomial_selectors(circuit_constructor, circuit_proving_key.get()); compute_monomial_and_coset_selector_forms(circuit_proving_key.get(), turbo_selector_properties()); @@ -61,7 +61,7 @@ std::shared_ptr TurboPlonkComposerHelper: * @return Pointer to created circuit verification key. * */ template -std::shared_ptr TurboPlonkComposerHelper::compute_verification_key( +std::shared_ptr TurboPlonkComposerHelper::compute_verification_key( const CircuitConstructor& circuit_constructor) { if (circuit_verification_key) { @@ -71,7 +71,8 @@ std::shared_ptr TurboPlonkComposerHelperget_verifier_crs()); + circuit_verification_key = + plonk::compute_verification_key_common(circuit_proving_key, crs_factory_->get_verifier_crs()); circuit_verification_key->composer_type = circuit_proving_key->composer_type; circuit_verification_key->recursive_proof_public_input_indices = std::vector(recursive_proof_public_input_indices.begin(), recursive_proof_public_input_indices.end()); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp index ce374bc263..fa18a7a939 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp @@ -1,8 +1,9 @@ #pragma once +#include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" #include "barretenberg/proof_system/composer/composer_helper_lib.hpp" #include "barretenberg/srs/reference_string/file_reference_string.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/prover/prover.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" @@ -14,8 +15,8 @@ template class TurboPlonkComposerHelper { static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; - std::shared_ptr circuit_proving_key; - std::shared_ptr circuit_verification_key; + std::shared_ptr circuit_proving_key; + std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all @@ -36,7 +37,7 @@ template class TurboPlonkComposerHelper { TurboPlonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} - TurboPlonkComposerHelper(std::shared_ptr p_key, std::shared_ptr v_key) + TurboPlonkComposerHelper(std::shared_ptr p_key, std::shared_ptr v_key) : circuit_proving_key(std::move(p_key)) , circuit_verification_key(std::move(v_key)) {} @@ -50,7 +51,7 @@ template class TurboPlonkComposerHelper { TurboProver create_prover(const CircuitConstructor& circuit_constructor); TurboVerifier create_verifier(const CircuitConstructor& circuit_constructor); - inline std::vector turbo_selector_properties() + inline std::vector turbo_selector_properties() { const std::vector result{ { "q_m", false }, { "q_c", false }, { "q_1", false }, { "q_2", false }, diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp index 57d00325fc..c09f67c55c 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp @@ -58,8 +58,8 @@ class StandardPlonkComposer { {} - StandardPlonkComposer(std::shared_ptr const& p_key, - std::shared_ptr const& v_key, + StandardPlonkComposer(std::shared_ptr const& p_key, + std::shared_ptr const& v_key, size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(p_key, v_key) @@ -162,12 +162,12 @@ class StandardPlonkComposer { /**Proof and verification-related methods*/ - std::shared_ptr compute_proving_key() + std::shared_ptr compute_proving_key() { return composer_helper.compute_proving_key(circuit_constructor); } - std::shared_ptr compute_verification_key() + std::shared_ptr compute_verification_key() { return composer_helper.compute_verification_key(circuit_constructor); } diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp index d371578b52..525cd2b7a2 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp @@ -2,7 +2,7 @@ #include #include "barretenberg/crypto/pedersen/pedersen.hpp" #include "barretenberg/crypto/pedersen/generator_data.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; using namespace bonk; @@ -33,13 +33,13 @@ TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) auto pk_buf = to_buffer(*composer.compute_proving_key()); auto vk_buf = to_buffer(*composer.compute_verification_key()); - auto pk_data = from_buffer(pk_buf); - auto vk_data = from_buffer(vk_buf); + auto pk_data = from_buffer(pk_buf); + auto vk_data = from_buffer(vk_buf); auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = - std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); - auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); + std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); + auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); plonk::StandardPlonkComposer composer2 = plonk::StandardPlonkComposer(proving_key, verification_key); composer2.add_public_variable(a); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp index c01e365f55..26953f4705 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp @@ -54,8 +54,8 @@ class TurboPlonkComposer { , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables){}; - TurboPlonkComposer(std::shared_ptr const& p_key, - std::shared_ptr const& v_key, + TurboPlonkComposer(std::shared_ptr const& p_key, + std::shared_ptr const& v_key, size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(p_key, v_key) @@ -169,12 +169,12 @@ class TurboPlonkComposer { barretenberg::fr get_variable(const uint32_t index) const { return circuit_constructor.get_variable(index); } /**Proof and verification-related methods*/ - std::shared_ptr compute_proving_key() + std::shared_ptr compute_proving_key() { return composer_helper.compute_proving_key(circuit_constructor); } - std::shared_ptr compute_verification_key() + std::shared_ptr compute_verification_key() { return composer_helper.compute_verification_key(circuit_constructor); } diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp index 24ac9a02be..cc2eb26e66 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp @@ -1,15 +1,17 @@ #include "turbo_plonk_composer.hpp" #include "barretenberg/crypto/pedersen/pedersen.hpp" #include -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; using namespace bonk; using namespace crypto::pedersen; +namespace plonk::test_turbo_plonk_composer { namespace { auto& engine = numeric::random::get_debug_engine(); } + TEST(turbo_plonk_composer_splitting_tmp, base_case) { TurboPlonkComposer composer = TurboPlonkComposer(); @@ -33,13 +35,13 @@ TEST(turbo_plonk_composer_splitting_tmp, composer_from_serialized_keys) auto pk_buf = to_buffer(*composer.compute_proving_key()); auto vk_buf = to_buffer(*composer.compute_verification_key()); - auto pk_data = from_buffer(pk_buf); - auto vk_data = from_buffer(vk_buf); + auto pk_data = from_buffer(pk_buf); + auto vk_data = from_buffer(vk_buf); auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = - std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); - auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); + std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); + auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); TurboPlonkComposer composer2 = TurboPlonkComposer(proving_key, verification_key); composer2.add_public_variable(a); @@ -1151,3 +1153,4 @@ TEST(turbo_plonk_composer_splitting_tmp, test_check_circuit_xor) EXPECT_EQ(result, true); } +} // namespace plonk::test_turbo_plonk_composer \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp index 632b40da09..a7f33cb05c 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp @@ -2,7 +2,7 @@ #include #include "barretenberg/crypto/pedersen/pedersen.hpp" #include "barretenberg/crypto/pedersen/generator_data.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; using namespace bonk; @@ -34,13 +34,13 @@ TEST(standard_composer, composer_from_serialized_keys) auto pk_buf = to_buffer(*composer.compute_proving_key()); auto vk_buf = to_buffer(*composer.compute_verification_key()); - auto pk_data = from_buffer(pk_buf); - auto vk_data = from_buffer(vk_buf); + auto pk_data = from_buffer(pk_buf); + auto vk_data = from_buffer(vk_buf); auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = - std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); - auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); + std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); + auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); StandardComposer composer2 = StandardComposer(proving_key, verification_key); composer2.add_public_variable(a); diff --git a/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp index 2cbefaa1ae..37c8c96f9d 100644 --- a/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp @@ -1,7 +1,7 @@ #include "turbo_composer.hpp" #include "barretenberg/crypto/pedersen/pedersen.hpp" #include -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; using namespace bonk; @@ -34,13 +34,13 @@ TEST(turbo_composer, composer_from_serialized_keys) auto pk_buf = to_buffer(*composer.compute_proving_key()); auto vk_buf = to_buffer(*composer.compute_verification_key()); - auto pk_data = from_buffer(pk_buf); - auto vk_data = from_buffer(vk_buf); + auto pk_data = from_buffer(pk_buf); + auto vk_data = from_buffer(vk_buf); auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = - std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); - auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); + std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); + auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); TurboComposer composer2 = TurboComposer(proving_key, verification_key); composer2.add_public_variable(a); diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp index 0e3712b3ba..a0bca9616f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp @@ -35,15 +35,15 @@ class CommitmentScheme { virtual void batch_open(const transcript::StandardTranscript& transcript, work_queue& queue, - std::shared_ptr input_key = nullptr) = 0; + std::shared_ptr input_key = nullptr) = 0; virtual void batch_verify(const transcript::StandardTranscript& transcript, std::map& kate_g1_elements, std::map& kate_fr_elements, - std::shared_ptr input_key = nullptr) = 0; + std::shared_ptr input_key = nullptr) = 0; virtual void add_opening_evaluations_to_transcript(transcript::StandardTranscript& trancript, - std::shared_ptr input_key = nullptr, + std::shared_ptr input_key = nullptr, bool in_lagrange_form = false) = 0; }; diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp index 5465b68ac4..7a65fcaf4c 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp @@ -133,7 +133,7 @@ void KateCommitmentScheme::generic_batch_open(const fr* src, template void KateCommitmentScheme::batch_open(const transcript::StandardTranscript& transcript, work_queue& queue, - std::shared_ptr input_key) + std::shared_ptr input_key) { /* Compute batch opening polynomials according to the Kate commitment scheme. @@ -233,7 +233,7 @@ template void KateCommitmentScheme::batch_verify(const transcript::StandardTranscript& transcript, std::map& kate_g1_elements, std::map& kate_fr_elements, - std::shared_ptr input_key) + std::shared_ptr input_key) { // Compute batch evaluation commitment [F]_1 // In this method, we accumulate scalars and corresponding group elements for the multi-scalar @@ -345,9 +345,8 @@ void KateCommitmentScheme::batch_verify(const transcript::StandardTran } template -void KateCommitmentScheme::add_opening_evaluations_to_transcript(transcript::StandardTranscript& transcript, - std::shared_ptr input_key, - bool in_lagrange_form) +void KateCommitmentScheme::add_opening_evaluations_to_transcript( + transcript::StandardTranscript& transcript, std::shared_ptr input_key, bool in_lagrange_form) { // In this function, we compute the evaluations of all polynomials in the polynomial manifest at the // evaluation challenge "zeta", as well as the needed evaluations at shifts. diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp index 48f49a6055..2ba694ee8b 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp @@ -24,15 +24,15 @@ template class KateCommitmentScheme : public CommitmentSchem void batch_open(const transcript::StandardTranscript& transcript, work_queue& queue, - std::shared_ptr input_key = nullptr) override; + std::shared_ptr input_key = nullptr) override; void batch_verify(const transcript::StandardTranscript& transcript, std::map& kate_g1_elements, std::map& kate_fr_elements, - std::shared_ptr input_key = nullptr) override; + std::shared_ptr input_key = nullptr) override; void add_opening_evaluations_to_transcript(transcript::StandardTranscript& transcript, - std::shared_ptr input_key = nullptr, + std::shared_ptr input_key = nullptr, bool in_lagrange_form = false) override; private: diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp b/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp index 50d303c81a..b181f28afa 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp @@ -1,12 +1,12 @@ #pragma once -#include "../../../proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "../types/proof.hpp" #include "../types/program_settings.hpp" #include "../widgets/random_widgets/random_widget.hpp" #include "../../../proof_system/work_queue/work_queue.hpp" #include "../widgets/transition_widgets/transition_widget.hpp" #include "../commitment_scheme/commitment_scheme.hpp" -using namespace plonk; + namespace plonk { template class ProverBase { diff --git a/cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp similarity index 96% rename from cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp rename to cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp index 0802a6a342..7089b7c3a1 100644 --- a/cpp/src/barretenberg/proof_system/proving_key/proving_key.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp @@ -2,7 +2,8 @@ #include "barretenberg/polynomials/polynomial_arithmetic.hpp" #include "barretenberg/common/throw_or_abort.hpp" #include "barretenberg/numeric/bitop/get_msb.hpp" -namespace bonk { + +namespace plonk { // In all the constructors below, the pippenger_runtime_state takes (n + 1) as the input // as the degree of t_{high}(X) is (n + 1) for standard plonk. Refer to @@ -24,7 +25,7 @@ namespace bonk { proving_key::proving_key( const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, bonk::ComposerType type = bonk::ComposerType::STANDARD) // TODO(Cody): Don't use default for Honk : composer_type(type) , circuit_size(num_gates) @@ -45,7 +46,7 @@ proving_key::proving_key( * @param data * @param crs */ -proving_key::proving_key(proving_key_data&& data, std::shared_ptr const& crs) +proving_key::proving_key(proving_key_data&& data, std::shared_ptr const& crs) : composer_type(data.composer_type) , circuit_size(data.circuit_size) , num_public_inputs(data.num_public_inputs) @@ -89,4 +90,4 @@ void proving_key::init() memset((void*)"ient_polynomial_parts[3][0], 0x00, sizeof(barretenberg::fr) * circuit_size); } -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp similarity index 81% rename from cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp rename to cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp index 7e4c371e11..7b150c02b9 100644 --- a/cpp/src/barretenberg/proof_system/proving_key/proving_key.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp @@ -7,10 +7,10 @@ #include "barretenberg/proof_system/polynomial_store/polynomial_store.hpp" #include "barretenberg/srs/reference_string/reference_string.hpp" #include "barretenberg/plonk/proof_system/constants.hpp" -#include "barretenberg/proof_system/types/polynomial_manifest.hpp" +#include "barretenberg/plonk/proof_system/types/polynomial_manifest.hpp" #include -namespace bonk { +namespace plonk { struct proving_key_data { uint32_t composer_type; @@ -20,7 +20,7 @@ struct proving_key_data { std::vector recursive_proof_public_input_indices; std::vector memory_read_records; std::vector memory_write_records; - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; }; struct proving_key { @@ -31,11 +31,11 @@ struct proving_key { RELATIVE_LOOKUP, }; - proving_key(proving_key_data&& data, std::shared_ptr const& crs); + proving_key(proving_key_data&& data, std::shared_ptr const& crs); proving_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, bonk::ComposerType type); proving_key(std::ostream& is, std::string const& crs_path); @@ -51,14 +51,14 @@ struct proving_key { std::vector memory_read_records; // Used by UltraComposer only; for ROM, RAM reads. std::vector memory_write_records; // Used by UltraComposer only, for RAM writes. - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; barretenberg::evaluation_domain small_domain; barretenberg::evaluation_domain large_domain; // The reference_string object contains the monomial SRS. We can access it using: // Monomial SRS: reference_string->get_monomial_points() - std::shared_ptr reference_string; + std::shared_ptr reference_string; barretenberg::polynomial quotient_polynomial_parts[plonk::NUM_QUOTIENT_PARTS]; @@ -69,4 +69,4 @@ struct proving_key { static constexpr size_t min_thread_block = 4UL; }; -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/proof_system/proving_key/proving_key.test.cpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp similarity index 88% rename from cpp/src/barretenberg/proof_system/proving_key/proving_key.test.cpp rename to cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp index fd4a0ff2cf..a02cc0fc68 100644 --- a/cpp/src/barretenberg/proof_system/proving_key/proving_key.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp @@ -19,17 +19,17 @@ TEST(proving_key, proving_key_from_serialized_key) fr a = fr::one(); composer.add_public_variable(a); - bonk::proving_key& p_key = *composer.compute_proving_key(); + plonk::proving_key& p_key = *composer.compute_proving_key(); auto pk_buf = to_buffer(p_key); - auto pk_data = from_buffer(pk_buf); + auto pk_data = from_buffer(pk_buf); auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = - std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); + std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); // Loop over all pre-computed polys for the given composer type and ensure equality // between original proving key polynomial store and the polynomial store that was // serialized/deserialized from buffer - bonk::PrecomputedPolyList precomputed_poly_list(p_key.composer_type); + plonk::PrecomputedPolyList precomputed_poly_list(p_key.composer_type); bool all_polys_are_equal{ true }; for (size_t i = 0; i < precomputed_poly_list.size(); ++i) { std::string poly_id = precomputed_poly_list[i]; @@ -55,17 +55,17 @@ TEST(proving_key, proving_key_from_serialized_key_ultra) fr a = fr::one(); composer.add_public_variable(a); - bonk::proving_key& p_key = *composer.compute_proving_key(); + plonk::proving_key& p_key = *composer.compute_proving_key(); auto pk_buf = to_buffer(p_key); - auto pk_data = from_buffer(pk_buf); + auto pk_data = from_buffer(pk_buf); auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = - std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); + std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); // Loop over all pre-computed polys for the given composer type and ensure equality // between original proving key polynomial store and the polynomial store that was // serialized/deserialized from buffer - bonk::PrecomputedPolyList precomputed_poly_list(p_key.composer_type); + plonk::PrecomputedPolyList precomputed_poly_list(p_key.composer_type); bool all_polys_are_equal{ true }; for (size_t i = 0; i < precomputed_poly_list.size(); ++i) { std::string poly_id = precomputed_poly_list[i]; @@ -115,7 +115,7 @@ TEST(proving_key, proving_key_from_mmaped_key) if (!os.good()) { std::cerr << "OS failed in composer_from_mmap_keys! \n"; } - bonk::proving_key& p_key = *composer.compute_proving_key(); + plonk::proving_key& p_key = *composer.compute_proving_key(); write_mmap(os, pk_dir, p_key); os.close(); @@ -125,14 +125,14 @@ TEST(proving_key, proving_key_from_mmaped_key) if (!pk_stream.good()) { std::cerr << "IS failed in composer_from_mmap_keys! \n"; } - bonk::proving_key_data pk_data; + plonk::proving_key_data pk_data; read_mmap(pk_stream, pk_dir, pk_data); pk_stream.close(); // Loop over all pre-computed polys for the given composer type and ensure equality // between original proving key polynomial store and the polynomial store that was // serialized/deserialized via mmap - bonk::PrecomputedPolyList precomputed_poly_list(p_key.composer_type); + plonk::PrecomputedPolyList precomputed_poly_list(p_key.composer_type); bool all_polys_are_equal{ true }; for (size_t i = 0; i < precomputed_poly_list.size(); ++i) { std::string poly_id = precomputed_poly_list[i]; diff --git a/cpp/src/barretenberg/proof_system/proving_key/serialize.hpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp similarity index 99% rename from cpp/src/barretenberg/proof_system/proving_key/serialize.hpp rename to cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp index 4248d0a5cc..2f58962c59 100644 --- a/cpp/src/barretenberg/proof_system/proving_key/serialize.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp @@ -4,7 +4,7 @@ #include "barretenberg/common/throw_or_abort.hpp" #include "barretenberg/common/serialize.hpp" -namespace bonk { +namespace plonk { // Read the pre-computed polynomials template inline void read(B& any, proving_key_data& key) @@ -115,4 +115,4 @@ template inline void write_mmap(B& os, std::string const& path, pro write(os, key.memory_write_records); } -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp b/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp similarity index 99% rename from cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp rename to cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp index 5c511ac5be..6d629346c8 100644 --- a/cpp/src/barretenberg/proof_system/types/polynomial_manifest.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp @@ -6,7 +6,7 @@ #include "barretenberg/plonk/proof_system/constants.hpp" // ToDo(Arijit): The below namespace should be plonk once all the honk related stuffs are moved out // ToDo(Cody): This is now plonk-specific. -namespace bonk { +namespace plonk { enum PolynomialSource { WITNESS, SELECTOR, PERMUTATION, OTHER }; @@ -87,7 +87,7 @@ struct PolynomialDescriptor { std::string_view polynomial_label; bool requires_shifted_evaluation; PolynomialSource source; - bonk::PolynomialIndex index; + PolynomialIndex index; }; static constexpr size_t STANDARD_MANIFEST_SIZE = 12; @@ -256,4 +256,4 @@ class PrecomputedPolyList { std::string operator[](size_t index) const { return precomputed_poly_ids[index]; } }; -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/proof_system/verification_key/sol_gen.hpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp similarity index 100% rename from cpp/src/barretenberg/proof_system/verification_key/sol_gen.hpp rename to cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp diff --git a/cpp/src/barretenberg/proof_system/verification_key/verification_key.cpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp similarity index 92% rename from cpp/src/barretenberg/proof_system/verification_key/verification_key.cpp rename to cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp index 3838656c8a..eca7ed120b 100644 --- a/cpp/src/barretenberg/proof_system/verification_key/verification_key.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp @@ -1,12 +1,12 @@ #include "barretenberg/crypto/sha256/sha256.hpp" #include "verification_key.hpp" -#include "../../plonk/proof_system/constants.hpp" +#include "barretenberg/plonk/proof_system/constants.hpp" -namespace bonk { +namespace plonk { verification_key::verification_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, uint32_t composer_type_) : composer_type(composer_type_) , circuit_size(num_gates) @@ -17,7 +17,8 @@ verification_key::verification_key(const size_t num_gates, , polynomial_manifest(composer_type) {} -verification_key::verification_key(verification_key_data&& data, std::shared_ptr const& crs) +verification_key::verification_key(verification_key_data&& data, + std::shared_ptr const& crs) : composer_type(data.composer_type) , circuit_size(data.circuit_size) , log_circuit_size(numeric::get_msb(data.circuit_size)) @@ -87,4 +88,4 @@ sha256::hash verification_key::sha256_hash() return sha256::sha256(to_buffer(vk_data)); } -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/proof_system/verification_key/verification_key.hpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp similarity index 90% rename from cpp/src/barretenberg/proof_system/verification_key/verification_key.hpp rename to cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp index 08b0f85751..86a93ba011 100644 --- a/cpp/src/barretenberg/proof_system/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp @@ -3,9 +3,9 @@ #include "barretenberg/srs/reference_string/reference_string.hpp" #include "barretenberg/polynomials/evaluation_domain.hpp" #include "barretenberg/crypto/sha256/sha256.hpp" -#include "../../proof_system/types/polynomial_manifest.hpp" +#include "barretenberg/plonk/proof_system/types/polynomial_manifest.hpp" -namespace bonk { +namespace plonk { struct verification_key_data { uint32_t composer_type; @@ -45,10 +45,10 @@ inline bool operator==(verification_key_data const& lhs, verification_key_data c } struct verification_key { - verification_key(verification_key_data&& data, std::shared_ptr const& crs); + verification_key(verification_key_data&& data, std::shared_ptr const& crs); verification_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, uint32_t composer_type); verification_key(const verification_key& other); verification_key(verification_key&& other); @@ -65,7 +65,7 @@ struct verification_key { barretenberg::evaluation_domain domain; - std::shared_ptr reference_string; + std::shared_ptr reference_string; std::map commitments; @@ -91,4 +91,4 @@ template inline void write(B& buf, verification_key const& key) write(buf, key.recursive_proof_public_input_indices); } -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp similarity index 92% rename from cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp rename to cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp index 8faaca2a02..2236e0194e 100644 --- a/cpp/src/barretenberg/proof_system/verification_key/verification_key.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp @@ -3,7 +3,9 @@ #include "verification_key.hpp" using namespace barretenberg; -using namespace bonk; +using namespace plonk; + +namespace plonk::test_verification_key { TEST(verification_key, buffer_serialization) { @@ -41,3 +43,4 @@ TEST(verification_key, stream_serialization) EXPECT_EQ(key, result); } +} // namespace plonk::test_verification_key \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp index 3046639e6a..f71bf58f71 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp @@ -1,5 +1,5 @@ #include "../prover/prover.hpp" -#include "../../../proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "../utils/permutation.hpp" #include "../widgets/transition_widgets/arithmetic_widget.hpp" #include "../../../transcript/transcript.hpp" diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget_impl.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget_impl.hpp index a25000f72f..784e7d8566 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget_impl.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget_impl.hpp @@ -1,7 +1,7 @@ #pragma once #include "barretenberg/common/mem.hpp" #include "barretenberg/ecc/curves/bn254/scalar_multiplication/scalar_multiplication.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/public_inputs/public_inputs.hpp" #include "barretenberg/transcript/transcript.hpp" #include "barretenberg/polynomials/iterate_over_domain.hpp" diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget_impl.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget_impl.hpp index 7a9a09ef4f..959fc74758 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget_impl.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget_impl.hpp @@ -1,6 +1,6 @@ #pragma once -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/transcript/transcript.hpp" #include "barretenberg/polynomials/iterate_over_domain.hpp" #include "barretenberg/ecc/curves/bn254/scalar_multiplication/scalar_multiplication.hpp" diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp index 56fb3ae1f9..b902e96dae 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp @@ -9,7 +9,7 @@ class Transcript; } // TODO(Cody) Fix this namespace. -namespace bonk { +namespace plonk { struct proving_key; @@ -53,4 +53,4 @@ class ProverRandomWidget { proving_key* key; }; -} // namespace bonk +} // namespace plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp index 7b403a5897..461fc1e358 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp @@ -32,13 +32,12 @@ template class ArithmeticKe typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_1, bonk::PolynomialIndex::Q_2, bonk::PolynomialIndex::Q_3, - bonk::PolynomialIndex::Q_M, bonk::PolynomialIndex::Q_C, bonk::PolynomialIndex::W_1, - bonk::PolynomialIndex::W_2, bonk::PolynomialIndex::W_3 - }; + static const std::set required_polynomial_ids = { PolynomialIndex::Q_1, PolynomialIndex::Q_2, + PolynomialIndex::Q_3, PolynomialIndex::Q_M, + PolynomialIndex::Q_C, PolynomialIndex::W_1, + PolynomialIndex::W_2, PolynomialIndex::W_3 }; return required_polynomial_ids; } @@ -58,11 +57,11 @@ template class ArithmeticKe const size_t i = 0) { const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); linear_terms[0] = w_1 * w_2; linear_terms[1] = w_1; @@ -94,15 +93,15 @@ template class ArithmeticKe { const Field& alpha = challenges.alpha_powers[0]; const Field& q_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_m = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_c = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); Field result = linear_terms[0] * q_m; result += (linear_terms[1] * q_1); diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp index 65e545a37b..c963f8ad41 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp @@ -73,12 +73,11 @@ template class EllipticKern typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_1, bonk::PolynomialIndex::Q_3, bonk::PolynomialIndex::Q_4, - bonk::PolynomialIndex::Q_ELLIPTIC, bonk::PolynomialIndex::W_1, bonk::PolynomialIndex::W_2, - bonk::PolynomialIndex::W_3, bonk::PolynomialIndex::W_4 + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_1, PolynomialIndex::Q_3, PolynomialIndex::Q_4, PolynomialIndex::Q_ELLIPTIC, + PolynomialIndex::W_1, PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 }; return required_polynomial_ids; } @@ -97,27 +96,23 @@ template class EllipticKern const size_t i = 0) { const Field& x_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& y_1 = - Getters::template get_value(polynomials, i); - const Field& x_2 = - Getters::template get_value(polynomials, i); - const Field& y_2 = - Getters::template get_value(polynomials, i); - const Field& x_3 = - Getters::template get_value(polynomials, i); - const Field& y_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); + const Field& x_2 = Getters::template get_value(polynomials, i); + const Field& y_2 = Getters::template get_value(polynomials, i); + const Field& x_3 = Getters::template get_value(polynomials, i); + const Field& y_3 = Getters::template get_value(polynomials, i); // Endomorphism coefficient for when we add and multiply by beta at the same time const Field& q_beta = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); // Square of endomorphism coefficient const Field& q_beta_sqr = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); // sign const Field& q_sign = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); // TODO: Can this be implemented more efficiently? // It seems that Zac wanted to group the elements by selectors to use several linear terms initially, @@ -165,7 +160,7 @@ template class EllipticKern const size_t i = 0) { const Field& q_elliptic = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); return linear_terms[0] * q_elliptic; } diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp index d5b7e9c4ef..53eb89ec8c 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp @@ -86,13 +86,12 @@ template class typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_1, bonk::PolynomialIndex::Q_2, bonk::PolynomialIndex::Q_3, - bonk::PolynomialIndex::Q_4, bonk::PolynomialIndex::Q_5, bonk::PolynomialIndex::Q_M, - PolynomialIndex::Q_C, PolynomialIndex::Q_FIXED_BASE, PolynomialIndex::W_1, - PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_1, PolynomialIndex::Q_2, PolynomialIndex::Q_3, PolynomialIndex::Q_4, + PolynomialIndex::Q_5, PolynomialIndex::Q_M, PolynomialIndex::Q_C, PolynomialIndex::Q_FIXED_BASE, + PolynomialIndex::W_1, PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 }; return required_polynomial_ids; } diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp index b7e7e3453a..269a1b03fc 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp @@ -18,11 +18,11 @@ template class GenPermSortK typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_SORT, bonk::PolynomialIndex::W_1, bonk::PolynomialIndex::W_2, - bonk::PolynomialIndex::W_3, bonk::PolynomialIndex::W_4, bonk::PolynomialIndex::Z + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_SORT, PolynomialIndex::W_1, PolynomialIndex::W_2, + PolynomialIndex::W_3, PolynomialIndex::W_4, PolynomialIndex::Z }; return required_polynomial_ids; } @@ -38,15 +38,15 @@ template class GenPermSortK const Field& alpha_base = challenges.alpha_powers[0]; const Field& alpha = challenges.elements[ChallengeIndex::ALPHA]; const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_1_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); Field alpha_a = alpha_base; Field alpha_b = alpha_a * alpha; @@ -105,7 +105,7 @@ template class GenPermSortK const size_t i = 0) { const Field& q_sort = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); return linear_terms[0] * q_sort; } diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp index bf6458fb6e..0bc7828990 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp @@ -64,13 +64,12 @@ template class PlookupArith typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_1, bonk::PolynomialIndex::Q_2, bonk::PolynomialIndex::Q_3, - bonk::PolynomialIndex::Q_4, bonk::PolynomialIndex::Q_5, bonk::PolynomialIndex::Q_M, - bonk::PolynomialIndex::Q_C, bonk::PolynomialIndex::Q_ARITHMETIC, bonk::PolynomialIndex::W_1, - bonk::PolynomialIndex::W_2, bonk::PolynomialIndex::W_3, bonk::PolynomialIndex::W_4 + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_1, PolynomialIndex::Q_2, PolynomialIndex::Q_3, PolynomialIndex::Q_4, + PolynomialIndex::Q_5, PolynomialIndex::Q_M, PolynomialIndex::Q_C, PolynomialIndex::Q_ARITHMETIC, + PolynomialIndex::W_1, PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 }; return required_polynomial_ids; } @@ -100,32 +99,31 @@ template class PlookupArith { // For subgroup element i, this term evaluates to W_4(i \omega) * 2 iff Q_ARITH(i \omega) = 2 const Field& q_arith = - Getters::template get_value(polynomials, - i); + Getters::template get_value(polynomials, i); const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_1_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_m = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_c = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& alpha_base = challenges.alpha_powers[0]; const Field& alpha = challenges.elements[ChallengeIndex::ALPHA]; diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp index 894ec072e1..7d50cf11c1 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp @@ -52,13 +52,12 @@ template class PlookupAuxil typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_1, bonk::PolynomialIndex::Q_2, bonk::PolynomialIndex::Q_3, - bonk::PolynomialIndex::Q_4, bonk::PolynomialIndex::Q_M, bonk::PolynomialIndex::Q_C, - bonk::PolynomialIndex::Q_ARITHMETIC, bonk::PolynomialIndex::Q_AUX, bonk::PolynomialIndex::W_1, - bonk::PolynomialIndex::W_2, bonk::PolynomialIndex::W_3, bonk::PolynomialIndex::W_4 + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_1, PolynomialIndex::Q_2, PolynomialIndex::Q_3, PolynomialIndex::Q_4, + PolynomialIndex::Q_M, PolynomialIndex::Q_C, PolynomialIndex::Q_ARITHMETIC, PolynomialIndex::Q_AUX, + PolynomialIndex::W_1, PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 }; return required_polynomial_ids; } @@ -78,43 +77,42 @@ template class PlookupAuxil constexpr barretenberg::fr SUBLIMB_SHIFT(uint256_t(1) << 14); const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_1_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& alpha_base = challenges.alpha_powers[0]; const Field& alpha = challenges.elements[ChallengeIndex::ALPHA]; const Field& eta = challenges.elements[ChallengeIndex::ETA]; const Field& q_aux = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_m = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_c = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_arith = - Getters::template get_value(polynomials, - i); + Getters::template get_value(polynomials, i); /** * Non native field arithmetic gate 2 diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp index 006ea63e45..c7ab9ea0e8 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp @@ -7,8 +7,9 @@ #include "barretenberg/polynomials/iterate_over_domain.hpp" #include "../../types/prover_settings.hpp" -#include "../../../../proof_system/proving_key/proving_key.hpp" -#include "../../../../proof_system/work_queue/work_queue.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/proof_system/work_queue/work_queue.hpp" + using namespace bonk; namespace plonk { diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp index 39098e68ac..1c4472a689 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp @@ -49,18 +49,16 @@ template class TurboArithme inline static bool gate_enabled(PolyContainer& polynomials, const size_t i = 0) { const Field& q_arith = - Getters::template get_value(polynomials, - i); + Getters::template get_value(polynomials, i); return !q_arith.is_zero(); } - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_1, bonk::PolynomialIndex::Q_2, bonk::PolynomialIndex::Q_3, - bonk::PolynomialIndex::Q_4, bonk::PolynomialIndex::Q_5, bonk::PolynomialIndex::Q_M, - bonk::PolynomialIndex::Q_C, bonk::PolynomialIndex::Q_ARITHMETIC, bonk::PolynomialIndex::W_1, - bonk::PolynomialIndex::W_2, bonk::PolynomialIndex::W_3, bonk::PolynomialIndex::W_4 + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_1, PolynomialIndex::Q_2, PolynomialIndex::Q_3, PolynomialIndex::Q_4, + PolynomialIndex::Q_5, PolynomialIndex::Q_M, PolynomialIndex::Q_C, PolynomialIndex::Q_ARITHMETIC, + PolynomialIndex::W_1, PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 }; return required_polynomial_ids; } @@ -87,17 +85,16 @@ template class TurboArithme constexpr barretenberg::fr minus_two(-2); const Field& alpha = challenges.elements[ChallengeIndex::ALPHA]; const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_arith = - Getters::template get_value(polynomials, - i); + Getters::template get_value(polynomials, i); Field T0; Field T1; @@ -147,12 +144,11 @@ template class TurboArithme constexpr barretenberg::fr minus_seven(-7); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_arith = - Getters::template get_value(polynomials, - i); + Getters::template get_value(polynomials, i); const Field& alpha_base = challenges.alpha_powers[0]; Field T1; @@ -242,19 +238,19 @@ template class TurboArithme { const Field& alpha_base = challenges.alpha_powers[0]; const Field& q_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_5 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_m = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_c = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); Field result = linear_terms[0] * q_m; result += (linear_terms[1] * q_1); diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp index 239c548f51..62be73022c 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp @@ -18,11 +18,11 @@ template class TurboLogicKe typedef containers::coefficient_array coefficient_array; public: - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { - bonk::PolynomialIndex::Q_C, bonk::PolynomialIndex::Q_LOGIC, bonk::PolynomialIndex::W_1, - bonk::PolynomialIndex::W_2, bonk::PolynomialIndex::W_3, bonk::PolynomialIndex::W_4 + static const std::set required_polynomial_ids = { + PolynomialIndex::Q_C, PolynomialIndex::Q_LOGIC, PolynomialIndex::W_1, + PolynomialIndex::W_2, PolynomialIndex::W_3, PolynomialIndex::W_4 }; return required_polynomial_ids; } @@ -37,7 +37,7 @@ template class TurboLogicKe inline static bool gate_enabled(PolyContainer& polynomials, const size_t i = 0) { const Field& q_logic = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); return !q_logic.is_zero(); } @@ -53,22 +53,22 @@ template class TurboLogicKe const Field& alpha_base = challenges.alpha_powers[0]; const Field& alpha = challenges.elements[ChallengeIndex::ALPHA]; const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_1_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& q_c = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); Field delta_sum; Field delta_squared_sum; @@ -212,7 +212,7 @@ template class TurboLogicKe const size_t i = 0) { const Field& q_logic = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); return linear_terms[0] * q_logic; } diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp index afb7e0f574..d72b964f58 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp @@ -85,17 +85,17 @@ template class TurboRangeKe inline static bool gate_enabled(PolyContainer& polynomials, const size_t i = 0) { const Field& q_range = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); return !q_range.is_zero(); } - inline static std::set const& get_required_polynomial_ids() + inline static std::set const& get_required_polynomial_ids() { - static const std::set required_polynomial_ids = { bonk::PolynomialIndex::Q_RANGE, - bonk::PolynomialIndex::W_1, - bonk::PolynomialIndex::W_2, - bonk::PolynomialIndex::W_3, - bonk::PolynomialIndex::W_4 }; + static const std::set required_polynomial_ids = { PolynomialIndex::Q_RANGE, + PolynomialIndex::W_1, + PolynomialIndex::W_2, + PolynomialIndex::W_3, + PolynomialIndex::W_4 }; return required_polynomial_ids; } @@ -110,15 +110,15 @@ template class TurboRangeKe const Field& alpha_base = challenges.alpha_powers[0]; const Field& alpha = challenges.elements[ChallengeIndex::ALPHA]; const Field& w_1 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_2 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_3 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4 = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); const Field& w_4_omega = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); Field alpha_a = alpha_base; Field alpha_b = alpha_a * alpha; @@ -188,7 +188,7 @@ template class TurboRangeKe const size_t i = 0) { const Field& q_range = - Getters::template get_value(polynomials, i); + Getters::template get_value(polynomials, i); return linear_terms[0] * q_range; } diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp index 7c2e20c7d6..65c8943a6e 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp @@ -19,14 +19,14 @@ namespace bonk { * @param minimum_circuit_size The minimum size of polynomials without randomized elements * @param num_randomized_gates Number of gates with randomized witnesses * @param composer_type The type of composer we are using - * @return std::shared_ptr + * @return std::shared_ptr */ template -std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, - bonk::ReferenceStringFactory* crs_factory, - const size_t minimum_circuit_size, - const size_t num_randomized_gates, - bonk::ComposerType composer_type) +std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, + bonk::ReferenceStringFactory* crs_factory, + const size_t minimum_circuit_size, + const size_t num_randomized_gates, + bonk::ComposerType composer_type) { const size_t num_gates = circuit_constructor.num_gates; std::span public_inputs = circuit_constructor.public_inputs; @@ -39,7 +39,7 @@ std::shared_ptr initialize_proving_key(const CircuitConstruct auto crs = crs_factory->get_prover_crs(subgroup_size + 1); - return std::make_shared(subgroup_size, num_public_inputs, crs, composer_type); + return std::make_shared(subgroup_size, num_public_inputs, crs, composer_type); } /** @@ -51,7 +51,7 @@ std::shared_ptr initialize_proving_key(const CircuitConstruct */ template void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constructor, - bonk::proving_key* circuit_proving_key) + plonk::proving_key* circuit_proving_key) { const size_t num_public_inputs = circuit_constructor.public_inputs.size(); for (size_t j = 0; j < circuit_constructor.num_selectors; ++j) { @@ -84,7 +84,7 @@ void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constru */ template void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_constructor, - bonk::proving_key* circuit_proving_key) + plonk::proving_key* circuit_proving_key) { for (size_t j = 0; j < circuit_constructor.num_selectors; ++j) { auto current_selector = @@ -95,34 +95,39 @@ void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_cons } } -/** - * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into - * cache - * - * @param key Pointer to the proving key - * @param selector_properties Names of selectors - */ -void compute_monomial_and_coset_selector_forms(bonk::proving_key* circuit_proving_key, - std::vector selector_properties) -{ - for (size_t i = 0; i < selector_properties.size(); i++) { - // Compute monomial form of selector polynomial - auto& selector_poly_lagrange = - circuit_proving_key->polynomial_store.get(selector_properties[i].name + "_lagrange"); - barretenberg::polynomial selector_poly(circuit_proving_key->circuit_size); - barretenberg::polynomial_arithmetic::ifft( - &selector_poly_lagrange[0], &selector_poly[0], circuit_proving_key->small_domain); - - // Compute coset FFT of selector polynomial - barretenberg::polynomial selector_poly_fft(selector_poly, circuit_proving_key->circuit_size * 4 + 4); - selector_poly_fft.coset_fft(circuit_proving_key->large_domain); - - // TODO(luke): For Standard/Turbo, the lagrange polynomials can be removed from the store at this point but this - // is not the case for Ultra. Implement? - circuit_proving_key->polynomial_store.put(selector_properties[i].name, std::move(selector_poly)); - circuit_proving_key->polynomial_store.put(selector_properties[i].name + "_fft", std::move(selector_poly_fft)); - } -} +// /** +// * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into +// * cache +// * +// * @note This function also deletes the lagrange forms of the selectors from memory since they are not needed +// * for proof construction once the monomial and coset forms have been computed +// * +// * @param key Pointer to the proving key +// * @param selector_properties Names of selectors +// */ +// void compute_monomial_and_coset_selector_forms(plonk::proving_key* circuit_proving_key, +// std::vector selector_properties) +// { +// for (size_t i = 0; i < selector_properties.size(); i++) { +// // Compute monomial form of selector polynomial + +// auto& selector_poly_lagrange = +// circuit_proving_key->polynomial_store.get(selector_properties[i].name + "_lagrange"); +// barretenberg::polynomial selector_poly(circuit_proving_key->circuit_size); +// barretenberg::polynomial_arithmetic::ifft( +// &selector_poly_lagrange[0], &selector_poly[0], circuit_proving_key->small_domain); + +// // Compute coset FFT of selector polynomial +// barretenberg::polynomial selector_poly_fft(selector_poly, circuit_proving_key->circuit_size * 4 + 4); +// selector_poly_fft.coset_fft(circuit_proving_key->large_domain); + +// // Remove the selector lagrange forms since they will not be needed beyond this point +// circuit_proving_key->polynomial_store.remove(selector_properties[i].name + "_lagrange"); +// circuit_proving_key->polynomial_store.put(selector_properties[i].name, std::move(selector_poly)); +// circuit_proving_key->polynomial_store.put(selector_properties[i].name + "_fft", +// std::move(selector_poly_fft)); +// } +// } /** * Compute witness polynomials (w_1, w_2, w_3, w_4) and put them into polynomial cache @@ -186,52 +191,54 @@ std::vector compute_witness_base(const CircuitConstruc return wires; } -/** - * @brief Computes the verification key by computing the: - * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, - * (2) sets the polynomial manifest using the data from proving key. - */ -std::shared_ptr compute_verification_key_common( - std::shared_ptr const& proving_key, std::shared_ptr const& vrs) -{ - auto circuit_verification_key = std::make_shared( - proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); - // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc - auto commitment_key = honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); +// /** +// * @brief Computes the verification key by computing the: +// * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, +// * (2) sets the polynomial manifest using the data from proving key. +// */ +// std::shared_ptr compute_verification_key_common( +// std::shared_ptr const& proving_key, std::shared_ptr const& +// vrs) +// { +// auto circuit_verification_key = std::make_shared( +// proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); +// // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc +// auto commitment_key = honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); - for (size_t i = 0; i < proving_key->polynomial_manifest.size(); ++i) { - const auto& poly_info = proving_key->polynomial_manifest[i]; +// for (size_t i = 0; i < proving_key->polynomial_manifest.size(); ++i) { +// const auto& poly_info = proving_key->polynomial_manifest[i]; - const std::string poly_label(poly_info.polynomial_label); - const std::string selector_commitment_label(poly_info.commitment_label); +// const std::string poly_label(poly_info.polynomial_label); +// const std::string selector_commitment_label(poly_info.commitment_label); - if (poly_info.source == bonk::PolynomialSource::SELECTOR || - poly_info.source == bonk::PolynomialSource::PERMUTATION || - poly_info.source == bonk::PolynomialSource::OTHER) { - // Fetch the polynomial in its vector form. +// if (poly_info.source == bonk::PolynomialSource::SELECTOR || +// poly_info.source == bonk::PolynomialSource::PERMUTATION || +// poly_info.source == bonk::PolynomialSource::OTHER) { +// // Fetch the polynomial in its vector form. - // Commit to the constraint selector polynomial and insert the commitment in the verification key. +// // Commit to the constraint selector polynomial and insert the commitment in the verification key. - auto poly_commitment = commitment_key.commit(proving_key->polynomial_store.get(poly_label)); - circuit_verification_key->commitments.insert({ selector_commitment_label, poly_commitment }); - } - } +// auto poly_commitment = commitment_key.commit(proving_key->polynomial_store.get(poly_label)); +// circuit_verification_key->commitments.insert({ selector_commitment_label, poly_commitment }); +// } +// } - // Set the polynomial manifest in verification key. - circuit_verification_key->polynomial_manifest = bonk::PolynomialManifest(proving_key->composer_type); +// // Set the polynomial manifest in verification key. +// circuit_verification_key->polynomial_manifest = plonk::PolynomialManifest(proving_key->composer_type); + +// return circuit_verification_key; +// } - return circuit_verification_key; -} // Ensure we compile all versions so that there are no issues during linkage #define COMPILE_FOR_CIRCUIT_CONSTRUCTOR(circuit_constructor) \ - template std::shared_ptr initialize_proving_key( \ + template std::shared_ptr initialize_proving_key( \ const circuit_constructor&, bonk::ReferenceStringFactory*, const size_t, const size_t, bonk::ComposerType); \ template void construct_lagrange_selector_forms(const circuit_constructor&, \ - bonk::proving_key*); \ + plonk::proving_key*); \ template std::vector compute_witness_base( \ const circuit_constructor&, const size_t, const size_t); \ template void enforce_nonzero_polynomial_selectors(const circuit_constructor& constructor, \ - bonk::proving_key* circuit_proving_key); + plonk::proving_key* circuit_proving_key); COMPILE_FOR_CIRCUIT_CONSTRUCTOR(StandardCircuitConstructor) COMPILE_FOR_CIRCUIT_CONSTRUCTOR(TurboCircuitConstructor) diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp index 080cbc4ee7..d888d5a729 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp @@ -1,13 +1,10 @@ #pragma once -#include "barretenberg/proof_system/proving_key/proving_key.hpp" -#include "barretenberg/proof_system/verification_key/verification_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" #include "barretenberg/polynomials/polynomial_arithmetic.hpp" #include "barretenberg/polynomials/polynomial.hpp" + namespace bonk { -struct SelectorProperties { - std::string name; - bool requires_lagrange_base_polynomial = false; // does the prover need the raw lagrange-base selector values? -}; /** * @brief Initialize proving key and load the crs @@ -17,14 +14,14 @@ struct SelectorProperties { * @param minimum_circuit_size The minimum size of polynomials without randomized elements * @param num_randomized_gates Number of gates with randomized witnesses * @param composer_type The type of composer we are using - * @return std::shared_ptr + * @return std::shared_ptr */ template -std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, - bonk::ReferenceStringFactory* crs_factory, - const size_t minimum_circuit_size, - const size_t num_randomized_gates, - bonk::ComposerType composer_type); +std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, + bonk::ReferenceStringFactory* crs_factory, + const size_t minimum_circuit_size, + const size_t num_randomized_gates, + bonk::ComposerType composer_type); /** * @brief Construct lagrange selector polynomials from circuit selector information and put into polynomial cache @@ -34,7 +31,7 @@ std::shared_ptr initialize_proving_key(const CircuitConstruct * @param key Pointer to the proving key */ template -void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constructor, bonk::proving_key* key); +void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constructor, plonk::proving_key* key); /** * @brief Fill the last index of each selector polynomial in lagrange form with a non-zero value @@ -44,17 +41,17 @@ void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constru * @param key Pointer to the proving key */ template -void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_constructor, bonk::proving_key* key); +void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_constructor, plonk::proving_key* key); -/** - * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into - * cache - * - * @param key Pointer to the proving key - * @param selector_properties Names of selectors - */ -void compute_monomial_and_coset_selector_forms(bonk::proving_key* key, - std::vector selector_properties); +// /** +// * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into +// * cache +// * +// * @param key Pointer to the proving key +// * @param selector_properties Names of selectors +// */ +// void compute_monomial_and_coset_selector_forms(plonk::proving_key* key, +// std::vector selector_properties); /** * Compute witness polynomials (w_1, w_2, w_3, w_4) and put them into polynomial cache @@ -70,12 +67,13 @@ std::vector compute_witness_base(const CircuitConstruc const size_t minimum_circuit_size, const size_t number_of_randomized_gates); -/** - * @brief Computes the verification key by computing the: - * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, - * (2) sets the polynomial manifest using the data from proving key. - */ -std::shared_ptr compute_verification_key_common( - std::shared_ptr const& proving_key, std::shared_ptr const& vrs); +// /** +// * @brief Computes the verification key by computing the: +// * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, +// * (2) sets the polynomial manifest using the data from proving key. +// */ +// std::shared_ptr compute_verification_key_common( +// std::shared_ptr const& proving_key, std::shared_ptr const& +// vrs); } // namespace bonk diff --git a/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp b/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp index d9baedaef4..80b1910e63 100644 --- a/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp +++ b/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp @@ -10,7 +10,7 @@ #include "barretenberg/ecc/curves/bn254/fr.hpp" #include "barretenberg/polynomials/polynomial.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include #include @@ -132,7 +132,7 @@ std::vector compute_wire_copy_cycles(const CircuitConstructor */ template std::array, program_width> compute_basic_bonk_sigma_permutations( - const CircuitConstructor& circuit_constructor, bonk::proving_key* key) + const CircuitConstructor& circuit_constructor, plonk::proving_key* key) { // Compute wire copy cycles (cycles of permutations) auto wire_copy_cycles = compute_wire_copy_cycles(circuit_constructor); @@ -192,7 +192,7 @@ std::array, program_width> compute_bas */ template void compute_honk_style_sigma_lagrange_polynomials_from_mapping( - std::array, program_width>& sigma_mappings, bonk::proving_key* key) + std::array, program_width>& sigma_mappings, plonk::proving_key* key) { const size_t num_gates = key->circuit_size; @@ -317,7 +317,7 @@ template void compute_plonk_permutation_lagrange_polynomials_from_mapping( std::string label, std::array, program_width>& mappings, - bonk::proving_key* key) + plonk::proving_key* key) { for (size_t i = 0; i < program_width; i++) { std::string index = std::to_string(i + 1); @@ -337,7 +337,7 @@ void compute_plonk_permutation_lagrange_polynomials_from_mapping( * @param key Pointer to the proving key */ template -void compute_monomial_and_coset_fft_polynomials_from_lagrange(std::string label, bonk::proving_key* key) +void compute_monomial_and_coset_fft_polynomials_from_lagrange(std::string label, plonk::proving_key* key) { for (size_t i = 0; i < program_width; ++i) { std::string index = std::to_string(i + 1); @@ -400,7 +400,7 @@ void compute_standard_honk_id_polynomials(auto key) // proving_key* and shared_p */ // TODO(#293): Update this (and all similar functions) to take a smart pointer. template -void compute_standard_honk_sigma_permutations(CircuitConstructor& circuit_constructor, bonk::proving_key* key) +void compute_standard_honk_sigma_permutations(CircuitConstructor& circuit_constructor, plonk::proving_key* key) { // Compute the permutation table specifying which element becomes which auto sigma_mappings = compute_basic_bonk_sigma_permutations(circuit_constructor, key); @@ -417,7 +417,7 @@ void compute_standard_honk_sigma_permutations(CircuitConstructor& circuit_constr * @param key Pointer to a proving key */ template -void compute_standard_plonk_sigma_permutations(CircuitConstructor& circuit_constructor, bonk::proving_key* key) +void compute_standard_plonk_sigma_permutations(CircuitConstructor& circuit_constructor, plonk::proving_key* key) { // Compute the permutation table specifying which element becomes which auto sigma_mappings = compute_basic_bonk_sigma_permutations(circuit_constructor, key); diff --git a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp index 01b1e7c777..d3e2eb1055 100644 --- a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp +++ b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp @@ -6,12 +6,14 @@ #include #include #include + namespace bonk { /** * @brief Basic storage class for Polynomials * * @tparam Fr */ +// TODO(Cody): Move into plonk namespace. template class PolynomialStore { using Polynomial = barretenberg::Polynomial; diff --git a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp index f0486cccbf..638fb01d62 100644 --- a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp +++ b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp @@ -13,7 +13,7 @@ using Polynomial = barretenberg::Polynomial; // Test basic put and get functionality TEST(PolynomialStore, PutThenGet) { - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; // Instantiate a polynomial with random coefficients Polynomial poly(1024); @@ -34,7 +34,7 @@ TEST(PolynomialStore, PutThenGet) // Ensure that attempt to access non-existent key throws out_of_range exception TEST(PolynomialStore, NonexistentKey) { - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; polynomial_store.put("id_1", Polynomial(100)); @@ -46,7 +46,7 @@ TEST(PolynomialStore, NonexistentKey) // Ensure correct calculation of volume in bytes TEST(PolynomialStore, Volume) { - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; size_t size1 = 100; size_t size2 = 10; size_t size3 = 5000; @@ -69,7 +69,7 @@ TEST(PolynomialStore, Volume) // Ensure that the remove method erases entry and reduces memory TEST(PolynomialStore, Remove) { - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; size_t size1 = 100; size_t size2 = 500; Polynomial poly1(size1); @@ -93,7 +93,7 @@ TEST(PolynomialStore, Remove) // Check that PolynomialStore supports range based for loop TEST(PolynomialStore, RangeBasedFor) { - PolynomialStore polynomial_store; + bonk::PolynomialStore polynomial_store; size_t size = 100; Polynomial poly1(size); Polynomial poly2(size); @@ -102,7 +102,7 @@ TEST(PolynomialStore, RangeBasedFor) polynomial_store.put("id_2", std::move(poly2)); // Check that PolynomialStore meets criteria for std::ranges::range - EXPECT_TRUE(std::ranges::range>); + EXPECT_TRUE(std::ranges::range>); // For example ... Polynomial polynomial_sum(size); diff --git a/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp b/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp index ef8e51616b..171e6c5614 100644 --- a/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp +++ b/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp @@ -5,7 +5,7 @@ namespace bonk { -work_queue::work_queue(proving_key* prover_key, transcript::StandardTranscript* prover_transcript) +work_queue::work_queue(plonk::proving_key* prover_key, transcript::StandardTranscript* prover_transcript) : key(prover_key) , transcript(prover_transcript) , work_item_queue() diff --git a/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp b/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp index 88aff2c4c4..f8feb5e324 100644 --- a/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp +++ b/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp @@ -1,9 +1,10 @@ #pragma once #include "../../transcript/transcript_wrappers.hpp" -#include "../proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" namespace bonk { +// TODO(Cody): Template by flavor class work_queue { public: @@ -29,7 +30,7 @@ class work_queue { barretenberg::fr shift_factor; }; - work_queue(proving_key* prover_key = nullptr, transcript::StandardTranscript* prover_transcript = nullptr); + work_queue(plonk::proving_key* prover_key = nullptr, transcript::StandardTranscript* prover_transcript = nullptr); work_queue(const work_queue& other) = default; work_queue(work_queue&& other) = default; @@ -61,7 +62,7 @@ class work_queue { std::vector get_queue() const; private: - proving_key* key; + plonk::proving_key* key; transcript::StandardTranscript* transcript; std::vector work_item_queue; }; diff --git a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp index fb0de97603..447319bd18 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp @@ -3,7 +3,7 @@ #include "barretenberg/srs/reference_string/reference_string.hpp" #include "barretenberg/polynomials/evaluation_domain.hpp" -#include "barretenberg/proof_system/types/polynomial_manifest.hpp" +#include "barretenberg/plonk/proof_system/types/polynomial_manifest.hpp" #include "barretenberg/plonk/proof_system/utils/kate_verification.hpp" #include "barretenberg/plonk/proof_system/public_inputs/public_inputs.hpp" @@ -107,7 +107,7 @@ template struct evaluation_domain { template struct verification_key { using Composer = typename Curve::Composer; static std::shared_ptr from_witness(Composer* ctx, - const std::shared_ptr& input_key) + const std::shared_ptr& input_key) { std::shared_ptr key = std::make_shared(); // Native data: @@ -129,7 +129,7 @@ template struct verification_key { } static std::shared_ptr from_constants(Composer* ctx, - const std::shared_ptr& input_key) + const std::shared_ptr& input_key) { std::shared_ptr key = std::make_shared(); key->context = ctx; @@ -150,7 +150,7 @@ template struct verification_key { return key; } - void validate_key_is_in_set(const std::vector>& keys_in_set) + void validate_key_is_in_set(const std::vector>& keys_in_set) { const auto circuit_key_compressed = compress(); bool found = false; @@ -213,7 +213,7 @@ template struct verification_key { return compressed_key; } - barretenberg::fr compress_native(const std::shared_ptr& key) + barretenberg::fr compress_native(const std::shared_ptr& key) { barretenberg::fr compressed_domain = evaluation_domain::compress_native(key->domain); @@ -267,11 +267,11 @@ template struct verification_key { std::shared_ptr reference_string; - bonk::PolynomialManifest polynomial_manifest; + PolynomialManifest polynomial_manifest; size_t program_width = 4; - std::shared_ptr base_key; + std::shared_ptr base_key; Composer* context; }; diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp index 1b87e6ab44..70119d77b1 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp @@ -61,7 +61,7 @@ void populate_kate_element_map(typename Curve::Composer* ctx, const std::string label(item.commitment_label); const std::string poly_label(item.polynomial_label); switch (item.source) { - case bonk::PolynomialSource::WITNESS: { + case PolynomialSource::WITNESS: { const auto element = transcript.get_group_element(label); ASSERT(element.on_curve()); if (element.is_point_at_infinity()) { @@ -72,8 +72,8 @@ void populate_kate_element_map(typename Curve::Composer* ctx, kate_g1_elements.insert({ label, g1_ct::from_witness(ctx, element) }); break; } - case bonk::PolynomialSource::SELECTOR: - case bonk::PolynomialSource::PERMUTATION: { + case PolynomialSource::SELECTOR: + case PolynomialSource::PERMUTATION: { const auto element = key->commitments.at(label); // TODO: with user-defined circuits, we will need verify that the point // lies on the curve with constraints @@ -87,7 +87,7 @@ void populate_kate_element_map(typename Curve::Composer* ctx, kate_g1_elements.insert({ label, element }); break; } - case bonk::PolynomialSource::OTHER: { + case PolynomialSource::OTHER: { break; } } diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp index 1a6ee080bb..9135d22313 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp @@ -1,7 +1,7 @@ #include "verifier.hpp" #include "barretenberg/common/test.hpp" #include "barretenberg/transcript/transcript.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #include "barretenberg/stdlib/primitives/curves/bn254.hpp" #include "barretenberg/ecc/curves/bn254/fq12.hpp" #include "barretenberg/ecc/curves/bn254/pairing.hpp" diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp index 61d0b55a8f..db2b6703ef 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp @@ -1,7 +1,7 @@ #include "verifier.hpp" #include "barretenberg/common/test.hpp" #include "barretenberg/transcript/transcript.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #include "barretenberg/stdlib/primitives/curves/bn254.hpp" #include "barretenberg/ecc/curves/bn254/fq12.hpp" #include "barretenberg/ecc/curves/bn254/pairing.hpp" diff --git a/cpp/src/barretenberg/transcript/transcript.hpp b/cpp/src/barretenberg/transcript/transcript.hpp index 8dd72033fa..7e51b364f2 100644 --- a/cpp/src/barretenberg/transcript/transcript.hpp +++ b/cpp/src/barretenberg/transcript/transcript.hpp @@ -6,7 +6,7 @@ #include #include -#include "../proof_system/verification_key/verification_key.hpp" +#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" namespace transcript { @@ -39,7 +39,7 @@ class Transcript { }; public: - typedef bonk::verification_key Key; + typedef plonk::verification_key Key; /** * Create a new transcript for Prover based on the manifest. From b97db86f8f2e4ae9ceeb11a476ff81829bd8ba1d Mon Sep 17 00:00:00 2001 From: codygunton Date: Sun, 2 Apr 2023 15:29:17 -0400 Subject: [PATCH 3/5] bonk ~> proof_system; nest plonk and honk in it. --- .../benchmark/honk_bench/honk.bench.cpp | 8 +-- .../benchmark/pippenger_bench/main.cpp | 2 +- .../benchmark/plonk_bench/plonk.bench.cpp | 6 +- .../dsl/acir_format/acir_format.cpp | 2 +- .../dsl/acir_format/acir_format.hpp | 2 +- .../dsl/acir_format/blake2s_constraint.cpp | 4 +- .../dsl/acir_format/ecdsa_secp256k1.cpp | 2 +- .../dsl/acir_format/fixed_base_scalar_mul.cpp | 2 +- .../dsl/acir_format/hash_to_field.cpp | 4 +- .../merkle_membership_constraint.cpp | 4 +- .../barretenberg/dsl/acir_format/pedersen.cpp | 2 +- .../dsl/acir_format/schnorr_verify.cpp | 2 +- .../dsl/acir_format/sha256_constraint.cpp | 4 +- .../dsl/acir_proofs/acir_proofs.cpp | 6 +- cpp/src/barretenberg/ecc/curves/types.hpp | 2 +- .../standard_honk_composer_helper.cpp | 17 ++++-- .../standard_honk_composer_helper.hpp | 16 ++--- .../honk/composer/standard_honk_composer.hpp | 18 +++--- .../composer/standard_honk_composer.test.cpp | 8 +-- cpp/src/barretenberg/honk/flavor/flavor.hpp | 10 ++-- cpp/src/barretenberg/honk/oracle/oracle.hpp | 4 +- cpp/src/barretenberg/honk/pcs/claim.hpp | 4 +- .../barretenberg/honk/pcs/commitment_key.hpp | 12 ++-- .../honk/pcs/commitment_key.test.hpp | 4 +- .../barretenberg/honk/pcs/gemini/gemini.hpp | 4 +- .../honk/pcs/gemini/gemini.test.cpp | 4 +- cpp/src/barretenberg/honk/pcs/ipa/ipa.hpp | 10 ++-- .../barretenberg/honk/pcs/ipa/ipa.test.cpp | 4 +- cpp/src/barretenberg/honk/pcs/kzg/kzg.hpp | 4 +- .../barretenberg/honk/pcs/kzg/kzg.test.cpp | 4 +- .../barretenberg/honk/pcs/shplonk/shplonk.hpp | 4 +- .../honk/pcs/shplonk/shplonk.test.cpp | 4 +- .../honk/pcs/shplonk/shplonk_single.hpp | 4 +- cpp/src/barretenberg/honk/pcs/wrapper.hpp | 4 +- .../honk/proof_system/program_settings.hpp | 8 +-- .../barretenberg/honk/proof_system/prover.cpp | 10 ++-- .../barretenberg/honk/proof_system/prover.hpp | 8 +-- .../honk/proof_system/prover_library.cpp | 4 +- .../honk/proof_system/prover_library.hpp | 4 +- .../honk/proof_system/prover_library.test.cpp | 17 +++--- .../honk/proof_system/verifier.cpp | 12 ++-- .../honk/proof_system/verifier.hpp | 4 +- .../honk/proof_system/verifier.test.cpp | 12 ++-- .../sumcheck/polynomials/barycentric_data.hpp | 4 +- .../polynomials/barycentric_data.test.cpp | 2 +- .../polynomials/multivariates.test.cpp | 14 ++--- .../honk/sumcheck/polynomials/pow.hpp | 4 +- .../honk/sumcheck/polynomials/pow.test.cpp | 6 +- .../honk/sumcheck/polynomials/univariate.hpp | 4 +- .../sumcheck/polynomials/univariate.test.cpp | 2 +- .../relations/arithmetic_relation.hpp | 4 +- .../grand_product_computation_relation.hpp | 4 +- .../grand_product_initialization_relation.hpp | 4 +- .../honk/sumcheck/relations/relation.hpp | 4 +- .../honk/sumcheck/relations/relation.test.cpp | 16 ++--- .../barretenberg/honk/sumcheck/sumcheck.hpp | 6 +- .../honk/sumcheck/sumcheck.test.cpp | 8 +-- .../honk/sumcheck/sumcheck_output.hpp | 4 +- .../honk/sumcheck/sumcheck_round.hpp | 4 +- .../honk/sumcheck/sumcheck_round.test.cpp | 8 +-- .../honk/transcript/transcript.hpp | 4 +- .../honk/transcript/transcript.test.cpp | 4 +- .../honk/utils/power_polynomial.hpp | 4 +- .../honk/utils/power_polynomial.test.cpp | 4 +- .../barretenberg/honk/utils/public_inputs.hpp | 4 +- .../proofs/compute_circuit_data.hpp | 26 ++++----- .../proofs/join_split/c_bind.cpp | 10 ++-- .../join_split/compute_circuit_data.cpp | 6 +- .../join_split/compute_circuit_data.hpp | 2 +- .../proofs/join_split/join_split.cpp | 13 +++-- .../proofs/join_split/join_split.hpp | 13 +++-- .../proofs/join_split/join_split.test.cpp | 8 +-- .../proofs/join_split/join_split_circuit.cpp | 4 +- .../proofs/join_split/join_split_circuit.hpp | 2 +- .../join_split/join_split_js_parity.test.cpp | 8 +-- .../proofs/join_split/join_split_tx.hpp | 2 +- .../proofs/mock/mock_circuit.hpp | 2 +- .../proofs/mock/mock_circuit.test.cpp | 2 +- .../notes/circuit/account/account_note.hpp | 2 +- .../proofs/notes/circuit/account/commit.hpp | 2 +- .../proofs/notes/circuit/asset_id.cpp | 2 +- .../proofs/notes/circuit/asset_id.hpp | 2 +- .../proofs/notes/circuit/bridge_call_data.hpp | 2 +- .../proofs/notes/circuit/claim/claim_note.hpp | 2 +- .../claim/complete_partial_commitment.hpp | 2 +- .../notes/circuit/claim/compute_nullifier.hpp | 2 +- .../claim/create_partial_commitment.hpp | 2 +- .../notes/circuit/claim/witness_data.hpp | 2 +- .../value/complete_partial_commitment.hpp | 2 +- .../notes/circuit/value/compute_nullifier.cpp | 4 +- .../notes/circuit/value/compute_nullifier.hpp | 2 +- .../circuit/value/compute_nullifier.test.cpp | 2 +- .../value/create_partial_commitment.hpp | 2 +- .../proofs/notes/circuit/value/value_note.hpp | 2 +- .../notes/circuit/value/value_note.test.cpp | 2 +- .../notes/circuit/value/witness_data.hpp | 2 +- .../join_split_example/proofs/verify.hpp | 2 +- .../plonk/composer/composer_base.cpp | 6 +- .../plonk/composer/composer_base.hpp | 6 +- .../composer_helper/composer_helper_lib.cpp | 11 ++-- .../composer_helper/composer_helper_lib.hpp | 7 ++- .../standard_plonk_composer_helper.cpp | 22 +++---- .../standard_plonk_composer_helper.hpp | 14 ++--- .../turbo_plonk_composer_helper.cpp | 19 +++--- .../turbo_plonk_composer_helper.hpp | 16 ++--- .../splitting_tmp/standard_plonk_composer.hpp | 18 +++--- .../standard_plonk_composer.test.cpp | 30 +++++----- .../splitting_tmp/turbo_plonk_composer.hpp | 19 +++--- .../turbo_plonk_composer.test.cpp | 8 +-- .../plonk/composer/standard_composer.cpp | 6 +- .../plonk/composer/standard_composer.hpp | 7 +-- .../plonk/composer/standard_composer.test.cpp | 8 +-- .../plonk/composer/turbo_composer.cpp | 6 +- .../plonk/composer/turbo_composer.hpp | 18 +++--- .../plonk/composer/turbo_composer.test.cpp | 8 +-- .../plonk/composer/ultra_composer.cpp | 4 +- .../plonk/composer/ultra_composer.hpp | 8 +-- .../plonk/composer/ultra_composer.test.cpp | 6 +- .../commitment_scheme/commitment_scheme.hpp | 4 +- .../commitment_scheme.test.cpp | 10 ++-- .../kate_commitment_scheme.cpp | 4 +- .../kate_commitment_scheme.hpp | 4 +- .../plonk/proof_system/constants.hpp | 6 +- .../plonk/proof_system/prover/c_bind.cpp | 5 +- .../proof_system/prover/c_bind_unrolled.cpp | 5 +- .../plonk/proof_system/prover/prover.cpp | 6 +- .../plonk/proof_system/prover/prover.hpp | 4 +- .../plonk/proof_system/prover/prover.test.cpp | 8 +-- .../proof_system/proving_key/proving_key.cpp | 10 ++-- .../proof_system/proving_key/proving_key.hpp | 16 ++--- .../proving_key/proving_key.test.cpp | 12 ++-- .../proof_system/proving_key/serialize.hpp | 4 +- .../public_inputs/public_inputs.hpp | 2 +- .../public_inputs/public_inputs.test.cpp | 4 +- .../public_inputs/public_inputs_impl.hpp | 4 +- .../types/commitment_open_proof.hpp | 4 +- .../types/polynomial_manifest.hpp | 12 ++-- .../proof_system/types/program_settings.hpp | 4 +- .../plonk/proof_system/types/proof.hpp | 4 +- .../proof_system/types/prover_settings.hpp | 4 +- .../utils/generalized_permutation.hpp | 4 +- .../proof_system/utils/kate_verification.hpp | 4 +- .../plonk/proof_system/utils/permutation.hpp | 4 +- .../proof_system/verification_key/sol_gen.hpp | 14 ++--- .../verification_key/verification_key.cpp | 8 +-- .../verification_key/verification_key.hpp | 10 ++-- .../verification_key.test.cpp | 10 ++-- .../plonk/proof_system/verifier/verifier.cpp | 4 +- .../plonk/proof_system/verifier/verifier.hpp | 4 +- .../proof_system/verifier/verifier.test.cpp | 10 ++-- .../random_widgets/permutation_widget.hpp | 4 +- .../permutation_widget_impl.hpp | 4 +- .../widgets/random_widgets/plookup_widget.hpp | 4 +- .../random_widgets/plookup_widget_impl.hpp | 6 +- .../widgets/random_widgets/random_widget.hpp | 4 +- .../transition_widgets/arithmetic_widget.hpp | 4 +- .../transition_widgets/elliptic_widget.hpp | 4 +- .../transition_widgets/fixed_base_widget.hpp | 4 +- .../genperm_sort_widget.hpp | 4 +- .../plookup_arithmetic_widget.hpp | 4 +- .../plookup_auxiliary_widget.hpp | 4 +- .../transition_widgets/transition_widget.hpp | 6 +- .../turbo_arithmetic_widget.hpp | 4 +- .../transition_widgets/turbo_logic_widget.hpp | 4 +- .../transition_widgets/turbo_range_widget.hpp | 4 +- .../arithmetization/gate_data.hpp | 4 +- .../circuit_constructor_base.cpp | 4 +- .../circuit_constructor_base.hpp | 4 +- .../standard_circuit_constructor.cpp | 4 +- .../standard_circuit_constructor.hpp | 7 ++- .../standard_circuit_constructor.test.cpp | 2 +- .../turbo_circuit_constructor.cpp | 4 +- .../turbo_circuit_constructor.hpp | 6 +- .../turbo_circuit_constructor.test.cpp | 4 +- .../composer/composer_helper_lib.cpp | 32 +++++----- .../composer/composer_helper_lib.hpp | 12 ++-- .../composer/permutation_helper.hpp | 10 ++-- .../polynomial_store/polynomial_store.hpp | 4 +- .../polynomial_store.test.cpp | 16 ++--- .../proof_system/types/composer_type.hpp | 7 ++- .../proof_system/work_queue/work_queue.cpp | 4 +- .../proof_system/work_queue/work_queue.hpp | 4 +- .../reference_string/env_reference_string.hpp | 6 +- .../env_reference_string.test.cpp | 10 ++-- .../file_reference_string.cpp | 4 +- .../file_reference_string.hpp | 4 +- .../reference_string/mem_reference_string.cpp | 4 +- .../reference_string/mem_reference_string.hpp | 4 +- .../mem_reference_string.test.cpp | 4 +- .../pippenger_reference_string.hpp | 4 +- .../srs/reference_string/reference_string.hpp | 4 +- .../stdlib/encryption/aes128/aes128.cpp | 8 +-- .../stdlib/encryption/aes128/aes128.hpp | 4 +- .../stdlib/encryption/aes128/aes128.test.cpp | 10 ++-- .../stdlib/encryption/ecdsa/ecdsa.hpp | 4 +- .../stdlib/encryption/ecdsa/ecdsa.test.cpp | 4 +- .../stdlib/encryption/ecdsa/ecdsa_impl.hpp | 8 +-- .../stdlib/encryption/schnorr/schnorr.cpp | 12 ++-- .../stdlib/encryption/schnorr/schnorr.hpp | 4 +- .../encryption/schnorr/schnorr.test.cpp | 4 +- .../stdlib/hash/blake2s/blake2s.cpp | 6 +- .../stdlib/hash/blake2s/blake2s.hpp | 8 +-- .../stdlib/hash/blake2s/blake2s.test.cpp | 8 +-- .../stdlib/hash/blake2s/blake2s_plookup.cpp | 4 +- .../stdlib/hash/blake2s/blake2s_plookup.hpp | 4 +- .../stdlib/hash/blake2s/blake_util.hpp | 4 +- .../stdlib/hash/blake3s/blake3s.cpp | 6 +- .../stdlib/hash/blake3s/blake3s.hpp | 8 +-- .../stdlib/hash/blake3s/blake3s.test.cpp | 8 +-- .../stdlib/hash/blake3s/blake3s_plookup.cpp | 4 +- .../stdlib/hash/blake3s/blake3s_plookup.hpp | 4 +- .../stdlib/hash/keccak/keccak.cpp | 4 +- .../stdlib/hash/keccak/keccak.hpp | 8 +-- .../stdlib/hash/keccak/keccak.test.cpp | 4 +- .../stdlib/hash/pedersen/pedersen.bench.cpp | 2 +- .../stdlib/hash/pedersen/pedersen.cpp | 12 ++-- .../stdlib/hash/pedersen/pedersen.hpp | 12 ++-- .../stdlib/hash/pedersen/pedersen.test.cpp | 8 +-- .../stdlib/hash/pedersen/pedersen_gates.hpp | 18 +++--- .../stdlib/hash/pedersen/pedersen_plookup.cpp | 6 +- .../stdlib/hash/pedersen/pedersen_plookup.hpp | 12 ++-- .../stdlib/hash/sha256/sha256.bench.cpp | 2 +- .../stdlib/hash/sha256/sha256.cpp | 6 +- .../stdlib/hash/sha256/sha256.hpp | 8 +-- .../stdlib/hash/sha256/sha256.test.cpp | 56 +++++++++--------- .../stdlib/hash/sha256/sha256_plookup.cpp | 4 +- .../stdlib/hash/sha256/sha256_plookup.hpp | 8 +-- .../barretenberg/stdlib/merkle_tree/hash.hpp | 4 +- .../stdlib/merkle_tree/hash.test.cpp | 4 +- .../stdlib/merkle_tree/hash_path.hpp | 4 +- .../stdlib/merkle_tree/membership.hpp | 4 +- .../stdlib/merkle_tree/membership.test.cpp | 4 +- .../stdlib/merkle_tree/memory_store.hpp | 4 +- .../stdlib/merkle_tree/memory_tree.cpp | 4 +- .../stdlib/merkle_tree/memory_tree.hpp | 4 +- .../stdlib/merkle_tree/memory_tree.test.cpp | 2 +- .../stdlib/merkle_tree/merkle_tree.bench.cpp | 2 +- .../stdlib/merkle_tree/merkle_tree.cpp | 4 +- .../stdlib/merkle_tree/merkle_tree.hpp | 4 +- .../stdlib/merkle_tree/merkle_tree.test.cpp | 2 +- .../primitives/bigfield/bigfield.fuzzer.hpp | 10 ++-- .../stdlib/primitives/bigfield/bigfield.hpp | 4 +- .../primitives/bigfield/bigfield.test.cpp | 6 +- .../bigfield/bigfield_all.fuzzer.cpp | 2 +- .../primitives/bigfield/bigfield_impl.hpp | 30 +++++----- .../bigfield/bigfield_standard.fuzzer.cpp | 2 +- .../bigfield/bigfield_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/biggroup/biggroup.hpp | 16 ++--- .../primitives/biggroup/biggroup.test.cpp | 19 +++--- .../biggroup/biggroup_batch_mul.hpp | 6 +- .../primitives/biggroup/biggroup_bn254.hpp | 6 +- .../primitives/biggroup/biggroup_impl.hpp | 4 +- .../primitives/biggroup/biggroup_nafs.hpp | 4 +- .../biggroup/biggroup_secp256k1.hpp | 6 +- .../primitives/biggroup/biggroup_tables.hpp | 4 +- .../stdlib/primitives/bit_array/bit_array.cpp | 4 +- .../primitives/bit_array/bit_array.fuzzer.hpp | 4 +- .../stdlib/primitives/bit_array/bit_array.hpp | 4 +- .../primitives/bit_array/bit_array.test.cpp | 12 ++-- .../bit_array/bit_array_all.fuzzer.cpp | 2 +- .../bit_array/bit_array_standard.fuzzer.cpp | 2 +- .../bit_array/bit_array_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/bool/bool.cpp | 6 +- .../stdlib/primitives/bool/bool.fuzzer.hpp | 4 +- .../stdlib/primitives/bool/bool.hpp | 4 +- .../stdlib/primitives/bool/bool.test.cpp | 32 +++++----- .../primitives/bool/bool_all.fuzzer.cpp | 2 +- .../primitives/bool/bool_standard.fuzzer.cpp | 2 +- .../primitives/bool/bool_turbo.fuzzer.cpp | 2 +- .../primitives/byte_array/byte_array.cpp | 6 +- .../byte_array/byte_array.fuzzer.hpp | 6 +- .../primitives/byte_array/byte_array.hpp | 4 +- .../primitives/byte_array/byte_array.test.cpp | 2 +- .../byte_array/byte_array_all.fuzzer.cpp | 2 +- .../byte_array/byte_array_standard.fuzzer.cpp | 2 +- .../byte_array/byte_array_turbo.fuzzer.cpp | 2 +- .../primitives/composers/composers_fwd.hpp | 8 +-- .../stdlib/primitives/curves/bn254.hpp | 6 +- .../stdlib/primitives/curves/secp256k1.hpp | 6 +- .../stdlib/primitives/curves/secp256r1.hpp | 6 +- .../stdlib/primitives/field/field.cpp | 12 ++-- .../stdlib/primitives/field/field.fuzzer.hpp | 10 ++-- .../stdlib/primitives/field/field.hpp | 4 +- .../stdlib/primitives/field/field.test.cpp | 8 +-- .../primitives/field/field_all.fuzzer.cpp | 2 +- .../field/field_standard.fuzzer.cpp | 2 +- .../primitives/field/field_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/group/group.hpp | 6 +- .../stdlib/primitives/group/group.test.cpp | 10 ++-- .../primitives/memory/dynamic_array.cpp | 6 +- .../primitives/memory/dynamic_array.hpp | 4 +- .../primitives/memory/dynamic_array.test.cpp | 4 +- .../stdlib/primitives/memory/ram_table.cpp | 8 +-- .../stdlib/primitives/memory/ram_table.hpp | 4 +- .../primitives/memory/ram_table.test.cpp | 4 +- .../stdlib/primitives/memory/rom_table.cpp | 6 +- .../stdlib/primitives/memory/rom_table.hpp | 4 +- .../primitives/memory/rom_table.test.cpp | 4 +- .../primitives/memory/twin_rom_table.cpp | 6 +- .../primitives/memory/twin_rom_table.hpp | 4 +- .../packed_byte_array/packed_byte_array.cpp | 4 +- .../packed_byte_array/packed_byte_array.hpp | 4 +- .../packed_byte_array.test.cpp | 14 ++--- .../stdlib/primitives/plookup/plookup.cpp | 8 +-- .../stdlib/primitives/plookup/plookup.hpp | 4 +- .../primitives/plookup/plookup.test.cpp | 4 +- .../stdlib/primitives/point/point.hpp | 4 +- .../stdlib/primitives/safe_uint/safe_uint.cpp | 4 +- .../primitives/safe_uint/safe_uint.fuzzer.hpp | 10 ++-- .../stdlib/primitives/safe_uint/safe_uint.hpp | 4 +- .../primitives/safe_uint/safe_uint.test.cpp | 16 ++--- .../safe_uint/safe_uint_all.fuzzer.cpp | 2 +- .../safe_uint/safe_uint_standard.fuzzer.cpp | 2 +- .../safe_uint/safe_uint_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/uint/arithmetic.cpp | 6 +- .../stdlib/primitives/uint/comparison.cpp | 4 +- .../stdlib/primitives/uint/logic.cpp | 6 +- .../primitives/uint/plookup/arithmetic.cpp | 6 +- .../primitives/uint/plookup/comparison.cpp | 4 +- .../stdlib/primitives/uint/plookup/logic.cpp | 4 +- .../stdlib/primitives/uint/plookup/uint.cpp | 4 +- .../stdlib/primitives/uint/plookup/uint.hpp | 4 +- .../stdlib/primitives/uint/uint.cpp | 10 ++-- .../stdlib/primitives/uint/uint.fuzzer.hpp | 14 ++--- .../stdlib/primitives/uint/uint.hpp | 12 ++-- .../stdlib/primitives/uint/uint.test.cpp | 12 ++-- .../primitives/uint/uint_all.fuzzer.cpp | 2 +- .../primitives/uint/uint_standard.fuzzer.cpp | 2 +- .../primitives/uint/uint_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/witness/witness.hpp | 4 +- .../recursion/transcript/transcript.hpp | 8 +-- .../recursion/transcript/transcript.test.cpp | 4 +- .../verification_key/verification_key.hpp | 16 ++--- .../recursion/verifier/program_settings.hpp | 58 ++++++++++--------- .../stdlib/recursion/verifier/verifier.hpp | 7 ++- .../recursion/verifier/verifier.test.cpp | 10 ++-- .../verifier/verifier_turbo.test.cpp | 8 +-- cpp/src/barretenberg/stdlib/types/types.hpp | 36 ++++++------ .../barretenberg/transcript/transcript.hpp | 2 +- .../transcript/transcript.test.cpp | 2 +- 340 files changed, 1142 insertions(+), 1105 deletions(-) diff --git a/cpp/src/barretenberg/benchmark/honk_bench/honk.bench.cpp b/cpp/src/barretenberg/benchmark/honk_bench/honk.bench.cpp index 4b9a049dad..aa472edd18 100644 --- a/cpp/src/barretenberg/benchmark/honk_bench/honk.bench.cpp +++ b/cpp/src/barretenberg/benchmark/honk_bench/honk.bench.cpp @@ -34,7 +34,7 @@ void create_prover_bench(State& state) noexcept for (auto _ : state) { state.PauseTiming(); auto num_gates = 1 << (size_t)state.range(0); - auto composer = honk::StandardHonkComposer(static_cast(num_gates)); + auto composer = proof_system::honk::StandardHonkComposer(static_cast(num_gates)); generate_test_plonk_circuit(composer, static_cast(num_gates)); state.ResumeTiming(); @@ -51,7 +51,7 @@ void create_verifier_bench(State& state) noexcept for (auto _ : state) { state.PauseTiming(); auto num_gates = 1 << (size_t)state.range(0); - auto composer = honk::StandardHonkComposer(static_cast(num_gates)); + auto composer = proof_system::honk::StandardHonkComposer(static_cast(num_gates)); generate_test_plonk_circuit(composer, static_cast(num_gates)); state.ResumeTiming(); @@ -68,7 +68,7 @@ void construct_proof_bench(State& state) noexcept auto num_gates = 1 << (size_t)state.range(0); for (auto _ : state) { state.PauseTiming(); - auto composer = honk::StandardHonkComposer(static_cast(num_gates)); + auto composer = proof_system::honk::StandardHonkComposer(static_cast(num_gates)); generate_test_plonk_circuit(composer, static_cast(num_gates)); auto ext_prover = composer.create_prover(); state.ResumeTiming(); @@ -90,7 +90,7 @@ void verify_proof_bench(State& state) noexcept for (auto _ : state) { state.PauseTiming(); auto num_gates = (size_t)state.range(0); - auto composer = honk::StandardHonkComposer(static_cast(num_gates)); + auto composer = proof_system::honk::StandardHonkComposer(static_cast(num_gates)); generate_test_plonk_circuit(composer, static_cast(num_gates)); auto prover = composer.create_prover(); auto proof = prover.construct_proof(); diff --git a/cpp/src/barretenberg/benchmark/pippenger_bench/main.cpp b/cpp/src/barretenberg/benchmark/pippenger_bench/main.cpp index 2208ce5228..40f2b15284 100644 --- a/cpp/src/barretenberg/benchmark/pippenger_bench/main.cpp +++ b/cpp/src/barretenberg/benchmark/pippenger_bench/main.cpp @@ -41,7 +41,7 @@ constexpr size_t NUM_POINTS = 1 << 16; std::vector scalars; static barretenberg::evaluation_domain small_domain; static barretenberg::evaluation_domain large_domain; -auto reference_string = std::make_shared(NUM_POINTS, "../srs_db/ignition"); +auto reference_string = std::make_shared(NUM_POINTS, "../srs_db/ignition"); const auto init = []() { small_domain = barretenberg::evaluation_domain(NUM_POINTS); diff --git a/cpp/src/barretenberg/benchmark/plonk_bench/plonk.bench.cpp b/cpp/src/barretenberg/benchmark/plonk_bench/plonk.bench.cpp index 38581ff231..475499bd72 100644 --- a/cpp/src/barretenberg/benchmark/plonk_bench/plonk.bench.cpp +++ b/cpp/src/barretenberg/benchmark/plonk_bench/plonk.bench.cpp @@ -36,7 +36,7 @@ void construct_witnesses_bench(State& state) noexcept { for (auto _ : state) { state.PauseTiming(); - plonk::StandardComposer composer = plonk::StandardComposer(static_cast(state.range(0))); + plonk::StandardComposer composer = proof_system::plonk::StandardComposer(static_cast(state.range(0))); generate_test_plonk_circuit(composer, static_cast(state.range(0))); composer.compute_proving_key(); state.ResumeTiming(); @@ -49,7 +49,7 @@ BENCHMARK(construct_witnesses_bench)->RangeMultiplier(2)->Range(START, MAX_GATES void construct_proving_keys_bench(State& state) noexcept { for (auto _ : state) { - plonk::StandardComposer composer = plonk::StandardComposer(static_cast(state.range(0))); + plonk::StandardComposer composer = proof_system::plonk::StandardComposer(static_cast(state.range(0))); generate_test_plonk_circuit(composer, static_cast(state.range(0))); size_t idx = static_cast(numeric::get_msb((uint64_t)state.range(0))) - static_cast(numeric::get_msb(START)); @@ -65,7 +65,7 @@ void construct_instances_bench(State& state) noexcept { for (auto _ : state) { state.PauseTiming(); - plonk::StandardComposer composer = plonk::StandardComposer(static_cast(state.range(0))); + plonk::StandardComposer composer = proof_system::plonk::StandardComposer(static_cast(state.range(0))); generate_test_plonk_circuit(composer, static_cast(state.range(0))); size_t idx = static_cast(numeric::get_msb((uint64_t)state.range(0))) - static_cast(numeric::get_msb(START)); diff --git a/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp b/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp index 30160837c7..da82622c7a 100644 --- a/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp @@ -88,7 +88,7 @@ void create_circuit(Composer& composer, const acir_format& constraint_system) } Composer create_circuit(const acir_format& constraint_system, - std::unique_ptr&& crs_factory) + std::unique_ptr&& crs_factory) { if (constraint_system.public_inputs.size() > constraint_system.varnum) { std::cout << "too many public inputs!" << std::endl; diff --git a/cpp/src/barretenberg/dsl/acir_format/acir_format.hpp b/cpp/src/barretenberg/dsl/acir_format/acir_format.hpp index b6f2f2ae4b..55d5ee969e 100644 --- a/cpp/src/barretenberg/dsl/acir_format/acir_format.hpp +++ b/cpp/src/barretenberg/dsl/acir_format/acir_format.hpp @@ -41,7 +41,7 @@ void read_witness(plonk::stdlib::types::Composer& composer, std::vector&& crs_factory); + std::unique_ptr&& crs_factory); plonk::stdlib::types::Composer create_circuit_with_witness(const acir_format& constraint_system, std::vector witness, diff --git a/cpp/src/barretenberg/dsl/acir_format/blake2s_constraint.cpp b/cpp/src/barretenberg/dsl/acir_format/blake2s_constraint.cpp index 56fe6a521f..03deb176f6 100644 --- a/cpp/src/barretenberg/dsl/acir_format/blake2s_constraint.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/blake2s_constraint.cpp @@ -1,7 +1,7 @@ #include "blake2s_constraint.hpp" #include "round.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { @@ -26,7 +26,7 @@ void create_blake2s_constraints(Composer& composer, const Blake2sConstraint& con arr.write(element_bytes); } - byte_array_ct output_bytes = plonk::stdlib::blake2s(arr); + byte_array_ct output_bytes = proof_system::plonk::stdlib::blake2s(arr); // Convert byte array to vector of field_t auto bytes = output_bytes.bytes(); diff --git a/cpp/src/barretenberg/dsl/acir_format/ecdsa_secp256k1.cpp b/cpp/src/barretenberg/dsl/acir_format/ecdsa_secp256k1.cpp index 4287faf643..d81a670cb0 100644 --- a/cpp/src/barretenberg/dsl/acir_format/ecdsa_secp256k1.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/ecdsa_secp256k1.cpp @@ -2,7 +2,7 @@ #include "barretenberg/crypto/ecdsa/ecdsa.hpp" #include "barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_format/fixed_base_scalar_mul.cpp b/cpp/src/barretenberg/dsl/acir_format/fixed_base_scalar_mul.cpp index 6e829a8a9a..81251944e6 100644 --- a/cpp/src/barretenberg/dsl/acir_format/fixed_base_scalar_mul.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/fixed_base_scalar_mul.cpp @@ -1,6 +1,6 @@ #include "fixed_base_scalar_mul.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_format/hash_to_field.cpp b/cpp/src/barretenberg/dsl/acir_format/hash_to_field.cpp index 564cd13c2e..998b414cd4 100644 --- a/cpp/src/barretenberg/dsl/acir_format/hash_to_field.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/hash_to_field.cpp @@ -1,7 +1,7 @@ #include "hash_to_field.hpp" #include "round.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { @@ -30,7 +30,7 @@ void create_hash_to_field_constraints(Composer& composer, const HashToFieldConst // Hash To Field using blake2s. // Note: It does not need to be blake2s in the future - byte_array_ct out_bytes = plonk::stdlib::blake2s(arr); + byte_array_ct out_bytes = proof_system::plonk::stdlib::blake2s(arr); field_ct out(out_bytes); field_ct normalised_out = out.normalize(); diff --git a/cpp/src/barretenberg/dsl/acir_format/merkle_membership_constraint.cpp b/cpp/src/barretenberg/dsl/acir_format/merkle_membership_constraint.cpp index 8ff90de39d..3f30a61fcb 100644 --- a/cpp/src/barretenberg/dsl/acir_format/merkle_membership_constraint.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/merkle_membership_constraint.cpp @@ -1,8 +1,8 @@ #include "merkle_membership_constraint.hpp" #include "barretenberg/stdlib/merkle_tree/membership.hpp" -using namespace plonk::stdlib::types; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::merkle_tree; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_format/pedersen.cpp b/cpp/src/barretenberg/dsl/acir_format/pedersen.cpp index 466929df42..03a8c4fe1f 100644 --- a/cpp/src/barretenberg/dsl/acir_format/pedersen.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/pedersen.cpp @@ -1,6 +1,6 @@ #include "pedersen.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_format/schnorr_verify.cpp b/cpp/src/barretenberg/dsl/acir_format/schnorr_verify.cpp index 7c80c4208c..f92176bd08 100644 --- a/cpp/src/barretenberg/dsl/acir_format/schnorr_verify.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/schnorr_verify.cpp @@ -1,7 +1,7 @@ #include "schnorr_verify.hpp" #include "barretenberg/crypto/schnorr/schnorr.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp b/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp index 4da8a53567..e54697d4e7 100644 --- a/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/sha256_constraint.cpp @@ -2,7 +2,7 @@ #include "round.hpp" #include "barretenberg/stdlib/hash/sha256/sha256.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { @@ -30,7 +30,7 @@ void create_sha256_constraints(Composer& composer, const Sha256Constraint& const } // Compute sha256 - byte_array_ct output_bytes = plonk::stdlib::sha256(arr); + byte_array_ct output_bytes = proof_system::plonk::stdlib::sha256(arr); // Convert byte array to vector of field_t auto bytes = output_bytes.bytes(); diff --git a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp index d6e673eca9..aa3cb22f75 100644 --- a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp +++ b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp @@ -6,7 +6,7 @@ #include "barretenberg/srs/reference_string/pippenger_reference_string.hpp" #include "barretenberg/proof_system/verification_key/sol_gen.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_proofs { @@ -32,7 +32,7 @@ size_t get_solidity_verifier(uint8_t const* g2x, uint8_t const* vk_buf, uint8_t* uint32_t get_exact_circuit_size(uint8_t const* constraint_system_buf) { auto constraint_system = from_buffer(constraint_system_buf); - auto crs_factory = std::make_unique(); + auto crs_factory = std::make_unique(); auto composer = create_circuit(constraint_system, std::move(crs_factory)); auto num_gates = composer.get_num_gates(); @@ -83,7 +83,7 @@ size_t init_verification_key(void* pippenger, uint8_t const* g2x, uint8_t const* // The composer_type has not yet been set. We need to set the composer_type for when we later read in and // construct the verification key so that we have the correct polynomial manifest - verification_key->composer_type = bonk::ComposerType::PLOOKUP; + verification_key->composer_type = proof_system::ComposerType::PLOOKUP; auto buffer = to_buffer(*verification_key); auto raw_buf = (uint8_t*)malloc(buffer.size()); diff --git a/cpp/src/barretenberg/ecc/curves/types.hpp b/cpp/src/barretenberg/ecc/curves/types.hpp index f716c7c4d1..deb7384216 100644 --- a/cpp/src/barretenberg/ecc/curves/types.hpp +++ b/cpp/src/barretenberg/ecc/curves/types.hpp @@ -1,5 +1,5 @@ #pragma once -namespace bonk { +namespace proof_system { enum CurveType { BN254, SECP256K1, SECP256R1, GRUMPKIN }; } diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp index 7d878d9fd5..d824abc1bf 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp @@ -8,7 +8,7 @@ #include #include -namespace honk { +namespace proof_system::honk { /** * Compute proving key base. @@ -28,8 +28,11 @@ std::shared_ptr StandardHonkComposerHelper StandardHonkComposerHelper std::shared_ptr StandardHonkComposerHelper::compute_verification_key_base( - std::shared_ptr const& proving_key, std::shared_ptr const& vrs) + std::shared_ptr const& proving_key, + std::shared_ptr const& vrs) { auto key = std::make_shared( proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); @@ -105,7 +109,8 @@ std::shared_ptr StandardHonkComposerHelper(circuit_constructor, @@ -179,4 +184,4 @@ StandardProver StandardHonkComposerHelper::create_prover( template class StandardHonkComposerHelper; template StandardProver StandardHonkComposerHelper::create_prover( const StandardCircuitConstructor& circuit_constructor); -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp index 8c6d56ccc0..266a07769b 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp @@ -15,7 +15,7 @@ #include -namespace honk { +namespace proof_system::honk { // TODO(Kesha): change initializations to specify this parameter // Cody: What does this mean? template class StandardHonkComposerHelper { @@ -27,17 +27,17 @@ template class StandardHonkComposerHelper { std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; bool computed_witness = false; StandardHonkComposerHelper() - : StandardHonkComposerHelper( - std::shared_ptr(new bonk::FileReferenceStringFactory("../srs_db/ignition"))) + : StandardHonkComposerHelper(std::shared_ptr( + new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) {} - StandardHonkComposerHelper(std::shared_ptr crs_factory) + StandardHonkComposerHelper(std::shared_ptr crs_factory) : crs_factory_(std::move(crs_factory)) {} - StandardHonkComposerHelper(std::unique_ptr&& crs_factory) + StandardHonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} StandardHonkComposerHelper(std::shared_ptr p_key, @@ -68,9 +68,9 @@ template class StandardHonkComposerHelper { static std::shared_ptr compute_verification_key_base( std::shared_ptr const& proving_key, - std::shared_ptr const& vrs); + std::shared_ptr const& vrs); void compute_witness(const CircuitConstructor& circuit_constructor, const size_t minimum_circuit_size = 0); }; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp index c918ed117d..3674576a6c 100644 --- a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp +++ b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp @@ -6,7 +6,7 @@ #include "barretenberg/transcript/manifest.hpp" #include "barretenberg/honk/flavor/flavor.hpp" -namespace honk { +namespace proof_system::honk { /** * @brief Standard Honk Composer has everything required to construct a prover and verifier, just as the legacy classes. * @@ -15,7 +15,7 @@ namespace honk { */ class StandardHonkComposer { public: - static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD_HONK; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD_HONK; static constexpr size_t UINT_LOG2_BASE = 2; // An instantiation of the circuit constructor that only depends on arithmetization, not on the proof system @@ -38,18 +38,20 @@ class StandardHonkComposer { , variables(circuit_constructor.variables){}; StandardHonkComposer(std::string const& crs_path, const size_t size_hint = 0) - : StandardHonkComposer( - std::unique_ptr(new bonk::FileReferenceStringFactory(crs_path)), - size_hint){}; + : StandardHonkComposer(std::unique_ptr( + new proof_system::FileReferenceStringFactory(crs_path)), + size_hint){}; - StandardHonkComposer(std::shared_ptr const& crs_factory, const size_t size_hint = 0) + StandardHonkComposer(std::shared_ptr const& crs_factory, + const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(crs_factory) , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables) {} - StandardHonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) + StandardHonkComposer(std::unique_ptr&& crs_factory, + const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(std::move(crs_factory)) , num_gates(circuit_constructor.num_gates) @@ -184,4 +186,4 @@ class StandardHonkComposer { const std::string& err() const { return circuit_constructor.err(); }; void failure(std::string msg) { circuit_constructor.failure(msg); } }; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/composer/standard_honk_composer.test.cpp b/cpp/src/barretenberg/honk/composer/standard_honk_composer.test.cpp index a9970add68..84717e21a4 100644 --- a/cpp/src/barretenberg/honk/composer/standard_honk_composer.test.cpp +++ b/cpp/src/barretenberg/honk/composer/standard_honk_composer.test.cpp @@ -11,7 +11,7 @@ #include -using namespace honk; +using namespace proof_system::honk; namespace test_standard_honk_composer { /** @@ -93,7 +93,7 @@ TEST(StandardHonkComposer, SigmaIDCorrectness) } // test correctness of the public input delta - auto delta = honk::compute_public_input_delta(public_inputs, beta, gamma, n); + auto delta = proof_system::honk::compute_public_input_delta(public_inputs, beta, gamma, n); EXPECT_EQ(left / right, delta); for (size_t i = 0; i < num_public_inputs; ++i) { @@ -348,7 +348,7 @@ TEST(StandardHonkComposer, SumcheckRelationCorrectness) .public_input_delta = public_input_delta, }; - constexpr size_t num_polynomials = honk::StandardArithmetization::NUM_POLYNOMIALS; + constexpr size_t num_polynomials = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; // Compute grand product polynomial polynomial z_perm_poly = prover_library::compute_permutation_grand_product(prover.key, prover.wire_polynomials, beta, gamma); @@ -359,7 +359,7 @@ TEST(StandardHonkComposer, SumcheckRelationCorrectness) // in the list below std::array, num_polynomials> evaluations_array; - using POLYNOMIAL = honk::StandardArithmetization::POLYNOMIAL; + using POLYNOMIAL = proof_system::honk::StandardArithmetization::POLYNOMIAL; evaluations_array[POLYNOMIAL::W_L] = prover.wire_polynomials[0]; evaluations_array[POLYNOMIAL::W_R] = prover.wire_polynomials[1]; evaluations_array[POLYNOMIAL::W_O] = prover.wire_polynomials[2]; diff --git a/cpp/src/barretenberg/honk/flavor/flavor.hpp b/cpp/src/barretenberg/honk/flavor/flavor.hpp index 0d8903f945..ad47783e1d 100644 --- a/cpp/src/barretenberg/honk/flavor/flavor.hpp +++ b/cpp/src/barretenberg/honk/flavor/flavor.hpp @@ -5,7 +5,7 @@ #include "barretenberg/proof_system/arithmetization/arithmetization.hpp" #include "barretenberg/transcript/manifest.hpp" -namespace honk { +namespace proof_system::honk { // TODO(Cody) This _should_ be shared with Plonk, but it isn't. struct StandardArithmetization { /** @@ -59,14 +59,14 @@ struct StandardArithmetization { "LAGRANGE_LAST", "W_1", "W_2", "W_3", "Z_PERM", "Z_PERM_SHIFT" }; }; -} // namespace honk +} // namespace proof_system::honk -namespace honk { +namespace proof_system::honk { struct StandardHonk { public: // This whole file is broken; changes here are in anticipation of a follow-up rework of the flavor specificaiton. using Arithmetization = arithmetization::Standard; - using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; // // TODO(Cody): Where to specify? is this polynomial manifest size? // static constexpr size_t STANDARD_HONK_MANIFEST_SIZE = 16; // TODO(Cody): Maybe relation should be supplied and this should be computed as is done in sumcheck? @@ -187,4 +187,4 @@ struct StandardHonk { return output; } }; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/oracle/oracle.hpp b/cpp/src/barretenberg/honk/oracle/oracle.hpp index 0a78654fa9..52beed5d12 100644 --- a/cpp/src/barretenberg/honk/oracle/oracle.hpp +++ b/cpp/src/barretenberg/honk/oracle/oracle.hpp @@ -3,7 +3,7 @@ #include #include -namespace honk { +namespace proof_system::honk { template struct Oracle { size_t consumed{ 0 }; @@ -271,4 +271,4 @@ template struct Oracle { // Fr public_input_delta = 1; // TODO FIX // }; -} // namespace honk \ No newline at end of file +} // namespace proof_system::honk \ No newline at end of file diff --git a/cpp/src/barretenberg/honk/pcs/claim.hpp b/cpp/src/barretenberg/honk/pcs/claim.hpp index 55f26bfd15..d009edc0d3 100644 --- a/cpp/src/barretenberg/honk/pcs/claim.hpp +++ b/cpp/src/barretenberg/honk/pcs/claim.hpp @@ -2,7 +2,7 @@ #include "barretenberg/polynomials/polynomial.hpp" -namespace honk::pcs { +namespace proof_system::honk::pcs { /** * @brief Opening pair (r,v) for some witness polynomial p(X) such that p(r) = v * @@ -90,4 +90,4 @@ template class MLEOpeningClaim { // v↺ = g(u) = a₁⋅L₀(u) + … + aₙ₋₁⋅Lₙ₋₂(u) Fr evaluation; }; -} // namespace honk::pcs +} // namespace proof_system::honk::pcs diff --git a/cpp/src/barretenberg/honk/pcs/commitment_key.hpp b/cpp/src/barretenberg/honk/pcs/commitment_key.hpp index 81aec686f4..ce29e5fe7d 100644 --- a/cpp/src/barretenberg/honk/pcs/commitment_key.hpp +++ b/cpp/src/barretenberg/honk/pcs/commitment_key.hpp @@ -15,7 +15,7 @@ #include #include -namespace honk::pcs { +namespace proof_system::honk::pcs { namespace kzg { @@ -66,7 +66,7 @@ class CommitmentKey { private: barretenberg::scalar_multiplication::pippenger_runtime_state pippenger_runtime_state; - bonk::FileReferenceString srs; + proof_system::FileReferenceString srs; }; class VerificationKey { @@ -108,7 +108,7 @@ class VerificationKey { } private: - bonk::VerifierFileReferenceString verifier_srs; + proof_system::VerifierFileReferenceString verifier_srs; }; struct Params { @@ -243,7 +243,7 @@ class CommitmentKey { }; barretenberg::scalar_multiplication::pippenger_runtime_state pippenger_runtime_state; - bonk::FileReferenceString srs; + proof_system::FileReferenceString srs; }; class VerificationKey { @@ -268,7 +268,7 @@ class VerificationKey { {} barretenberg::scalar_multiplication::pippenger_runtime_state pippenger_runtime_state; - bonk::FileReferenceString srs; + proof_system::FileReferenceString srs; }; struct Params { @@ -284,4 +284,4 @@ struct Params { } // namespace ipa -} // namespace honk::pcs +} // namespace proof_system::honk::pcs diff --git a/cpp/src/barretenberg/honk/pcs/commitment_key.test.hpp b/cpp/src/barretenberg/honk/pcs/commitment_key.test.hpp index 47623ee453..0676a2631f 100644 --- a/cpp/src/barretenberg/honk/pcs/commitment_key.test.hpp +++ b/cpp/src/barretenberg/honk/pcs/commitment_key.test.hpp @@ -19,7 +19,7 @@ #include "claim.hpp" #include "commitment_key.hpp" -namespace honk::pcs { +namespace proof_system::honk::pcs { namespace { constexpr std::string_view kzg_srs_path = "../srs_db/ignition"; } @@ -202,4 +202,4 @@ using IpaCommitmentSchemeParams = ::testing::Types; // using CommitmentSchemeParams = // ::testing::Types, fake::Params, kzg::Params>; -} // namespace honk::pcs +} // namespace proof_system::honk::pcs diff --git a/cpp/src/barretenberg/honk/pcs/gemini/gemini.hpp b/cpp/src/barretenberg/honk/pcs/gemini/gemini.hpp index e4b0126949..6e2cd50fe7 100644 --- a/cpp/src/barretenberg/honk/pcs/gemini/gemini.hpp +++ b/cpp/src/barretenberg/honk/pcs/gemini/gemini.hpp @@ -46,7 +46,7 @@ * The verifier is able to computed the simulated commitments to A₀₊(X) and A₀₋(X) * since they are linear-combinations of the commitments [fⱼ] and [gⱼ]. */ -namespace honk::pcs::gemini { +namespace proof_system::honk::pcs::gemini { /** * @brief Prover output (evalutation pair, witness) that can be passed on to Shplonk batch opening. @@ -346,4 +346,4 @@ template class MultilinearReductionScheme { return { C0_r_pos, C0_r_neg }; }; }; -} // namespace honk::pcs::gemini +} // namespace proof_system::honk::pcs::gemini diff --git a/cpp/src/barretenberg/honk/pcs/gemini/gemini.test.cpp b/cpp/src/barretenberg/honk/pcs/gemini/gemini.test.cpp index 17af010e23..cf2e0549cf 100644 --- a/cpp/src/barretenberg/honk/pcs/gemini/gemini.test.cpp +++ b/cpp/src/barretenberg/honk/pcs/gemini/gemini.test.cpp @@ -7,7 +7,7 @@ #include #include -namespace honk::pcs::gemini { +namespace proof_system::honk::pcs::gemini { template class GeminiTest : public CommitmentTest { using Gemini = MultilinearReductionScheme; @@ -237,4 +237,4 @@ TYPED_TEST(GeminiTest, DoubleWithShift) multilinear_commitments_to_be_shifted); } -} // namespace honk::pcs::gemini +} // namespace proof_system::honk::pcs::gemini diff --git a/cpp/src/barretenberg/honk/pcs/ipa/ipa.hpp b/cpp/src/barretenberg/honk/pcs/ipa/ipa.hpp index b4add52fe5..6175d4da46 100644 --- a/cpp/src/barretenberg/honk/pcs/ipa/ipa.hpp +++ b/cpp/src/barretenberg/honk/pcs/ipa/ipa.hpp @@ -17,7 +17,7 @@ * https://hackmd.io/q-A8y6aITWyWJrvsGGMWNA?view. * */ -namespace honk::pcs::ipa { +namespace proof_system::honk::pcs::ipa { template class InnerProductArgument { using Fr = typename Params::Fr; using element = typename Params::Commitment; @@ -66,9 +66,9 @@ template class InnerProductArgument { "The poly_degree should be positive and a power of two"); auto& aux_generator = pub_input.aux_generator; auto a_vec = polynomial; - // TODO(#220)(Arijit): to make it more efficient by directly using G_vector for the input points when i = 0 and write the - // output points to G_vec_local. Then use G_vec_local for rounds where i>0, this can be done after we use SRS - // instead of G_vector. + // TODO(#220)(Arijit): to make it more efficient by directly using G_vector for the input points when i = 0 and + // write the output points to G_vec_local. Then use G_vec_local for rounds where i>0, this can be done after we + // use SRS instead of G_vector. auto srs_elements = ck->srs.get_monomial_points(); std::vector G_vec_local(poly_degree); for (size_t i = 0; i < poly_degree; i++) { @@ -251,4 +251,4 @@ template class InnerProductArgument { } }; -} // namespace honk::pcs::ipa +} // namespace proof_system::honk::pcs::ipa diff --git a/cpp/src/barretenberg/honk/pcs/ipa/ipa.test.cpp b/cpp/src/barretenberg/honk/pcs/ipa/ipa.test.cpp index 39bd880312..513e931d47 100644 --- a/cpp/src/barretenberg/honk/pcs/ipa/ipa.test.cpp +++ b/cpp/src/barretenberg/honk/pcs/ipa/ipa.test.cpp @@ -7,7 +7,7 @@ #include "barretenberg/honk/pcs/commitment_key.hpp" #include "barretenberg/honk/pcs/commitment_key.test.hpp" using namespace barretenberg; -namespace honk::pcs::ipa { +namespace proof_system::honk::pcs::ipa { template class IpaCommitmentTest : public CommitmentTest { using Fr = typename Params::Fr; @@ -58,4 +58,4 @@ TYPED_TEST(IpaCommitmentTest, open) auto result = IPA::reduce_verify(this->vk(), proof, pub_input); EXPECT_TRUE(result); } -} // namespace honk::pcs::ipa +} // namespace proof_system::honk::pcs::ipa diff --git a/cpp/src/barretenberg/honk/pcs/kzg/kzg.hpp b/cpp/src/barretenberg/honk/pcs/kzg/kzg.hpp index 0a38b09c3a..b6ba93653a 100644 --- a/cpp/src/barretenberg/honk/pcs/kzg/kzg.hpp +++ b/cpp/src/barretenberg/honk/pcs/kzg/kzg.hpp @@ -7,7 +7,7 @@ #include #include -namespace honk::pcs::kzg { +namespace proof_system::honk::pcs::kzg { /** * @brief A transformed polynomial commitment opening claim of the form (P₀, P₁) ∈ 𝔾₁ * which should satisfy e(P₀, [1]₂) ⋅ e(P₁, [x]₂)=1. @@ -93,4 +93,4 @@ template class UnivariateOpeningScheme { return Accumulator(claim, quotient_commitment); }; }; -} // namespace honk::pcs::kzg +} // namespace proof_system::honk::pcs::kzg diff --git a/cpp/src/barretenberg/honk/pcs/kzg/kzg.test.cpp b/cpp/src/barretenberg/honk/pcs/kzg/kzg.test.cpp index ebbf44af0a..5d4e53a8c1 100644 --- a/cpp/src/barretenberg/honk/pcs/kzg/kzg.test.cpp +++ b/cpp/src/barretenberg/honk/pcs/kzg/kzg.test.cpp @@ -13,7 +13,7 @@ #include #include -namespace honk::pcs::kzg { +namespace proof_system::honk::pcs::kzg { template class BilinearAccumulationTest : public CommitmentTest { public: @@ -170,4 +170,4 @@ TYPED_TEST(BilinearAccumulationTest, GeminiShplonkKzgWithShift) EXPECT_EQ(verified, true); } -} // namespace honk::pcs::kzg +} // namespace proof_system::honk::pcs::kzg diff --git a/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.hpp b/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.hpp index f09be9da05..af84e1b632 100644 --- a/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.hpp +++ b/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.hpp @@ -17,7 +17,7 @@ * The challenges are ρ (batching) and r (random evaluation). * */ -namespace honk::pcs::shplonk { +namespace proof_system::honk::pcs::shplonk { /** * @brief Single commitment to Q(X) = ∑ₖ ( Bₖ(X) − Tₖ(X) ) / zₖ(X) @@ -43,4 +43,4 @@ template struct ProverOutput { OutputWitness witness; // single polynomial G(X) }; -} // namespace honk::pcs::shplonk +} // namespace proof_system::honk::pcs::shplonk diff --git a/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.test.cpp b/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.test.cpp index 2e406414f5..072b665e8c 100644 --- a/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.test.cpp +++ b/cpp/src/barretenberg/honk/pcs/shplonk/shplonk.test.cpp @@ -10,7 +10,7 @@ #include "../commitment_key.test.hpp" #include "barretenberg/honk/pcs/claim.hpp" #include "barretenberg/polynomials/polynomial.hpp" -namespace honk::pcs::shplonk { +namespace proof_system::honk::pcs::shplonk { template class ShplonkTest : public CommitmentTest {}; TYPED_TEST_SUITE(ShplonkTest, CommitmentSchemeParams); @@ -63,4 +63,4 @@ TYPED_TEST(ShplonkTest, ShplonkSimple) this->verify_opening_claim(verifier_claim, shplonk_prover_witness); } -} // namespace honk::pcs::shplonk +} // namespace proof_system::honk::pcs::shplonk diff --git a/cpp/src/barretenberg/honk/pcs/shplonk/shplonk_single.hpp b/cpp/src/barretenberg/honk/pcs/shplonk/shplonk_single.hpp index f68a0f98d5..099e73962a 100644 --- a/cpp/src/barretenberg/honk/pcs/shplonk/shplonk_single.hpp +++ b/cpp/src/barretenberg/honk/pcs/shplonk/shplonk_single.hpp @@ -4,7 +4,7 @@ #include "barretenberg/honk/pcs/commitment_key.hpp" #include "barretenberg/honk/transcript/transcript.hpp" -namespace honk::pcs::shplonk { +namespace proof_system::honk::pcs::shplonk { /** * @brief Protocol for opening several polynomials, each in a single different point. @@ -164,4 +164,4 @@ template class SingleBatchOpeningScheme { return { { z_challenge, Fr::zero() }, G_commitment }; }; }; -} // namespace honk::pcs::shplonk +} // namespace proof_system::honk::pcs::shplonk diff --git a/cpp/src/barretenberg/honk/pcs/wrapper.hpp b/cpp/src/barretenberg/honk/pcs/wrapper.hpp index d5f60d8cd7..eb04f99565 100644 --- a/cpp/src/barretenberg/honk/pcs/wrapper.hpp +++ b/cpp/src/barretenberg/honk/pcs/wrapper.hpp @@ -4,7 +4,7 @@ #include "gemini/gemini.hpp" #include "barretenberg/ecc/curves/bn254/g1.hpp" -namespace honk { +namespace proof_system::honk { struct OpeningProof { std::vector gemini; @@ -12,4 +12,4 @@ struct OpeningProof { barretenberg::g1::affine_element kzg; }; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/proof_system/program_settings.hpp b/cpp/src/barretenberg/honk/proof_system/program_settings.hpp index 037d24362e..b3df26bec6 100644 --- a/cpp/src/barretenberg/honk/proof_system/program_settings.hpp +++ b/cpp/src/barretenberg/honk/proof_system/program_settings.hpp @@ -6,7 +6,7 @@ #include "../../plonk/proof_system/types/prover_settings.hpp" #include "barretenberg/honk/flavor/flavor.hpp" -namespace honk { +namespace proof_system::honk { // TODO(#221)(Luke/Cody): Shouldn't subclass plonk settings here. Also, define standard_settings for Honk prover. class standard_verifier_settings : public plonk::standard_settings { @@ -15,8 +15,8 @@ class standard_verifier_settings : public plonk::standard_settings { typedef transcript::StandardTranscript Transcript; static constexpr size_t num_challenge_bytes = 16; static constexpr transcript::HashType hash_type = transcript::HashType::PedersenBlake3s; - static constexpr size_t num_wires = honk::StandardHonk::Arithmetization::num_wires; - static constexpr size_t num_polys = honk::StandardArithmetization::NUM_POLYNOMIALS; + static constexpr size_t num_wires = proof_system::honk::StandardHonk::Arithmetization::num_wires; + static constexpr size_t num_polys = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; }; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/proof_system/prover.cpp b/cpp/src/barretenberg/honk/proof_system/prover.cpp index 73b4aa9711..7dbd085f40 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover.cpp @@ -22,12 +22,12 @@ #include #include "barretenberg/honk/pcs/claim.hpp" -namespace honk { +namespace proof_system::honk { using Fr = barretenberg::fr; using Commitment = barretenberg::g1::affine_element; using Polynomial = barretenberg::Polynomial; -using POLYNOMIAL = honk::StandardArithmetization::POLYNOMIAL; +using POLYNOMIAL = proof_system::honk::StandardArithmetization::POLYNOMIAL; /** * Create Prover from proving key, witness and manifest. @@ -182,8 +182,8 @@ template void Prover::execute_relation_check_round * */ template void Prover::execute_univariatization_round() { - const size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; - const size_t NUM_UNSHIFTED_POLYS = honk::StandardArithmetization::NUM_UNSHIFTED_POLYNOMIALS; + const size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; + const size_t NUM_UNSHIFTED_POLYS = proof_system::honk::StandardArithmetization::NUM_UNSHIFTED_POLYNOMIALS; // Generate batching challenge ρ and powers 1,ρ,…,ρᵐ⁻¹ Fr rho = transcript.get_challenge("rho"); @@ -317,4 +317,4 @@ template plonk::proof& Prover::construct_proof() template class Prover; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/proof_system/prover.hpp b/cpp/src/barretenberg/honk/proof_system/prover.hpp index f3111efcf0..43d2d27f38 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover.hpp +++ b/cpp/src/barretenberg/honk/proof_system/prover.hpp @@ -25,7 +25,7 @@ #include "barretenberg/honk/pcs/claim.hpp" #include "barretenberg/honk/proof_system/prover_library.hpp" -namespace honk { +namespace proof_system::honk { using Fr = barretenberg::fr; using Polynomial = Polynomial; @@ -74,9 +74,9 @@ template class Prover { // Honk only needs a small portion of the functionality but may be fine to use existing work_queue // NOTE: this is not currently in use, but it may well be used in the future. // TODO(Adrian): Uncomment when we need this again. - // bonk::work_queue queue; + // proof_system::work_queue queue; // void flush_queued_work_items() { queue.flush_queue(); } - // bonk::work_queue::work_item_info get_queued_work_item_info() const { + // proof_system::work_queue::work_item_info get_queued_work_item_info() const { // return queue.get_queued_work_item_info(); // } // size_t get_scalar_multiplication_size(const size_t work_item_number) const @@ -103,4 +103,4 @@ extern template class Prover; using StandardProver = Prover; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.cpp b/cpp/src/barretenberg/honk/proof_system/prover_library.cpp index 5e96419ded..d99a2947a4 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.cpp @@ -2,7 +2,7 @@ #include "barretenberg/plonk/proof_system/types/prover_settings.hpp" #include -namespace honk::prover_library { +namespace proof_system::honk::prover_library { using Fr = barretenberg::fr; using Polynomial = barretenberg::Polynomial; @@ -357,4 +357,4 @@ template Polynomial compute_permutation_grand_product( std::shared_ptr&, std::vector&, Fr, Fr); -} // namespace honk::prover_library +} // namespace proof_system::honk::prover_library diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.hpp b/cpp/src/barretenberg/honk/proof_system/prover_library.hpp index 33f5f36bbd..c88a089f85 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.hpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.hpp @@ -5,7 +5,7 @@ #include "barretenberg/plonk/proof_system/types/proof.hpp" #include "barretenberg/plonk/proof_system/types/program_settings.hpp" -namespace honk::prover_library { +namespace proof_system::honk::prover_library { using Fr = barretenberg::fr; using Polynomial = barretenberg::Polynomial; @@ -27,4 +27,4 @@ Polynomial compute_sorted_list_accumulator(std::shared_ptr& std::vector& sorted_list_polynomials, Fr eta); -} // namespace honk::prover_library +} // namespace proof_system::honk::prover_library diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp index aca4083440..314b26d02c 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp @@ -10,7 +10,7 @@ #include #include -using namespace honk; +using namespace proof_system::honk; namespace prover_library_tests { // field is named Fscalar here because of clash with the Fr @@ -47,11 +47,12 @@ template class ProverLibraryTests : public testing::Test { // Define some mock inputs for proving key constructor static const size_t num_gates = 8; static const size_t num_public_inputs = 0; - auto reference_string = std::make_shared(num_gates + 1, "../srs_db/ignition"); + auto reference_string = + std::make_shared(num_gates + 1, "../srs_db/ignition"); // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. auto proving_key = std::make_shared( - num_gates, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); + num_gates, num_public_inputs, reference_string, proof_system::ComposerType::STANDARD_HONK); // static const size_t program_width = StandardProver::settings_::program_width; @@ -156,11 +157,12 @@ template class ProverLibraryTests : public testing::Test { // Define some mock inputs for proving key constructor static const size_t circuit_size = 8; static const size_t num_public_inputs = 0; - auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); + auto reference_string = + std::make_shared(circuit_size + 1, "../srs_db/ignition"); // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. auto proving_key = std::make_shared( - circuit_size, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); + circuit_size, num_public_inputs, reference_string, proof_system::ComposerType::STANDARD_HONK); // Construct mock wire and permutation polynomials. // Note: for the purpose of checking the consistency between two methods of computing z_perm, these polynomials @@ -285,9 +287,10 @@ template class ProverLibraryTests : public testing::Test { // Construct a proving_key static const size_t circuit_size = 8; static const size_t num_public_inputs = 0; - auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); + auto reference_string = + std::make_shared(circuit_size + 1, "../srs_db/ignition"); auto proving_key = std::make_shared( - circuit_size, num_public_inputs, reference_string, bonk::ComposerType::STANDARD_HONK); + circuit_size, num_public_inputs, reference_string, proof_system::ComposerType::STANDARD_HONK); // Get random challenge eta auto eta = FF::random_element(); diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.cpp index 36f3ff3cf7..a40054f2c5 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.cpp @@ -26,9 +26,9 @@ #include "barretenberg/honk/sumcheck/relations/grand_product_initialization_relation.hpp" using namespace barretenberg; -using namespace honk::sumcheck; +using namespace proof_system::honk::sumcheck; -namespace honk { +namespace proof_system::honk { template Verifier::Verifier(std::shared_ptr verifier_key) : key(verifier_key) @@ -83,9 +83,9 @@ template bool Verifier::verify_pro using Gemini = pcs::gemini::MultilinearReductionScheme; using Shplonk = pcs::shplonk::SingleBatchOpeningScheme; using KZG = pcs::kzg::UnivariateOpeningScheme; - const size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; - const size_t NUM_UNSHIFTED = honk::StandardArithmetization::NUM_UNSHIFTED_POLYNOMIALS; - const size_t NUM_PRECOMPUTED = honk::StandardArithmetization::NUM_PRECOMPUTED_POLYNOMIALS; + const size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; + const size_t NUM_UNSHIFTED = proof_system::honk::StandardArithmetization::NUM_UNSHIFTED_POLYNOMIALS; + const size_t NUM_PRECOMPUTED = proof_system::honk::StandardArithmetization::NUM_PRECOMPUTED_POLYNOMIALS; constexpr auto num_wires = program_settings::num_wires; @@ -199,4 +199,4 @@ template bool Verifier::verify_pro template class Verifier; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.hpp b/cpp/src/barretenberg/honk/proof_system/verifier.hpp index 180fe9ddf3..ed4fe608a1 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.hpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.hpp @@ -12,7 +12,7 @@ #include "barretenberg/honk/pcs/shplonk/shplonk_single.hpp" #include "barretenberg/honk/pcs/kzg/kzg.hpp" -namespace honk { +namespace proof_system::honk { template class Verifier { public: @@ -35,4 +35,4 @@ extern template class Verifier; typedef Verifier StandardVerifier; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp index 3efc21d46f..482281ca89 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp @@ -15,7 +15,7 @@ #include using namespace barretenberg; -using namespace honk; +using namespace proof_system::honk; namespace test_honk_verifier { @@ -50,7 +50,7 @@ template class VerifierTests : public testing::Test { prover)); } - auto crs = std::make_shared("../srs_db/ignition"); + auto crs = std::make_shared("../srs_db/ignition"); auto circuit_verification_key = std::make_shared(circuit_proving_key->circuit_size, circuit_proving_key->num_public_inputs, @@ -82,9 +82,9 @@ template class VerifierTests : public testing::Test { // Create some constraints that satisfy our arithmetic circuit relation // even indices = mul gates, odd incides = add gates - auto crs = std::make_shared(n + 1, "../srs_db/ignition"); + auto crs = std::make_shared(n + 1, "../srs_db/ignition"); std::shared_ptr proving_key = - std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD_HONK); + std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD_HONK); polynomial w_l(n); polynomial w_r(n); @@ -178,8 +178,8 @@ template class VerifierTests : public testing::Test { proving_key->polynomial_store.put("sigma_2_lagrange", std::move(sigma_2_lagrange_base)); proving_key->polynomial_store.put("sigma_3_lagrange", std::move(sigma_3_lagrange_base)); - bonk::compute_standard_honk_id_polynomials<3>(proving_key); - bonk::compute_first_and_last_lagrange_polynomials(proving_key); + proof_system::compute_standard_honk_id_polynomials<3>(proving_key); + proof_system::compute_first_and_last_lagrange_polynomials(proving_key); proving_key->polynomial_store.put("w_1_lagrange", std::move(w_l)); proving_key->polynomial_store.put("w_2_lagrange", std::move(w_r)); diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.hpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.hpp index 7fb7667368..ae2d5f5d9b 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.hpp @@ -13,7 +13,7 @@ 4) There should be more thorough testing of this class in isolation. */ -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { /** * NOTE: We should definitely consider question of optimal choice of domain, but if decide on {0,1,...,t-1} then we can @@ -147,4 +147,4 @@ template class BarycentricData return result; }; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.test.cpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.test.cpp index baee00800e..ed2471d01e 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/barycentric_data.test.cpp @@ -4,7 +4,7 @@ #include #include "barretenberg/numeric/random/engine.hpp" -using namespace honk::sumcheck; +using namespace proof_system::honk::sumcheck; namespace test_sumcheck_polynomials { template class BarycentricDataTests : public testing::Test {}; diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp index c5d7756b8a..d9d792daf8 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp @@ -6,13 +6,13 @@ #include "barretenberg/honk/transcript/transcript.hpp" #include "barretenberg/numeric/random/engine.hpp" -using namespace honk::sumcheck; +using namespace proof_system::honk::sumcheck; namespace test_sumcheck_polynomials { template class MultivariatesTests : public testing::Test {}; using FieldTypes = testing::Types; -using Transcript = honk::ProverTranscript; +using Transcript = proof_system::honk::ProverTranscript; TYPED_TEST_SUITE(MultivariatesTests, FieldTypes); #define MULTIVARIATES_TESTS_TYPE_ALIASES using FF = TypeParam; @@ -59,7 +59,7 @@ TYPED_TEST(MultivariatesTests, FoldTwoRoundsSpecial) std::array f0 = { v00, v10, v01, v11 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = honk::ProverTranscript::init_empty(); + auto transcript = proof_system::honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = { 0x6c7301b49d85a46c, 0x44311531e39c64f6, 0xb13d66d8d6c1a24c, 0x04410c360230a295 }; @@ -94,7 +94,7 @@ TYPED_TEST(MultivariatesTests, FoldTwoRoundsGeneric) std::array f0 = { v00, v10, v01, v11 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = honk::ProverTranscript::init_empty(); + auto transcript = proof_system::honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = FF::random_element(); @@ -153,7 +153,7 @@ TYPED_TEST(MultivariatesTests, FoldThreeRoundsSpecial) std::array f0 = { v000, v100, v010, v110, v001, v101, v011, v111 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = honk::ProverTranscript::init_empty(); + auto transcript = proof_system::honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = 1; @@ -202,7 +202,7 @@ TYPED_TEST(MultivariatesTests, FoldThreeRoundsGeneric) std::array f0 = { v000, v100, v010, v110, v001, v101, v011, v111 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = honk::ProverTranscript::init_empty(); + auto transcript = proof_system::honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = FF::random_element(); @@ -261,7 +261,7 @@ TYPED_TEST(MultivariatesTests, FoldThreeRoundsGenericMultiplePolys) std::array f2 = { v000[2], v100[2], v010[2], v110[2], v001[2], v101[2], v011[2], v111[2] }; auto full_polynomials = std::array, 3>{ f0, f1, f2 }; - auto transcript = honk::ProverTranscript::init_empty(); + auto transcript = proof_system::honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); std::array expected_q1; diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.hpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.hpp index 8cd92ac17e..654c348753 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.hpp @@ -1,6 +1,6 @@ #pragma once -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { /** * @brief Succinct representation of the `pow` polynomial that can be partially evaluated variable-by-variable. @@ -126,4 +126,4 @@ template struct PowUnivariate { partial_evaluation_constant *= current_univariate_eval; } }; -} // namespace honk::sumcheck \ No newline at end of file +} // namespace proof_system::honk::sumcheck \ No newline at end of file diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.test.cpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.test.cpp index 91bbad1a50..a8dd2f5ef3 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/pow.test.cpp @@ -3,7 +3,7 @@ #include "barretenberg/ecc/curves/bn254/fr.hpp" #include -namespace honk::sumcheck::pow_test { +namespace proof_system::honk::sumcheck::pow_test { using FF = barretenberg::fr; @@ -20,7 +20,7 @@ TEST(SumcheckPow, FullPowConsistency) pow_univariate.partially_evaluate(u_i); } - FF expected_eval = honk::power_polynomial::evaluate(zeta, variables); + FF expected_eval = proof_system::honk::power_polynomial::evaluate(zeta, variables); EXPECT_EQ(pow_univariate.partial_evaluation_constant, expected_eval); } -} // namespace honk::sumcheck::pow_test +} // namespace proof_system::honk::sumcheck::pow_test diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.hpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.hpp index 89804ebc8f..a3cc9cf82f 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.hpp @@ -6,7 +6,7 @@ #include "barretenberg/common/serialize.hpp" #include "barretenberg/common/assert.hpp" -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { template class UnivariateView; @@ -349,4 +349,4 @@ template std::array array_to_array return array_to_array_aux(elements, std::make_index_sequence()); }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.test.cpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.test.cpp index e1e5477858..ffc870e46d 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/univariate.test.cpp @@ -5,7 +5,7 @@ #include #include "barretenberg/numeric/random/engine.hpp" -using namespace honk::sumcheck; +using namespace proof_system::honk::sumcheck; namespace test_univariate { template class UnivariateTest : public testing::Test { diff --git a/cpp/src/barretenberg/honk/sumcheck/relations/arithmetic_relation.hpp b/cpp/src/barretenberg/honk/sumcheck/relations/arithmetic_relation.hpp index 4bfd999bd4..55947abeb4 100644 --- a/cpp/src/barretenberg/honk/sumcheck/relations/arithmetic_relation.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/relations/arithmetic_relation.hpp @@ -6,7 +6,7 @@ #include "../polynomials/univariate.hpp" #include "relation.hpp" -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { template class ArithmeticRelation { public: @@ -68,4 +68,4 @@ template class ArithmeticRelation { full_honk_relation_value += q_c; }; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_computation_relation.hpp b/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_computation_relation.hpp index c2cab137ce..5ecdedf61d 100644 --- a/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_computation_relation.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_computation_relation.hpp @@ -3,7 +3,7 @@ #include "barretenberg/honk/flavor/flavor.hpp" #include "../polynomials/univariate.hpp" -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { template class GrandProductComputationRelation { public: @@ -90,4 +90,4 @@ template class GrandProductComputationRelation { (w_2 + beta * sigma_2 + gamma) * (w_3 + beta * sigma_3 + gamma)); }; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_initialization_relation.hpp b/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_initialization_relation.hpp index 66853b2e23..788cec7f52 100644 --- a/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_initialization_relation.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/relations/grand_product_initialization_relation.hpp @@ -3,7 +3,7 @@ #include "barretenberg/honk/flavor/flavor.hpp" #include "../polynomials/univariate.hpp" -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { template class GrandProductInitializationRelation { public: @@ -45,4 +45,4 @@ template class GrandProductInitializationRelation { full_honk_relation_value += lagrange_last * z_perm_shift; }; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/relations/relation.hpp b/cpp/src/barretenberg/honk/sumcheck/relations/relation.hpp index 8218aaa3f0..a7860faeeb 100644 --- a/cpp/src/barretenberg/honk/sumcheck/relations/relation.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/relations/relation.hpp @@ -1,6 +1,6 @@ #pragma once -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { // TODO(#226)(Adrian): Remove zeta, alpha as they are not used by the relations. template struct RelationParameters { @@ -8,4 +8,4 @@ template struct RelationParameters { FF gamma; FF public_input_delta; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp b/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp index 8a2620badc..89ea8d5444 100644 --- a/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp @@ -10,7 +10,7 @@ #include "barretenberg/numeric/random/engine.hpp" #include -using namespace honk::sumcheck; +using namespace proof_system::honk::sumcheck; /** * We want to test if all three relations (namely, ArithmeticRelation, GrandProductComputationRelation, * GrandProductInitializationRelation) provide correct contributions by manually computing their @@ -23,15 +23,15 @@ using namespace honk::sumcheck; */ static const size_t input_univariate_length = 2; static constexpr size_t FULL_RELATION_LENGTH = 5; -static const size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; +static const size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; -namespace honk_relation_tests { +namespace proof_system::honk_relation_tests { template class SumcheckRelation : public testing::Test { public: template using Univariate = Univariate; template using UnivariateView = UnivariateView; - using POLYNOMIAL = honk::StandardArithmetization::POLYNOMIAL; + using POLYNOMIAL = proof_system::honk::StandardArithmetization::POLYNOMIAL; // TODO(#225)(Adrian): Accept FULL_RELATION_LENGTH as a template parameter for this function only, so that the test // can decide to which degree the polynomials must be extended. Possible accept an existing list of "edges" and // extend them to the degree. @@ -173,7 +173,7 @@ TYPED_TEST_SUITE(SumcheckRelation, FieldTypes); TYPED_TEST(SumcheckRelation, ArithmeticRelation) { SUMCHECK_RELATION_TYPE_ALIASES - using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; const auto relation_parameters = TestFixture::compute_mock_relation_parameters(); auto run_test = [&relation_parameters](bool is_random_input) { std::array, NUM_POLYNOMIALS> extended_edges; @@ -216,7 +216,7 @@ TYPED_TEST(SumcheckRelation, ArithmeticRelation) TYPED_TEST(SumcheckRelation, GrandProductComputationRelation) { SUMCHECK_RELATION_TYPE_ALIASES - using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; const auto relation_parameters = TestFixture::compute_mock_relation_parameters(); auto run_test = [&relation_parameters](bool is_random_input) { std::array, NUM_POLYNOMIALS> extended_edges; @@ -278,7 +278,7 @@ TYPED_TEST(SumcheckRelation, GrandProductComputationRelation) TYPED_TEST(SumcheckRelation, GrandProductInitializationRelation) { SUMCHECK_RELATION_TYPE_ALIASES - using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; const auto relation_parameters = TestFixture::compute_mock_relation_parameters(); auto run_test = [&relation_parameters](bool is_random_input) { std::array, NUM_POLYNOMIALS> extended_edges; @@ -311,4 +311,4 @@ TYPED_TEST(SumcheckRelation, GrandProductInitializationRelation) run_test(/* is_random_input=*/false); }; -} // namespace honk_relation_tests +} // namespace proof_system::honk_relation_tests diff --git a/cpp/src/barretenberg/honk/sumcheck/sumcheck.hpp b/cpp/src/barretenberg/honk/sumcheck/sumcheck.hpp index b96bd99d67..837922feb2 100644 --- a/cpp/src/barretenberg/honk/sumcheck/sumcheck.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/sumcheck.hpp @@ -17,13 +17,13 @@ #include "barretenberg/honk/sumcheck/sumcheck_output.hpp" #include -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { template class... Relations> class Sumcheck { public: static constexpr size_t MAX_RELATION_LENGTH = std::max({ Relations::RELATION_LENGTH... }); - static constexpr size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; + static constexpr size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; std::array purported_evaluations; Transcript& transcript; @@ -217,4 +217,4 @@ template class... Relations> cl } }; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/sumcheck.test.cpp b/cpp/src/barretenberg/honk/sumcheck/sumcheck.test.cpp index 9f3092c5be..95316ca5cb 100644 --- a/cpp/src/barretenberg/honk/sumcheck/sumcheck.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/sumcheck.test.cpp @@ -20,11 +20,11 @@ #include #include -using namespace honk; -using namespace honk::sumcheck; +using namespace proof_system::honk; +using namespace proof_system::honk::sumcheck; using FF = barretenberg::fr; -const size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; -using POLYNOMIAL = honk::StandardArithmetization::POLYNOMIAL; +const size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; +using POLYNOMIAL = proof_system::honk::StandardArithmetization::POLYNOMIAL; namespace test_sumcheck_round { diff --git a/cpp/src/barretenberg/honk/sumcheck/sumcheck_output.hpp b/cpp/src/barretenberg/honk/sumcheck/sumcheck_output.hpp index ab47f20e6c..52383cc80b 100644 --- a/cpp/src/barretenberg/honk/sumcheck/sumcheck_output.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/sumcheck_output.hpp @@ -2,7 +2,7 @@ #include #include -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { /** * @brief Contains the multi-linear evaluations of the polynomials at the challenge point 'u'. @@ -16,4 +16,4 @@ template struct SumcheckOutput { bool operator==(const SumcheckOutput& other) const = default; }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.hpp b/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.hpp index 021d14730f..8a10169b8a 100644 --- a/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.hpp +++ b/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.hpp @@ -8,7 +8,7 @@ #include "polynomials/pow.hpp" #include "relations/relation.hpp" -namespace honk::sumcheck { +namespace proof_system::honk::sumcheck { /* Notation: The polynomial P(X0, X1) that is the low-degree extension of its values vij = P(i,j) @@ -318,4 +318,4 @@ template class... Relation } } }; -} // namespace honk::sumcheck +} // namespace proof_system::honk::sumcheck diff --git a/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.test.cpp b/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.test.cpp index f0129c1061..97b8ab4c47 100644 --- a/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/sumcheck_round.test.cpp @@ -19,13 +19,13 @@ * similar approach. */ -using namespace honk; -using namespace honk::sumcheck; +using namespace proof_system::honk; +using namespace proof_system::honk::sumcheck; const size_t max_relation_length = 5; const size_t input_polynomial_length = 2; using FF = barretenberg::fr; -const size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; -using POLYNOMIAL = honk::StandardArithmetization::POLYNOMIAL; +const size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; +using POLYNOMIAL = proof_system::honk::StandardArithmetization::POLYNOMIAL; namespace test_sumcheck_round { /** diff --git a/cpp/src/barretenberg/honk/transcript/transcript.hpp b/cpp/src/barretenberg/honk/transcript/transcript.hpp index 89cef26219..15d92c679b 100644 --- a/cpp/src/barretenberg/honk/transcript/transcript.hpp +++ b/cpp/src/barretenberg/honk/transcript/transcript.hpp @@ -15,7 +15,7 @@ #include #include -namespace honk { +namespace proof_system::honk { class TranscriptManifest { struct RoundData { @@ -272,4 +272,4 @@ template class VerifierTranscript : public BaseTranscript { return element; } }; -} // namespace honk +} // namespace proof_system::honk diff --git a/cpp/src/barretenberg/honk/transcript/transcript.test.cpp b/cpp/src/barretenberg/honk/transcript/transcript.test.cpp index d9c8bc8c74..1e2de3d9d9 100644 --- a/cpp/src/barretenberg/honk/transcript/transcript.test.cpp +++ b/cpp/src/barretenberg/honk/transcript/transcript.test.cpp @@ -8,7 +8,7 @@ #include #include -using namespace honk; +using namespace proof_system::honk; template class TranscriptTest : public testing::Test { public: @@ -158,7 +158,7 @@ TYPED_TEST(TranscriptTest, ProverAndVerifierBasic) constexpr size_t LENGTH = 8; using Fr = barretenberg::fr; - using Univariate = honk::sumcheck::Univariate; + using Univariate = proof_system::honk::sumcheck::Univariate; using Commitment = barretenberg::g1::affine_element; std::array evaluations; diff --git a/cpp/src/barretenberg/honk/utils/power_polynomial.hpp b/cpp/src/barretenberg/honk/utils/power_polynomial.hpp index 3459679e37..4f2e1ed5b2 100644 --- a/cpp/src/barretenberg/honk/utils/power_polynomial.hpp +++ b/cpp/src/barretenberg/honk/utils/power_polynomial.hpp @@ -5,7 +5,7 @@ #ifndef NO_MULTITHREADING #include "omp.h" #endif -namespace honk::power_polynomial { +namespace proof_system::honk::power_polynomial { /** * @brief Generate the power polynomial vector * @@ -71,4 +71,4 @@ template Fr evaluate(Fr zeta, std::span variables) } return evaluation; } -} // namespace honk::power_polynomial +} // namespace proof_system::honk::power_polynomial diff --git a/cpp/src/barretenberg/honk/utils/power_polynomial.test.cpp b/cpp/src/barretenberg/honk/utils/power_polynomial.test.cpp index d62658e592..748731f014 100644 --- a/cpp/src/barretenberg/honk/utils/power_polynomial.test.cpp +++ b/cpp/src/barretenberg/honk/utils/power_polynomial.test.cpp @@ -7,7 +7,7 @@ TEST(power_polynomial, test_full_polynomial_correctness) const size_t order = 17; const size_t n = size_t(1) << order; barretenberg::fr zeta = barretenberg::fr::random_element(); - barretenberg::polynomial power_polynomial = honk::power_polynomial::generate_vector(zeta, n); + barretenberg::polynomial power_polynomial = proof_system::honk::power_polynomial::generate_vector(zeta, n); barretenberg::fr current_power = barretenberg::fr::one(); for (size_t i = 0; i < n; i++) { @@ -31,5 +31,5 @@ TEST(power_polynomial, test_evaluation_correctness) variables.emplace_back((random_index >> i) & 1); } EXPECT_EQ(zeta.pow(static_cast(random_index)), - honk::power_polynomial::evaluate(zeta, variables)); + proof_system::honk::power_polynomial::evaluate(zeta, variables)); } diff --git a/cpp/src/barretenberg/honk/utils/public_inputs.hpp b/cpp/src/barretenberg/honk/utils/public_inputs.hpp index e281aeab8e..52c66cff94 100644 --- a/cpp/src/barretenberg/honk/utils/public_inputs.hpp +++ b/cpp/src/barretenberg/honk/utils/public_inputs.hpp @@ -1,7 +1,7 @@ #pragma once #include -namespace honk { +namespace proof_system::honk { /** * @brief Compute the correction term for the permutation argument. @@ -54,4 +54,4 @@ Field compute_public_input_delta(std::span public_inputs, return numerator / denominator; } -} // namespace honk \ No newline at end of file +} // namespace proof_system::honk \ No newline at end of file diff --git a/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp index c40bd4894a..e5371b8bd0 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/compute_circuit_data.hpp @@ -19,7 +19,7 @@ struct circuit_data { : num_gates(0) {} - std::shared_ptr srs; + std::shared_ptr srs; std::shared_ptr proving_key; std::shared_ptr verification_key; size_t num_gates; @@ -38,7 +38,7 @@ inline bool exists(std::string const& path) template circuit_data get_circuit_data(std::string const& name, std::string const& path_name, - std::shared_ptr const& srs, + std::shared_ptr const& srs, std::string const& key_path, bool compute, bool save, @@ -70,12 +70,12 @@ circuit_data get_circuit_data(std::string const& name, Timer timer; build_circuit(composer); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Build time", timer.toString()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Gates", @@ -86,7 +86,7 @@ circuit_data get_circuit_data(std::string const& name, auto public_inputs = composer.get_public_inputs(); mock::mock_circuit(mock_proof_composer, public_inputs); info(name, ": Mock circuit size: ", mock_proof_composer.get_num_gates()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Mock Gates", @@ -113,7 +113,7 @@ circuit_data get_circuit_data(std::string const& name, std::make_shared(std::move(pk_data), srs->get_prover_crs(pk_data.circuit_size + 1)); data.num_gates = pk_data.circuit_size; info(name, ": Circuit size 2^n: ", data.num_gates); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Gates 2^n", @@ -127,7 +127,7 @@ circuit_data get_circuit_data(std::string const& name, data.proving_key = composer.compute_proving_key(); info(name, ": Circuit size 2^n: ", data.proving_key->circuit_size); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Gates 2^n", @@ -136,7 +136,7 @@ circuit_data get_circuit_data(std::string const& name, data.num_gates = mock_proof_composer.get_num_gates(); data.proving_key = mock_proof_composer.compute_proving_key(); info(name, ": Mock circuit size 2^n: ", data.proving_key->circuit_size); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Mock Gates 2^n", @@ -145,7 +145,7 @@ circuit_data get_circuit_data(std::string const& name, info(name, ": Proving key computed in ", timer.toString(), "s"); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Proving key computed in", @@ -175,7 +175,7 @@ circuit_data get_circuit_data(std::string const& name, data.verification_key = std::make_shared(std::move(vk_data), data.srs->get_verifier_crs()); info(name, ": Verification key hash: ", data.verification_key->sha256_hash()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Verification key hash", @@ -191,13 +191,13 @@ circuit_data get_circuit_data(std::string const& name, } info(name, ": Computed verification key in ", timer.toString(), "s"); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Verification key computed in", timer.toString()); info(name, ": Verification key hash: ", data.verification_key->sha256_hash()); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Verification key hash", @@ -246,7 +246,7 @@ circuit_data get_circuit_data(std::string const& name, info(name, ": Padding verified: ", verifier.verify_proof(proof)); } info(name, ": Padding proof computed in ", timer.toString(), "s"); - benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(bonk::ComposerType), + benchmark_collator.benchmark_info_deferred(GET_COMPOSER_NAME_STRING(proof_system::ComposerType), "Core", name + name_suffix_for_benchmarks, "Padding proof computed in", diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp index e46a34307f..cb35a19d27 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/c_bind.cpp @@ -12,7 +12,7 @@ #include using namespace barretenberg; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; using namespace join_split_example::proofs::join_split; #define WASM_EXPORT __attribute__((visibility("default"))) @@ -23,13 +23,13 @@ WASM_EXPORT void join_split__init_proving_key(bool mock) { // We know that we don't actually need any CRS to create a proving key, so just feed in a nothing. // Hacky, but, right now it needs *something*. - auto crs_factory = std::make_shared(); + auto crs_factory = std::make_shared(); init_proving_key(crs_factory, mock); } WASM_EXPORT void join_split__init_proving_key_from_buffer(uint8_t const* pk_buf) { - std::shared_ptr crs; + std::shared_ptr crs; plonk::proving_key_data pk_data; read(pk_buf, pk_data); init_proving_key(crs, std::move(pk_data)); @@ -70,14 +70,14 @@ WASM_EXPORT uint32_t join_split__get_new_proving_key_data(uint8_t** output) WASM_EXPORT void join_split__init_verification_key(void* pippenger, uint8_t const* g2x) { - auto crs_factory = std::make_unique( + auto crs_factory = std::make_unique( reinterpret_cast(pippenger), g2x); init_verification_key(std::move(crs_factory)); } WASM_EXPORT void join_split__init_verification_key_from_buffer(uint8_t const* vk_buf, uint8_t const* g2x) { - auto crs = std::make_shared(g2x); + auto crs = std::make_shared(g2x); plonk::verification_key_data vk_data; read(vk_buf, vk_data); init_verification_key(crs, std::move(vk_data)); diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.cpp index 700310f724..47fc4deec2 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.cpp @@ -9,9 +9,9 @@ namespace proofs { namespace join_split { using namespace join_split_example::proofs::join_split; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; using namespace join_split_example::proofs::notes::native; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::merkle_tree; join_split_tx noop_tx() { @@ -58,7 +58,7 @@ join_split_tx noop_tx() return tx; } -circuit_data get_circuit_data(std::shared_ptr const& srs, bool mock) +circuit_data get_circuit_data(std::shared_ptr const& srs, bool mock) { std::cerr << "Getting join-split circuit data..." << std::endl; diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.hpp index 8e4c533e6e..6c01a5b144 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/compute_circuit_data.hpp @@ -10,7 +10,7 @@ join_split_tx noop_tx(); using circuit_data = proofs::circuit_data; -circuit_data get_circuit_data(std::shared_ptr const& srs, bool mock = false); +circuit_data get_circuit_data(std::shared_ptr const& srs, bool mock = false); } // namespace join_split } // namespace proofs diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp index a9ba1033d7..44567b5b26 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.cpp @@ -7,13 +7,13 @@ namespace join_split_example { namespace proofs { namespace join_split { -using namespace plonk; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk; +using namespace proof_system::plonk::stdlib::merkle_tree; static std::shared_ptr proving_key; static std::shared_ptr verification_key; -void init_proving_key(std::shared_ptr const& crs_factory, bool mock) +void init_proving_key(std::shared_ptr const& crs_factory, bool mock) { if (proving_key) { return; @@ -35,7 +35,8 @@ void init_proving_key(std::shared_ptr const& crs_f } } -void init_proving_key(std::shared_ptr const& crs, plonk::proving_key_data&& pk_data) +void init_proving_key(std::shared_ptr const& crs, + plonk::proving_key_data&& pk_data) { release_key(); proving_key = std::make_shared(std::move(pk_data), crs); @@ -46,7 +47,7 @@ void release_key() proving_key.reset(); } -void init_verification_key(std::unique_ptr&& crs_factory) +void init_verification_key(std::unique_ptr&& crs_factory) { if (!proving_key) { std::abort(); @@ -58,7 +59,7 @@ void init_verification_key(std::unique_ptr&& crs_f plonk::stdlib::types::Composer::compute_verification_key_base(proving_key, crs_factory->get_verifier_crs()); } -void init_verification_key(std::shared_ptr const& crs, +void init_verification_key(std::shared_ptr const& crs, plonk::verification_key_data&& vk_data) { verification_key = std::make_shared(std::move(vk_data), crs); diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp index 001ac4e2df..6c9b4ac5ab 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.hpp @@ -7,18 +7,19 @@ namespace join_split_example { namespace proofs { namespace join_split { -using namespace plonk::stdlib::merkle_tree; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::types; -void init_proving_key(std::shared_ptr const& crs_factory, bool mock); +void init_proving_key(std::shared_ptr const& crs_factory, bool mock); -void init_proving_key(std::shared_ptr const& crs, plonk::proving_key_data&& pk_data); +void init_proving_key(std::shared_ptr const& crs, + plonk::proving_key_data&& pk_data); void release_key(); -void init_verification_key(std::unique_ptr&& crs_factory); +void init_verification_key(std::unique_ptr&& crs_factory); -void init_verification_key(std::shared_ptr const& crs, +void init_verification_key(std::shared_ptr const& crs, plonk::verification_key_data&& vk_data); stdlib::types::Prover new_join_split_prover(join_split_tx const& tx, bool mock); diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp index 3b4ad79e04..46a45c6150 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split.test.cpp @@ -122,8 +122,8 @@ constexpr bool CIRCUIT_CHANGE_EXPECTED = false; #endif using namespace barretenberg; -using namespace plonk::stdlib::types; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::merkle_tree; using namespace join_split_example::proofs::notes::native; using key_pair = join_split_example::fixtures::grumpkin_key_pair; @@ -139,9 +139,9 @@ class join_split_tests : public ::testing::Test { static constexpr size_t ACCOUNT_INDEX = 14; static void SetUpTestCase() { - auto null_crs_factory = std::make_shared(); + auto null_crs_factory = std::make_shared(); init_proving_key(null_crs_factory, false); - auto crs_factory = std::make_unique("../srs_db/ignition"); + auto crs_factory = std::make_unique("../srs_db/ignition"); init_verification_key(std::move(crs_factory)); info("vk hash: ", get_verification_key()->sha256_hash()); } diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.cpp index 0bc3b796b1..a0061cde88 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.cpp @@ -11,9 +11,9 @@ namespace join_split_example { namespace proofs { namespace join_split { -using namespace plonk; +using namespace proof_system::plonk; using namespace notes::circuit; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::merkle_tree; /** * Check that the input note data, follows the given hash paths, to the publically given merkle root. diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.hpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.hpp index 5e28d1e161..b8821989b4 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_circuit.hpp @@ -9,7 +9,7 @@ namespace join_split_example { namespace proofs { namespace join_split { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; struct join_split_inputs { field_ct proof_id; diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp index 8917fdd60b..0294983f7c 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_js_parity.test.cpp @@ -13,8 +13,8 @@ namespace proofs { namespace join_split { using namespace barretenberg; -// using namespace plonk::stdlib::types; -using namespace plonk::stdlib::merkle_tree; +// using namespace proof_system::plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::merkle_tree; using namespace join_split_example::proofs::notes::native; using key_pair = join_split_example::fixtures::grumpkin_key_pair; @@ -25,9 +25,9 @@ class join_split_js_parity_tests : public ::testing::Test { protected: static void SetUpTestCase() { - auto null_crs_factory = std::make_shared(); + auto null_crs_factory = std::make_shared(); init_proving_key(null_crs_factory, false); - auto crs_factory = std::make_unique("../srs_db/ignition"); + auto crs_factory = std::make_unique("../srs_db/ignition"); init_verification_key(std::move(crs_factory)); info("vk hash: ", get_verification_key()->sha256_hash()); } diff --git a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_tx.hpp b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_tx.hpp index 38c9cc4624..4dae8f30e3 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_tx.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/join_split/join_split_tx.hpp @@ -9,7 +9,7 @@ namespace join_split_example { namespace proofs { namespace join_split { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; struct join_split_tx { uint32_t proof_id; diff --git a/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.hpp b/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.hpp index 6f61e4e936..f629a32f18 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.hpp @@ -7,7 +7,7 @@ namespace join_split_example { namespace proofs { namespace mock { -using namespace plonk::stdlib; +using namespace proof_system::plonk::stdlib; template void mock_circuit(Composer& composer, std::vector const& public_inputs_) { diff --git a/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.test.cpp index dc4683353a..16004e9787 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/mock/mock_circuit.test.cpp @@ -3,7 +3,7 @@ #include "barretenberg/common/test.hpp" #include "barretenberg/stdlib/types/types.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace rollup { namespace proofs { diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/account_note.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/account_note.hpp index 7252072da9..334b2edfc3 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/account_note.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/account_note.hpp @@ -8,7 +8,7 @@ namespace notes { namespace circuit { namespace account { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; struct account_note { field_ct account_alias_hash; diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/commit.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/commit.hpp index b1e6f3eadb..ca668b94f6 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/commit.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/account/commit.hpp @@ -8,7 +8,7 @@ namespace notes { namespace circuit { namespace account { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; inline auto commit(field_ct const& account_alias_hash, point_ct const& account_public_key, diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.cpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.cpp index b2c5d86c18..5163231bc5 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.cpp @@ -3,7 +3,7 @@ namespace join_split_example::proofs::notes::circuit { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; std::pair deflag_asset_id(suint_ct const& asset_id) { diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.hpp index 8a4b5a5520..3c67f16695 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/asset_id.hpp @@ -3,7 +3,7 @@ namespace join_split_example::proofs::notes::circuit { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; std::pair deflag_asset_id(suint_ct const& asset_id); diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/bridge_call_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/bridge_call_data.hpp index 40040322ee..f5b1bbd319 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/bridge_call_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/bridge_call_data.hpp @@ -9,7 +9,7 @@ namespace proofs { namespace notes { namespace circuit { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; constexpr uint32_t input_asset_id_a_shift = DEFI_BRIDGE_ADDRESS_ID_LEN; constexpr uint32_t input_asset_id_b_shift = input_asset_id_a_shift + DEFI_BRIDGE_INPUT_A_ASSET_ID_LEN; diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/claim_note.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/claim_note.hpp index f2f24a5a91..8021265a43 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/claim_note.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/claim_note.hpp @@ -12,7 +12,7 @@ namespace notes { namespace circuit { namespace claim { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; struct partial_claim_note { suint_ct deposit_value; diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/complete_partial_commitment.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/complete_partial_commitment.hpp index d92ded2135..c1ea735d12 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/complete_partial_commitment.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/complete_partial_commitment.hpp @@ -8,7 +8,7 @@ namespace notes { namespace circuit { namespace claim { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; inline auto complete_partial_commitment(field_ct const& partial_commitment, field_ct const& interaction_nonce, diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/compute_nullifier.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/compute_nullifier.hpp index 27f7284ea5..05666cacc4 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/compute_nullifier.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/compute_nullifier.hpp @@ -9,7 +9,7 @@ namespace notes { namespace circuit { namespace claim { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; inline field_ct compute_nullifier(field_ct const& note_commitment) { diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/create_partial_commitment.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/create_partial_commitment.hpp index b5c6180b5e..d903e5688d 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/create_partial_commitment.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/create_partial_commitment.hpp @@ -9,7 +9,7 @@ namespace notes { namespace circuit { namespace claim { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; inline auto create_partial_commitment(field_ct const& deposit_value, field_ct const& bridge_call_data, diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/witness_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/witness_data.hpp index a5fd321a85..b49bddd3bb 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/witness_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/claim/witness_data.hpp @@ -11,7 +11,7 @@ namespace notes { namespace circuit { namespace claim { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; /** * Convert native claim note data into circuit witness data. diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/complete_partial_commitment.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/complete_partial_commitment.hpp index cb1c475283..2ec86fc763 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/complete_partial_commitment.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/complete_partial_commitment.hpp @@ -9,7 +9,7 @@ namespace notes { namespace circuit { namespace value { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; inline auto complete_partial_commitment(field_ct const& value_note_partial_commitment, suint_ct const& value, diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.cpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.cpp index f501e2df2b..08f00dbf16 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.cpp @@ -8,7 +8,7 @@ namespace notes { namespace circuit { using namespace barretenberg; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; field_ct compute_nullifier(field_ct const& note_commitment, field_ct const& account_private_key, @@ -42,7 +42,7 @@ field_ct compute_nullifier(field_ct const& note_commitment, * eth address. */ auto blake_input = byte_array_ct(compressed_inputs); - auto blake_result = plonk::stdlib::blake2s(blake_input); + auto blake_result = proof_system::plonk::stdlib::blake2s(blake_input); return field_ct(blake_result); } diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.hpp index 7b78685348..3271035abb 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.hpp @@ -7,7 +7,7 @@ namespace notes { namespace circuit { using namespace barretenberg; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; field_ct compute_nullifier(field_ct const& note_commitment, field_ct const& account_private_key, diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.test.cpp index c6c7f83861..063ef93edd 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/compute_nullifier.test.cpp @@ -7,7 +7,7 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace join_split_example::proofs::notes; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; TEST(compute_nullifier_circuit, native_consistency) { diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/create_partial_commitment.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/create_partial_commitment.hpp index bedd3d0688..2cb12fa9d2 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/create_partial_commitment.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/create_partial_commitment.hpp @@ -9,7 +9,7 @@ namespace notes { namespace circuit { namespace value { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; inline auto create_partial_commitment(field_ct const& secret, point_ct const& owner, diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.hpp index 10ef82d110..a4f8cc04c8 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.hpp @@ -9,7 +9,7 @@ namespace notes { namespace circuit { namespace value { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; struct value_note { point_ct owner; diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.test.cpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.test.cpp index 3bdee7e2c4..e243b35fb8 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.test.cpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/value_note.test.cpp @@ -5,7 +5,7 @@ #include using namespace barretenberg; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; using namespace join_split_example::proofs::notes; using namespace join_split_example::proofs::notes::circuit::value; diff --git a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/witness_data.hpp b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/witness_data.hpp index 69e26fd9e2..ff0cbc0cc2 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/witness_data.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/notes/circuit/value/witness_data.hpp @@ -9,7 +9,7 @@ namespace notes { namespace circuit { namespace value { -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; struct witness_data { point_ct owner; diff --git a/cpp/src/barretenberg/join_split_example/proofs/verify.hpp b/cpp/src/barretenberg/join_split_example/proofs/verify.hpp index f706adf0ca..4c26b58980 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/verify.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/verify.hpp @@ -26,7 +26,7 @@ template struct verify_result { template inline bool pairing_check(plonk::stdlib::recursion::recursion_output> recursion_output, - std::shared_ptr const& srs) + std::shared_ptr const& srs) { g1::affine_element P[2]; P[0].x = barretenberg::fq(recursion_output.P0.x.get_value().lo); diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.cpp b/cpp/src/barretenberg/plonk/composer/composer_base.cpp index 1f62fe5c8a..2874935584 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.cpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.cpp @@ -2,7 +2,7 @@ #include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/utils/permutation.hpp" -namespace plonk { +namespace proof_system::plonk { /** * Join variable class b to variable class a. @@ -231,7 +231,7 @@ template void ComposerBase::compute_sigma * @param num_reserved_gates The number of reserved gates. * @return Pointer to the initialized proving key updated with selector polynomials. * */ -std::shared_ptr ComposerBase::compute_proving_key_base(const bonk::ComposerType composer_type, +std::shared_ptr ComposerBase::compute_proving_key_base(const proof_system::ComposerType composer_type, const size_t minimum_circuit_size, const size_t num_reserved_gates) { @@ -422,4 +422,4 @@ template void ComposerBase::compute_witness_base<4>(const size_t); // turbo and template void ComposerBase::compute_wire_copy_cycles<3>(); template void ComposerBase::compute_wire_copy_cycles<4>(); -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.hpp b/cpp/src/barretenberg/plonk/composer/composer_base.hpp index daf4871700..4d9c9dd896 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.hpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.hpp @@ -6,7 +6,7 @@ #include "barretenberg/plonk/proof_system/types/prover_settings.hpp" #include "barretenberg/srs/reference_string/file_reference_string.hpp" -namespace plonk { +namespace proof_system::plonk { static constexpr uint32_t DUMMY_TAG = 0; class ComposerBase { public: @@ -110,7 +110,7 @@ class ComposerBase { virtual size_t get_total_circuit_size() const = 0; virtual void print_num_gates() const { std::cout << num_gates << std::endl; } virtual size_t get_num_variables() const { return variables.size(); } - virtual std::shared_ptr compute_proving_key_base(const bonk::ComposerType type = STANDARD, + virtual std::shared_ptr compute_proving_key_base(const proof_system::ComposerType type = STANDARD, const size_t minimum_ciricut_size = 0, const size_t num_reserved_gates = NUM_RESERVED_GATES); // This needs to be static as it may be used only to compute the selector commitments. @@ -350,7 +350,7 @@ extern template void ComposerBase::compute_witness_base<3>(const size_t); // sta extern template void ComposerBase::compute_witness_base<4>(const size_t); // turbo and ultra extern template void ComposerBase::compute_sigma_permutations<4, true>(proving_key* key); -} // namespace plonk +} // namespace proof_system::plonk /** * Composer Example: Pythagorean triples. diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp index 457a42511e..7d2a7972b2 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp @@ -7,7 +7,7 @@ #include "composer_helper_lib.hpp" #include "barretenberg/honk/pcs/commitment_key.hpp" -namespace plonk { +namespace proof_system::plonk { /** * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into @@ -44,12 +44,13 @@ void compute_monomial_and_coset_selector_forms(plonk::proving_key* circuit_provi * (2) sets the polynomial manifest using the data from proving key. */ std::shared_ptr compute_verification_key_common( - std::shared_ptr const& proving_key, std::shared_ptr const& vrs) + std::shared_ptr const& proving_key, + std::shared_ptr const& vrs) { auto circuit_verification_key = std::make_shared( proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc - auto commitment_key = honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); + auto commitment_key = proof_system::honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); for (size_t i = 0; i < proving_key->polynomial_manifest.size(); ++i) { const auto& poly_info = proving_key->polynomial_manifest[i]; @@ -69,9 +70,9 @@ std::shared_ptr compute_verification_key_common( } // Set the polynomial manifest in verification key. - circuit_verification_key->polynomial_manifest = plonk::PolynomialManifest(proving_key->composer_type); + circuit_verification_key->polynomial_manifest = proof_system::plonk::PolynomialManifest(proving_key->composer_type); return circuit_verification_key; } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp index 5e374486f6..f8f18cd92a 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp @@ -2,7 +2,7 @@ #include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" -namespace plonk { +namespace proof_system::plonk { struct SelectorProperties { std::string name; bool requires_lagrange_base_polynomial = false; // does the prover need the raw lagrange-base selector values? @@ -24,6 +24,7 @@ void compute_monomial_and_coset_selector_forms(plonk::proving_key* key, * (2) sets the polynomial manifest using the data from proving key. */ std::shared_ptr compute_verification_key_common( - std::shared_ptr const& proving_key, std::shared_ptr const& vrs); + std::shared_ptr const& proving_key, + std::shared_ptr const& vrs); -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp index c6c87d973e..968cf07abd 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp @@ -12,7 +12,7 @@ #include #include -namespace plonk { +namespace proof_system::plonk { /** * Compute witness polynomials (w_1, w_2, w_3, w_4). @@ -64,21 +64,21 @@ std::shared_ptr StandardPlonkComposerHelper(circuit_constructor, - circuit_proving_key.get()); + proof_system::compute_standard_plonk_sigma_permutations( + circuit_constructor, circuit_proving_key.get()); circuit_proving_key->recursive_proof_public_input_indices = std::vector(recursive_proof_public_input_indices.begin(), recursive_proof_public_input_indices.end()); @@ -175,4 +175,4 @@ plonk::Prover StandardPlonkComposerHelper::create_prover( } template class StandardPlonkComposerHelper; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp index 5b045ebec9..2074d91b1d 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp @@ -12,7 +12,7 @@ #include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" #include -namespace plonk { +namespace proof_system::plonk { // TODO(Kesha): change initializations to specify this parameter // Cody: What does this mean? template class StandardPlonkComposerHelper { @@ -23,22 +23,22 @@ template class StandardPlonkComposerHelper { std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; std::vector recursive_proof_public_input_indices; bool contains_recursive_proof = false; bool computed_witness = false; StandardPlonkComposerHelper() - : StandardPlonkComposerHelper( - std::shared_ptr(new bonk::FileReferenceStringFactory("../srs_db/ignition"))) + : StandardPlonkComposerHelper(std::shared_ptr( + new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) {} - StandardPlonkComposerHelper(std::shared_ptr crs_factory) + StandardPlonkComposerHelper(std::shared_ptr crs_factory) : crs_factory_(std::move(crs_factory)) {} - StandardPlonkComposerHelper(std::unique_ptr&& crs_factory) + StandardPlonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} StandardPlonkComposerHelper(std::shared_ptr p_key, @@ -173,4 +173,4 @@ template class StandardPlonkComposerHelper { } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp index 24af0e92a0..04f2b3fbcd 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp @@ -13,7 +13,7 @@ #include "barretenberg/proof_system/composer/permutation_helper.hpp" using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { /** * Compute proving key @@ -37,18 +37,21 @@ std::shared_ptr TurboPlonkComposerHelper const size_t num_randomized_gates = NUM_RANDOMIZED_GATES; // Initialize circuit_proving_key // TODO(#229)(Kesha): replace composer types. - circuit_proving_key = bonk::initialize_proving_key( - circuit_constructor, crs_factory_.get(), minimum_circuit_size, num_randomized_gates, bonk::ComposerType::TURBO); + circuit_proving_key = proof_system::initialize_proving_key(circuit_constructor, + crs_factory_.get(), + minimum_circuit_size, + num_randomized_gates, + proof_system::ComposerType::TURBO); - bonk::construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); + proof_system::construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); - bonk::enforce_nonzero_polynomial_selectors(circuit_constructor, circuit_proving_key.get()); + proof_system::enforce_nonzero_polynomial_selectors(circuit_constructor, circuit_proving_key.get()); compute_monomial_and_coset_selector_forms(circuit_proving_key.get(), turbo_selector_properties()); // Compute sigma polynomials (TODO(kesha): we should update that late) - bonk::compute_standard_plonk_sigma_permutations(circuit_constructor, - circuit_proving_key.get()); + proof_system::compute_standard_plonk_sigma_permutations( + circuit_constructor, circuit_proving_key.get()); circuit_proving_key->recursive_proof_public_input_indices = std::vector(recursive_proof_public_input_indices.begin(), recursive_proof_public_input_indices.end()); circuit_proving_key->contains_recursive_proof = contains_recursive_proof; @@ -175,4 +178,4 @@ plonk::TurboVerifier TurboPlonkComposerHelper::create_verifi } template class TurboPlonkComposerHelper; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp index fa18a7a939..5153124fd8 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp @@ -7,12 +7,12 @@ #include "barretenberg/plonk/proof_system/prover/prover.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" -namespace plonk { +namespace proof_system::plonk { template class TurboPlonkComposerHelper { public: static constexpr size_t NUM_RANDOMIZED_GATES = 2; // equal to the number of multilinear evaluations leaked static constexpr size_t program_width = CircuitConstructor::program_width; - static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; std::shared_ptr circuit_proving_key; @@ -20,21 +20,21 @@ template class TurboPlonkComposerHelper { // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; std::vector recursive_proof_public_input_indices; bool contains_recursive_proof = false; bool computed_witness = false; TurboPlonkComposerHelper() - : TurboPlonkComposerHelper( - std::shared_ptr(new bonk::FileReferenceStringFactory("../srs_db/ignition"))) + : TurboPlonkComposerHelper(std::shared_ptr( + new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) {} - TurboPlonkComposerHelper(std::shared_ptr crs_factory) + TurboPlonkComposerHelper(std::shared_ptr crs_factory) : crs_factory_(std::move(crs_factory)) {} - TurboPlonkComposerHelper(std::unique_ptr&& crs_factory) + TurboPlonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} TurboPlonkComposerHelper(std::shared_ptr p_key, std::shared_ptr v_key) @@ -133,4 +133,4 @@ template class TurboPlonkComposerHelper { return output; } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp index c09f67c55c..c8571b94ee 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp @@ -6,7 +6,7 @@ #include "barretenberg/transcript/manifest.hpp" #include "barretenberg/proof_system/flavor/flavor.hpp" -namespace plonk { +namespace proof_system::plonk { /** * @brief Standard Plonk Composer has everything required to construct a prover and verifier, just as the legacy * classes. @@ -16,7 +16,7 @@ namespace plonk { */ class StandardPlonkComposer { public: - static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD; static constexpr size_t UINT_LOG2_BASE = 2; // An instantiation of the circuit constructor that only depends on arithmetization, not on the proof system @@ -39,18 +39,20 @@ class StandardPlonkComposer { , variables(circuit_constructor.variables){}; StandardPlonkComposer(std::string const& crs_path, const size_t size_hint = 0) - : StandardPlonkComposer( - std::unique_ptr(new bonk::FileReferenceStringFactory(crs_path)), - size_hint){}; + : StandardPlonkComposer(std::unique_ptr( + new proof_system::FileReferenceStringFactory(crs_path)), + size_hint){}; - StandardPlonkComposer(std::shared_ptr const& crs_factory, const size_t size_hint = 0) + StandardPlonkComposer(std::shared_ptr const& crs_factory, + const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(crs_factory) , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables) {} - StandardPlonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) + StandardPlonkComposer(std::unique_ptr&& crs_factory, + const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(std::move(crs_factory)) , num_gates(circuit_constructor.num_gates) @@ -200,4 +202,4 @@ class StandardPlonkComposer { const std::string& err() const { return circuit_constructor.err(); }; void failure(std::string msg) { circuit_constructor.failure(msg); } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp index 525cd2b7a2..fb9373f76b 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp @@ -5,7 +5,7 @@ #include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; namespace { auto& engine = numeric::random::get_debug_engine(); @@ -13,7 +13,7 @@ auto& engine = numeric::random::get_debug_engine(); TEST(standard_plonk_composer_splitting_tmp, base_case) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); fr a = fr::one(); composer.add_public_variable(a); plonk::Prover prover = composer.create_prover(); @@ -27,7 +27,7 @@ TEST(standard_plonk_composer_splitting_tmp, base_case) TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); fr a = fr::one(); composer.add_public_variable(a); @@ -36,12 +36,12 @@ TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) auto pk_data = from_buffer(pk_buf); auto vk_data = from_buffer(vk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); - plonk::StandardPlonkComposer composer2 = plonk::StandardPlonkComposer(proving_key, verification_key); + plonk::StandardPlonkComposer composer2 = proof_system::plonk::StandardPlonkComposer(proving_key, verification_key); composer2.add_public_variable(a); plonk::Prover prover = composer2.create_prover(); @@ -55,7 +55,7 @@ TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) TEST(standard_plonk_composer_splitting_tmp, test_add_gate_proofs) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); fr a = fr::one(); uint32_t a_idx = composer.add_public_variable(a); fr b = fr::one(); @@ -114,7 +114,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_add_gate_proofs) TEST(standard_plonk_composer_splitting_tmp, test_mul_gate_proofs) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); fr q[7]{ fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element() }; fr q_inv[7]{ @@ -193,7 +193,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_mul_gate_proofs) TEST(standard_plonk_composer_splitting_tmp, range_constraint) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); for (size_t i = 0; i < 10; ++i) { uint32_t value = engine.get_random_uint32(); @@ -236,7 +236,7 @@ TEST(standard_plonk_composer_splitting_tmp, range_constraint) TEST(standard_plonk_composer_splitting_tmp, range_constraint_fail) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); uint64_t value = 0xffffff; uint32_t witness_index = composer.add_variable(fr(value)); @@ -256,7 +256,7 @@ TEST(standard_plonk_composer_splitting_tmp, range_constraint_fail) TEST(standard_plonk_composer_splitting_tmp, and_constraint) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); for (size_t i = 0; i < /*10*/ 1; ++i) { uint32_t left_value = engine.get_random_uint32(); @@ -327,7 +327,7 @@ TEST(standard_plonk_composer_splitting_tmp, and_constraint) TEST(standard_plonk_composer_splitting_tmp, xor_constraint) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); for (size_t i = 0; i < /*10*/ 1; ++i) { uint32_t left_value = engine.get_random_uint32(); @@ -397,7 +397,7 @@ TEST(standard_plonk_composer_splitting_tmp, xor_constraint) TEST(standard_plonk_composer_splitting_tmp, big_add_gate_with_bit_extract) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); const auto generate_constraints = [&composer](uint32_t quad_value) { uint32_t quad_accumulator_left = @@ -441,7 +441,7 @@ TEST(standard_plonk_composer_splitting_tmp, big_add_gate_with_bit_extract) TEST(standard_plonk_composer_splitting_tmp, test_range_constraint_fail) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); uint32_t witness_index = composer.add_variable(fr::neg_one()); composer.decompose_into_base4_accumulators(witness_index, 32); @@ -458,7 +458,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_range_constraint_fail) TEST(standard_plonk_composer_splitting_tmp, test_check_circuit_correct) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); fr a = fr::one(); uint32_t a_idx = composer.add_public_variable(a); fr b = fr::one(); @@ -478,7 +478,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_check_circuit_correct) TEST(standard_plonk_composer_splitting_tmp, test_check_circuit_broken) { - plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); fr a = fr::one(); uint32_t a_idx = composer.add_public_variable(a); fr b = fr::one(); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp index 26953f4705..93b7450c94 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp @@ -1,8 +1,8 @@ #pragma once #include "composer_helper/turbo_plonk_composer_helper.hpp" #include "barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp" -using namespace bonk; -namespace plonk { + +namespace proof_system::plonk { /** * @brief Standard Plonk Composer has everything required to construct a prover and verifier, just as the legacy * classes. @@ -12,7 +12,7 @@ namespace plonk { */ class TurboPlonkComposer { public: - static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD; static constexpr size_t UINT_LOG2_BASE = 2; @@ -38,17 +38,18 @@ class TurboPlonkComposer { , variables(circuit_constructor.variables){}; TurboPlonkComposer(std::string const& crs_path, const size_t size_hint = 0) - : TurboPlonkComposer( - std::unique_ptr(new bonk::FileReferenceStringFactory(crs_path)), - size_hint){}; + : TurboPlonkComposer(std::unique_ptr( + new proof_system::FileReferenceStringFactory(crs_path)), + size_hint){}; - TurboPlonkComposer(std::shared_ptr const& crs_factory, const size_t size_hint = 0) + TurboPlonkComposer(std::shared_ptr const& crs_factory, + const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(crs_factory) , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables){}; - TurboPlonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) + TurboPlonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(std::move(crs_factory)) , num_gates(circuit_constructor.num_gates) @@ -205,4 +206,4 @@ class TurboPlonkComposer { const std::string& err() const { return circuit_constructor.err(); }; void failure(std::string msg) { circuit_constructor.failure(msg); } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp index cc2eb26e66..007afa3e19 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.test.cpp @@ -4,10 +4,10 @@ #include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; using namespace crypto::pedersen; -namespace plonk::test_turbo_plonk_composer { +namespace proof_system::plonk::test_turbo_plonk_composer { namespace { auto& engine = numeric::random::get_debug_engine(); } @@ -38,7 +38,7 @@ TEST(turbo_plonk_composer_splitting_tmp, composer_from_serialized_keys) auto pk_data = from_buffer(pk_buf); auto vk_data = from_buffer(vk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); @@ -1153,4 +1153,4 @@ TEST(turbo_plonk_composer_splitting_tmp, test_check_circuit_xor) EXPECT_EQ(result, true); } -} // namespace plonk::test_turbo_plonk_composer \ No newline at end of file +} // namespace proof_system::plonk::test_turbo_plonk_composer \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.cpp b/cpp/src/barretenberg/plonk/composer/standard_composer.cpp index dfa084e79f..1158590acf 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.cpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.cpp @@ -9,9 +9,9 @@ #include using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { #define STANDARD_SELECTOR_REFS \ auto& q_m = selectors[StandardSelectors::QM]; \ auto& q_c = selectors[StandardSelectors::QC]; \ @@ -616,4 +616,4 @@ bool StandardComposer::check_circuit() } return true; } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.hpp b/cpp/src/barretenberg/plonk/composer/standard_composer.hpp index 8b75b5476e..a4d3fc4bc7 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.hpp @@ -3,8 +3,7 @@ #include "barretenberg/transcript/manifest.hpp" #include "barretenberg/srs/reference_string/file_reference_string.hpp" -using namespace bonk; -namespace plonk { +namespace proof_system::plonk { enum StandardSelectors { QM, QC, Q1, Q2, Q3, NUM }; inline std::vector standard_selector_properties() @@ -17,7 +16,7 @@ inline std::vector standard_selector_propertie class StandardComposer : public ComposerBase { public: - static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; @@ -230,4 +229,4 @@ class StandardComposer : public ComposerBase { bool check_circuit(); }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp index a7f33cb05c..d593040f21 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp @@ -5,12 +5,12 @@ #include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; namespace { auto& engine = numeric::random::get_debug_engine(); } -namespace plonk { +namespace proof_system::plonk { TEST(standard_composer, base_case) { StandardComposer composer = StandardComposer(); @@ -37,7 +37,7 @@ TEST(standard_composer, composer_from_serialized_keys) auto pk_data = from_buffer(pk_buf); auto vk_data = from_buffer(vk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); @@ -540,4 +540,4 @@ TEST(standard_composer, test_check_circuit_broken) bool result = composer.check_circuit(); EXPECT_EQ(result, false); } -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/composer/turbo_composer.cpp b/cpp/src/barretenberg/plonk/composer/turbo_composer.cpp index cf599e26b6..f3339cf147 100644 --- a/cpp/src/barretenberg/plonk/composer/turbo_composer.cpp +++ b/cpp/src/barretenberg/plonk/composer/turbo_composer.cpp @@ -12,9 +12,9 @@ #include "barretenberg/srs/reference_string/file_reference_string.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { #define TURBO_SELECTOR_REFS \ auto& q_m = selectors[TurboSelectors::QM]; \ @@ -1039,4 +1039,4 @@ TurboVerifier TurboComposer::create_verifier() return output_state; } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp b/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp index e49b7fe3c7..80087bb131 100644 --- a/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp @@ -1,12 +1,10 @@ #pragma once #include "composer_base.hpp" -using namespace bonk; - -namespace plonk { +namespace proof_system::plonk { class TurboComposer : public ComposerBase { public: - static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; enum TurboSelectors { QM, QC, Q1, Q2, Q3, Q4, Q5, QARITH, QFIXED, QRANGE, QLOGIC, NUM }; @@ -229,8 +227,10 @@ class CheckGetter { } }; -using TurboArithmeticChecker = plonk::widget::TurboArithmeticKernel; -using TurboRangeChecker = plonk::widget::TurboRangeKernel; -using TurboLogicChecker = plonk::widget::TurboLogicKernel; -using TurboFixedBaseChecker = plonk::widget::TurboFixedBaseKernel; -} // namespace plonk +using TurboArithmeticChecker = + proof_system::plonk::widget::TurboArithmeticKernel; +using TurboRangeChecker = proof_system::plonk::widget::TurboRangeKernel; +using TurboLogicChecker = proof_system::plonk::widget::TurboLogicKernel; +using TurboFixedBaseChecker = + proof_system::plonk::widget::TurboFixedBaseKernel; +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp index 37c8c96f9d..14b448db48 100644 --- a/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/turbo_composer.test.cpp @@ -4,13 +4,13 @@ #include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; using namespace crypto::pedersen; namespace { auto& engine = numeric::random::get_debug_engine(); } -namespace plonk { +namespace proof_system::plonk { TEST(turbo_composer, base_case) { TurboComposer composer = TurboComposer(); @@ -37,7 +37,7 @@ TEST(turbo_composer, composer_from_serialized_keys) auto pk_data = from_buffer(pk_buf); auto vk_data = from_buffer(vk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); @@ -1152,4 +1152,4 @@ TEST(turbo_composer, test_check_circuit_xor) EXPECT_EQ(result, true); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/ultra_composer.cpp b/cpp/src/barretenberg/plonk/composer/ultra_composer.cpp index 0cb677d6b2..597b2ddea0 100644 --- a/cpp/src/barretenberg/plonk/composer/ultra_composer.cpp +++ b/cpp/src/barretenberg/plonk/composer/ultra_composer.cpp @@ -29,7 +29,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { #define ULTRA_SELECTOR_REFS \ auto& q_m = selectors[UltraSelectors::QM]; \ @@ -2828,4 +2828,4 @@ void UltraComposer::process_RAM_arrays(const size_t gate_offset_from_public_inpu process_RAM_array(i, gate_offset_from_public_inputs); } } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp b/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp index cbd35d18da..301e7a656c 100644 --- a/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp @@ -3,14 +3,12 @@ #include "plookup_tables/plookup_tables.hpp" #include -using namespace bonk; - -namespace plonk { +namespace proof_system::plonk { class UltraComposer : public ComposerBase { public: - static constexpr bonk::ComposerType type = bonk::ComposerType::PLOOKUP; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::PLOOKUP; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::LOOKUP_PEDERSEN; static constexpr size_t NUM_RESERVED_GATES = 4; // This must be >= num_roots_cut_out_of_vanishing_polynomial // See the comment in plonk/proof_system/prover/prover.cpp @@ -690,4 +688,4 @@ class UltraComposer : public ComposerBase { return create_manifest(num_public_inputs); } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/ultra_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/ultra_composer.test.cpp index 51e0838b5f..5b0f6b6ce8 100644 --- a/cpp/src/barretenberg/plonk/composer/ultra_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/ultra_composer.test.cpp @@ -8,9 +8,9 @@ #include "./plookup_tables/sha256.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace { auto& engine = numeric::random::get_debug_engine(); @@ -856,4 +856,4 @@ TEST(ultra_composer, ram) EXPECT_EQ(result, true); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp index a0bca9616f..8dc934984f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp @@ -7,7 +7,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { class CommitmentScheme { public: @@ -47,4 +47,4 @@ class CommitmentScheme { bool in_lagrange_form = false) = 0; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp index d342a47e4d..51ba344e26 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp @@ -15,7 +15,7 @@ #include "barretenberg/ecc/curves/bn254/pairing.hpp" using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; TEST(commitment_scheme, kate_open) { @@ -36,9 +36,9 @@ TEST(commitment_scheme, kate_open) plonk::KateCommitmentScheme newKate; // std::shared_ptr crs_factory = (new FileReferenceStringFactory("../srs_db/ignition")); - auto file_crs = std::make_shared("../srs_db/ignition"); + auto file_crs = std::make_shared("../srs_db/ignition"); auto crs = file_crs->get_prover_crs(n); - auto circuit_proving_key = std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD); + auto circuit_proving_key = std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD); work_queue queue(circuit_proving_key.get(), &inp_tx); newKate.commit(&coeffs[0], "F_COMM", 0, queue); @@ -93,9 +93,9 @@ TEST(commitment_scheme, kate_batch_open) transcript::StandardTranscript inp_tx = transcript::StandardTranscript(transcript::Manifest()); plonk::KateCommitmentScheme newKate; - auto file_crs = std::make_shared("../srs_db/ignition"); + auto file_crs = std::make_shared("../srs_db/ignition"); auto crs = file_crs->get_prover_crs(n); - auto circuit_proving_key = std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD); + auto circuit_proving_key = std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD); work_queue queue(circuit_proving_key.get(), &inp_tx); // commit to individual polynomials diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp index 7a65fcaf4c..1992b97435 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.cpp @@ -2,7 +2,7 @@ #include "kate_commitment_scheme.hpp" #include "../../../polynomials/polynomial_arithmetic.hpp" -namespace plonk { +namespace proof_system::plonk { // Constructors for KateCommitmentScheme template @@ -390,4 +390,4 @@ template class KateCommitmentScheme; template class KateCommitmentScheme; template class KateCommitmentScheme; template class KateCommitmentScheme; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp index 2ba694ee8b..653340dbdf 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp @@ -1,7 +1,7 @@ #pragma once #include "commitment_scheme.hpp" -namespace plonk { +namespace proof_system::plonk { template class KateCommitmentScheme : public CommitmentScheme { public: @@ -44,4 +44,4 @@ extern template class KateCommitmentScheme; extern template class KateCommitmentScheme; extern template class KateCommitmentScheme; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/constants.hpp b/cpp/src/barretenberg/plonk/proof_system/constants.hpp index 7a444943c1..5c7336d49c 100644 --- a/cpp/src/barretenberg/plonk/proof_system/constants.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/constants.hpp @@ -1,7 +1,7 @@ #pragma once #include #include "barretenberg/proof_system/types/composer_type.hpp" -namespace plonk { +namespace proof_system::plonk { // This variable sets the composer (TURBO or ULTRA) of the entire stdlib and rollup modules. // To switch to using a new composer, only changing this variable should activate the new composer @@ -9,7 +9,7 @@ namespace plonk { #ifdef USE_TURBO static constexpr uint32_t SYSTEM_COMPOSER = ComposerType::TURBO; #else -static constexpr uint32_t SYSTEM_COMPOSER = bonk::ComposerType::PLOOKUP; +static constexpr uint32_t SYSTEM_COMPOSER = proof_system::ComposerType::PLOOKUP; #endif enum MerkleHashType { @@ -22,4 +22,4 @@ enum MerkleHashType { static constexpr uint64_t NUM_LIMB_BITS_IN_FIELD_SIMULATION = 68; static constexpr uint32_t NUM_QUOTIENT_PARTS = 4; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp index 08bfd8755f..100ce79047 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp @@ -48,8 +48,9 @@ WASM_EXPORT void* test_env_load_prover_crs(size_t num_points) { return env_load_prover_crs(num_points); } -typedef std::conditional_t - WasmProver; +typedef std:: + conditional_t + WasmProver; WASM_EXPORT void prover_process_queue(WasmProver* prover) { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp index 533e07e813..3de3e3a02e 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp @@ -8,8 +8,9 @@ using namespace barretenberg; extern "C" { // TODO(Cody): Removed "unrolled" here when the time comes, if it does. -typedef std::conditional_t - WasmUnrolledProver; +typedef std:: + conditional_t + WasmUnrolledProver; WASM_EXPORT void unrolled_prover_process_queue(WasmUnrolledProver* prover) { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/prover.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/prover.cpp index 12c5a3b1ea..3c3647e7f0 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/prover.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/prover.cpp @@ -8,7 +8,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { /** * Create ProverBase from proving key, witness and manifest. @@ -468,7 +468,7 @@ template void ProverBase::execute_fourth_round() diff = std::chrono::duration_cast(end - start); std::cerr << "compute quotient commitment: " << diff.count() << "ms" << std::endl; #endif -} // namespace plonk +} // namespace proof_system::plonk template void ProverBase::execute_fifth_round() { @@ -640,4 +640,4 @@ template class ProverBase; template class ProverBase; template class ProverBase; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp b/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp index b181f28afa..d0476608e2 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/prover.hpp @@ -7,7 +7,7 @@ #include "../widgets/transition_widgets/transition_widget.hpp" #include "../commitment_scheme/commitment_scheme.hpp" -namespace plonk { +namespace proof_system::plonk { template class ProverBase { @@ -110,4 +110,4 @@ typedef ProverBase UltraProver; // TODO(Mike): maybe just return // TODO(Cody): Make this into an issue? typedef ProverBase UltraToStandardProver; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp index 7eb4f323dc..2f170b1e29 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp @@ -65,7 +65,7 @@ sigma_3 = [39, 23, 4, 40, 41, 25, 33, 36, 37, 42, 43, 44, 45, 46, 47, 48] ``` */ using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace prover_helpers { @@ -112,9 +112,9 @@ plonk::Prover generate_test_data(const size_t n) // even indices = mul gates, odd incides = add gates - auto reference_string = std::make_shared(n + 1, "../srs_db/ignition"); + auto reference_string = std::make_shared(n + 1, "../srs_db/ignition"); std::shared_ptr key = - std::make_shared(n, 0, reference_string, bonk::ComposerType::STANDARD); + std::make_shared(n, 0, reference_string, proof_system::ComposerType::STANDARD); polynomial w_l(n); polynomial w_r(n); @@ -277,7 +277,7 @@ plonk::Prover generate_test_data(const size_t n) std::unique_ptr> kate_commitment_scheme = std::make_unique>(); - plonk::Prover state = plonk::Prover(key, create_manifest()); + plonk::Prover state = proof_system::plonk::Prover(key, create_manifest()); state.random_widgets.emplace_back(std::move(permutation_widget)); state.transition_widgets.emplace_back(std::move(widget)); state.commitment_scheme = std::move(kate_commitment_scheme); diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp index 7089b7c3a1..db4179c306 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp @@ -3,7 +3,7 @@ #include "barretenberg/common/throw_or_abort.hpp" #include "barretenberg/numeric/bitop/get_msb.hpp" -namespace plonk { +namespace proof_system::plonk { // In all the constructors below, the pippenger_runtime_state takes (n + 1) as the input // as the degree of t_{high}(X) is (n + 1) for standard plonk. Refer to @@ -25,8 +25,8 @@ namespace plonk { proving_key::proving_key( const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, - bonk::ComposerType type = bonk::ComposerType::STANDARD) // TODO(Cody): Don't use default for Honk + std::shared_ptr const& crs, + proof_system::ComposerType type = proof_system::ComposerType::STANDARD) // TODO(Cody): Don't use default for Honk : composer_type(type) , circuit_size(num_gates) , log_circuit_size(numeric::get_msb(num_gates)) @@ -46,7 +46,7 @@ proving_key::proving_key( * @param data * @param crs */ -proving_key::proving_key(proving_key_data&& data, std::shared_ptr const& crs) +proving_key::proving_key(proving_key_data&& data, std::shared_ptr const& crs) : composer_type(data.composer_type) , circuit_size(data.circuit_size) , num_public_inputs(data.num_public_inputs) @@ -90,4 +90,4 @@ void proving_key::init() memset((void*)"ient_polynomial_parts[3][0], 0x00, sizeof(barretenberg::fr) * circuit_size); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp index 7b150c02b9..6fef8bb861 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp @@ -10,7 +10,7 @@ #include "barretenberg/plonk/proof_system/types/polynomial_manifest.hpp" #include -namespace plonk { +namespace proof_system::plonk { struct proving_key_data { uint32_t composer_type; @@ -20,7 +20,7 @@ struct proving_key_data { std::vector recursive_proof_public_input_indices; std::vector memory_read_records; std::vector memory_write_records; - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; }; struct proving_key { @@ -31,12 +31,12 @@ struct proving_key { RELATIVE_LOOKUP, }; - proving_key(proving_key_data&& data, std::shared_ptr const& crs); + proving_key(proving_key_data&& data, std::shared_ptr const& crs); proving_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, - bonk::ComposerType type); + std::shared_ptr const& crs, + proof_system::ComposerType type); proving_key(std::ostream& is, std::string const& crs_path); @@ -51,14 +51,14 @@ struct proving_key { std::vector memory_read_records; // Used by UltraComposer only; for ROM, RAM reads. std::vector memory_write_records; // Used by UltraComposer only, for RAM writes. - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; barretenberg::evaluation_domain small_domain; barretenberg::evaluation_domain large_domain; // The reference_string object contains the monomial SRS. We can access it using: // Monomial SRS: reference_string->get_monomial_points() - std::shared_ptr reference_string; + std::shared_ptr reference_string; barretenberg::polynomial quotient_polynomial_parts[plonk::NUM_QUOTIENT_PARTS]; @@ -69,4 +69,4 @@ struct proving_key { static constexpr size_t min_thread_block = 4UL; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp index a02cc0fc68..32a28fe96d 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp @@ -10,19 +10,19 @@ #endif using namespace barretenberg; -using namespace bonk; +using namespace proof_system; // Test proving key serialization/deserialization to/from buffer TEST(proving_key, proving_key_from_serialized_key) { - plonk::StandardComposer composer = plonk::StandardComposer(); + plonk::StandardComposer composer = proof_system::plonk::StandardComposer(); fr a = fr::one(); composer.add_public_variable(a); plonk::proving_key& p_key = *composer.compute_proving_key(); auto pk_buf = to_buffer(p_key); auto pk_data = from_buffer(pk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); @@ -51,14 +51,14 @@ TEST(proving_key, proving_key_from_serialized_key) // Test proving key serialization/deserialization to/from buffer using UltraComposer TEST(proving_key, proving_key_from_serialized_key_ultra) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); fr a = fr::one(); composer.add_public_variable(a); plonk::proving_key& p_key = *composer.compute_proving_key(); auto pk_buf = to_buffer(p_key); auto pk_data = from_buffer(pk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); @@ -88,7 +88,7 @@ TEST(proving_key, proving_key_from_serialized_key_ultra) #ifndef __wasm__ TEST(proving_key, proving_key_from_mmaped_key) { - plonk::StandardComposer composer = plonk::StandardComposer(); + plonk::StandardComposer composer = proof_system::plonk::StandardComposer(); fr a = fr::one(); composer.add_public_variable(a); diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp index 2f58962c59..6bc7e79ed5 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/serialize.hpp @@ -4,7 +4,7 @@ #include "barretenberg/common/throw_or_abort.hpp" #include "barretenberg/common/serialize.hpp" -namespace plonk { +namespace proof_system::plonk { // Read the pre-computed polynomials template inline void read(B& any, proving_key_data& key) @@ -115,4 +115,4 @@ template inline void write_mmap(B& os, std::string const& path, pro write(os, key.memory_write_records); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.hpp b/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.hpp index a137bca18c..13b9effd29 100644 --- a/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.hpp @@ -2,7 +2,7 @@ #include "barretenberg/ecc/curves/bn254/fr.hpp" #include -namespace plonk { +namespace proof_system::plonk { template Field compute_public_input_delta(const std::vector& inputs, const Field& beta, diff --git a/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.test.cpp b/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.test.cpp index 8730d41afe..33e47a32e8 100644 --- a/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs.test.cpp @@ -61,7 +61,7 @@ sigma_3 = [39, 23, 4, 40, 41, 25, 33, 36, 37, 42, 43, 44, 45, 46, 47, 48] ``` */ using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace { @@ -138,7 +138,7 @@ TEST(test_public_inputs, compute_delta) for (size_t i = 0; i < num_public_inputs; ++i) { public_inputs.push_back(left[i]); } - fr target_delta = plonk::compute_public_input_delta(public_inputs, beta, gamma, domain.root); + fr target_delta = proof_system::plonk::compute_public_input_delta(public_inputs, beta, gamma, domain.root); EXPECT_EQ((modified_result == target_delta), true); } diff --git a/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs_impl.hpp b/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs_impl.hpp index 5f14716eb6..cb28bca3c4 100644 --- a/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs_impl.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/public_inputs/public_inputs_impl.hpp @@ -1,6 +1,6 @@ #pragma once -namespace plonk { +namespace proof_system::plonk { /** * Public inputs! @@ -137,4 +137,4 @@ Field compute_public_input_delta(const std::vector& public_inputs, T0 = numerator / denominator; return T0; } -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/types/commitment_open_proof.hpp b/cpp/src/barretenberg/plonk/proof_system/types/commitment_open_proof.hpp index b7269f79e5..e35951dc9b 100644 --- a/cpp/src/barretenberg/plonk/proof_system/types/commitment_open_proof.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/commitment_open_proof.hpp @@ -3,10 +3,10 @@ #include #include -namespace plonk { +namespace proof_system::plonk { struct commitment_open_proof { std::vector proof_data; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp b/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp index 6d629346c8..c55cc9b13a 100644 --- a/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp @@ -6,7 +6,7 @@ #include "barretenberg/plonk/proof_system/constants.hpp" // ToDo(Arijit): The below namespace should be plonk once all the honk related stuffs are moved out // ToDo(Cody): This is now plonk-specific. -namespace plonk { +namespace proof_system::plonk { enum PolynomialSource { WITNESS, SELECTOR, PERMUTATION, OTHER }; @@ -176,19 +176,19 @@ class PolynomialManifest { PolynomialManifest(uint32_t composer_type) { switch (composer_type) { - case bonk::ComposerType::STANDARD: { + case proof_system::ComposerType::STANDARD: { std::copy(standard_polynomial_manifest, standard_polynomial_manifest + STANDARD_MANIFEST_SIZE, std::back_inserter(manifest)); break; }; - case bonk::ComposerType::TURBO: { + case proof_system::ComposerType::TURBO: { std::copy(turbo_polynomial_manifest, turbo_polynomial_manifest + TURBO_MANIFEST_SIZE, std::back_inserter(manifest)); break; }; - case bonk::ComposerType::PLOOKUP: { + case proof_system::ComposerType::PLOOKUP: { std::copy(ultra_polynomial_manifest, ultra_polynomial_manifest + ULTRA_MANIFEST_SIZE, std::back_inserter(manifest)); @@ -236,7 +236,7 @@ class PrecomputedPolyList { precomputed_poly_ids.emplace_back(label); precomputed_poly_ids.emplace_back(label + "_fft"); // Store all lagrange forms of selector polynomials for ultra - if (composer_type == bonk::ComposerType::PLOOKUP) { + if (composer_type == proof_system::ComposerType::PLOOKUP) { precomputed_poly_ids.emplace_back(label + "_lagrange"); } break; @@ -256,4 +256,4 @@ class PrecomputedPolyList { std::string operator[](size_t index) const { return precomputed_poly_ids[index]; } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/types/program_settings.hpp b/cpp/src/barretenberg/plonk/proof_system/types/program_settings.hpp index 8e4b072c67..b4b9d5d753 100644 --- a/cpp/src/barretenberg/plonk/proof_system/types/program_settings.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/program_settings.hpp @@ -17,7 +17,7 @@ #include "../widgets/random_widgets/plookup_widget.hpp" #include "./prover_settings.hpp" -namespace plonk { +namespace proof_system::plonk { class standard_verifier_settings : public standard_settings { public: @@ -187,4 +187,4 @@ class ultra_to_standard_verifier_settings : public ultra_verifier_settings { static constexpr transcript::HashType hash_type = transcript::HashType::PedersenBlake3s; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/types/proof.hpp b/cpp/src/barretenberg/plonk/proof_system/types/proof.hpp index eb0398d35a..9d4713ccd6 100644 --- a/cpp/src/barretenberg/plonk/proof_system/types/proof.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/proof.hpp @@ -2,10 +2,10 @@ #include #include -namespace plonk { +namespace proof_system::plonk { struct proof { std::vector proof_data; }; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/types/prover_settings.hpp b/cpp/src/barretenberg/plonk/proof_system/types/prover_settings.hpp index 0862073254..fd439df766 100644 --- a/cpp/src/barretenberg/plonk/proof_system/types/prover_settings.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/prover_settings.hpp @@ -1,7 +1,7 @@ #pragma once #include "barretenberg/proof_system/arithmetization/arithmetization.hpp" #include "barretenberg/transcript/transcript.hpp" -namespace plonk { +namespace proof_system::plonk { class settings_base { public: static constexpr bool requires_shifted_wire(const uint64_t wire_shift_settings, const uint64_t wire_index) @@ -57,4 +57,4 @@ class ultra_to_standard_settings : public ultra_settings { static constexpr transcript::HashType hash_type = transcript::HashType::PedersenBlake3s; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/utils/generalized_permutation.hpp b/cpp/src/barretenberg/plonk/proof_system/utils/generalized_permutation.hpp index a85f9a6e3d..fbf08b9c10 100644 --- a/cpp/src/barretenberg/plonk/proof_system/utils/generalized_permutation.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/utils/generalized_permutation.hpp @@ -3,7 +3,7 @@ #include "barretenberg/polynomials/iterate_over_domain.hpp" #include "barretenberg/polynomials/polynomial.hpp" -namespace plonk { +namespace proof_system::plonk { template inline void compute_gen_permutation_lagrange_base_single(barretenberg::polynomial& output, const std::vector& permutation, @@ -63,4 +63,4 @@ inline void compute_gen_permutation_lagrange_base_single(barretenberg::polynomia } ITERATE_OVER_DOMAIN_END; } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/utils/kate_verification.hpp b/cpp/src/barretenberg/plonk/proof_system/utils/kate_verification.hpp index 91ee51d3b7..5fa5eeda39 100644 --- a/cpp/src/barretenberg/plonk/proof_system/utils/kate_verification.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/utils/kate_verification.hpp @@ -2,7 +2,7 @@ #include -namespace plonk { +namespace proof_system::plonk { template Field compute_kate_batch_evaluation(typename Transcript::Key* key, const Transcript& transcript) @@ -146,4 +146,4 @@ inline void print_turbo_verification_key(verification_key* key) print_fr("permutation_non_residues[1]", 6); print_fr("permutation_non_residues[2]", 7); } -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/utils/permutation.hpp b/cpp/src/barretenberg/plonk/proof_system/utils/permutation.hpp index d33cf98d46..24ae1810f0 100644 --- a/cpp/src/barretenberg/plonk/proof_system/utils/permutation.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/utils/permutation.hpp @@ -4,7 +4,7 @@ #include "barretenberg/polynomials/iterate_over_domain.hpp" #include "barretenberg/polynomials/polynomial.hpp" -namespace plonk { +namespace proof_system::plonk { struct permutation_subgroup_element { uint32_t subgroup_index = 0; @@ -107,4 +107,4 @@ inline void compute_permutation_lagrange_base_single(barretenberg::polynomial& o } ITERATE_OVER_DOMAIN_END; } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp index d41e60cb11..9e549d212c 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp @@ -1,4 +1,4 @@ -namespace bonk { +namespace proof_system { /** * Write a solidity file containing the vk params to the given stream. @@ -143,24 +143,24 @@ inline void output_vk_sol_ultra(std::ostream& os, std::shared_ptr const& key, std::string const& class_name) { - bonk::ComposerType composer_type = static_cast(key->composer_type); + proof_system::ComposerType composer_type = static_cast(key->composer_type); switch (composer_type) { - case bonk::ComposerType::STANDARD: { + case proof_system::ComposerType::STANDARD: { return output_vk_sol_standard(os, key, class_name); break; } - // case bonk::ComposerType::TURBO: { + // case proof_system::ComposerType::TURBO: { // return output_vk_sol_turbo(os, key, class_name); // break; // } - case bonk::ComposerType::PLOOKUP: { + case proof_system::ComposerType::PLOOKUP: { return output_vk_sol_ultra(os, key, class_name); break; } default: { - std::cerr << "bonk::output_vk_sol unsupported composer type. Defaulting to standard composer" << std::endl; + std::cerr << "proof_system::output_vk_sol unsupported composer type. Defaulting to standard composer" << std::endl; return output_vk_sol_standard(os, key, class_name); } } } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp index eca7ed120b..aeccd3f70e 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp @@ -2,11 +2,11 @@ #include "verification_key.hpp" #include "barretenberg/plonk/proof_system/constants.hpp" -namespace plonk { +namespace proof_system::plonk { verification_key::verification_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, uint32_t composer_type_) : composer_type(composer_type_) , circuit_size(num_gates) @@ -18,7 +18,7 @@ verification_key::verification_key(const size_t num_gates, {} verification_key::verification_key(verification_key_data&& data, - std::shared_ptr const& crs) + std::shared_ptr const& crs) : composer_type(data.composer_type) , circuit_size(data.circuit_size) , log_circuit_size(numeric::get_msb(data.circuit_size)) @@ -88,4 +88,4 @@ sha256::hash verification_key::sha256_hash() return sha256::sha256(to_buffer(vk_data)); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp index 86a93ba011..3b5e2ee36e 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp @@ -5,7 +5,7 @@ #include "barretenberg/crypto/sha256/sha256.hpp" #include "barretenberg/plonk/proof_system/types/polynomial_manifest.hpp" -namespace plonk { +namespace proof_system::plonk { struct verification_key_data { uint32_t composer_type; @@ -45,10 +45,10 @@ inline bool operator==(verification_key_data const& lhs, verification_key_data c } struct verification_key { - verification_key(verification_key_data&& data, std::shared_ptr const& crs); + verification_key(verification_key_data&& data, std::shared_ptr const& crs); verification_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, uint32_t composer_type); verification_key(const verification_key& other); verification_key(verification_key&& other); @@ -65,7 +65,7 @@ struct verification_key { barretenberg::evaluation_domain domain; - std::shared_ptr reference_string; + std::shared_ptr reference_string; std::map commitments; @@ -91,4 +91,4 @@ template inline void write(B& buf, verification_key const& key) write(buf, key.recursive_proof_public_input_indices); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp index 2236e0194e..8f3fff05aa 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp @@ -3,14 +3,14 @@ #include "verification_key.hpp" using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; -namespace plonk::test_verification_key { +namespace proof_system::plonk::test_verification_key { TEST(verification_key, buffer_serialization) { verification_key_data key; - key.composer_type = static_cast(bonk::ComposerType::STANDARD); + key.composer_type = static_cast(proof_system::ComposerType::STANDARD); key.circuit_size = 1234; key.num_public_inputs = 10; key.commitments["test1"] = g1::element::random_element(); @@ -27,7 +27,7 @@ TEST(verification_key, buffer_serialization) TEST(verification_key, stream_serialization) { verification_key_data key; - key.composer_type = static_cast(bonk::ComposerType::STANDARD); + key.composer_type = static_cast(proof_system::ComposerType::STANDARD); key.circuit_size = 1234; key.num_public_inputs = 10; key.commitments["test1"] = g1::element::random_element(); @@ -43,4 +43,4 @@ TEST(verification_key, stream_serialization) EXPECT_EQ(key, result); } -} // namespace plonk::test_verification_key \ No newline at end of file +} // namespace proof_system::plonk::test_verification_key \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.cpp b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.cpp index 4986bec460..2a4681df5f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.cpp @@ -10,7 +10,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { template VerifierBase::VerifierBase(std::shared_ptr verifier_key, const transcript::Manifest& input_manifest) @@ -242,4 +242,4 @@ template class VerifierBase; template class VerifierBase; template class VerifierBase; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.hpp b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.hpp index 32be98f126..151117ba10 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.hpp @@ -5,7 +5,7 @@ #include "barretenberg/transcript/manifest.hpp" #include "barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.hpp" -namespace plonk { +namespace proof_system::plonk { template class VerifierBase { public: @@ -38,4 +38,4 @@ typedef VerifierBase TurboVerifier; typedef VerifierBase UltraVerifier; typedef VerifierBase UltraToStandardVerifier; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp index f71bf58f71..9a5501a328 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp @@ -14,7 +14,7 @@ namespace verifier_helpers { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; plonk::Verifier generate_verifier(std::shared_ptr circuit_proving_key) { @@ -40,7 +40,7 @@ plonk::Verifier generate_verifier(std::shared_ptr circuit_proving_k state)); } - auto crs = std::make_shared("../srs_db/ignition"); + auto crs = std::make_shared("../srs_db/ignition"); std::shared_ptr circuit_verification_key = std::make_shared(circuit_proving_key->circuit_size, circuit_proving_key->num_public_inputs, @@ -76,8 +76,8 @@ plonk::Prover generate_test_data(const size_t n) // even indices = mul gates, odd incides = add gates - auto crs = std::make_shared(n + 1, "../srs_db/ignition"); - std::shared_ptr key = std::make_shared(n, 0, crs, bonk::ComposerType::STANDARD); + auto crs = std::make_shared(n + 1, "../srs_db/ignition"); + std::shared_ptr key = std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD); polynomial w_l(n); polynomial w_r(n); @@ -232,7 +232,7 @@ plonk::Prover generate_test_data(const size_t n) std::unique_ptr> kate_commitment_scheme = std::make_unique>(); - plonk::Prover state = plonk::Prover(std::move(key), plonk::StandardComposer::create_manifest(0)); + plonk::Prover state = proof_system::plonk::Prover(std::move(key), plonk::StandardComposer::create_manifest(0)); state.random_widgets.emplace_back(std::move(permutation_widget)); state.transition_widgets.emplace_back(std::move(widget)); state.commitment_scheme = std::move(kate_commitment_scheme); diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget.hpp index 92606be5e4..98e58b0bad 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/permutation_widget.hpp @@ -1,7 +1,7 @@ #pragma once #include "random_widget.hpp" -namespace plonk { +namespace proof_system::plonk { template ProverPermutationWidget::ProverPermutationWidget( @@ -789,4 +789,4 @@ template class VerifierPermutationWidget; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget.hpp index 003f292769..623f3a6193 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/plookup_widget.hpp @@ -1,7 +1,7 @@ #pragma once #include "random_widget.hpp" -namespace plonk { +namespace proof_system::plonk { template ProverPlookupWidget::ProverPlookupWidget(proving_key* input_key) @@ -734,7 +734,7 @@ Field VerifierPlookupWidget Field VerifierPlookupWidget:: @@ -751,4 +751,4 @@ template class VerifierPlookupWidget; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp index b902e96dae..39829799cc 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/random_widgets/random_widget.hpp @@ -9,7 +9,7 @@ class Transcript; } // TODO(Cody) Fix this namespace. -namespace plonk { +namespace proof_system::plonk { struct proving_key; @@ -53,4 +53,4 @@ class ProverRandomWidget { proving_key* key; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp index 461fc1e358..e21da0141e 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/arithmetic_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /** @@ -154,4 +154,4 @@ using ProverArithmeticWidget = widget::TransitionWidget using VerifierArithmeticWidget = widget::GenericVerifierWidget; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp index c963f8ad41..e628a85563 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/elliptic_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /** @@ -188,4 +188,4 @@ using ProverEllipticWidget = widget::TransitionWidget using VerifierEllipticWidget = widget::GenericVerifierWidget; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp index 53eb89ec8c..8ee5d507b6 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/fixed_base_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /** @@ -328,4 +328,4 @@ using VerifierTurboFixedBaseWidget = template using VerifierUltraFixedBaseWidget = widget::GenericVerifierWidget; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp index 269a1b03fc..ee8afe2dc9 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/genperm_sort_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { template class GenPermSortKernel { @@ -126,4 +126,4 @@ using ProverGenPermSortWidget = widget::TransitionWidget using VerifierGenPermSortWidget = widget::GenericVerifierWidget; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp index 0bc7828990..3a10bb9787 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_arithmetic_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /** @@ -205,4 +205,4 @@ template ; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp index 7d50cf11c1..093568b58a 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/plookup_auxiliary_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /** @@ -348,4 +348,4 @@ template ; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp index c7ab9ea0e8..5dc62aa2a9 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp @@ -10,8 +10,8 @@ #include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/proof_system/work_queue/work_queue.hpp" -using namespace bonk; -namespace plonk { +using namespace proof_system; +namespace proof_system::plonk { namespace widget { enum ChallengeIndex { @@ -387,4 +387,4 @@ class GenericVerifierWidget { } }; } // namespace widget -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp index 1c4472a689..9daaba1f0c 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /** @@ -305,4 +305,4 @@ template ; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp index 62be73022c..95ade04896 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_logic_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { template class TurboLogicKernel { @@ -233,4 +233,4 @@ using ProverTurboLogicWidget = widget::TransitionWidget using VerifierTurboLogicWidget = widget::GenericVerifierWidget; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp index d72b964f58..ffa9852c11 100644 --- a/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_range_widget.hpp @@ -2,7 +2,7 @@ #include "./transition_widget.hpp" -namespace plonk { +namespace proof_system::plonk { namespace widget { /* @@ -209,4 +209,4 @@ using ProverTurboRangeWidget = widget::TransitionWidget using VerifierTurboRangeWidget = widget::GenericVerifierWidget; -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/arithmetization/gate_data.hpp b/cpp/src/barretenberg/proof_system/arithmetization/gate_data.hpp index f62a121960..5175867bfd 100644 --- a/cpp/src/barretenberg/proof_system/arithmetization/gate_data.hpp +++ b/cpp/src/barretenberg/proof_system/arithmetization/gate_data.hpp @@ -3,7 +3,7 @@ #include "barretenberg/ecc/curves/bn254/fr.hpp" #include "barretenberg/common/serialize.hpp" -namespace bonk { +namespace proof_system { struct add_triple { uint32_t a; uint32_t b; @@ -121,4 +121,4 @@ struct ecc_add_gate { barretenberg::fr endomorphism_coefficient; barretenberg::fr sign_coefficient; }; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.cpp b/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.cpp index ee2cbb9fff..2f1f190805 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.cpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.cpp @@ -1,6 +1,6 @@ #include "circuit_constructor_base.hpp" -namespace bonk { +namespace proof_system { /** * Join variable class b to variable class a. @@ -43,4 +43,4 @@ void CircuitConstructorBase::assert_equal(const uint32_t a_vari // Standard honk/ plonk instantiation template class CircuitConstructorBase; template class CircuitConstructorBase; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.hpp index 619d8fbffd..325349708d 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/circuit_constructor_base.hpp @@ -4,7 +4,7 @@ #include "barretenberg/ecc/curves/bn254/fr.hpp" #include -namespace bonk { +namespace proof_system { static constexpr uint32_t DUMMY_TAG = 0; template class CircuitConstructorBase { @@ -236,7 +236,7 @@ template class CircuitConstructorBase { } }; -} // namespace bonk +} // namespace proof_system // TODO(#217)(Cody): This will need updating based on the approach we take to ensure no multivariate is zero. /** diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.cpp b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.cpp index 7960064700..61c6ed8de5 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.cpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.cpp @@ -4,7 +4,7 @@ using namespace barretenberg; -namespace bonk { +namespace proof_system { /** * Create an addition gate. @@ -496,4 +496,4 @@ bool StandardCircuitConstructor::check_circuit() } return true; } -} // namespace bonk \ No newline at end of file +} // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp index 3aba1aec3c..7479fbadb1 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp @@ -4,7 +4,7 @@ #include "barretenberg/plonk/proof_system/constants.hpp" #include "barretenberg/proof_system/flavor/flavor.hpp" -namespace bonk { +namespace proof_system { inline std::vector standard_selector_names() { std::vector result{ "q_m", "q_1", "q_2", "q_3", "q_c" }; @@ -23,7 +23,8 @@ class StandardCircuitConstructor : public CircuitConstructorBase& q_3 = std::get<3>(selectors); std::vector& q_c = std::get<4>(selectors); - static constexpr bonk::ComposerType type = bonk::ComposerType::STANDARD_HONK; // TODO(Cody): Get rid of this. + static constexpr proof_system::ComposerType type = + proof_system::ComposerType::STANDARD_HONK; // TODO(Cody): Get rid of this. static constexpr size_t UINT_LOG2_BASE = 2; // These are variables that we have used a gate on, to enforce that they are @@ -101,4 +102,4 @@ class StandardCircuitConstructor : public CircuitConstructorBase turbo_selector_names() { @@ -32,7 +32,7 @@ class TurboCircuitConstructor : public CircuitConstructorBase& q_range = std::get<9>(selectors); std::vector& q_logic = std::get<10>(selectors); - static constexpr bonk::ComposerType type = bonk::ComposerType::TURBO; + static constexpr proof_system::ComposerType type = proof_system::ComposerType::TURBO; static constexpr size_t UINT_LOG2_BASE = 2; TurboCircuitConstructor(const size_t size_hint = 0); @@ -114,4 +114,4 @@ class TurboCircuitConstructor : public CircuitConstructorBase constant_variable_indices; }; -} // namespace bonk \ No newline at end of file +} // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.test.cpp b/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.test.cpp index 3be6bbea1e..1efacb4622 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.test.cpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.test.cpp @@ -8,7 +8,7 @@ using namespace crypto::pedersen; namespace { auto& engine = numeric::random::get_debug_engine(); } -namespace bonk { +namespace proof_system { TEST(turbo_circuit_constructor, base_case) { TurboCircuitConstructor circuit_constructor = TurboCircuitConstructor(); @@ -687,4 +687,4 @@ TEST(turbo_circuit_constructor, big_add_gate_with_bit_extract) EXPECT_EQ(result, true); } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp index 65c8943a6e..73a48b220d 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp @@ -8,8 +8,8 @@ #include "barretenberg/honk/pcs/commitment_key.hpp" #include "barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp" #include "barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp" -#include "barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.hpp" -namespace bonk { + +namespace proof_system { /** * @brief Initialize proving key and load the crs @@ -23,10 +23,10 @@ namespace bonk { */ template std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, - bonk::ReferenceStringFactory* crs_factory, + proof_system::ReferenceStringFactory* crs_factory, const size_t minimum_circuit_size, const size_t num_randomized_gates, - bonk::ComposerType composer_type) + proof_system::ComposerType composer_type) { const size_t num_gates = circuit_constructor.num_gates; std::span public_inputs = circuit_constructor.public_inputs; @@ -197,13 +197,14 @@ std::vector compute_witness_base(const CircuitConstruc // * (2) sets the polynomial manifest using the data from proving key. // */ // std::shared_ptr compute_verification_key_common( -// std::shared_ptr const& proving_key, std::shared_ptr const& -// vrs) +// std::shared_ptr const& proving_key, std::shared_ptr +// const& vrs) // { // auto circuit_verification_key = std::make_shared( // proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); // // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc -// auto commitment_key = honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, "../srs_db/ignition"); +// auto commitment_key = proof_system::honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, +// "../srs_db/ignition"); // for (size_t i = 0; i < proving_key->polynomial_manifest.size(); ++i) { // const auto& poly_info = proving_key->polynomial_manifest[i]; @@ -211,9 +212,9 @@ std::vector compute_witness_base(const CircuitConstruc // const std::string poly_label(poly_info.polynomial_label); // const std::string selector_commitment_label(poly_info.commitment_label); -// if (poly_info.source == bonk::PolynomialSource::SELECTOR || -// poly_info.source == bonk::PolynomialSource::PERMUTATION || -// poly_info.source == bonk::PolynomialSource::OTHER) { +// if (poly_info.source == proof_system::PolynomialSource::SELECTOR || +// poly_info.source == proof_system::PolynomialSource::PERMUTATION || +// poly_info.source == proof_system::PolynomialSource::OTHER) { // // Fetch the polynomial in its vector form. // // Commit to the constraint selector polynomial and insert the commitment in the verification key. @@ -224,7 +225,8 @@ std::vector compute_witness_base(const CircuitConstruc // } // // Set the polynomial manifest in verification key. -// circuit_verification_key->polynomial_manifest = plonk::PolynomialManifest(proving_key->composer_type); +// circuit_verification_key->polynomial_manifest = +// proof_system::plonk::PolynomialManifest(proving_key->composer_type); // return circuit_verification_key; // } @@ -232,7 +234,11 @@ std::vector compute_witness_base(const CircuitConstruc // Ensure we compile all versions so that there are no issues during linkage #define COMPILE_FOR_CIRCUIT_CONSTRUCTOR(circuit_constructor) \ template std::shared_ptr initialize_proving_key( \ - const circuit_constructor&, bonk::ReferenceStringFactory*, const size_t, const size_t, bonk::ComposerType); \ + const circuit_constructor&, \ + proof_system::ReferenceStringFactory*, \ + const size_t, \ + const size_t, \ + proof_system::ComposerType); \ template void construct_lagrange_selector_forms(const circuit_constructor&, \ plonk::proving_key*); \ template std::vector compute_witness_base( \ @@ -244,4 +250,4 @@ COMPILE_FOR_CIRCUIT_CONSTRUCTOR(StandardCircuitConstructor) COMPILE_FOR_CIRCUIT_CONSTRUCTOR(TurboCircuitConstructor) COMPILE_FOR_CIRCUIT_CONSTRUCTOR(UltraCircuitConstructor) -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp index d888d5a729..d629fa79f0 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp @@ -4,7 +4,7 @@ #include "barretenberg/polynomials/polynomial_arithmetic.hpp" #include "barretenberg/polynomials/polynomial.hpp" -namespace bonk { +namespace proof_system { /** * @brief Initialize proving key and load the crs @@ -18,10 +18,10 @@ namespace bonk { */ template std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, - bonk::ReferenceStringFactory* crs_factory, + proof_system::ReferenceStringFactory* crs_factory, const size_t minimum_circuit_size, const size_t num_randomized_gates, - bonk::ComposerType composer_type); + proof_system::ComposerType composer_type); /** * @brief Construct lagrange selector polynomials from circuit selector information and put into polynomial cache @@ -73,7 +73,7 @@ std::vector compute_witness_base(const CircuitConstruc // * (2) sets the polynomial manifest using the data from proving key. // */ // std::shared_ptr compute_verification_key_common( -// std::shared_ptr const& proving_key, std::shared_ptr const& -// vrs); +// std::shared_ptr const& proving_key, std::shared_ptr +// const& vrs); -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp b/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp index 80b1910e63..6fb9de5540 100644 --- a/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp +++ b/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp @@ -21,7 +21,7 @@ #include #include -namespace bonk { +namespace proof_system { /** * @brief cycle_node represents the index of a value of the circuit. @@ -131,7 +131,7 @@ std::vector compute_wire_copy_cycles(const CircuitConstructor * @param key Pointer to the proving key */ template -std::array, program_width> compute_basic_bonk_sigma_permutations( +std::array, program_width> compute_basic_proof_system_sigma_permutations( const CircuitConstructor& circuit_constructor, plonk::proving_key* key) { // Compute wire copy cycles (cycles of permutations) @@ -403,7 +403,7 @@ template void compute_standard_honk_sigma_permutations(CircuitConstructor& circuit_constructor, plonk::proving_key* key) { // Compute the permutation table specifying which element becomes which - auto sigma_mappings = compute_basic_bonk_sigma_permutations(circuit_constructor, key); + auto sigma_mappings = compute_basic_proof_system_sigma_permutations(circuit_constructor, key); // Compute Honk-style sigma polynomial fromt the permutation table compute_honk_style_sigma_lagrange_polynomials_from_mapping(sigma_mappings, key); } @@ -420,7 +420,7 @@ template void compute_standard_plonk_sigma_permutations(CircuitConstructor& circuit_constructor, plonk::proving_key* key) { // Compute the permutation table specifying which element becomes which - auto sigma_mappings = compute_basic_bonk_sigma_permutations(circuit_constructor, key); + auto sigma_mappings = compute_basic_proof_system_sigma_permutations(circuit_constructor, key); // Compute Plonk-style sigma polynomials from the mapping compute_plonk_permutation_lagrange_polynomials_from_mapping("sigma", sigma_mappings, key); // Compute their monomial and coset versions @@ -536,4 +536,4 @@ void compute_plonk_generalized_sigma_permutations(const CircuitConstructor& circ compute_monomial_and_coset_fft_polynomials_from_lagrange("id", key); } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp index d3e2eb1055..cd91bd4414 100644 --- a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp +++ b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.hpp @@ -7,7 +7,7 @@ #include #include -namespace bonk { +namespace proof_system { /** * @brief Basic storage class for Polynomials * @@ -98,4 +98,4 @@ template class PolynomialStore { typename std::unordered_map::const_iterator end() const { return polynomial_map.end(); } }; -} // namespace bonk \ No newline at end of file +} // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp index 638fb01d62..c0221dd22f 100644 --- a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp +++ b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp @@ -4,7 +4,7 @@ #include "polynomial_store.hpp" #include "barretenberg/polynomials/polynomial.hpp" -namespace bonk { +namespace proof_system { using namespace barretenberg; using Fr = barretenberg::fr; @@ -13,7 +13,7 @@ using Polynomial = barretenberg::Polynomial; // Test basic put and get functionality TEST(PolynomialStore, PutThenGet) { - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; // Instantiate a polynomial with random coefficients Polynomial poly(1024); @@ -34,7 +34,7 @@ TEST(PolynomialStore, PutThenGet) // Ensure that attempt to access non-existent key throws out_of_range exception TEST(PolynomialStore, NonexistentKey) { - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; polynomial_store.put("id_1", Polynomial(100)); @@ -46,7 +46,7 @@ TEST(PolynomialStore, NonexistentKey) // Ensure correct calculation of volume in bytes TEST(PolynomialStore, Volume) { - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; size_t size1 = 100; size_t size2 = 10; size_t size3 = 5000; @@ -69,7 +69,7 @@ TEST(PolynomialStore, Volume) // Ensure that the remove method erases entry and reduces memory TEST(PolynomialStore, Remove) { - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; size_t size1 = 100; size_t size2 = 500; Polynomial poly1(size1); @@ -93,7 +93,7 @@ TEST(PolynomialStore, Remove) // Check that PolynomialStore supports range based for loop TEST(PolynomialStore, RangeBasedFor) { - bonk::PolynomialStore polynomial_store; + proof_system::PolynomialStore polynomial_store; size_t size = 100; Polynomial poly1(size); Polynomial poly2(size); @@ -102,7 +102,7 @@ TEST(PolynomialStore, RangeBasedFor) polynomial_store.put("id_2", std::move(poly2)); // Check that PolynomialStore meets criteria for std::ranges::range - EXPECT_TRUE(std::ranges::range>); + EXPECT_TRUE(std::ranges::range>); // For example ... Polynomial polynomial_sum(size); @@ -111,4 +111,4 @@ TEST(PolynomialStore, RangeBasedFor) } } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/types/composer_type.hpp b/cpp/src/barretenberg/proof_system/types/composer_type.hpp index 66e79810d4..6a19c8fe4d 100644 --- a/cpp/src/barretenberg/proof_system/types/composer_type.hpp +++ b/cpp/src/barretenberg/proof_system/types/composer_type.hpp @@ -1,11 +1,12 @@ #pragma once -namespace bonk { +namespace proof_system { // This will go away, but we move it here has a temporary measure to make proof_system not depend on honk or plonk. enum ComposerType { STANDARD, TURBO, PLOOKUP, - STANDARD_HONK, // Todo(Arijit): We should replace STANDARD_HONK outside plonk or the namespace should be bonk + STANDARD_HONK, // Todo(Arijit): We should replace STANDARD_HONK outside plonk or the namespace should be + // proof_system }; -} // namespace bonk \ No newline at end of file +} // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp b/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp index 171e6c5614..54d29fad31 100644 --- a/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp +++ b/cpp/src/barretenberg/proof_system/work_queue/work_queue.cpp @@ -3,7 +3,7 @@ #include "barretenberg/ecc/curves/bn254/scalar_multiplication/scalar_multiplication.hpp" #include "barretenberg/polynomials/polynomial_arithmetic.hpp" -namespace bonk { +namespace proof_system { work_queue::work_queue(plonk::proving_key* prover_key, transcript::StandardTranscript* prover_transcript) : key(prover_key) @@ -305,4 +305,4 @@ std::vector work_queue::get_queue() const return work_item_queue; } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp b/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp index f8feb5e324..ad0176723f 100644 --- a/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp +++ b/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp @@ -3,7 +3,7 @@ #include "../../transcript/transcript_wrappers.hpp" #include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" -namespace bonk { +namespace proof_system { // TODO(Cody): Template by flavor class work_queue { @@ -66,4 +66,4 @@ class work_queue { transcript::StandardTranscript* transcript; std::vector work_item_queue; }; -} // namespace bonk \ No newline at end of file +} // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/srs/reference_string/env_reference_string.hpp b/cpp/src/barretenberg/srs/reference_string/env_reference_string.hpp index 9f91243678..e4eebec39f 100644 --- a/cpp/src/barretenberg/srs/reference_string/env_reference_string.hpp +++ b/cpp/src/barretenberg/srs/reference_string/env_reference_string.hpp @@ -1,7 +1,7 @@ /** * Create reference strings given an environment that implements env/crs.hpp. * Usable in both native and WASM code, but particularly useful for accessing - * reference strings from a WASM context. + * reference strings from a WASM context. * In a native context, the implementations assume a hard-coded string path. * For that reason, ideally this is only used in c-bind functions to maintain flexibility. */ @@ -17,7 +17,7 @@ #include #include -namespace bonk { +namespace proof_system { using namespace barretenberg; @@ -50,4 +50,4 @@ class EnvReferenceStringFactory : public ReferenceStringFactory { } }; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/srs/reference_string/env_reference_string.test.cpp b/cpp/src/barretenberg/srs/reference_string/env_reference_string.test.cpp index b8c7e3787e..d71c5c34f9 100644 --- a/cpp/src/barretenberg/srs/reference_string/env_reference_string.test.cpp +++ b/cpp/src/barretenberg/srs/reference_string/env_reference_string.test.cpp @@ -9,9 +9,9 @@ TEST(reference_string, env_file_consistency) { - auto env_crs = std::make_unique(); + auto env_crs = std::make_unique(); - auto file_crs = std::make_unique("../srs_db/ignition"); + auto file_crs = std::make_unique("../srs_db/ignition"); auto file_verifier = file_crs->get_verifier_crs(); EXPECT_EQ(env_crs->get_verifier_crs()->get_g2x(), file_verifier->get_g2x()); @@ -19,8 +19,6 @@ TEST(reference_string, env_file_consistency) file_verifier->get_precomputed_g2_lines(), sizeof(barretenberg::pairing::miller_lines) * 2), 0); - EXPECT_EQ( - env_crs->get_prover_crs(1)->get_monomial_points()[0], - file_crs->get_prover_crs(1)->get_monomial_points()[0] - ); + EXPECT_EQ(env_crs->get_prover_crs(1)->get_monomial_points()[0], + file_crs->get_prover_crs(1)->get_monomial_points()[0]); } diff --git a/cpp/src/barretenberg/srs/reference_string/file_reference_string.cpp b/cpp/src/barretenberg/srs/reference_string/file_reference_string.cpp index e4dbae0bdd..99f09c776c 100644 --- a/cpp/src/barretenberg/srs/reference_string/file_reference_string.cpp +++ b/cpp/src/barretenberg/srs/reference_string/file_reference_string.cpp @@ -3,7 +3,7 @@ #include "barretenberg/ecc/curves/bn254/pairing.hpp" -namespace bonk { +namespace proof_system { VerifierFileReferenceString::VerifierFileReferenceString(std::string const& path) : precomputed_g2_lines( @@ -20,4 +20,4 @@ VerifierFileReferenceString::~VerifierFileReferenceString() aligned_free(precomputed_g2_lines); } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/srs/reference_string/file_reference_string.hpp b/cpp/src/barretenberg/srs/reference_string/file_reference_string.hpp index 02ff6e6a0a..ef6bebfc0a 100644 --- a/cpp/src/barretenberg/srs/reference_string/file_reference_string.hpp +++ b/cpp/src/barretenberg/srs/reference_string/file_reference_string.hpp @@ -15,7 +15,7 @@ namespace barretenberg::pairing { struct miller_lines; } // namespace barretenberg::pairing -namespace bonk { +namespace proof_system { using namespace barretenberg; @@ -99,4 +99,4 @@ class DynamicFileReferenceStringFactory : public ReferenceStringFactory { std::shared_ptr verifier_crs_; }; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/srs/reference_string/mem_reference_string.cpp b/cpp/src/barretenberg/srs/reference_string/mem_reference_string.cpp index 8fe33b25f3..0a9c71b40a 100644 --- a/cpp/src/barretenberg/srs/reference_string/mem_reference_string.cpp +++ b/cpp/src/barretenberg/srs/reference_string/mem_reference_string.cpp @@ -6,7 +6,7 @@ #include -namespace bonk { +namespace proof_system { VerifierMemReferenceString::VerifierMemReferenceString(uint8_t const* g2x) : precomputed_g2_lines( @@ -23,4 +23,4 @@ VerifierMemReferenceString::~VerifierMemReferenceString() aligned_free(precomputed_g2_lines); } -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/srs/reference_string/mem_reference_string.hpp b/cpp/src/barretenberg/srs/reference_string/mem_reference_string.hpp index 95a9598b88..608446fa77 100644 --- a/cpp/src/barretenberg/srs/reference_string/mem_reference_string.hpp +++ b/cpp/src/barretenberg/srs/reference_string/mem_reference_string.hpp @@ -11,7 +11,7 @@ namespace barretenberg::pairing { struct miller_lines; } // namespace barretenberg::pairing -namespace bonk { +namespace proof_system { using namespace barretenberg; @@ -29,4 +29,4 @@ class VerifierMemReferenceString : public VerifierReferenceString { pairing::miller_lines* precomputed_g2_lines; }; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/srs/reference_string/mem_reference_string.test.cpp b/cpp/src/barretenberg/srs/reference_string/mem_reference_string.test.cpp index 598d6aa9cf..18701cc537 100644 --- a/cpp/src/barretenberg/srs/reference_string/mem_reference_string.test.cpp +++ b/cpp/src/barretenberg/srs/reference_string/mem_reference_string.test.cpp @@ -20,9 +20,9 @@ TEST(reference_string, mem_file_consistency) transcript.read((char*)g2x.data(), 128); transcript.close(); - auto mem_verifier = std::make_unique(g2x.data()); + auto mem_verifier = std::make_unique(g2x.data()); - auto file_crs = std::make_unique("../srs_db/ignition"); + auto file_crs = std::make_unique("../srs_db/ignition"); auto file_verifier = file_crs->get_verifier_crs(); EXPECT_EQ(mem_verifier->get_g2x(), file_verifier->get_g2x()); diff --git a/cpp/src/barretenberg/srs/reference_string/pippenger_reference_string.hpp b/cpp/src/barretenberg/srs/reference_string/pippenger_reference_string.hpp index f409b9225d..53c6867018 100644 --- a/cpp/src/barretenberg/srs/reference_string/pippenger_reference_string.hpp +++ b/cpp/src/barretenberg/srs/reference_string/pippenger_reference_string.hpp @@ -9,7 +9,7 @@ namespace barretenberg::pairing { struct miller_lines; } // namespace barretenberg::pairing -namespace bonk { +namespace proof_system { using namespace barretenberg; @@ -51,4 +51,4 @@ class PippengerReferenceStringFactory : public ReferenceStringFactory { uint8_t const* g2x_; }; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/srs/reference_string/reference_string.hpp b/cpp/src/barretenberg/srs/reference_string/reference_string.hpp index 13033d9f37..e43d9fa798 100644 --- a/cpp/src/barretenberg/srs/reference_string/reference_string.hpp +++ b/cpp/src/barretenberg/srs/reference_string/reference_string.hpp @@ -10,7 +10,7 @@ namespace barretenberg::pairing { struct miller_lines; } // namespace barretenberg::pairing -namespace bonk { +namespace proof_system { class VerifierReferenceString { public: @@ -40,4 +40,4 @@ class ReferenceStringFactory { virtual std::shared_ptr get_verifier_crs() { return nullptr; } }; -} // namespace bonk +} // namespace proof_system diff --git a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp index fa45398119..bfd5b43d2c 100644 --- a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp @@ -11,13 +11,13 @@ using namespace crypto::aes128; using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace aes128 { constexpr uint32_t AES128_BASE = 9; -typedef plonk::stdlib::field_t field_t; -typedef plonk::stdlib::witness_t witness_t; +typedef proof_system::plonk::stdlib::field_t field_t; +typedef proof_system::plonk::stdlib::witness_t witness_t; typedef std::pair byte_pair; @@ -296,4 +296,4 @@ std::vector encrypt_buffer_cbc(const std::vector& input, const } // namespace aes128 } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.hpp b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.hpp index 14dea9b396..fc9dbfcc1d 100644 --- a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.hpp +++ b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.hpp @@ -8,7 +8,7 @@ #include "../../primitives/field/field.hpp" #include "../../primitives/witness/witness.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace aes128 { @@ -19,4 +19,4 @@ std::vector> encrypt_buffer_cbc(const std::vector< } // namespace aes128 } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp index ca97c0b11e..1b315039c3 100644 --- a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp @@ -7,12 +7,12 @@ #include using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; TEST(stdlib_aes128, encrypt_64_bytes) { - typedef plonk::stdlib::field_t field_pt; - typedef plonk::stdlib::witness_t witness_pt; + typedef proof_system::plonk::stdlib::field_t field_pt; + typedef proof_system::plonk::stdlib::witness_t witness_pt; uint8_t key[16]{ 0x2b, 0x7e, 0x15, 0x16, 0x28, 0xae, 0xd2, 0xa6, 0xab, 0xf7, 0x15, 0x88, 0x09, 0xcf, 0x4f, 0x3c }; uint8_t out[64]{ 0x76, 0x49, 0xab, 0xac, 0x81, 0x19, 0xb2, 0x46, 0xce, 0xe9, 0x8e, 0x9b, 0x12, 0xe9, 0x19, 0x7d, @@ -34,7 +34,7 @@ TEST(stdlib_aes128, encrypt_64_bytes) return converted; }; - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::vector in_field{ witness_pt(&composer, fr(convert_bytes(in))), @@ -50,7 +50,7 @@ TEST(stdlib_aes128, encrypt_64_bytes) convert_bytes(out), convert_bytes(out + 16), convert_bytes(out + 32), convert_bytes(out + 48) }; - const auto result = plonk::stdlib::aes128::encrypt_buffer_cbc(in_field, iv_field, key_field); + const auto result = proof_system::plonk::stdlib::aes128::encrypt_buffer_cbc(in_field, iv_field, key_field); for (size_t i = 0; i < 4; ++i) { EXPECT_EQ(result[i].get_value(), expected[i]); diff --git a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp index bdd67f46b4..c6ab50fbae 100644 --- a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp +++ b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.hpp @@ -3,7 +3,7 @@ #include "../../primitives/byte_array/byte_array.hpp" #include "../../primitives/composers/composers_fwd.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace ecdsa { @@ -18,6 +18,6 @@ bool_t verify_signature(const stdlib::byte_array& message, const signature& sig); } // namespace ecdsa } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk #include "./ecdsa_impl.hpp" \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.test.cpp b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.test.cpp index 808bfbdf04..b1edc24d84 100644 --- a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.test.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa.test.cpp @@ -7,10 +7,10 @@ #include "barretenberg/common/test.hpp" using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace test_stdlib_ecdsa { -using Composer = plonk::UltraComposer; +using Composer = proof_system::plonk::UltraComposer; using curve = stdlib::secp256k1; TEST(stdlib_ecdsa, verify_signature) diff --git a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp index 8048b56d07..e0bb6ccb61 100644 --- a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp +++ b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp @@ -2,7 +2,7 @@ #include "../../hash/sha256/sha256.hpp" #include "../../primitives/bit_array/bit_array.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace ecdsa { @@ -33,8 +33,8 @@ bool_t verify_signature(const stdlib::byte_array& message, Fr u2 = r / s; G1 result; - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { - ASSERT(Curve::type == bonk::CurveType::SECP256K1); + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + ASSERT(Curve::type == proof_system::CurveType::SECP256K1); public_key.validate_on_curve(); result = G1::secp256k1_ecdsa_mul(public_key, u1, u2); } else { @@ -68,4 +68,4 @@ bool_t verify_signature(const stdlib::byte_array& message, } // namespace ecdsa } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp b/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp index 35ebcde4b9..ac889f2bf9 100644 --- a/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp @@ -6,7 +6,7 @@ #include "../../primitives/composers/composers.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace schnorr { @@ -119,12 +119,12 @@ point variable_base_mul(const point& pub_key, const field_t& low_bits, field_t zero_test = (low_bits * high_bits); zero_test.assert_is_not_zero(); - const auto low_wnaf = plonk::stdlib::schnorr::convert_field_into_wnaf(context, low_bits); - const auto high_wnaf = plonk::stdlib::schnorr::convert_field_into_wnaf(context, high_bits); + const auto low_wnaf = proof_system::plonk::stdlib::schnorr::convert_field_into_wnaf(context, low_bits); + const auto high_wnaf = proof_system::plonk::stdlib::schnorr::convert_field_into_wnaf(context, high_bits); // current_accumulator is pub_key, so init is true, so high_output is [high_wnaf]pub_key - point high_output = plonk::stdlib::schnorr::variable_base_mul(pub_key, pub_key, high_wnaf); + point high_output = proof_system::plonk::stdlib::schnorr::variable_base_mul(pub_key, pub_key, high_wnaf); // compute output = [low_wnaf]pub_key + [2^128]high_output. - point output = plonk::stdlib::schnorr::variable_base_mul(pub_key, high_output, low_wnaf); + point output = proof_system::plonk::stdlib::schnorr::variable_base_mul(pub_key, high_output, low_wnaf); return output; } @@ -376,4 +376,4 @@ template signature_bits convert_signature convert_signature void blake2s(blake2s_state& S, byte_array template byte_array blake2s(const byte_array& input) { - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { return blake2s_plookup::blake2s(input); } @@ -144,4 +144,4 @@ template byte_array blake2s(const byte_array blake2s(const byte_array& input); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.hpp b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.hpp index 242fbbc607..aeaf759b6c 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.hpp +++ b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.hpp @@ -1,13 +1,13 @@ #pragma once #include "barretenberg/stdlib/primitives/byte_array/byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { class StandardComposer; class TurboComposer; class UltraComposer; -} // namespace plonk +} // namespace proof_system::plonk -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template byte_array blake2s(const byte_array& input); @@ -17,4 +17,4 @@ extern template byte_array blake2s(const byte_array blake2s(const byte_array& input); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp index ac920961f9..387b42ddf2 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp @@ -5,9 +5,9 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; typedef stdlib::byte_array byte_array; typedef stdlib::byte_array byte_array_plookup; typedef stdlib::public_witness_t public_witness_t; @@ -39,7 +39,7 @@ TEST(stdlib_blake2s, test_single_block) TEST(stdlib_blake2s, test_single_block_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::string input = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz01"; std::vector input_v(input.begin(), input.end()); @@ -87,7 +87,7 @@ TEST(stdlib_blake2s, test_double_block) TEST(stdlib_blake2s, test_double_block_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::string input = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz0123456789"; std::vector input_v(input.begin(), input.end()); diff --git a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s_plookup.cpp b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s_plookup.cpp index c967769cea..3fad189ef2 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s_plookup.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s_plookup.cpp @@ -16,7 +16,7 @@ * 2. replace use of uint32 with basic field_t type * **/ -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace blake2s_plookup { @@ -171,4 +171,4 @@ template byte_array blake2s(const byte_array blake2s(const byte_array state[BLAKE3_STATE_SIZE], } // namespace blake_util } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp index 5d2a7b1517..a9e85132d0 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp @@ -5,7 +5,7 @@ #include "barretenberg/stdlib/primitives/uint/uint.hpp" #include "../blake2s/blake_util.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace blake3_internal { @@ -246,7 +246,7 @@ using namespace blake3_internal; template byte_array blake3s(const byte_array& input) { - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { return blake3s_plookup::blake3s(input); } @@ -264,4 +264,4 @@ template byte_array blake3s(const byte_array blake3s(const byte_array& input); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.hpp b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.hpp index 70e4c14b2e..79e265586a 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.hpp +++ b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.hpp @@ -1,12 +1,12 @@ #pragma once #include "barretenberg/stdlib/primitives/byte_array/byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { class TurboComposer; class UltraComposer; -} // namespace plonk +} // namespace proof_system::plonk -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template byte_array blake3s(const byte_array& input); @@ -16,4 +16,4 @@ extern template byte_array blake3s(const byte_array blake3s(const byte_array& input); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.test.cpp b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.test.cpp index 3b9db59eec..583bd87db4 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.test.cpp @@ -6,9 +6,9 @@ #include "barretenberg/plonk/composer/ultra_composer.hpp" using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; -typedef plonk::TurboComposer Composer; +typedef proof_system::plonk::TurboComposer Composer; typedef stdlib::byte_array byte_array; typedef stdlib::byte_array byte_array_plookup; typedef stdlib::public_witness_t public_witness_t; @@ -52,7 +52,7 @@ TEST(stdlib_blake3s, test_single_block) TEST(stdlib_blake3s, test_single_block_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::string input = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz01"; std::vector input_v(input.begin(), input.end()); @@ -100,7 +100,7 @@ TEST(stdlib_blake3s, test_double_block) TEST(stdlib_blake3s, test_double_block_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::string input = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz0123456789"; std::vector input_v(input.begin(), input.end()); diff --git a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s_plookup.cpp b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s_plookup.cpp index b27c488bea..3253483722 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s_plookup.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s_plookup.cpp @@ -8,7 +8,7 @@ #include "barretenberg/stdlib/primitives/uint/uint.hpp" #include "barretenberg/stdlib/primitives/plookup/plookup.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace blake3s_plookup { @@ -264,4 +264,4 @@ template byte_array blake3s(const byte_array blake3s(const byte_array stdlib::byte_array keccak::hash template class keccak; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/keccak/keccak.hpp b/cpp/src/barretenberg/stdlib/hash/keccak/keccak.hpp index 5c8423a03f..ec52db7fab 100644 --- a/cpp/src/barretenberg/stdlib/hash/keccak/keccak.hpp +++ b/cpp/src/barretenberg/stdlib/hash/keccak/keccak.hpp @@ -4,11 +4,11 @@ #include "barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.hpp" #include "barretenberg/stdlib/primitives/byte_array/byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { class UltraComposer; -} // namespace plonk +} // namespace proof_system::plonk -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class bit_array; @@ -186,4 +186,4 @@ template class keccak { extern template class keccak; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp b/cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp index 5a914402c8..589d14dd0e 100644 --- a/cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp @@ -6,9 +6,9 @@ #include "../../primitives/plookup/plookup.hpp" using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; -typedef plonk::UltraComposer Composer; +typedef proof_system::plonk::UltraComposer Composer; typedef stdlib::byte_array byte_array; typedef stdlib::public_witness_t public_witness_t; typedef stdlib::field_t field_ct; diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.bench.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.bench.cpp index 1f330830d0..5fd4073dea 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.bench.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.bench.cpp @@ -43,7 +43,7 @@ void generate_test_pedersen_circuit(plonk::TurboComposer& turbo_composer, size_t plonk::stdlib::witness_t(&turbo_composer, barretenberg::fr::random_element())); for (size_t i = 0; i < num_repetitions; ++i) { - out = plonk::stdlib::pedersen::compress(left, out); + out = proof_system::plonk::stdlib::pedersen::compress(left, out); } } diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp index 3933d85893..39202840f3 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp @@ -7,12 +7,12 @@ #include "../../primitives/composers/composers.hpp" #include "../../primitives/packed_byte_array/packed_byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { using namespace barretenberg; using namespace crypto::pedersen; -using namespace bonk; +using namespace proof_system; namespace { /** @@ -225,8 +225,8 @@ point pedersen::hash_single(const field_t& in, if (i > 0) { gates.create_fixed_group_add_gate(round_quad); } else { - if constexpr (C::type == bonk::ComposerType::PLOOKUP && - C::merkle_hash_type == plonk::MerkleHashType::FIXED_BASE_PEDERSEN) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP && + C::merkle_hash_type == proof_system::plonk::MerkleHashType::FIXED_BASE_PEDERSEN) { /* In TurboComposer, the selector q_5 is used to show that w_1 and w_2 are properly initialized to the * coordinates of P_s = (-s + 4^n)[g]. In UltraPlonK, we have removed q_5 for overall efficiency (it * would only be used here in this gate), but this presents us a cost in the present circuit: we must @@ -463,7 +463,7 @@ template void pedersen::validate_wnaf_is_in_field(C* ctx, const field_t y_lo = (-reconstructed_input).add_two(high_limb_with_skew * shift + (r_lo + shift), is_even); field_t y_overlap; - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { // carve out the 2 high bits from y_lo and instantiate as y_overlap const uint256_t y_lo_value = y_lo.get_value(); const uint256_t y_overlap_value = y_lo_value >> 126; @@ -577,4 +577,4 @@ template class pedersen; template class pedersen; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp index 1f8b1afd52..d428cd8eab 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp @@ -5,17 +5,17 @@ #include "../../primitives/point/point.hpp" #include "../../primitives/byte_array/byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { constexpr uint64_t WNAF_MASK = crypto::pedersen::WNAF_MASK; template class pedersen { private: - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::point point; - typedef plonk::stdlib::byte_array byte_array; - typedef plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::point point; + typedef proof_system::plonk::stdlib::byte_array byte_array; + typedef proof_system::plonk::stdlib::bool_t bool_t; static point hash_single(const field_t& in, const crypto::pedersen::generator_index_t hash_index, @@ -54,4 +54,4 @@ extern template class pedersen; extern template class pedersen; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp index 725d09752f..1dc5d64192 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp @@ -9,7 +9,7 @@ namespace test_stdlib_pedersen { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace { auto& engine = numeric::random::get_debug_engine(); } @@ -454,7 +454,7 @@ typedef stdlib::field_t field_ct; typedef stdlib::witness_t witness_ct; TEST(stdlib_pedersen, test_pedersen_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); fr left_in = fr::random_element(); fr right_in = fr::random_element(); @@ -481,7 +481,7 @@ TEST(stdlib_pedersen, test_pedersen_plookup) TEST(stdlib_pedersen, test_compress_many_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::vector input_values{ fr::random_element(), fr::random_element(), fr::random_element(), @@ -513,7 +513,7 @@ TEST(stdlib_pedersen, test_compress_many_plookup) TEST(stdlib_pedersen, test_merkle_damgard_compress_plookup) { - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); std::vector input_values{ fr::random_element(), fr::random_element(), fr::random_element(), diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp index 9c1ca282ae..6f23139529 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp @@ -5,7 +5,7 @@ #include "../../primitives/point/point.hpp" #include "../../primitives/byte_array/byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -22,10 +22,10 @@ namespace stdlib { */ template class pedersen_gates { public: - using fixed_group_add_quad = bonk::fixed_group_add_quad; - using fixed_group_init_quad = bonk::fixed_group_init_quad; - using add_quad = bonk::add_quad; - using ComposerType = bonk::ComposerType; + using fixed_group_add_quad = proof_system::fixed_group_add_quad; + using fixed_group_init_quad = proof_system::fixed_group_init_quad; + using add_quad = proof_system::add_quad; + using ComposerType = proof_system::ComposerType; Composer* context; fixed_group_add_quad previous_add_quad; @@ -36,7 +36,7 @@ template class pedersen_gates { void create_fixed_group_add_gate(const fixed_group_add_quad& in) { - if constexpr (Composer::type == bonk::ComposerType::TURBO) { + if constexpr (Composer::type == proof_system::ComposerType::TURBO) { context->create_fixed_group_add_gate(in); } else { @@ -229,7 +229,7 @@ template class pedersen_gates { void create_fixed_group_add_gate_with_init(const fixed_group_add_quad& in, const fixed_group_init_quad& init) { - if constexpr (Composer::type == bonk::ComposerType::TURBO) { + if constexpr (Composer::type == proof_system::ComposerType::TURBO) { context->create_fixed_group_add_gate_with_init(in, init); } else { uint32_t x_0_idx = in.a; @@ -295,7 +295,7 @@ template class pedersen_gates { void create_fixed_group_add_gate_final(const add_quad& in) { - if constexpr (Composer::type == bonk::ComposerType::TURBO) { + if constexpr (Composer::type == proof_system::ComposerType::TURBO) { context->create_fixed_group_add_gate_final(in); } else { @@ -313,4 +313,4 @@ template class pedersen_gates { }; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.cpp index f2f3d85148..d7c062d77f 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.cpp @@ -6,9 +6,9 @@ #include "../../primitives/composers/composers.hpp" #include "../../primitives/plookup/plookup.hpp" -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { using namespace barretenberg; @@ -168,4 +168,4 @@ field_t pedersen_plookup::compress(const std::vector& inputs, con template class pedersen_plookup; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp index bc01ff94a8..5b10abe606 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp @@ -4,15 +4,15 @@ #include "../../primitives/point/point.hpp" #include "../../primitives/packed_byte_array/packed_byte_array.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class pedersen_plookup { private: - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::point point; - typedef plonk::stdlib::packed_byte_array packed_byte_array; - typedef plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::point point; + typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array; + typedef proof_system::plonk::stdlib::bool_t bool_t; enum AddType { LAMBDA, @@ -43,4 +43,4 @@ template class pedersen_plookup { extern template class pedersen_plookup; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.bench.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.bench.cpp index 00d00082e1..1c5947c669 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.bench.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.bench.cpp @@ -5,7 +5,7 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace benchmark; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; constexpr size_t NUM_HASHES = 8; constexpr size_t BYTES_PER_CHUNK = 512; diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp index e936fd26be..35863d05d2 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp @@ -5,7 +5,7 @@ #include "barretenberg/plonk/composer/ultra_composer.hpp" #include "barretenberg/stdlib/primitives/bit_array/bit_array.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace internal { constexpr uint32_t init_constants[8]{ 0x6a09e667, 0xbb67ae85, 0x3c6ef372, 0xa54ff53a, @@ -139,7 +139,7 @@ template byte_array sha256_block(const byte_array< template packed_byte_array sha256(const packed_byte_array& input) { - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { return sha256_plookup::sha256(input); } typedef field_t field_pt; @@ -186,4 +186,4 @@ template packed_byte_array sha256(const packed_byte_arr template packed_byte_array sha256(const packed_byte_array& input); template packed_byte_array sha256(const packed_byte_array& input); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.hpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.hpp index ec30872a8f..57ec0a7253 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.hpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.hpp @@ -6,13 +6,13 @@ #include "sha256_plookup.hpp" -namespace plonk { +namespace proof_system::plonk { class UltraComposer; class StandardComposer; class TurboComposer; -} // namespace plonk +} // namespace proof_system::plonk -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class bit_array; @@ -41,4 +41,4 @@ extern template packed_byte_array sha256( extern template packed_byte_array sha256(const packed_byte_array& input); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp index b9d9d3add7..fae71f980c 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp @@ -16,7 +16,7 @@ auto& engine = numeric::random::get_debug_engine(); namespace test_stdlib_sha256 { using namespace barretenberg; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; constexpr uint64_t ror(uint64_t val, uint64_t shift) { @@ -111,7 +111,7 @@ std::array inner_block(std::array& w) TEST(stdlib_sha256, test_duplicate_proving_key) { - plonk::StandardComposer first_composer = plonk::StandardComposer(); + plonk::StandardComposer first_composer = proof_system::plonk::StandardComposer(); stdlib::packed_byte_array input(&first_composer, "An 8 character password? Snow White and the 7 Dwarves.."); plonk::stdlib::sha256(input); auto prover = first_composer.create_prover(); @@ -124,7 +124,8 @@ TEST(stdlib_sha256, test_duplicate_proving_key) auto circuit_size = prover.circuit_size; // Test a second time with same keys and different input. - plonk::StandardComposer second_composer = plonk::StandardComposer(proving_key, verification_key, circuit_size); + plonk::StandardComposer second_composer = + proof_system::plonk::StandardComposer(proving_key, verification_key, circuit_size); stdlib::packed_byte_array input2(&second_composer, "An 8 character password? Snow White and the 9 Dwarves.."); plonk::stdlib::sha256(input2); auto second_prover = second_composer.create_prover(); @@ -137,14 +138,15 @@ TEST(stdlib_sha256, test_duplicate_proving_key) // TEST(stdlib_sha256_plookup, test_round) // { -// plonk::UltraComposer composer = plonk::UltraComposer(); +// plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); // std::array w_inputs; // std::array, 64> w_elements; // for (size_t i = 0; i < 64; ++i) { // w_inputs[i] = engine.get_random_uint32(); -// w_elements[i] = plonk::stdlib::witness_t(&composer, barretenberg::fr(w_inputs[i])); +// w_elements[i] = proof_system::plonk::stdlib::witness_t(&composer, +// barretenberg::fr(w_inputs[i])); // } // const auto expected = inner_block(w_inputs); @@ -167,15 +169,15 @@ TEST(stdlib_sha256, test_duplicate_proving_key) TEST(stdlib_sha256, test_plookup_55_bytes) { - typedef plonk::stdlib::field_t field_pt; - typedef plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef proof_system::plonk::stdlib::field_t field_pt; + typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; // 55 bytes is the largest number of bytes that can be hashed in a single block, // accounting for the single padding bit, and the 64 size bits required by the SHA-256 standard. - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); packed_byte_array_pt input(&composer, "An 8 character password? Snow White and the 7 Dwarves.."); - packed_byte_array_pt output_bits = plonk::stdlib::sha256(input); + packed_byte_array_pt output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -206,7 +208,7 @@ TEST(stdlib_sha256, test_55_bytes) Composer composer = Composer(); packed_byte_array_ct input(&composer, "An 8 character password? Snow White and the 7 Dwarves.."); - packed_byte_array_ct output_bits = plonk::stdlib::sha256(input); + packed_byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -232,13 +234,13 @@ TEST(stdlib_sha256, test_55_bytes) TEST(stdlib_sha256, test_NIST_vector_one_packed_byte_array) { - typedef plonk::stdlib::field_t field_pt; - typedef plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef proof_system::plonk::stdlib::field_t field_pt; + typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); packed_byte_array_pt input(&composer, "abc"); - packed_byte_array_pt output_bytes = plonk::stdlib::sha256(input); + packed_byte_array_pt output_bytes = proof_system::plonk::stdlib::sha256(input); std::vector output = output_bytes.to_unverified_byte_slices(4); EXPECT_EQ(uint256_t(output[0].get_value()).data[0], (uint64_t)0xBA7816BFU); EXPECT_EQ(uint256_t(output[1].get_value()).data[0], (uint64_t)0x8F01CFEAU); @@ -263,14 +265,14 @@ TEST(stdlib_sha256, test_NIST_vector_one_packed_byte_array) TEST(stdlib_sha256, test_NIST_vector_one) { - typedef plonk::stdlib::field_t field_pt; - typedef plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef proof_system::plonk::stdlib::field_t field_pt; + typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); packed_byte_array_pt input(&composer, "abc"); - packed_byte_array_pt output_bits = plonk::stdlib::sha256(input); + packed_byte_array_pt output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -301,7 +303,7 @@ TEST(stdlib_sha256, test_NIST_vector_two) byte_array_ct input(&composer, "abcdbcdecdefdefgefghfghighijhijkijkljklmklmnlmnomnopnopq"); - byte_array_ct output_bits = plonk::stdlib::sha256(input); + byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = packed_byte_array_ct(output_bits).to_unverified_byte_slices(4); @@ -333,7 +335,7 @@ TEST(stdlib_sha256, test_NIST_vector_three) // one byte, 0xbd byte_array_ct input(&composer, std::vector{ 0xbd }); - byte_array_ct output_bits = plonk::stdlib::sha256(input); + byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = packed_byte_array_ct(output_bits).to_unverified_byte_slices(4); @@ -364,7 +366,7 @@ TEST(stdlib_sha256, test_NIST_vector_four) // 4 bytes, 0xc98c8e55 byte_array_ct input(&composer, std::vector{ 0xc9, 0x8c, 0x8e, 0x55 }); - byte_array_ct output_bits = plonk::stdlib::sha256(input); + byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = packed_byte_array_ct(output_bits).to_unverified_byte_slices(4); @@ -390,10 +392,10 @@ TEST(stdlib_sha256, test_NIST_vector_four) HEAVY_TEST(stdlib_sha256, test_NIST_vector_five) { - typedef plonk::stdlib::field_t field_pt; - typedef plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef proof_system::plonk::stdlib::field_t field_pt; + typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); packed_byte_array_pt input( &composer, @@ -408,7 +410,7 @@ HEAVY_TEST(stdlib_sha256, test_NIST_vector_five) "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA" "AAAAAAAAAA"); - packed_byte_array_pt output_bits = plonk::stdlib::sha256(input); + packed_byte_array_pt output_bits = proof_system::plonk::stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -442,7 +444,7 @@ TEST(stdlib_sha256, test_input_len_multiple) auto input_buf = std::vector(inp, 1); byte_array_ct input(&composer, input_buf); - byte_array_ct output_bits = plonk::stdlib::sha256(input); + byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); auto circuit_output = output_bits.get_value(); @@ -486,7 +488,7 @@ TEST(stdlib_sha256, test_input_str_len_multiple) auto input_buf = std::vector(input_str.begin(), input_str.end()); byte_array_ct input(&composer, input_buf); - byte_array_ct output_bits = plonk::stdlib::sha256(input); + byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); auto circuit_output = output_bits.get_value(); diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256_plookup.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256_plookup.cpp index c86ca33195..04a5632eab 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256_plookup.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256_plookup.cpp @@ -10,7 +10,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace sha256_plookup { @@ -361,4 +361,4 @@ packed_byte_array sha256(const packed_byte_array, 8> sha256_block(const std::array sha256(const packed_byte_array& input); } // namespace sha256_plookup } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/hash.hpp b/cpp/src/barretenberg/stdlib/merkle_tree/hash.hpp index 56af194120..c24ccf6059 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/hash.hpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/hash.hpp @@ -7,7 +7,7 @@ #include "barretenberg/stdlib/primitives/field/field.hpp" #include -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -28,4 +28,4 @@ inline barretenberg::fr compress_native(barretenberg::fr const& lhs, barretenber } // namespace merkle_tree } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/hash.test.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/hash.test.cpp index 34874b412c..dbe178c3ae 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/hash.test.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/hash.test.cpp @@ -4,14 +4,14 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace barretenberg; -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; TEST(stdlib_merkle_tree_hash, compress_native_vs_circuit) { fr x = uint256_t(0x5ec473eb273a8011, 0x50160109385471ca, 0x2f3095267e02607d, 0x02586f4a39e69b86); Composer composer = Composer(); witness_ct y = witness_ct(&composer, x); - field_ct z = plonk::stdlib::pedersen::compress(y, y); + field_ct z = proof_system::plonk::stdlib::pedersen::compress(y, y); auto zz = crypto::pedersen::compress_native({ x, x }); EXPECT_EQ(z.get_value(), zz); } diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/hash_path.hpp b/cpp/src/barretenberg/stdlib/merkle_tree/hash_path.hpp index 174db8b7e2..dbe62f2611 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/hash_path.hpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/hash_path.hpp @@ -4,7 +4,7 @@ #include "barretenberg/stdlib/primitives/field/field.hpp" #include -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -64,7 +64,7 @@ inline fr zero_hash_at_height(size_t height) } // namespace merkle_tree } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk // We add to std namespace as fr_hash_path is actually a std::vector, and this is the only way // to achieve effective ADL. diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/membership.hpp b/cpp/src/barretenberg/stdlib/merkle_tree/membership.hpp index 3273eefcf6..8b62921fbe 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/membership.hpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/membership.hpp @@ -4,7 +4,7 @@ #include "barretenberg/stdlib/primitives/byte_array/byte_array.hpp" #include "barretenberg/stdlib/primitives/field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -262,4 +262,4 @@ void batch_update_membership(field_t const& new_root, } // namespace merkle_tree } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/membership.test.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/membership.test.cpp index 0dee186932..53e43ff816 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/membership.test.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/membership.test.cpp @@ -6,8 +6,8 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace barretenberg; -using namespace plonk::stdlib::types; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::merkle_tree; TEST(stdlib_merkle_tree, test_check_membership) { diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/memory_store.hpp b/cpp/src/barretenberg/stdlib/merkle_tree/memory_store.hpp index f0b735a1e4..d1aad8b551 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/memory_store.hpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/memory_store.hpp @@ -4,7 +4,7 @@ #include #include -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -88,4 +88,4 @@ class MemoryStore { } // namespace merkle_tree } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.cpp index 331d5a2075..cdfacca7ff 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.cpp @@ -1,7 +1,7 @@ #include "memory_tree.hpp" #include "hash.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -59,4 +59,4 @@ fr MemoryTree::update_element(size_t index, fr const& value) } // namespace merkle_tree } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.hpp b/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.hpp index 792ac7dbb0..b0e2504c77 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.hpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.hpp @@ -1,7 +1,7 @@ #pragma once #include "hash_path.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -43,4 +43,4 @@ class MemoryTree { } // namespace merkle_tree } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.test.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.test.cpp index cdceef6ea4..08dfd18595 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.test.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/memory_tree.test.cpp @@ -3,7 +3,7 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace barretenberg; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::merkle_tree; static std::vector VALUES = []() { std::vector values(4); diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.bench.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.bench.cpp index 46a8ad9363..01d51b68c0 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.bench.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.bench.cpp @@ -5,7 +5,7 @@ #include "barretenberg/numeric/random/engine.hpp" using namespace benchmark; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::merkle_tree; namespace { auto& engine = numeric::random::get_debug_engine(); diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.cpp index f37ed0c901..23765f24ac 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.cpp @@ -8,7 +8,7 @@ #include "barretenberg/numeric/uint128/uint128.hpp" #include -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -292,4 +292,4 @@ template class MerkleTree; } // namespace merkle_tree } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.hpp b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.hpp index 4d34c41947..a5c1013581 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.hpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.hpp @@ -2,7 +2,7 @@ #include "hash_path.hpp" #include "barretenberg/stdlib/primitives/field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace merkle_tree { @@ -99,4 +99,4 @@ extern template class MerkleTree; } // namespace merkle_tree } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.test.cpp b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.test.cpp index 03e111b717..a4b3607be9 100644 --- a/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.test.cpp +++ b/cpp/src/barretenberg/stdlib/merkle_tree/merkle_tree.test.cpp @@ -7,7 +7,7 @@ #include "barretenberg/stdlib/types/types.hpp" using namespace barretenberg; -using namespace plonk::stdlib::merkle_tree; +using namespace proof_system::plonk::stdlib::merkle_tree; namespace { auto& engine = numeric::random::get_debug_engine(); diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.fuzzer.hpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.fuzzer.hpp index b7ede3f00b..f3caaa88c1 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.fuzzer.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.fuzzer.hpp @@ -119,11 +119,11 @@ FastRandom VarianceRNG(0); */ template class BigFieldBase { private: - typedef plonk::stdlib::bool_t bool_t; - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::witness_t witness_t; - typedef plonk::stdlib::public_witness_t public_witness_t; - typedef plonk::stdlib::bigfield bigfield_t; + typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::witness_t witness_t; + typedef proof_system::plonk::stdlib::public_witness_t public_witness_t; + typedef proof_system::plonk::stdlib::bigfield bigfield_t; public: /** diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.hpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.hpp index 86b0d3f91f..1552eb845a 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.hpp @@ -11,7 +11,7 @@ #include "../composers/composers_fwd.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class bigfield { @@ -496,6 +496,6 @@ template inline std::ostream& operator<<(std::ostream& } } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk #include "bigfield_impl.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.test.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.test.cpp index b6e5626b34..899b4cf4d5 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield.test.cpp @@ -22,7 +22,7 @@ namespace test_stdlib_bigfield { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; /* A note regarding Plookup: stdlib_bigfield_plookup tests were present when this file was standardized @@ -994,7 +994,7 @@ TYPED_TEST(stdlib_bigfield, division_context) // // PLOOKUP TESTS // TEST(stdlib_bigfield_plookup, test_mul) // { -// plonk::UltraComposer composer = plonk::UltraComposer(); +// plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); // size_t num_repetitions = 1; // for (size_t i = 0; i < num_repetitions; ++i) { // fq inputs[3]{ fq::random_element(), fq::random_element(), fq::random_element() }; @@ -1041,7 +1041,7 @@ TYPED_TEST(stdlib_bigfield, division_context) // TEST(stdlib_bigfield_plookup, test_sqr) // { -// plonk::UltraComposer composer = plonk::UltraComposer(); +// plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); // size_t num_repetitions = 10; // for (size_t i = 0; i < num_repetitions; ++i) { // fq inputs[3]{ fq::random_element(), fq::random_element(), fq::random_element() }; diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp index 2b974913c0..1640d10ec4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp index b070a6910e..33879aa4d1 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp @@ -11,7 +11,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -56,7 +56,7 @@ bigfield::bigfield(const field_t& low_bits_in, field_t limb_3(context); if (low_bits_in.witness_index != IS_CONSTANT) { std::vector low_accumulator; - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { // MERGE NOTE: this was the if constexpr block introduced in ecebe7643 const auto limb_witnesses = context->decompose_non_native_field_double_width_limb(low_bits_in.normalize().witness_index); @@ -107,7 +107,7 @@ bigfield::bigfield(const field_t& low_bits_in, if (high_bits_in.witness_index != IS_CONSTANT) { std::vector high_accumulator; - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { const auto limb_witnesses = context->decompose_non_native_field_double_width_limb( high_bits_in.normalize().witness_index, (size_t)num_high_limb_bits); limb_2.witness_index = limb_witnesses[0]; @@ -187,7 +187,7 @@ bigfield bigfield::create_from_u512_as_witness(C* ctx, limbs[2] = value.slice(NUM_LIMB_BITS * 2, NUM_LIMB_BITS * 3).lo; limbs[3] = value.slice(NUM_LIMB_BITS * 3, NUM_LIMB_BITS * 4).lo; - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { field_t limb_0(ctx); field_t limb_1(ctx); field_t limb_2(ctx); @@ -384,7 +384,7 @@ template bigfield bigfield::operator+(const result.binary_basis_limbs[3].maximum_value = binary_basis_limbs[3].maximum_value + other.binary_basis_limbs[3].maximum_value; - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { if (prime_basis_limb.multiplicative_constant == 1 && other.prime_basis_limb.multiplicative_constant == 1 && !is_constant() && !other.is_constant()) { bool limbconst = binary_basis_limbs[0].element.is_constant(); @@ -592,7 +592,7 @@ template bigfield bigfield::operator-(const result.binary_basis_limbs[2].element = binary_basis_limbs[2].element + barretenberg::fr(to_add_2); result.binary_basis_limbs[3].element = binary_basis_limbs[3].element + barretenberg::fr(to_add_3); - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { if (result.prime_basis_limb.multiplicative_constant == 1 && other.prime_basis_limb.multiplicative_constant == 1 && !result.is_constant() && !other.is_constant()) { bool limbconst = result.binary_basis_limbs[0].element.is_constant(); @@ -1645,7 +1645,7 @@ template void bigfield::assert_is_in_field() cons r1 = r1.normalize(); r2 = r2.normalize(); r3 = r3.normalize(); - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { context->decompose_into_default_range(r0.witness_index, static_cast(NUM_LIMB_BITS)); context->decompose_into_default_range(r1.witness_index, static_cast(NUM_LIMB_BITS)); context->decompose_into_default_range(r2.witness_index, static_cast(NUM_LIMB_BITS)); @@ -1778,7 +1778,7 @@ template void bigfield::self_reduce() const // TODO: implicit assumption here - NUM_LIMB_BITS large enough for all the quotient uint32_t quotient_limb_index = context->add_variable(barretenberg::fr(quotient_value.lo)); field_t quotient_limb = field_t::from_witness_index(context, quotient_limb_index); - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { context->decompose_into_default_range(quotient_limb.witness_index, static_cast(maximum_quotient_bits)); } else { context->decompose_into_base4_accumulators(quotient_limb.witness_index, @@ -1880,7 +1880,7 @@ void bigfield::unsafe_evaluate_multiply_add(const bigfield& input_left, ++max_hi_bits; } - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { // The plookup custom bigfield gate requires inputs are witnesses. // If we're using constant values, instantiate them as circuit variables const auto convert_constant_to_witness = [ctx](const bigfield& input) { @@ -2238,7 +2238,7 @@ void bigfield::unsafe_evaluate_multiple_multiply_add(const std::vector::unsafe_evaluate_multiple_multiply_add(const std::vectordecompose_into_default_range(lo.normalize().witness_index, carry_lo_msb); } /* NOTE TO AUDITOR: An extraneous block - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { carry_lo = carry_lo.normalize(); carry_hi = carry_hi.normalize(); ctx->decompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2604,7 +2604,7 @@ void bigfield::unsafe_evaluate_multiple_multiply_add(const std::vectordecompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2643,7 +2643,7 @@ void bigfield::unsafe_evaluate_square_add(const bigfield& left, const bigfield& quotient, const bigfield& remainder) { - if (C::type == bonk::ComposerType::PLOOKUP) { + if (C::type == proof_system::ComposerType::PLOOKUP) { unsafe_evaluate_multiply_add(left, left, to_add, quotient, { remainder }); return; } @@ -2764,7 +2764,7 @@ void bigfield::unsafe_evaluate_square_add(const bigfield& left, const uint64_t carry_hi_msb = max_hi_bits - (2 * NUM_LIMB_BITS); const barretenberg::fr carry_lo_shift(uint256_t(uint256_t(1) << carry_lo_msb)); - if constexpr (C::type == bonk::ComposerType::PLOOKUP) { + if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { carry_lo = carry_lo.normalize(); carry_hi = carry_hi.normalize(); ctx->decompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2863,4 +2863,4 @@ std::pair bigfield::get_quotient_reduction_info(const std::v } } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp index e3166bc0a6..ff5310e283 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp index c1494d6267..4b03fdb19b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp index aeec29d4d6..e0c68ce25d 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp @@ -14,7 +14,7 @@ #include "../composers/composers_fwd.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { // ( ͡° ͜ʖ ͡°) @@ -393,15 +393,15 @@ template class element { std::array, 5> coordinates; }; - using twin_lookup_table = typename std::conditional, lookup_table_base<2>>::type; - using triple_lookup_table = typename std::conditional, lookup_table_base<3>>::type; - using quad_lookup_table = typename std::conditional, lookup_table_base<4>>::type; @@ -416,7 +416,7 @@ template class element { quad_lookup_table endo_table; uint256_t beta_val = barretenberg::field::cube_root_of_unity(); Fq beta(barretenberg::fr(beta_val.slice(0, 136)), barretenberg::fr(beta_val.slice(136, 256)), false); - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { for (size_t i = 0; i < 8; ++i) { endo_table.element_table[i + 8].x = base_table[7 - i].x * beta; endo_table.element_table[i + 8].y = base_table[7 - i].y; @@ -449,7 +449,7 @@ template class element { lookup_table_plookup<5> endo_table; uint256_t beta_val = barretenberg::field::cube_root_of_unity(); Fq beta(barretenberg::fr(beta_val.slice(0, 136)), barretenberg::fr(beta_val.slice(136, 256)), false); - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { for (size_t i = 0; i < 16; ++i) { endo_table.element_table[i + 16].x = base_table[15 - i].x * beta; endo_table.element_table[i + 16].y = base_table[15 - i].y; @@ -938,7 +938,7 @@ template class element { bool has_singleton; }; - using batch_lookup_table = typename std::conditional, batch_lookup_table_base>::type; }; @@ -949,7 +949,7 @@ inline std::ostream& operator<<(std::ostream& os, element const& v return os << "{ " << v.x << " , " << v.y << " }"; } } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk #include "biggroup_nafs.hpp" #include "biggroup_tables.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp index d3ce8aaceb..3ea4326238 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp @@ -20,7 +20,7 @@ auto& engine = numeric::random::get_debug_engine(); } // using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; // One can only define a TYPED_TEST with a single template paramter. // Our workaround is to pass parameters of the following type. @@ -900,7 +900,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, double_montgomery_ladder) HEAVY_TYPED_TEST(stdlib_biggroup, compute_naf) { // ULTRATODO: make this work for secp curves - if constexpr (TypeParam::Curve::type == bonk::CurveType::BN254) { + if constexpr (TypeParam::Curve::type == proof_system::CurveType::BN254) { size_t num_repetitions = 1; for (size_t i = 0; i < num_repetitions; i++) { TestFixture::test_compute_naf(); @@ -913,7 +913,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, compute_naf) /* These tests only work for UltraComposer */ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_mul) { - if constexpr (TypeParam::Curve::Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (TypeParam::Curve::Composer::type == proof_system::ComposerType::PLOOKUP) { TestFixture::test_compute_wnaf(); } else { GTEST_SKIP(); @@ -924,7 +924,8 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_mul) Fr is a bigfield. */ HEAVY_TYPED_TEST(stdlib_biggroup, compute_wnaf) { - if constexpr (TypeParam::Curve::Composer::type != plonk::UltraComposer::type && TypeParam::use_bigfield) { + if constexpr (TypeParam::Curve::Composer::type != proof_system::plonk::UltraComposer::type && + TypeParam::use_bigfield) { GTEST_SKIP(); } else { TestFixture::test_compute_wnaf(); @@ -961,7 +962,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_4) /* The following tests are specific to BN254 and don't work when Fr is a bigfield */ HEAVY_TYPED_TEST(stdlib_biggroup, bn254_endo_batch_mul) { - if constexpr (TypeParam::Curve::type == bonk::CurveType::BN254 && !TypeParam::use_bigfield) { + if constexpr (TypeParam::Curve::type == proof_system::CurveType::BN254 && !TypeParam::use_bigfield) { TestFixture::test_bn254_endo_batch_mul(); } else { GTEST_SKIP(); @@ -969,7 +970,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, bn254_endo_batch_mul) } HEAVY_TYPED_TEST(stdlib_biggroup, mixed_mul_bn254_endo) { - if constexpr (TypeParam::Curve::type == bonk::CurveType::BN254 && !TypeParam::use_bigfield) { + if constexpr (TypeParam::Curve::type == proof_system::CurveType::BN254 && !TypeParam::use_bigfield) { TestFixture::test_mixed_mul_bn254_endo(); } else { GTEST_SKIP(); @@ -979,7 +980,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, mixed_mul_bn254_endo) /* The following tests are specific to SECP256k1 */ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_secp256k1) { - if constexpr (TypeParam::Curve::type == bonk::CurveType::SECP256K1) { + if constexpr (TypeParam::Curve::type == proof_system::CurveType::SECP256K1) { TestFixture::test_wnaf_secp256k1(); } else { GTEST_SKIP(); @@ -987,7 +988,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_secp256k1) } HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_8bit_secp256k1) { - if constexpr (TypeParam::Curve::type == bonk::CurveType::SECP256K1) { + if constexpr (TypeParam::Curve::type == proof_system::CurveType::SECP256K1) { TestFixture::test_wnaf_8bit_secp256k1(); } else { GTEST_SKIP(); @@ -995,7 +996,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_8bit_secp256k1) } HEAVY_TYPED_TEST(stdlib_biggroup, ecdsa_mul_secp256k1) { - if constexpr (TypeParam::Curve::type == bonk::CurveType::SECP256K1) { + if constexpr (TypeParam::Curve::type == proof_system::CurveType::SECP256K1) { TestFixture::test_ecdsa_mul_secp256k1(); } else { GTEST_SKIP(); diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp index 0e6a060304..e0787df4b9 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp @@ -1,6 +1,6 @@ #pragma once -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -15,7 +15,7 @@ element element::wnaf_batch_mul(const std::vector element::wnaf_batch_mul(const std::vector element::bn254_endo_batch_mul_with_generator break; } } - if constexpr (C::type != bonk::ComposerType::PLOOKUP) { + if constexpr (C::type != proof_system::ComposerType::PLOOKUP) { // MERGENOTE: these four lines don't have an equivalent in d-b-p std::vector modified_big_points = big_points; std::vector modified_big_scalars = big_scalars; @@ -422,4 +422,4 @@ element element::bn254_endo_batch_mul(const std::vec return accumulator; } } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp index ea107e2300..78d6f37855 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp @@ -11,7 +11,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -660,4 +660,4 @@ element element::operator*(const Fr& scalar) const return element(out_x, out_y) - element(offset_generators.second); } } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_nafs.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_nafs.hpp index 71cd984c30..63257d5687 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_nafs.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_nafs.hpp @@ -1,7 +1,7 @@ #pragma once #include "barretenberg/ecc/curves/secp256k1/secp256k1.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -548,4 +548,4 @@ std::vector> element::compute_naf(const Fr& scalar, cons return naf_entries; } } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp index 96bbbd9d7f..a003cc18d2 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp @@ -5,14 +5,14 @@ * TODO: we should try to genericize this, but this method is super fiddly and we need it to be efficient! * **/ -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template template element element::secp256k1_ecdsa_mul(const element& pubkey, const Fr& u1, const Fr& u2) { - if constexpr (C::type != bonk::ComposerType::PLOOKUP) { + if constexpr (C::type != proof_system::ComposerType::PLOOKUP) { C* ctx = pubkey.get_context(); return batch_mul({ element::one(ctx), pubkey }, { u1, u2 }); } @@ -138,4 +138,4 @@ element element::secp256k1_ecdsa_mul(const element& return accumulator; } } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_tables.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_tables.hpp index e10ffdabc5..9fee073888 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_tables.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_tables.hpp @@ -1,5 +1,5 @@ #pragma once -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -583,4 +583,4 @@ element element::lookup_table_base::get( return element::one(bits[0].get_context()); } } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.cpp index 74dfad7126..b8f9dbc343 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.cpp @@ -3,7 +3,7 @@ #include -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -163,4 +163,4 @@ template std::string bit_array::get_ INSTANTIATE_STDLIB_TYPE(bit_array) } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.fuzzer.hpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.fuzzer.hpp index 2f1a1f6536..45a2b04ed4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.fuzzer.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.fuzzer.hpp @@ -30,8 +30,8 @@ FastRandom VarianceRNG(0); */ template class BitArrayFuzzBase { private: - typedef plonk::stdlib::bit_array bit_array_t; - typedef plonk::stdlib::byte_array byte_array_t; + typedef proof_system::plonk::stdlib::bit_array bit_array_t; + typedef proof_system::plonk::stdlib::byte_array byte_array_t; template static std::vector to_vector(std::array, NumWords>& a32) { diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.hpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.hpp index dde913c8b1..9cf0ac5a20 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.hpp @@ -4,7 +4,7 @@ #include "barretenberg/honk/composer/standard_honk_composer.hpp" #include -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class bit_array { @@ -185,4 +185,4 @@ EXTERN_STDLIB_TYPE(bit_array); extern template class bit_array; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.test.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.test.cpp index 56af6d4e66..54b4b7439b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array.test.cpp @@ -6,7 +6,7 @@ namespace test_stdlib_bit_array { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace { auto& engine = numeric::random::get_debug_engine(); @@ -21,7 +21,7 @@ typedef stdlib::byte_array byte_array; TEST(stdlib_bit_array, test_uint32_input_output_consistency) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); uint32_t a_expected = engine.get_random_uint32(); uint32_t b_expected = engine.get_random_uint32(); @@ -47,7 +47,7 @@ TEST(stdlib_bit_array, test_uint32_input_output_consistency) TEST(stdlib_bit_array, test_binary_input_output_consistency) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); bit_array test_bit_array = bit_array(&composer, 5); @@ -70,7 +70,7 @@ TEST(stdlib_bit_array, test_binary_input_output_consistency) TEST(stdlib_bit_array, test_string_input_output_consistency) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); std::string expected = "string literals inside a SNARK circuit? What nonsense!"; bit_array test_bit_array = bit_array(&composer, expected); @@ -82,7 +82,7 @@ TEST(stdlib_bit_array, test_string_input_output_consistency) TEST(stdlib_bit_array, test_byte_array_conversion) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); std::string expected = "string literals inside a SNARK circuit? What nonsense!"; bit_array test_bit_array = bit_array(&composer, expected); @@ -96,7 +96,7 @@ TEST(stdlib_bit_array, test_byte_array_conversion) TEST(stdlib_bit_array, test_uint32_vector_constructor) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); uint32_t a_expected = engine.get_random_uint32(); uint32_t b_expected = engine.get_random_uint32(); diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp index 1f05fa7138..3a86b2c975 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp index 80efa2b4ce..c5bfb25570 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp index 3551217b7b..c79b7a7c64 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool.cpp index 46c29f632d..204b20790e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool.cpp @@ -3,9 +3,9 @@ #include "barretenberg/honk/composer/standard_honk_composer.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -474,4 +474,4 @@ template bool_t bool_t class BoolFuzzBase { private: - typedef plonk::stdlib::bool_t bool_t; - typedef plonk::stdlib::witness_t witness_t; + typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::witness_t witness_t; public: /** diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool.hpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool.hpp index 87eec13232..86ddee1e4a 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool.hpp @@ -3,7 +3,7 @@ #include "../witness/witness.hpp" #include "barretenberg/honk/composer/standard_honk_composer.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class bool_t { @@ -77,4 +77,4 @@ EXTERN_STDLIB_TYPE(bool_t); extern template class bool_t; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp index 015e7d5e87..bd0d877e45 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp @@ -6,14 +6,14 @@ namespace test_stdlib_bool { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; typedef stdlib::bool_t bool_t; typedef stdlib::witness_t witness_t; TEST(stdlib_bool, test_basic_operations) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); bool_t a(&composer); bool_t b(&composer); a = stdlib::witness_t(&composer, barretenberg::fr::one()); @@ -26,7 +26,7 @@ TEST(stdlib_bool, test_basic_operations) bool_t f = e ^ b; // f = 0 d = (!f) & a; // d = 1 auto prover = composer.create_prover(); - // if constexpr (Composer::type == bonk::ComposerType::STANDARD_HONK) { + // if constexpr (Composer::type == proof_system::ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[0][3], fr(1)); EXPECT_EQ(prover.wire_polynomials[1][3], fr(1)); EXPECT_EQ(prover.wire_polynomials[2][3], fr(1)); @@ -70,7 +70,7 @@ TEST(stdlib_bool, test_basic_operations) TEST(stdlib_bool, xor) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t j = 0; j < 4; ++j) { bool lhs_constant = (bool)(j % 2); bool rhs_constant = (bool)(j > 1 ? true : false); @@ -95,7 +95,7 @@ TEST(stdlib_bool, xor) TEST(stdlib_bool, xor_constants) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t i = 0; i < 32; ++i) { bool_t a = witness_t(&composer, (bool)(i % 2)); bool_t b = witness_t(&composer, (bool)(i % 3 == 1)); @@ -123,7 +123,7 @@ TEST(stdlib_bool, xor_constants) TEST(stdlib_bool, xor_twin_constants) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); bool_t c; for (size_t i = 0; i < 32; ++i) { bool_t a(&composer, (i % 1) == 0); @@ -153,7 +153,7 @@ TEST(stdlib_bool, xor_twin_constants) // TEST(stdlib_bool, logical_and) // { -// honk::StandardHonkComposer composer = honk::StandardHonkComposer(); +// honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); // bool_t a = witness_t(&composer, 1); // bool_t b = witness_t(&composer, 1); // (!a) && (!b); @@ -169,7 +169,7 @@ TEST(stdlib_bool, xor_twin_constants) TEST(stdlib_bool, and) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t i = 0; i < 32; ++i) { bool_t a = witness_t(&composer, (bool)(i % 1)); bool_t b = witness_t(&composer, (bool)(i % 2 == 1)); @@ -186,7 +186,7 @@ TEST(stdlib_bool, and) TEST(stdlib_bool, and_constants) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t i = 0; i < 32; ++i) { bool_t a = witness_t(&composer, (bool)(i % 2)); bool_t b = witness_t(&composer, (bool)(i % 3 == 1)); @@ -214,7 +214,7 @@ TEST(stdlib_bool, and_constants) TEST(stdlib_bool, or) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t i = 0; i < 32; ++i) { bool_t a = witness_t(&composer, (bool)(i % 2)); bool_t b = witness_t(&composer, (bool)(i % 3 == 1)); @@ -231,7 +231,7 @@ TEST(stdlib_bool, or) TEST(stdlib_bool, or_constants) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t i = 0; i < 32; ++i) { bool_t a = witness_t(&composer, (bool)(i % 2)); bool_t b = witness_t(&composer, (bool)(i % 3 == 1)); @@ -259,7 +259,7 @@ TEST(stdlib_bool, or_constants) TEST(stdlib_bool, eq) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); bool a_alt[32]; bool b_alt[32]; bool c_alt[32]; @@ -311,7 +311,7 @@ TEST(stdlib_bool, eq) TEST(stdlib_bool, implies) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t j = 0; j < 4; ++j) { bool lhs_constant = (bool)(j % 2); bool rhs_constant = (bool)(j > 1 ? true : false); @@ -336,7 +336,7 @@ TEST(stdlib_bool, implies) TEST(stdlib_bool, implies_both_ways) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); for (size_t j = 0; j < 4; ++j) { bool lhs_constant = (bool)(j % 2); bool rhs_constant = (bool)(j > 1 ? true : false); @@ -361,7 +361,7 @@ TEST(stdlib_bool, implies_both_ways) TEST(stdlib_bool, test_simple_proof) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); bool_t a(&composer); bool_t b(&composer); a = stdlib::witness_t(&composer, barretenberg::fr::one()); @@ -395,7 +395,7 @@ TEST(stdlib_bool, test_simple_proof) TEST(stdlib_bool, normalize) { - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); auto generate_constraints = [&composer](bool value, bool is_constant, bool is_inverted) { bool_t a = is_constant ? bool_t(&composer, value) : witness_t(&composer, value); diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp index c60eda71bd..252abe30ce 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp index 866efbe050..718e749aaf 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp index 9493733b5d..a63b35aec6 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp index 5fdd63f342..5c5abda2c1 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp @@ -6,7 +6,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { // ULTRA: Further merging with @@ -129,7 +129,7 @@ template byte_array::byte_array(const field_t y_lo = (-validator) + (s_lo + shift); field_t y_overlap; - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { // carve out the 2 high bits from (y_lo + shifted_high_limb) and instantiate as y_overlap const uint256_t y_lo_value = y_lo.get_value() + shifted_high_limb.get_value(); const uint256_t y_overlap_value = y_lo_value >> 128; @@ -383,4 +383,4 @@ typename byte_array::byte_slice byte_array::split_byte(const INSTANTIATE_STDLIB_TYPE(byte_array); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.fuzzer.hpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.fuzzer.hpp index d0bef67e52..5eda8ad5c1 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.fuzzer.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.fuzzer.hpp @@ -31,9 +31,9 @@ FastRandom VarianceRNG(0); */ template class ByteArrayFuzzBase { private: - typedef plonk::stdlib::byte_array byte_array_t; - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::safe_uint_t suint_t; + typedef proof_system::plonk::stdlib::byte_array byte_array_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::safe_uint_t suint_t; template static To from_to(const From& in, const std::optional size = std::nullopt) { diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.hpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.hpp index 2f0b8a676c..44675d51cc 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.hpp @@ -4,7 +4,7 @@ #include "../field/field.hpp" #include "../safe_uint/safe_uint.hpp" #include "barretenberg/honk/composer/standard_honk_composer.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class byte_array { @@ -106,4 +106,4 @@ EXTERN_STDLIB_TYPE(byte_array); extern template class byte_array; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.test.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.test.cpp index f0ebaa919a..bcd0631bc2 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.test.cpp @@ -7,7 +7,7 @@ // ULTRATODO: make these typed tests namespace test_stdlib_byte_array { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; typedef honk::StandardHonkComposer Composer; typedef stdlib::bool_t bool_t; typedef stdlib::field_t field_t; diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp index 24cf051f52..a0cb861f86 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp index 49aeb4eab4..2d82c10698 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp index 45657a00f6..1eca2596fb 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/composers/composers_fwd.hpp b/cpp/src/barretenberg/stdlib/primitives/composers/composers_fwd.hpp index 34246ac63c..8f3b986dbb 100644 --- a/cpp/src/barretenberg/stdlib/primitives/composers/composers_fwd.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/composers/composers_fwd.hpp @@ -1,16 +1,16 @@ #pragma once -namespace plonk { +namespace proof_system::plonk { class StandardComposer; class TurboComposer; class UltraComposer; class StandardPlonkComposer; -} // namespace plonk +} // namespace proof_system::plonk -namespace honk { +namespace proof_system::honk { class StandardHonkComposer; -} // namespace honk +} // namespace proof_system::honk #define EXTERN_STDLIB_TYPE(stdlib_type) \ extern template class stdlib_type; \ diff --git a/cpp/src/barretenberg/stdlib/primitives/curves/bn254.hpp b/cpp/src/barretenberg/stdlib/primitives/curves/bn254.hpp index c06ea60f3a..4fc46e4e41 100644 --- a/cpp/src/barretenberg/stdlib/primitives/curves/bn254.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/curves/bn254.hpp @@ -4,11 +4,11 @@ #include "../biggroup/biggroup.hpp" #include "../field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template struct bn254 { - static constexpr bonk::CurveType type = bonk::CurveType::BN254; + static constexpr proof_system::CurveType type = proof_system::CurveType::BN254; typedef barretenberg::fq fq; typedef barretenberg::fr fr; @@ -29,4 +29,4 @@ template struct bn254 { }; // namespace bn254 } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/curves/secp256k1.hpp b/cpp/src/barretenberg/stdlib/primitives/curves/secp256k1.hpp index 7617302320..a1e1cbe3af 100644 --- a/cpp/src/barretenberg/stdlib/primitives/curves/secp256k1.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/curves/secp256k1.hpp @@ -6,11 +6,11 @@ #include "barretenberg/ecc/curves/secp256k1/secp256k1.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template struct secp256k1 { - static constexpr bonk::CurveType type = bonk::CurveType::SECP256K1; + static constexpr proof_system::CurveType type = proof_system::CurveType::SECP256K1; typedef ::secp256k1::fq fq; typedef ::secp256k1::fr fr; @@ -30,4 +30,4 @@ template struct secp256k1 { typedef element g1_bigfr_ct; }; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/curves/secp256r1.hpp b/cpp/src/barretenberg/stdlib/primitives/curves/secp256r1.hpp index 87da0893dc..6157fa34d4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/curves/secp256r1.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/curves/secp256r1.hpp @@ -6,11 +6,11 @@ #include "barretenberg/ecc/curves/secp256r1/secp256r1.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template struct secp256r1 { - static constexpr bonk::CurveType type = bonk::CurveType::SECP256R1; + static constexpr proof_system::CurveType type = proof_system::CurveType::SECP256R1; typedef ::secp256r1::fq fq; typedef ::secp256r1::fr fr; @@ -30,4 +30,4 @@ template struct secp256r1 { typedef element g1_bigfr_ct; }; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field.cpp index eab866fee9..3debcc1824 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.cpp @@ -4,9 +4,9 @@ #include "../composers/composers.hpp" #include "barretenberg/ecc/curves/grumpkin/grumpkin.hpp" -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -739,7 +739,7 @@ void field_t::create_range_constraint(const size_t num_bits, st if (is_constant()) { ASSERT(uint256_t(get_value()).get_msb() < num_bits); } else { - if constexpr (ComposerContext::type == bonk::ComposerType::PLOOKUP) { + if constexpr (ComposerContext::type == proof_system::ComposerType::PLOOKUP) { context->decompose_into_default_range( normalize().get_witness_index(), num_bits, plonk::UltraComposer::DEFAULT_PLOOKUP_RANGE_BITNUM, msg); } else { @@ -981,7 +981,7 @@ field_t field_t::accumulate(const std::vector< * * If num elements is not a multiple of 3, the final gate will be padded with zero_idx wires **/ - if constexpr (ComposerContext::type == bonk::ComposerType::PLOOKUP) { + if constexpr (ComposerContext::type == proof_system::ComposerType::PLOOKUP) { ComposerContext* ctx = nullptr; std::vector accumulator; field_t constant_term = 0; @@ -1039,7 +1039,7 @@ field_t field_t::accumulate(const std::vector< accumulating_total = witness_t(ctx, new_total); } return total.normalize(); - } else if constexpr (ComposerContext::type == bonk::ComposerType::TURBO) { + } else if constexpr (ComposerContext::type == proof_system::ComposerType::TURBO) { field_t total(0); bool odd_number = (input.size() & 0x01UL) == 0x01ULL; @@ -1180,4 +1180,4 @@ std::vector> field_t::decompose_into_bi INSTANTIATE_STDLIB_TYPE(field_t); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.fuzzer.hpp b/cpp/src/barretenberg/stdlib/primitives/field/field.fuzzer.hpp index 612349149f..764d4c8303 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.fuzzer.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.fuzzer.hpp @@ -119,10 +119,10 @@ FastRandom VarianceRNG(0); */ template class FieldBase { private: - typedef plonk::stdlib::bool_t bool_t; - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::witness_t witness_t; - typedef plonk::stdlib::public_witness_t public_witness_t; + typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::witness_t witness_t; + typedef proof_system::plonk::stdlib::public_witness_t public_witness_t; public: /** @@ -1027,7 +1027,7 @@ template class FieldBase { * * TEST(stdlib_field, test_construct_via_bool_t) * { - * plonk::StandardComposer composer = plonk::StandardComposer(); + * plonk::StandardComposer composer = proof_system::plonk::StandardComposer(); * field_t a(witness_t(&composer, fr(uint256_t{0xf396b678452ebf15, 0x82ae10893982638b, * 0xdf185a29c65fbf80, 0x1d18b2de99e48308}))); field_t b = a - a; field_t c(static_cast(b)); * std::cout << c.get_value() << std::endl; diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.hpp b/cpp/src/barretenberg/stdlib/primitives/field/field.hpp index a175f62ab9..bbe7268727 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.hpp @@ -6,7 +6,7 @@ #include "barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp" #include "barretenberg/common/assert.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class bool_t; @@ -366,4 +366,4 @@ template inline std::ostream& operator<<(std::ostream EXTERN_STDLIB_TYPE(field_t); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp index 7fafb7d91b..5a71f5e7ef 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp @@ -8,7 +8,7 @@ #include "barretenberg/plonk/composer/turbo_composer.hpp" #include "barretenberg/numeric/random/engine.hpp" -using namespace bonk; +using namespace proof_system; namespace test_stdlib_field { @@ -19,7 +19,7 @@ auto& engine = numeric::random::get_debug_engine(); template void ignore_unused(T&) {} // use to ignore unused variables in lambdas using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; template class stdlib_field : public testing::Test { typedef stdlib::bool_t bool_ct; @@ -192,7 +192,7 @@ template class stdlib_field : public testing::Test { uint64_t expected = fidget(composer); auto prover = composer.create_prover(); - if constexpr (Composer::type == bonk::ComposerType::STANDARD_HONK) { + if constexpr (Composer::type == proof_system::ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[2][20], fr(expected)); } else { EXPECT_EQ(prover.key->polynomial_store.get("w_3_lagrange")[18], fr(expected)); @@ -249,7 +249,7 @@ template class stdlib_field : public testing::Test { auto prover = composer.create_prover(); - if constexpr (Composer::type == bonk::ComposerType::STANDARD_HONK) { + if constexpr (Composer::type == proof_system::ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[2][19], fr(4181)); } else { EXPECT_EQ(prover.key->polynomial_store.get("w_3_lagrange")[17], fr(4181)); diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp index abc7eee1a4..28ef5e5131 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp index 5fda2c405a..fc72bfffdc 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp index 49dc443813..75cc1ab00e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/group/group.hpp b/cpp/src/barretenberg/stdlib/primitives/group/group.hpp index 5886cc964f..f3cf23e1d5 100644 --- a/cpp/src/barretenberg/stdlib/primitives/group/group.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/group/group.hpp @@ -8,9 +8,9 @@ #include "../../hash/pedersen/pedersen.hpp" #include "../../hash/pedersen/pedersen_gates.hpp" -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { using namespace barretenberg; @@ -237,4 +237,4 @@ auto group::fixed_base_scalar_mul_internal(const field_t; -using field_ct = plonk::stdlib::field_t; -using group_ct = plonk::stdlib::group; +using Composer = proof_system::honk::StandardHonkComposer; +using witness_ct = proof_system::plonk::stdlib::witness_t; +using field_ct = proof_system::plonk::stdlib::field_t; +using group_ct = proof_system::plonk::stdlib::group; TEST(stdlib_group, test_fixed_base_scalar_mul) { diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp index ef561311c7..af7111f8ff 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp @@ -3,7 +3,7 @@ #include "../composers/composers.hpp" #include "../bool/bool.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -25,7 +25,7 @@ DynamicArray::DynamicArray(Composer* composer, const size_t maximum_si , _max_size(maximum_size) , _length(0) { - static_assert(Composer::type == bonk::ComposerType::PLOOKUP); + static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); ASSERT(_context != nullptr); _inner_table = ram_table(_context, maximum_size); // Initialize the ram table with all zeroes @@ -276,4 +276,4 @@ template void DynamicArray::conditional_pop(const INSTANTIATE_STDLIB_ULTRA_TYPE(DynamicArray); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.hpp b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.hpp index f5d81f71ff..0f274fe4d7 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.hpp @@ -1,7 +1,7 @@ #pragma once #include "ram_table.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -51,4 +51,4 @@ template class DynamicArray { EXTERN_STDLIB_ULTRA_TYPE(DynamicArray); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.test.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.test.cpp index 9db1d609dc..87ff2677ab 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.test.cpp @@ -10,14 +10,14 @@ namespace test_stdlib_dynamic_array { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace { auto& engine = numeric::random::get_debug_engine(); } // Defining ultra-specific types for local testing. -using Composer = plonk::UltraComposer; +using Composer = proof_system::plonk::UltraComposer; using bool_ct = stdlib::bool_t; using field_ct = stdlib::field_t; using witness_ct = stdlib::witness_t; diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp index c046ee81dc..df8237b0cd 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp @@ -2,7 +2,7 @@ #include "../composers/composers.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -13,7 +13,7 @@ namespace stdlib { */ template ram_table::ram_table(Composer* composer, const size_t table_size) { - static_assert(Composer::type == bonk::ComposerType::PLOOKUP); + static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); _context = composer; _length = table_size; _index_initialized.resize(table_size); @@ -35,7 +35,7 @@ template ram_table::ram_table(Composer* composer, */ template ram_table::ram_table(const std::vector& table_entries) { - static_assert(Composer::type == bonk::ComposerType::PLOOKUP); + static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); // get the composer _context for (const auto& entry : table_entries) { if (entry.get_context() != nullptr) { @@ -254,4 +254,4 @@ template void ram_table::write(const field_pt& ind INSTANTIATE_STDLIB_ULTRA_TYPE(ram_table); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.hpp b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.hpp index dd94b48dde..c8c1b085b9 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.hpp @@ -2,7 +2,7 @@ #include "../composers/composers_fwd.hpp" #include "../field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { // A runtime-defined read-only memory table. Table entries must be initialized in the constructor. @@ -60,4 +60,4 @@ template class ram_table { EXTERN_STDLIB_ULTRA_TYPE(ram_table); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.test.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.test.cpp index 9731be6498..22ba93e225 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.test.cpp @@ -7,10 +7,10 @@ #include "barretenberg/plonk/composer/ultra_composer.hpp" namespace test_stdlib_ram_table { -using namespace plonk; +using namespace proof_system::plonk; // Defining ultra-specific types for local testing. -using Composer = plonk::UltraComposer; +using Composer = proof_system::plonk::UltraComposer; using field_ct = stdlib::field_t; using witness_ct = stdlib::witness_t; using ram_table_ct = stdlib::ram_table; diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp index ac680f5990..3d978b23dd 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp @@ -4,12 +4,12 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template rom_table::rom_table(const std::vector& table_entries) { - static_assert(Composer::type == bonk::ComposerType::PLOOKUP); + static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); // get the composer context for (const auto& entry : table_entries) { if (entry.get_context() != nullptr) { @@ -124,4 +124,4 @@ template field_t rom_table::operator[](c INSTANTIATE_STDLIB_ULTRA_TYPE(rom_table); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.hpp b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.hpp index 0b93992e0f..ee3f519c2b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.hpp @@ -2,7 +2,7 @@ #include "../composers/composers_fwd.hpp" #include "../field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { // A runtime-defined read-only memory table. Table entries must be initialized in the constructor. @@ -44,4 +44,4 @@ template class rom_table { EXTERN_STDLIB_ULTRA_TYPE(rom_table); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.test.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.test.cpp index a6c8189edd..515d930271 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.test.cpp @@ -8,10 +8,10 @@ namespace test_stdlib_rom_array { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; // Defining ultra-specific types for local testing. -using Composer = plonk::UltraComposer; +using Composer = proof_system::plonk::UltraComposer; using field_ct = stdlib::field_t; using witness_ct = stdlib::witness_t; using rom_table_ct = stdlib::rom_table; diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp index 343b188405..a890496e9d 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp @@ -4,13 +4,13 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template twin_rom_table::twin_rom_table(const std::vector>& table_entries) { - static_assert(Composer::type == bonk::ComposerType::PLOOKUP); + static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); // get the composer context for (const auto& entry : table_entries) { if (entry[0].get_context() != nullptr) { @@ -141,4 +141,4 @@ std::array, 2> twin_rom_table::operator[](const fiel INSTANTIATE_STDLIB_ULTRA_TYPE(twin_rom_table); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.hpp b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.hpp index 555fe9efc2..24651b259a 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.hpp @@ -2,7 +2,7 @@ #include "../composers/composers_fwd.hpp" #include "../field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { // A runtime-defined read-only memory table. Table entries must be initialized in the constructor. @@ -46,4 +46,4 @@ template class twin_rom_table { EXTERN_STDLIB_ULTRA_TYPE(twin_rom_table); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.cpp b/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.cpp index e2dcc73237..62d0d1bb6b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.cpp @@ -4,7 +4,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace { @@ -271,4 +271,4 @@ template std::string packed_byte_array::get_value( INSTANTIATE_STDLIB_TYPE(packed_byte_array); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.hpp b/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.hpp index b1355e3a9d..79b4b4a797 100644 --- a/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.hpp @@ -5,7 +5,7 @@ #include "../byte_array/byte_array.hpp" #include "barretenberg/honk/composer/standard_honk_composer.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class packed_byte_array { @@ -69,4 +69,4 @@ EXTERN_STDLIB_TYPE(packed_byte_array); extern template class packed_byte_array; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.test.cpp b/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.test.cpp index 3020c6e4d8..acd8d082df 100644 --- a/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/packed_byte_array/packed_byte_array.test.cpp @@ -9,7 +9,7 @@ namespace test_stdlib_packed_byte_array { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; namespace { auto& engine = numeric::random::get_debug_engine(); @@ -21,7 +21,7 @@ TEST(packed_byte_array, string_constructor_and_get_value_consistency) { std::string input = "the quick brown fox jumped over the lazy dog."; - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); packed_byte_array arr(&composer, input); @@ -34,7 +34,7 @@ TEST(packed_byte_array, byte_array_constructor_consistency) { std::string input = "the quick brown fox jumped over the lazy dog."; - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); byte_array arr(&composer, input); packed_byte_array converted(arr); @@ -47,7 +47,7 @@ TEST(packed_byte_array, byte_array_cast_consistency) { std::string input = "the quick brown fox jumped over the lazy dog."; - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); packed_byte_array arr(&composer, input); byte_array converted(arr); @@ -71,7 +71,7 @@ TEST(packed_byte_array, unverified_byte_slices) uint32s.push_back(result); } - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); packed_byte_array arr(&composer, bytes); @@ -94,7 +94,7 @@ TEST(packed_byte_array, check_append_uint8) bytes.push_back(engine.get_random_uint8()); } - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); packed_byte_array arr(&composer, bytes); // append upto size (16x) @@ -149,7 +149,7 @@ TEST(packed_byte_array, check_append_uint32) uint32s.push_back(result); } - honk::StandardHonkComposer composer = honk::StandardHonkComposer(); + honk::StandardHonkComposer composer = proof_system::honk::StandardHonkComposer(); packed_byte_array arr(&composer, bytes); // append over size (16x) (this creates new limb internally) diff --git a/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.cpp b/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.cpp index ca69c95150..ac251c7081 100644 --- a/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.cpp @@ -3,11 +3,11 @@ #include "barretenberg/plonk/composer/plookup_tables/plookup_tables.hpp" #include "barretenberg/plonk/composer/plookup_tables/types.hpp" -namespace plonk { +namespace proof_system::plonk { class UltraComposer; -} // namespace plonk +} // namespace proof_system::plonk -namespace plonk { +namespace proof_system::plonk { namespace stdlib { using namespace barretenberg; @@ -91,4 +91,4 @@ field_t plookup_::read_from_1_to_2_table(const MultiTableId template class plookup_; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.hpp b/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.hpp index 6c468e372d..b178032b10 100644 --- a/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.hpp @@ -6,7 +6,7 @@ #include "barretenberg/plonk/composer/plookup_tables/types.hpp" #include "barretenberg/stdlib/primitives/field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { using namespace plookup; @@ -30,4 +30,4 @@ extern template class plookup_; typedef plookup_ plookup_read; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.test.cpp b/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.test.cpp index 60c5947536..235e966a67 100644 --- a/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/plookup/plookup.test.cpp @@ -12,11 +12,11 @@ namespace test_stdlib_plookups { using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; using namespace plookup; // Defining ultra-specific types for local testing. -using Composer = plonk::UltraComposer; +using Composer = proof_system::plonk::UltraComposer; using field_ct = stdlib::field_t; using witness_ct = stdlib::witness_t; diff --git a/cpp/src/barretenberg/stdlib/primitives/point/point.hpp b/cpp/src/barretenberg/stdlib/primitives/point/point.hpp index 5252a6ee9a..3c1f114320 100644 --- a/cpp/src/barretenberg/stdlib/primitives/point/point.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/point/point.hpp @@ -4,7 +4,7 @@ #include "../field/field.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template struct point { @@ -69,4 +69,4 @@ template std::ostream& operator<<(std::ostream& os, point @@ -102,4 +102,4 @@ std::array, 3> safe_uint_t::slice( INSTANTIATE_STDLIB_TYPE(safe_uint_t); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.fuzzer.hpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.fuzzer.hpp index a5d706dc14..32faf9c239 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.fuzzer.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.fuzzer.hpp @@ -109,11 +109,11 @@ FastRandom VarianceRNG(0); */ template class SafeUintFuzzBase { private: - typedef plonk::stdlib::bool_t bool_t; - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::safe_uint_t suint_t; - typedef plonk::stdlib::witness_t witness_t; - typedef plonk::stdlib::public_witness_t public_witness_t; + typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::safe_uint_t suint_t; + typedef proof_system::plonk::stdlib::witness_t witness_t; + typedef proof_system::plonk::stdlib::public_witness_t public_witness_t; public: /** diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.hpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.hpp index 15d3f8ad3a..436970d490 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.hpp @@ -11,7 +11,7 @@ // Despite the name, it is *not* a "safe" version of the uint class - as operations are positive integer // operations, and not modulo 2^t for some t, as they are in the uint class. -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class safe_uint_t { @@ -287,4 +287,4 @@ EXTERN_STDLIB_TYPE(safe_uint_t); extern template class safe_uint_t; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.test.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.test.cpp index 9e566212f4..622e896fee 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint.test.cpp @@ -11,18 +11,18 @@ namespace { auto& engine = numeric::random::get_debug_engine(); } -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace test_stdlib_safe_uint { template void ignore_unused(T&) {} // use to ignore unused variables in lambdas -using Composer = honk::StandardHonkComposer; -typedef plonk::stdlib::bool_t bool_t; -typedef plonk::stdlib::field_t field_t; -typedef plonk::stdlib::safe_uint_t suint_t; -typedef plonk::stdlib::witness_t witness_t; -typedef plonk::stdlib::public_witness_t public_witness_t; -typedef plonk::stdlib::byte_array byte_array_t; +using Composer = proof_system::honk::StandardHonkComposer; +typedef proof_system::plonk::stdlib::bool_t bool_t; +typedef proof_system::plonk::stdlib::field_t field_t; +typedef proof_system::plonk::stdlib::safe_uint_t suint_t; +typedef proof_system::plonk::stdlib::witness_t witness_t; +typedef proof_system::plonk::stdlib::public_witness_t public_witness_t; +typedef proof_system::plonk::stdlib::byte_array byte_array_t; struct verify_logic_result { bool valid; diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp index d041e08e38..d24c0f897a 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp index 7adce9d0a4..085c24f0a0 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp index d4b7e85a1f..f8b22f5540 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/arithmetic.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/arithmetic.cpp index f45b109bbf..fe4ea7284f 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/arithmetic.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/arithmetic.cpp @@ -2,9 +2,9 @@ #include "uint.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -413,4 +413,4 @@ template class uint; template class uint; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/comparison.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/comparison.cpp index d4ce51b983..505ed34360 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/comparison.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/comparison.cpp @@ -3,7 +3,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -122,4 +122,4 @@ template class uint; template class uint; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/logic.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/logic.cpp index 17ec3cd566..1a13734fbe 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/logic.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/logic.cpp @@ -3,9 +3,9 @@ #include "uint.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -545,4 +545,4 @@ template class uint; template class uint; } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/arithmetic.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/arithmetic.cpp index b4da7fa037..6f479c0aa7 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/arithmetic.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/arithmetic.cpp @@ -2,9 +2,9 @@ #include "uint.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -258,4 +258,4 @@ template class uint_plookup; template class uint_plookup; template class uint_plookup; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/comparison.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/comparison.cpp index 891484cddb..8868aae3a5 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/comparison.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/comparison.cpp @@ -3,7 +3,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -78,4 +78,4 @@ template class uint_plookup; template class uint_plookup; template class uint_plookup; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/logic.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/logic.cpp index 4268611822..db45a6f7c3 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/logic.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/logic.cpp @@ -3,7 +3,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -331,4 +331,4 @@ template class uint_plookup; template class uint_plookup; } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.cpp index 6dba609b4e..e626d348f9 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.cpp @@ -3,7 +3,7 @@ using namespace barretenberg; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template @@ -246,4 +246,4 @@ INSTANTIATE_STDLIB_ULTRA_TYPE_VA(uint_plookup, uint32_t); INSTANTIATE_STDLIB_ULTRA_TYPE_VA(uint_plookup, uint64_t); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.hpp b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.hpp index 2ba2699140..14eecbaf5e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/plookup/uint.hpp @@ -5,7 +5,7 @@ #include "../../field/field.hpp" #include "../../plookup/plookup.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { template class uint_plookup { @@ -178,4 +178,4 @@ EXTERN_STDLIB_ULTRA_TYPE_VA(uint_plookup, uint32_t); EXTERN_STDLIB_ULTRA_TYPE_VA(uint_plookup, uint64_t); } // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp index c628138caa..196c9a5753 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp @@ -2,9 +2,9 @@ #include "../composers/composers.hpp" using namespace barretenberg; -using namespace bonk; +using namespace proof_system; -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -16,7 +16,7 @@ std::vector uint::constrain_accumulators(Composer* c const size_t num_bits, std::string const& msg) const { - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { // TODO: manage higher bit ranges const auto sequence = plookup_read::get_lookup_accumulators(plookup::MultiTableId::UINT32_XOR, @@ -317,7 +317,7 @@ template bool_t uintget_variable(right_idx)) - uint256_t(context->get_variable(left_idx)) * uint256_t(4); - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { uint256_t lo_bit = quad & 1; uint256_t hi_bit = (quad & 2) >> 1; // difference in quads = 0, 1, 2, 3 = delta @@ -405,4 +405,4 @@ INSTANTIATE_STDLIB_BASIC_TYPE_VA(uint, uint32_t); INSTANTIATE_STDLIB_BASIC_TYPE_VA(uint, uint64_t); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.fuzzer.hpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.fuzzer.hpp index ba7dcaad1a..3d617c35ce 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.fuzzer.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.fuzzer.hpp @@ -31,13 +31,13 @@ FastRandom VarianceRNG(0); */ template class UintFuzzBase { private: - typedef plonk::stdlib::bool_t bool_t; - typedef plonk::stdlib::uint uint_8_t; - typedef plonk::stdlib::uint uint_16_t; - typedef plonk::stdlib::uint uint_32_t; - typedef plonk::stdlib::uint uint_64_t; - typedef plonk::stdlib::field_t field_t; - typedef plonk::stdlib::byte_array byte_array_t; + typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef proof_system::plonk::stdlib::uint uint_8_t; + typedef proof_system::plonk::stdlib::uint uint_16_t; + typedef proof_system::plonk::stdlib::uint uint_32_t; + typedef proof_system::plonk::stdlib::uint uint_64_t; + typedef proof_system::plonk::stdlib::field_t field_t; + typedef proof_system::plonk::stdlib::byte_array byte_array_t; template static To from_to(const From& in, const std::optional size = std::nullopt) { diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp index e7eccf30dd..3b61778464 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp @@ -12,7 +12,7 @@ #include "barretenberg/plonk/composer/turbo_composer.hpp" #include "barretenberg/plonk/composer/ultra_composer.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { /** @@ -194,19 +194,19 @@ template inline std::ostream& operator<<(std::ostream& } template -using uint8 = typename std::conditional, uint>::type; template -using uint16 = typename std::conditional, uint>::type; template -using uint32 = typename std::conditional, uint>::type; template -using uint64 = typename std::conditional, uint>::type; @@ -216,4 +216,4 @@ EXTERN_STDLIB_BASIC_TYPE_VA(uint, uint32_t); EXTERN_STDLIB_BASIC_TYPE_VA(uint, uint64_t); } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp index 025e8b8763..2c4b8b29b0 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp @@ -5,8 +5,8 @@ #include "barretenberg/numeric/random/engine.hpp" using namespace barretenberg; -using namespace plonk; -using namespace bonk; +using namespace proof_system::plonk; +using namespace proof_system; namespace { auto& engine = numeric::random::get_debug_engine(); @@ -76,7 +76,7 @@ uint_native rotate(uint_native value, size_t rotation) : value; } template class stdlib_uint : public testing::Test { - typedef typename std::conditional, stdlib::uint>::type uint_ct; typedef stdlib::bool_t bool_ct; @@ -2107,10 +2107,10 @@ TYPED_TEST(stdlib_uint, test_at) // There was one plookup-specific test in the ./plookup/uint_plookup.test.cpp TEST(stdlib_uint32, test_accumulators_plookup_uint32) { - using uint32_ct = plonk::stdlib::uint32; - using witness_ct = plonk::stdlib::witness_t; + using uint32_ct = proof_system::plonk::stdlib::uint32; + using witness_ct = proof_system::plonk::stdlib::witness_t; - plonk::UltraComposer composer = plonk::UltraComposer(); + plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); uint32_t a_val = engine.get_random_uint32(); uint32_t b_val = engine.get_random_uint32(); diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp index b1cc5137e1..8d7ed88eba 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard | bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp index a0bdec7827..42e8262e67 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp index 586631fb2b..4f4b2100d3 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = bonk::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/witness/witness.hpp b/cpp/src/barretenberg/stdlib/primitives/witness/witness.hpp index 33fadf1bc9..a157c9022d 100644 --- a/cpp/src/barretenberg/stdlib/primitives/witness/witness.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/witness/witness.hpp @@ -2,7 +2,7 @@ #include "barretenberg/plonk/composer/composer_base.hpp" #include "barretenberg/ecc/curves/bn254/fr.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { // indicates whether a witness index actually contains a constant @@ -84,4 +84,4 @@ template class public_witness_t : public witness_t class Transcript { @@ -25,7 +25,7 @@ template class Transcript { using witness_pt = witness_t; using fq_pt = bigfield; using group_pt = element; - using Key = plonk::stdlib::recursion::verification_key>; + using Key = proof_system::plonk::stdlib::recursion::verification_key>; Transcript(Composer* in_context, const transcript::Manifest input_manifest) : context(in_context) @@ -246,7 +246,7 @@ template class Transcript { } field_pt T0; - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { T0 = stdlib::pedersen_plookup::compress(compression_buffer); } else { T0 = stdlib::pedersen::compress(compression_buffer); @@ -404,4 +404,4 @@ template class Transcript { }; } // namespace recursion } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.test.cpp b/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.test.cpp index 598e91ba79..a5d7c9ddb2 100644 --- a/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.test.cpp +++ b/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.test.cpp @@ -6,7 +6,7 @@ #include "barretenberg/transcript/transcript.hpp" -using namespace plonk; +using namespace proof_system::plonk; // ULTRATODO: Add tests for other composers too (make tests modular?) @@ -195,7 +195,7 @@ TEST(stdlib_transcript, validate_transcript) TestData data = get_test_data(); transcript::Transcript normal_transcript = get_test_base_transcript(data); - plonk::TurboComposer composer = plonk::TurboComposer(); + plonk::TurboComposer composer = proof_system::plonk::TurboComposer(); plonk::stdlib::recursion::Transcript recursive_transcript = get_circuit_transcript(&composer, data); diff --git a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp index 447319bd18..bc245ae699 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp @@ -21,7 +21,7 @@ #include "../../hash/pedersen/pedersen_plookup.hpp" #include "../../primitives/curves/bn254.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace recursion { @@ -54,7 +54,7 @@ template struct evaluation_domain { field_t compress() const { - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { field_t out = pedersen_plookup::compress({ root, domain, @@ -74,7 +74,7 @@ template struct evaluation_domain { static barretenberg::fr compress_native(const barretenberg::evaluation_domain& input) { barretenberg::fr out; - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { out = crypto::pedersen::lookup::compress_native({ input.root, input.domain, @@ -155,7 +155,7 @@ template struct verification_key { const auto circuit_key_compressed = compress(); bool found = false; // if we're using Plookup, use a ROM table to index the keys - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { field_t key_index(witness_t(context, 0)); std::vector> compressed_keys; for (size_t i = 0; i < keys_in_set.size(); ++i) { @@ -205,7 +205,7 @@ template struct verification_key { } field_t compressed_key; - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { compressed_key = pedersen_plookup::compress(key_witnesses); } else { compressed_key = pedersen::compress(key_witnesses); @@ -245,7 +245,7 @@ template struct verification_key { key_witnesses.push_back(y_limbs[3]); } barretenberg::fr compressed_key; - if constexpr (Composer::type == bonk::ComposerType::PLOOKUP) { + if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { compressed_key = crypto::pedersen::lookup::compress_native(key_witnesses); } else { compressed_key = crypto::pedersen::compress_native(key_witnesses); @@ -265,7 +265,7 @@ template struct verification_key { // Native data: - std::shared_ptr reference_string; + std::shared_ptr reference_string; PolynomialManifest polynomial_manifest; @@ -277,4 +277,4 @@ template struct verification_key { } // namespace recursion } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/program_settings.hpp b/cpp/src/barretenberg/stdlib/recursion/verifier/program_settings.hpp index 4fc602071a..7b681206f4 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/program_settings.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/program_settings.hpp @@ -4,7 +4,7 @@ #include "../transcript/transcript.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace recursion { @@ -13,17 +13,19 @@ template class recursive_ultra_verifier_settings : public plonk typedef typename Curve::fr_ct fr_ct; typedef typename Curve::g1::affine_element g1; typedef typename Curve::Composer Composer; - typedef plonk::stdlib::recursion::Transcript Transcript_pt; - typedef plonk::VerifierPermutationWidget PermutationWidget; - typedef plonk::VerifierPlookupWidget PlookupWidget; + typedef proof_system::plonk::stdlib::recursion::Transcript Transcript_pt; + typedef proof_system::plonk::VerifierPermutationWidget PermutationWidget; + typedef proof_system::plonk::VerifierPlookupWidget PlookupWidget; - typedef plonk::ultra_settings base_settings; + typedef proof_system::plonk::ultra_settings base_settings; - typedef plonk::VerifierPlookupArithmeticWidget PlookupArithmeticWidget; - typedef plonk::VerifierTurboLogicWidget TurboLogicWidget; - typedef plonk::VerifierGenPermSortWidget GenPermSortWidget; - typedef plonk::VerifierEllipticWidget EllipticWidget; - typedef plonk::VerifierPlookupAuxiliaryWidget PlookupAuxiliaryWidget; + typedef proof_system::plonk::VerifierPlookupArithmeticWidget + PlookupArithmeticWidget; + typedef proof_system::plonk::VerifierTurboLogicWidget TurboLogicWidget; + typedef proof_system::plonk::VerifierGenPermSortWidget GenPermSortWidget; + typedef proof_system::plonk::VerifierEllipticWidget EllipticWidget; + typedef proof_system::plonk::VerifierPlookupAuxiliaryWidget + PlookupAuxiliaryWidget; static constexpr size_t num_challenge_bytes = 16; static constexpr transcript::HashType hash_type = transcript::HashType::PlookupPedersenBlake3s; @@ -89,17 +91,19 @@ class recursive_ultra_to_standard_verifier_settings : public recursive_ultra_ver typedef typename Curve::fr_ct fr_ct; typedef typename Curve::g1::affine_element g1; typedef typename Curve::Composer Composer; - typedef plonk::stdlib::recursion::Transcript Transcript_pt; - typedef plonk::VerifierPermutationWidget PermutationWidget; - typedef plonk::VerifierPlookupWidget PlookupWidget; + typedef proof_system::plonk::stdlib::recursion::Transcript Transcript_pt; + typedef proof_system::plonk::VerifierPermutationWidget PermutationWidget; + typedef proof_system::plonk::VerifierPlookupWidget PlookupWidget; - typedef plonk::ultra_to_standard_settings base_settings; + typedef proof_system::plonk::ultra_to_standard_settings base_settings; - typedef plonk::VerifierPlookupArithmeticWidget PlookupArithmeticWidget; - typedef plonk::VerifierTurboLogicWidget TurboLogicWidget; - typedef plonk::VerifierGenPermSortWidget GenPermSortWidget; - typedef plonk::VerifierEllipticWidget EllipticWidget; - typedef plonk::VerifierPlookupAuxiliaryWidget PlookupAuxiliaryWidget; + typedef proof_system::plonk::VerifierPlookupArithmeticWidget + PlookupArithmeticWidget; + typedef proof_system::plonk::VerifierTurboLogicWidget TurboLogicWidget; + typedef proof_system::plonk::VerifierGenPermSortWidget GenPermSortWidget; + typedef proof_system::plonk::VerifierEllipticWidget EllipticWidget; + typedef proof_system::plonk::VerifierPlookupAuxiliaryWidget + PlookupAuxiliaryWidget; static constexpr transcript::HashType hash_type = transcript::HashType::PedersenBlake3s; }; @@ -110,14 +114,16 @@ template class recursive_turbo_verifier_settings : public plonk typedef typename Curve::g1::affine_element g1; typedef typename Curve::Composer Composer; typedef Transcript Transcript_pt; - typedef plonk::VerifierPermutationWidget PermutationWidget; + typedef proof_system::plonk::VerifierPermutationWidget PermutationWidget; - typedef plonk::turbo_settings base_settings; + typedef proof_system::plonk::turbo_settings base_settings; - typedef plonk::VerifierTurboFixedBaseWidget TurboFixedBaseWidget; - typedef plonk::VerifierTurboArithmeticWidget TurboArithmeticWidget; - typedef plonk::VerifierTurboRangeWidget TurboRangeWidget; - typedef plonk::VerifierTurboLogicWidget TurboLogicWidget; + typedef proof_system::plonk::VerifierTurboFixedBaseWidget + TurboFixedBaseWidget; + typedef proof_system::plonk::VerifierTurboArithmeticWidget + TurboArithmeticWidget; + typedef proof_system::plonk::VerifierTurboRangeWidget TurboRangeWidget; + typedef proof_system::plonk::VerifierTurboLogicWidget TurboLogicWidget; static constexpr size_t num_challenge_bytes = 16; static constexpr transcript::HashType hash_type = transcript::HashType::PedersenBlake3s; @@ -162,4 +168,4 @@ template class recursive_turbo_verifier_settings : public plonk } // namespace recursion } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp index 70119d77b1..83800640ee 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.hpp @@ -15,7 +15,7 @@ #include "barretenberg/ecc/curves/bn254/fq12.hpp" #include "barretenberg/ecc/curves/bn254/pairing.hpp" -namespace plonk { +namespace proof_system::plonk { namespace stdlib { namespace recursion { @@ -118,7 +118,8 @@ void populate_kate_element_map(typename Curve::Composer* ctx, fr_ct u = transcript.get_challenge_field_element("separator", 0); - fr_ct batch_evaluation = plonk::compute_kate_batch_evaluation(key, transcript); + fr_ct batch_evaluation = + proof_system::plonk::compute_kate_batch_evaluation(key, transcript); batch_opening_scalar = -batch_evaluation; kate_g1_elements.insert({ "PI_Z_OMEGA", g1_ct::from_witness(ctx, PI_Z_OMEGA) }); @@ -424,4 +425,4 @@ recursion_output verify_proof(typename Curve::Composer* context, } // namespace recursion } // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp index 9135d22313..25364b2358 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier.test.cpp @@ -9,16 +9,16 @@ #include "../../hash/pedersen/pedersen.hpp" #include "program_settings.hpp" -using namespace plonk; +using namespace proof_system::plonk; template class stdlib_verifier : public testing::Test { - using InnerComposer = plonk::UltraComposer; + using InnerComposer = proof_system::plonk::UltraComposer; typedef stdlib::bn254 inner_curve; typedef stdlib::bn254 outer_curve; - typedef plonk::stdlib::recursion::verification_key verification_key_pt; - typedef plonk::stdlib::recursion::recursive_ultra_verifier_settings recursive_settings; - typedef plonk::stdlib::recursion::recursive_ultra_to_standard_verifier_settings + typedef proof_system::plonk::stdlib::recursion::verification_key verification_key_pt; + typedef proof_system::plonk::stdlib::recursion::recursive_ultra_verifier_settings recursive_settings; + typedef proof_system::plonk::stdlib::recursion::recursive_ultra_to_standard_verifier_settings ultra_to_standard_recursive_settings; typedef inner_curve::fr_ct fr_ct; typedef inner_curve::public_witness_ct public_witness_ct; diff --git a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp index db2b6703ef..3766296af7 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp +++ b/cpp/src/barretenberg/stdlib/recursion/verifier/verifier_turbo.test.cpp @@ -9,15 +9,15 @@ #include "../../hash/pedersen/pedersen.hpp" #include "program_settings.hpp" -using namespace plonk; +using namespace proof_system::plonk; template class stdlib_verifier_turbo : public testing::Test { - using InnerComposer = plonk::TurboComposer; + using InnerComposer = proof_system::plonk::TurboComposer; typedef stdlib::bn254 inner_curve; typedef stdlib::bn254 outer_curve; - typedef plonk::stdlib::recursion::verification_key verification_key_pt; - typedef plonk::stdlib::recursion::recursive_turbo_verifier_settings recursive_settings; + typedef proof_system::plonk::stdlib::recursion::verification_key verification_key_pt; + typedef proof_system::plonk::stdlib::recursion::recursive_turbo_verifier_settings recursive_settings; typedef inner_curve::fr_ct fr_ct; typedef inner_curve::public_witness_ct public_witness_ct; typedef inner_curve::witness_ct witness_ct; diff --git a/cpp/src/barretenberg/stdlib/types/types.hpp b/cpp/src/barretenberg/stdlib/types/types.hpp index 61f08b0c73..15f524d8ed 100644 --- a/cpp/src/barretenberg/stdlib/types/types.hpp +++ b/cpp/src/barretenberg/stdlib/types/types.hpp @@ -25,37 +25,39 @@ #include "barretenberg/stdlib/primitives/memory/rom_table.hpp" #include "barretenberg/stdlib/primitives/memory/dynamic_array.hpp" -namespace plonk::stdlib::types { +namespace proof_system::plonk::stdlib::types { -using namespace plonk; -static constexpr size_t SYSTEM_COMPOSER = plonk::SYSTEM_COMPOSER; +using namespace proof_system::plonk; +static constexpr size_t SYSTEM_COMPOSER = proof_system::plonk::SYSTEM_COMPOSER; typedef std::conditional_t< - SYSTEM_COMPOSER == bonk::STANDARD, + SYSTEM_COMPOSER == proof_system::STANDARD, plonk::StandardComposer, - std::conditional_t> + std::conditional_t> Composer; -typedef std::conditional_t> +typedef std::conditional_t< + SYSTEM_COMPOSER == proof_system::STANDARD, + plonk::Prover, + std::conditional_t> Prover; typedef std::conditional_t< - SYSTEM_COMPOSER == bonk::STANDARD, + SYSTEM_COMPOSER == proof_system::STANDARD, plonk::Verifier, - std::conditional_t> + std::conditional_t> Verifier; -typedef std::conditional_t> +typedef std::conditional_t< + SYSTEM_COMPOSER == proof_system::STANDARD, + plonk::Prover, + std::conditional_t> Prover; typedef std::conditional_t< - SYSTEM_COMPOSER == bonk::STANDARD, + SYSTEM_COMPOSER == proof_system::STANDARD, plonk::Verifier, - std::conditional_t> + std::conditional_t> Verifier; typedef stdlib::witness_t witness_ct; @@ -90,9 +92,9 @@ typedef stdlib::schnorr::signature_bits signature_bits; // Ultra-composer specific types typedef stdlib::rom_table rom_table_ct; -typedef std::conditional_t, recursion::recursive_ultra_verifier_settings> recursive_inner_verifier_settings; -} // namespace plonk::stdlib::types +} // namespace proof_system::plonk::stdlib::types diff --git a/cpp/src/barretenberg/transcript/transcript.hpp b/cpp/src/barretenberg/transcript/transcript.hpp index 7e51b364f2..43d47e3972 100644 --- a/cpp/src/barretenberg/transcript/transcript.hpp +++ b/cpp/src/barretenberg/transcript/transcript.hpp @@ -39,7 +39,7 @@ class Transcript { }; public: - typedef plonk::verification_key Key; + typedef proof_system::plonk::verification_key Key; /** * Create a new transcript for Prover based on the manifest. diff --git a/cpp/src/barretenberg/transcript/transcript.test.cpp b/cpp/src/barretenberg/transcript/transcript.test.cpp index d11e7413ac..b953173ae5 100644 --- a/cpp/src/barretenberg/transcript/transcript.test.cpp +++ b/cpp/src/barretenberg/transcript/transcript.test.cpp @@ -136,7 +136,7 @@ TEST(transcript, univariate_serialization) constexpr size_t LENGTH = 8; using Fr = barretenberg::fr; - using Univariate = honk::sumcheck::Univariate; + using Univariate = proof_system::honk::sumcheck::Univariate; using Transcript = transcript::StandardTranscript; std::vector g1_vector(64); From d72ffd03e6e4577a4c70bf069b14145ab66f5e98 Mon Sep 17 00:00:00 2001 From: codygunton Date: Mon, 3 Apr 2023 13:35:55 -0400 Subject: [PATCH 4/5] proof_system independent of plonk. --- .../dsl/acir_format/acir_format.cpp | 2 +- .../dsl/acir_format/logic_constraint.cpp | 2 +- .../dsl/acir_proofs/acir_proofs.cpp | 12 +- cpp/src/barretenberg/honk/CMakeLists.txt | 2 +- .../standard_honk_composer_helper.cpp | 13 +- .../standard_honk_composer_helper.hpp | 11 +- .../honk/composer/standard_honk_composer.hpp | 14 +- .../honk/proof_system/prover_library.test.cpp | 15 +- .../honk/proof_system/verifier.cpp | 6 +- .../honk/proof_system/verifier.test.cpp | 10 +- .../polynomials/multivariates.test.cpp | 10 +- .../honk/sumcheck/relations/relation.test.cpp | 6 +- .../join_split_example/proofs/verify.hpp | 2 +- .../plonk/composer/composer_base.cpp | 2 +- .../plonk/composer/composer_base.hpp | 2 +- .../composer_helper/composer_helper_lib.cpp | 3 +- .../composer_helper/composer_helper_lib.hpp | 3 +- .../standard_plonk_composer_helper.cpp | 16 +- .../standard_plonk_composer_helper.hpp | 10 +- .../turbo_plonk_composer_helper.cpp | 18 +- .../turbo_plonk_composer_helper.hpp | 10 +- .../ultra_plonk_composer_helper.cpp | 17 +- .../ultra_plonk_composer_helper.hpp | 21 +- .../splitting_tmp/standard_plonk_composer.hpp | 14 +- .../standard_plonk_composer.test.cpp | 28 +- .../splitting_tmp/turbo_plonk_composer.hpp | 13 +- .../splitting_tmp/ultra_plonk_composer.hpp | 8 +- .../ultra_plonk_composer.test.cpp | 7 +- .../plonk/composer/standard_composer.hpp | 2 +- .../plonk/composer/standard_composer.test.cpp | 2 +- .../plonk/composer/turbo_composer.hpp | 12 +- .../plonk/composer/ultra_composer.hpp | 2 +- .../commitment_scheme.test.cpp | 8 +- .../plonk/proof_system/constants.hpp | 2 +- .../plonk/proof_system/prover/c_bind.cpp | 5 +- .../proof_system/prover/c_bind_unrolled.cpp | 5 +- .../plonk/proof_system/prover/prover.test.cpp | 7 +- .../proof_system/proving_key/proving_key.cpp | 9 +- .../proof_system/proving_key/proving_key.hpp | 12 +- .../proving_key/proving_key.test.cpp | 10 +- .../types/polynomial_manifest.hpp | 11 +- .../proof_system/verification_key/sol_gen.hpp | 14 +- .../verification_key/verification_key.cpp | 5 +- .../verification_key/verification_key.hpp | 6 +- .../verification_key.test.cpp | 4 +- .../proof_system/verifier/verifier.test.cpp | 8 +- .../barretenberg/proof_system/CMakeLists.txt | 2 +- .../standard_circuit_constructor.hpp | 5 +- .../turbo_circuit_constructor.hpp | 4 +- .../ultra_circuit_constructor.cpp | 4 +- .../ultra_circuit_constructor.hpp | 10 +- .../composer/composer_helper_lib.cpp | 253 ------------------ .../composer/composer_helper_lib.hpp | 127 +++++++-- .../composer/permutation_helper.hpp | 3 +- .../polynomial_store.test.cpp | 12 +- .../proof_system/types/composer_type.hpp | 8 +- .../proof_system/work_queue/work_queue.hpp | 2 +- .../stdlib/encryption/aes128/aes128.cpp | 4 +- .../stdlib/encryption/aes128/aes128.test.cpp | 8 +- .../stdlib/encryption/ecdsa/ecdsa_impl.hpp | 2 +- .../stdlib/encryption/schnorr/schnorr.cpp | 8 +- .../stdlib/hash/blake2s/blake2s.cpp | 2 +- .../stdlib/hash/blake2s/blake2s.test.cpp | 4 +- .../stdlib/hash/blake3s/blake3s.cpp | 2 +- .../stdlib/hash/pedersen/pedersen.cpp | 6 +- .../stdlib/hash/pedersen/pedersen.hpp | 8 +- .../stdlib/hash/pedersen/pedersen.test.cpp | 6 +- .../stdlib/hash/pedersen/pedersen_gates.hpp | 7 +- .../stdlib/hash/pedersen/pedersen_plookup.hpp | 8 +- .../stdlib/hash/sha256/sha256.cpp | 2 +- .../stdlib/hash/sha256/sha256.test.cpp | 54 ++-- .../bigfield/bigfield_all.fuzzer.cpp | 2 +- .../primitives/bigfield/bigfield_impl.hpp | 26 +- .../bigfield/bigfield_standard.fuzzer.cpp | 2 +- .../bigfield/bigfield_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/biggroup/biggroup.hpp | 21 +- .../primitives/biggroup/biggroup.test.cpp | 17 +- .../biggroup/biggroup_batch_mul.hpp | 2 +- .../primitives/biggroup/biggroup_bn254.hpp | 2 +- .../biggroup/biggroup_secp256k1.hpp | 2 +- .../bit_array/bit_array_all.fuzzer.cpp | 2 +- .../bit_array/bit_array_standard.fuzzer.cpp | 2 +- .../bit_array/bit_array_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/bool/bool.test.cpp | 2 +- .../primitives/bool/bool_all.fuzzer.cpp | 2 +- .../primitives/bool/bool_standard.fuzzer.cpp | 2 +- .../primitives/bool/bool_turbo.fuzzer.cpp | 2 +- .../primitives/byte_array/byte_array.cpp | 2 +- .../byte_array/byte_array_all.fuzzer.cpp | 2 +- .../byte_array/byte_array_standard.fuzzer.cpp | 2 +- .../byte_array/byte_array_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/field/field.cpp | 6 +- .../stdlib/primitives/field/field.test.cpp | 4 +- .../primitives/field/field_all.fuzzer.cpp | 2 +- .../field/field_standard.fuzzer.cpp | 2 +- .../primitives/field/field_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/logic/logic.cpp | 6 +- .../stdlib/primitives/logic/logic.hpp | 15 +- .../stdlib/primitives/logic/logic.test.cpp | 4 +- .../primitives/memory/dynamic_array.cpp | 2 +- .../stdlib/primitives/memory/ram_table.cpp | 4 +- .../stdlib/primitives/memory/rom_table.cpp | 2 +- .../primitives/memory/twin_rom_table.cpp | 2 +- .../safe_uint/safe_uint_all.fuzzer.cpp | 2 +- .../safe_uint/safe_uint_standard.fuzzer.cpp | 2 +- .../safe_uint/safe_uint_turbo.fuzzer.cpp | 2 +- .../stdlib/primitives/uint/uint.cpp | 4 +- .../stdlib/primitives/uint/uint.hpp | 8 +- .../stdlib/primitives/uint/uint.test.cpp | 2 +- .../primitives/uint/uint_all.fuzzer.cpp | 2 +- .../primitives/uint/uint_standard.fuzzer.cpp | 2 +- .../primitives/uint/uint_turbo.fuzzer.cpp | 2 +- .../recursion/transcript/transcript.hpp | 2 +- .../verification_key/verification_key.hpp | 12 +- 114 files changed, 456 insertions(+), 685 deletions(-) delete mode 100644 cpp/src/barretenberg/proof_system/composer/composer_helper_lib.cpp diff --git a/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp b/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp index da82622c7a..a10eb40468 100644 --- a/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp @@ -1,6 +1,6 @@ #include "acir_format.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_format/logic_constraint.cpp b/cpp/src/barretenberg/dsl/acir_format/logic_constraint.cpp index b25530fa80..ca14b7cbc4 100644 --- a/cpp/src/barretenberg/dsl/acir_format/logic_constraint.cpp +++ b/cpp/src/barretenberg/dsl/acir_format/logic_constraint.cpp @@ -1,7 +1,7 @@ #include "logic_constraint.hpp" #include "barretenberg/stdlib/primitives/logic/logic.hpp" -using namespace plonk::stdlib::types; +using namespace proof_system::plonk::stdlib::types; namespace acir_format { diff --git a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp index aa3cb22f75..21585f6df4 100644 --- a/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp +++ b/cpp/src/barretenberg/dsl/acir_proofs/acir_proofs.cpp @@ -1,10 +1,10 @@ #include "acir_proofs.hpp" -#include "barretenberg/proof_system/proving_key/serialize.hpp" +#include "barretenberg/plonk/proof_system/proving_key/serialize.hpp" #include "barretenberg/dsl/acir_format/acir_format.hpp" #include "barretenberg/stdlib/types/types.hpp" #include "barretenberg/srs/reference_string/pippenger_reference_string.hpp" -#include "barretenberg/proof_system/verification_key/sol_gen.hpp" +#include "barretenberg/plonk/proof_system/verification_key/sol_gen.hpp" using namespace proof_system::plonk::stdlib::types; @@ -13,9 +13,9 @@ namespace acir_proofs { size_t get_solidity_verifier(uint8_t const* g2x, uint8_t const* vk_buf, uint8_t** output_buf) { auto crs = std::make_shared(g2x); - bonk::verification_key_data vk_data; + proof_system::plonk::verification_key_data vk_data; read(vk_buf, vk_data); - auto verification_key = std::make_shared(std::move(vk_data), crs); + auto verification_key = std::make_shared(std::move(vk_data), crs); std::ostringstream stream; // TODO(blaine): Should we just use "VerificationKey" generically? @@ -42,7 +42,7 @@ uint32_t get_exact_circuit_size(uint8_t const* constraint_system_buf) uint32_t get_total_circuit_size(uint8_t const* constraint_system_buf) { auto constraint_system = from_buffer(constraint_system_buf); - auto crs_factory = std::make_unique(); + auto crs_factory = std::make_unique(); auto composer = create_circuit(constraint_system, std::move(crs_factory)); return static_cast(composer.get_total_circuit_size()); @@ -138,7 +138,7 @@ bool verify_proof( auto crs = std::make_shared(g2x); plonk::verification_key_data vk_data; read(vk_buf, vk_data); - auto verification_key = std::make_shared(std::move(vk_data), crs); + auto verification_key = std::make_shared(std::move(vk_data), crs); Composer composer(nullptr, verification_key); create_circuit(composer, constraint_system); diff --git a/cpp/src/barretenberg/honk/CMakeLists.txt b/cpp/src/barretenberg/honk/CMakeLists.txt index ac0dc30fd0..df60576b16 100644 --- a/cpp/src/barretenberg/honk/CMakeLists.txt +++ b/cpp/src/barretenberg/honk/CMakeLists.txt @@ -1,4 +1,4 @@ -barretenberg_module(honk numeric ecc srs proof_system transcript) +barretenberg_module(honk numeric ecc srs proof_system transcript plonk) if(TESTING) # TODO: Re-enable all these warnings once PoC is finished diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp index d824abc1bf..2bbf1c596d 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.cpp @@ -28,11 +28,8 @@ std::shared_ptr StandardHonkComposerHelper StandardHonkComposerHelper std::shared_ptr StandardHonkComposerHelper::compute_verification_key_base( - std::shared_ptr const& proving_key, - std::shared_ptr const& vrs) + std::shared_ptr const& proving_key, std::shared_ptr const& vrs) { auto key = std::make_shared( proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); @@ -109,8 +105,7 @@ std::shared_ptr StandardHonkComposerHelper(circuit_constructor, diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp index 266a07769b..613daaf6a1 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp @@ -27,17 +27,17 @@ template class StandardHonkComposerHelper { std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; bool computed_witness = false; StandardHonkComposerHelper() - : StandardHonkComposerHelper(std::shared_ptr( + : StandardHonkComposerHelper(std::shared_ptr( new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) {} - StandardHonkComposerHelper(std::shared_ptr crs_factory) + StandardHonkComposerHelper(std::shared_ptr crs_factory) : crs_factory_(std::move(crs_factory)) {} - StandardHonkComposerHelper(std::unique_ptr&& crs_factory) + StandardHonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} StandardHonkComposerHelper(std::shared_ptr p_key, @@ -67,8 +67,7 @@ template class StandardHonkComposerHelper { // This needs to be static as it may be used only to compute the selector commitments. static std::shared_ptr compute_verification_key_base( - std::shared_ptr const& proving_key, - std::shared_ptr const& vrs); + std::shared_ptr const& proving_key, std::shared_ptr const& vrs); void compute_witness(const CircuitConstructor& circuit_constructor, const size_t minimum_circuit_size = 0); }; diff --git a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp index 3674576a6c..ab2c344514 100644 --- a/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp +++ b/cpp/src/barretenberg/honk/composer/standard_honk_composer.hpp @@ -15,7 +15,7 @@ namespace proof_system::honk { */ class StandardHonkComposer { public: - static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD_HONK; + static constexpr ComposerType type = ComposerType::STANDARD_HONK; static constexpr size_t UINT_LOG2_BASE = 2; // An instantiation of the circuit constructor that only depends on arithmetization, not on the proof system @@ -38,20 +38,18 @@ class StandardHonkComposer { , variables(circuit_constructor.variables){}; StandardHonkComposer(std::string const& crs_path, const size_t size_hint = 0) - : StandardHonkComposer(std::unique_ptr( - new proof_system::FileReferenceStringFactory(crs_path)), - size_hint){}; + : StandardHonkComposer( + std::unique_ptr(new proof_system::FileReferenceStringFactory(crs_path)), + size_hint){}; - StandardHonkComposer(std::shared_ptr const& crs_factory, - const size_t size_hint = 0) + StandardHonkComposer(std::shared_ptr const& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(crs_factory) , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables) {} - StandardHonkComposer(std::unique_ptr&& crs_factory, - const size_t size_hint = 0) + StandardHonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(std::move(crs_factory)) , num_gates(circuit_constructor.num_gates) diff --git a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp index 314b26d02c..0902129370 100644 --- a/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/prover_library.test.cpp @@ -47,12 +47,11 @@ template class ProverLibraryTests : public testing::Test { // Define some mock inputs for proving key constructor static const size_t num_gates = 8; static const size_t num_public_inputs = 0; - auto reference_string = - std::make_shared(num_gates + 1, "../srs_db/ignition"); + auto reference_string = std::make_shared(num_gates + 1, "../srs_db/ignition"); // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. auto proving_key = std::make_shared( - num_gates, num_public_inputs, reference_string, proof_system::ComposerType::STANDARD_HONK); + num_gates, num_public_inputs, reference_string, ComposerType::STANDARD_HONK); // static const size_t program_width = StandardProver::settings_::program_width; @@ -157,12 +156,11 @@ template class ProverLibraryTests : public testing::Test { // Define some mock inputs for proving key constructor static const size_t circuit_size = 8; static const size_t num_public_inputs = 0; - auto reference_string = - std::make_shared(circuit_size + 1, "../srs_db/ignition"); + auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); // Instatiate a proving_key and make a pointer to it. This will be used to instantiate a Prover. auto proving_key = std::make_shared( - circuit_size, num_public_inputs, reference_string, proof_system::ComposerType::STANDARD_HONK); + circuit_size, num_public_inputs, reference_string, ComposerType::STANDARD_HONK); // Construct mock wire and permutation polynomials. // Note: for the purpose of checking the consistency between two methods of computing z_perm, these polynomials @@ -287,10 +285,9 @@ template class ProverLibraryTests : public testing::Test { // Construct a proving_key static const size_t circuit_size = 8; static const size_t num_public_inputs = 0; - auto reference_string = - std::make_shared(circuit_size + 1, "../srs_db/ignition"); + auto reference_string = std::make_shared(circuit_size + 1, "../srs_db/ignition"); auto proving_key = std::make_shared( - circuit_size, num_public_inputs, reference_string, proof_system::ComposerType::STANDARD_HONK); + circuit_size, num_public_inputs, reference_string, ComposerType::STANDARD_HONK); // Get random challenge eta auto eta = FF::random_element(); diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.cpp index a40054f2c5..26e4b7e033 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.cpp @@ -83,9 +83,9 @@ template bool Verifier::verify_pro using Gemini = pcs::gemini::MultilinearReductionScheme; using Shplonk = pcs::shplonk::SingleBatchOpeningScheme; using KZG = pcs::kzg::UnivariateOpeningScheme; - const size_t NUM_POLYNOMIALS = proof_system::honk::StandardArithmetization::NUM_POLYNOMIALS; - const size_t NUM_UNSHIFTED = proof_system::honk::StandardArithmetization::NUM_UNSHIFTED_POLYNOMIALS; - const size_t NUM_PRECOMPUTED = proof_system::honk::StandardArithmetization::NUM_PRECOMPUTED_POLYNOMIALS; + const size_t NUM_POLYNOMIALS = honk::StandardArithmetization::NUM_POLYNOMIALS; + const size_t NUM_UNSHIFTED = honk::StandardArithmetization::NUM_UNSHIFTED_POLYNOMIALS; + const size_t NUM_PRECOMPUTED = honk::StandardArithmetization::NUM_PRECOMPUTED_POLYNOMIALS; constexpr auto num_wires = program_settings::num_wires; diff --git a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp index 482281ca89..42f559aabf 100644 --- a/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp +++ b/cpp/src/barretenberg/honk/proof_system/verifier.test.cpp @@ -50,7 +50,7 @@ template class VerifierTests : public testing::Test { prover)); } - auto crs = std::make_shared("../srs_db/ignition"); + auto crs = std::make_shared("../srs_db/ignition"); auto circuit_verification_key = std::make_shared(circuit_proving_key->circuit_size, circuit_proving_key->num_public_inputs, @@ -82,9 +82,9 @@ template class VerifierTests : public testing::Test { // Create some constraints that satisfy our arithmetic circuit relation // even indices = mul gates, odd incides = add gates - auto crs = std::make_shared(n + 1, "../srs_db/ignition"); + auto crs = std::make_shared(n + 1, "../srs_db/ignition"); std::shared_ptr proving_key = - std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD_HONK); + std::make_shared(n, 0, crs, ComposerType::STANDARD_HONK); polynomial w_l(n); polynomial w_r(n); @@ -178,8 +178,8 @@ template class VerifierTests : public testing::Test { proving_key->polynomial_store.put("sigma_2_lagrange", std::move(sigma_2_lagrange_base)); proving_key->polynomial_store.put("sigma_3_lagrange", std::move(sigma_3_lagrange_base)); - proof_system::compute_standard_honk_id_polynomials<3>(proving_key); - proof_system::compute_first_and_last_lagrange_polynomials(proving_key); + compute_standard_honk_id_polynomials<3>(proving_key); + compute_first_and_last_lagrange_polynomials(proving_key); proving_key->polynomial_store.put("w_1_lagrange", std::move(w_l)); proving_key->polynomial_store.put("w_2_lagrange", std::move(w_r)); diff --git a/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp b/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp index d9d792daf8..d30650154a 100644 --- a/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/polynomials/multivariates.test.cpp @@ -59,7 +59,7 @@ TYPED_TEST(MultivariatesTests, FoldTwoRoundsSpecial) std::array f0 = { v00, v10, v01, v11 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = proof_system::honk::ProverTranscript::init_empty(); + auto transcript = honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = { 0x6c7301b49d85a46c, 0x44311531e39c64f6, 0xb13d66d8d6c1a24c, 0x04410c360230a295 }; @@ -94,7 +94,7 @@ TYPED_TEST(MultivariatesTests, FoldTwoRoundsGeneric) std::array f0 = { v00, v10, v01, v11 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = proof_system::honk::ProverTranscript::init_empty(); + auto transcript = honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = FF::random_element(); @@ -153,7 +153,7 @@ TYPED_TEST(MultivariatesTests, FoldThreeRoundsSpecial) std::array f0 = { v000, v100, v010, v110, v001, v101, v011, v111 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = proof_system::honk::ProverTranscript::init_empty(); + auto transcript = honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = 1; @@ -202,7 +202,7 @@ TYPED_TEST(MultivariatesTests, FoldThreeRoundsGeneric) std::array f0 = { v000, v100, v010, v110, v001, v101, v011, v111 }; auto full_polynomials = std::array, 1>({ f0 }); - auto transcript = proof_system::honk::ProverTranscript::init_empty(); + auto transcript = honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); FF round_challenge_0 = FF::random_element(); @@ -261,7 +261,7 @@ TYPED_TEST(MultivariatesTests, FoldThreeRoundsGenericMultiplePolys) std::array f2 = { v000[2], v100[2], v010[2], v110[2], v001[2], v101[2], v011[2], v111[2] }; auto full_polynomials = std::array, 3>{ f0, f1, f2 }; - auto transcript = proof_system::honk::ProverTranscript::init_empty(); + auto transcript = honk::ProverTranscript::init_empty(); auto sumcheck = Sumcheck(multivariate_n, transcript); std::array expected_q1; diff --git a/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp b/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp index 89ea8d5444..6b7e1ac521 100644 --- a/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp +++ b/cpp/src/barretenberg/honk/sumcheck/relations/relation.test.cpp @@ -173,7 +173,7 @@ TYPED_TEST_SUITE(SumcheckRelation, FieldTypes); TYPED_TEST(SumcheckRelation, ArithmeticRelation) { SUMCHECK_RELATION_TYPE_ALIASES - using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; const auto relation_parameters = TestFixture::compute_mock_relation_parameters(); auto run_test = [&relation_parameters](bool is_random_input) { std::array, NUM_POLYNOMIALS> extended_edges; @@ -216,7 +216,7 @@ TYPED_TEST(SumcheckRelation, ArithmeticRelation) TYPED_TEST(SumcheckRelation, GrandProductComputationRelation) { SUMCHECK_RELATION_TYPE_ALIASES - using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; const auto relation_parameters = TestFixture::compute_mock_relation_parameters(); auto run_test = [&relation_parameters](bool is_random_input) { std::array, NUM_POLYNOMIALS> extended_edges; @@ -278,7 +278,7 @@ TYPED_TEST(SumcheckRelation, GrandProductComputationRelation) TYPED_TEST(SumcheckRelation, GrandProductInitializationRelation) { SUMCHECK_RELATION_TYPE_ALIASES - using MULTIVARIATE = proof_system::honk::StandardArithmetization::POLYNOMIAL; + using MULTIVARIATE = honk::StandardArithmetization::POLYNOMIAL; const auto relation_parameters = TestFixture::compute_mock_relation_parameters(); auto run_test = [&relation_parameters](bool is_random_input) { std::array, NUM_POLYNOMIALS> extended_edges; diff --git a/cpp/src/barretenberg/join_split_example/proofs/verify.hpp b/cpp/src/barretenberg/join_split_example/proofs/verify.hpp index 4c26b58980..b37b511691 100644 --- a/cpp/src/barretenberg/join_split_example/proofs/verify.hpp +++ b/cpp/src/barretenberg/join_split_example/proofs/verify.hpp @@ -26,7 +26,7 @@ template struct verify_result { template inline bool pairing_check(plonk::stdlib::recursion::recursion_output> recursion_output, - std::shared_ptr const& srs) + std::shared_ptr const& srs) { g1::affine_element P[2]; P[0].x = barretenberg::fq(recursion_output.P0.x.get_value().lo); diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.cpp b/cpp/src/barretenberg/plonk/composer/composer_base.cpp index 2874935584..46e404a57e 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.cpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.cpp @@ -231,7 +231,7 @@ template void ComposerBase::compute_sigma * @param num_reserved_gates The number of reserved gates. * @return Pointer to the initialized proving key updated with selector polynomials. * */ -std::shared_ptr ComposerBase::compute_proving_key_base(const proof_system::ComposerType composer_type, +std::shared_ptr ComposerBase::compute_proving_key_base(const ComposerType composer_type, const size_t minimum_circuit_size, const size_t num_reserved_gates) { diff --git a/cpp/src/barretenberg/plonk/composer/composer_base.hpp b/cpp/src/barretenberg/plonk/composer/composer_base.hpp index 4d9c9dd896..6c93da04b1 100644 --- a/cpp/src/barretenberg/plonk/composer/composer_base.hpp +++ b/cpp/src/barretenberg/plonk/composer/composer_base.hpp @@ -110,7 +110,7 @@ class ComposerBase { virtual size_t get_total_circuit_size() const = 0; virtual void print_num_gates() const { std::cout << num_gates << std::endl; } virtual size_t get_num_variables() const { return variables.size(); } - virtual std::shared_ptr compute_proving_key_base(const proof_system::ComposerType type = STANDARD, + virtual std::shared_ptr compute_proving_key_base(const ComposerType type = STANDARD, const size_t minimum_ciricut_size = 0, const size_t num_reserved_gates = NUM_RESERVED_GATES); // This needs to be static as it may be used only to compute the selector commitments. diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp index 7d2a7972b2..4ab16d7434 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.cpp @@ -44,8 +44,7 @@ void compute_monomial_and_coset_selector_forms(plonk::proving_key* circuit_provi * (2) sets the polynomial manifest using the data from proving key. */ std::shared_ptr compute_verification_key_common( - std::shared_ptr const& proving_key, - std::shared_ptr const& vrs) + std::shared_ptr const& proving_key, std::shared_ptr const& vrs) { auto circuit_verification_key = std::make_shared( proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp index f8f18cd92a..927174cc0f 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp @@ -24,7 +24,6 @@ void compute_monomial_and_coset_selector_forms(plonk::proving_key* key, * (2) sets the polynomial manifest using the data from proving key. */ std::shared_ptr compute_verification_key_common( - std::shared_ptr const& proving_key, - std::shared_ptr const& vrs); + std::shared_ptr const& proving_key, std::shared_ptr const& vrs); } // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp index 968cf07abd..601de58dac 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.cpp @@ -7,6 +7,7 @@ #include "barretenberg/plonk/proof_system/commitment_scheme/kate_commitment_scheme.hpp" #include "barretenberg/proof_system/composer/composer_helper_lib.hpp" #include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" +#include "barretenberg/proof_system/composer/permutation_helper.hpp" #include #include @@ -64,21 +65,18 @@ std::shared_ptr StandardPlonkComposerHelper( - circuit_constructor, circuit_proving_key.get()); + compute_standard_plonk_sigma_permutations(circuit_constructor, + circuit_proving_key.get()); circuit_proving_key->recursive_proof_public_input_indices = std::vector(recursive_proof_public_input_indices.begin(), recursive_proof_public_input_indices.end()); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp index 2074d91b1d..32085fcb57 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/standard_plonk_composer_helper.hpp @@ -8,7 +8,6 @@ #include "barretenberg/honk/pcs/commitment_key.hpp" #include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" -#include "barretenberg/proof_system/composer/permutation_helper.hpp" #include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" #include @@ -23,22 +22,21 @@ template class StandardPlonkComposerHelper { std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; std::vector recursive_proof_public_input_indices; bool contains_recursive_proof = false; bool computed_witness = false; StandardPlonkComposerHelper() - : StandardPlonkComposerHelper(std::shared_ptr( + : StandardPlonkComposerHelper(std::shared_ptr( new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) {} - - StandardPlonkComposerHelper(std::shared_ptr crs_factory) + StandardPlonkComposerHelper(std::shared_ptr crs_factory) : crs_factory_(std::move(crs_factory)) {} - StandardPlonkComposerHelper(std::unique_ptr&& crs_factory) + StandardPlonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} StandardPlonkComposerHelper(std::shared_ptr p_key, diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp index 04f2b3fbcd..c24524a928 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.cpp @@ -11,6 +11,9 @@ #include "barretenberg/plonk/proof_system/widgets/transition_widgets/transition_widget.hpp" #include "barretenberg/plonk/proof_system/widgets/transition_widgets/turbo_arithmetic_widget.hpp" #include "barretenberg/proof_system/composer/permutation_helper.hpp" +#include "barretenberg/proof_system/composer/composer_helper_lib.hpp" +#include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" + using namespace barretenberg; namespace proof_system::plonk { @@ -37,21 +40,18 @@ std::shared_ptr TurboPlonkComposerHelper const size_t num_randomized_gates = NUM_RANDOMIZED_GATES; // Initialize circuit_proving_key // TODO(#229)(Kesha): replace composer types. - circuit_proving_key = proof_system::initialize_proving_key(circuit_constructor, - crs_factory_.get(), - minimum_circuit_size, - num_randomized_gates, - proof_system::ComposerType::TURBO); + circuit_proving_key = initialize_proving_key( + circuit_constructor, crs_factory_.get(), minimum_circuit_size, num_randomized_gates, ComposerType::TURBO); - proof_system::construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); + construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); - proof_system::enforce_nonzero_polynomial_selectors(circuit_constructor, circuit_proving_key.get()); + enforce_nonzero_polynomial_selectors(circuit_constructor, circuit_proving_key.get()); compute_monomial_and_coset_selector_forms(circuit_proving_key.get(), turbo_selector_properties()); // Compute sigma polynomials (TODO(kesha): we should update that late) - proof_system::compute_standard_plonk_sigma_permutations( - circuit_constructor, circuit_proving_key.get()); + compute_standard_plonk_sigma_permutations(circuit_constructor, + circuit_proving_key.get()); circuit_proving_key->recursive_proof_public_input_indices = std::vector(recursive_proof_public_input_indices.begin(), recursive_proof_public_input_indices.end()); circuit_proving_key->contains_recursive_proof = contains_recursive_proof; diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp index 5153124fd8..2f12901330 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/turbo_plonk_composer_helper.hpp @@ -12,7 +12,7 @@ template class TurboPlonkComposerHelper { public: static constexpr size_t NUM_RANDOMIZED_GATES = 2; // equal to the number of multilinear evaluations leaked static constexpr size_t program_width = CircuitConstructor::program_width; - static constexpr proof_system::ComposerType type = proof_system::ComposerType::TURBO; + static constexpr ComposerType type = ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; std::shared_ptr circuit_proving_key; @@ -20,21 +20,21 @@ template class TurboPlonkComposerHelper { // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; std::vector recursive_proof_public_input_indices; bool contains_recursive_proof = false; bool computed_witness = false; TurboPlonkComposerHelper() - : TurboPlonkComposerHelper(std::shared_ptr( + : TurboPlonkComposerHelper(std::shared_ptr( new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) {} - TurboPlonkComposerHelper(std::shared_ptr crs_factory) + TurboPlonkComposerHelper(std::shared_ptr crs_factory) : crs_factory_(std::move(crs_factory)) {} - TurboPlonkComposerHelper(std::unique_ptr&& crs_factory) + TurboPlonkComposerHelper(std::unique_ptr&& crs_factory) : crs_factory_(std::move(crs_factory)) {} TurboPlonkComposerHelper(std::shared_ptr p_key, std::shared_ptr v_key) diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.cpp index 9049ed0e0b..26e7049443 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.cpp @@ -10,7 +10,7 @@ #include #include -namespace plonk { +namespace proof_system::plonk { /** * @brief Computes `this.witness`, which is basiclly a set of polynomials mapped-to by strings. @@ -228,11 +228,8 @@ std::shared_ptr UltraPlonkComposerHelper::compu const size_t num_randomized_gates = NUM_RANDOMIZED_GATES; // Initialize circuit_proving_key // TODO(#229)(Kesha): replace composer types. - circuit_proving_key = initialize_proving_key(circuit_constructor, - crs_factory_.get(), - minimum_circuit_size, - num_randomized_gates, - plonk::ComposerType::PLOOKUP); + circuit_proving_key = initialize_proving_key( + circuit_constructor, crs_factory_.get(), minimum_circuit_size, num_randomized_gates, ComposerType::PLOOKUP); construct_lagrange_selector_forms(circuit_constructor, circuit_proving_key.get()); @@ -240,8 +237,8 @@ std::shared_ptr UltraPlonkComposerHelper::compu compute_monomial_and_coset_selector_forms(circuit_proving_key.get(), ultra_selector_properties()); - bonk::compute_plonk_generalized_sigma_permutations(circuit_constructor, - circuit_proving_key.get()); + compute_plonk_generalized_sigma_permutations(circuit_constructor, + circuit_proving_key.get()); const size_t subgroup_size = circuit_proving_key->circuit_size; @@ -350,7 +347,7 @@ std::shared_ptr UltraPlonkComposerHelper::compu * @return Pointer to created circuit verification key. * */ template -std::shared_ptr UltraPlonkComposerHelper::compute_verification_key( +std::shared_ptr UltraPlonkComposerHelper::compute_verification_key( const CircuitConstructor& circuit_constructor) { if (circuit_verification_key) { @@ -391,4 +388,4 @@ void UltraPlonkComposerHelper::add_table_column_selector_pol } template class UltraPlonkComposerHelper; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.hpp index 45b218460d..c66ce7eea0 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.hpp @@ -1,15 +1,16 @@ #pragma once #include "barretenberg/proof_system/composer/composer_helper_lib.hpp" +#include "barretenberg/plonk/composer/splitting_tmp/composer_helper/composer_helper_lib.hpp" #include "barretenberg/srs/reference_string/file_reference_string.hpp" -#include "barretenberg/proof_system/proving_key/proving_key.hpp" +#include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" #include "barretenberg/plonk/proof_system/prover/prover.hpp" #include "barretenberg/plonk/proof_system/verifier/verifier.hpp" #include #include -namespace plonk { +namespace proof_system::plonk { // TODO(Kesha): change initializations to specify this parameter // Cody: What does this mean? template class UltraPlonkComposerHelper { @@ -21,11 +22,11 @@ template class UltraPlonkComposerHelper { // simultaneously here and in the other split composers. static constexpr size_t NUM_RANDOMIZED_GATES = 4; // equal to the number of multilinear evaluations leaked static constexpr size_t program_width = CircuitConstructor::program_width; - std::shared_ptr circuit_proving_key; - std::shared_ptr circuit_verification_key; + std::shared_ptr circuit_proving_key; + std::shared_ptr circuit_verification_key; // TODO(#218)(kesha): we need to put this into the commitment key, so that the composer doesn't have to handle srs // at all - std::shared_ptr crs_factory_; + std::shared_ptr crs_factory_; std::vector recursive_proof_public_input_indices; bool contains_recursive_proof = false; @@ -52,7 +53,7 @@ template class UltraPlonkComposerHelper { UltraPlonkComposerHelper& operator=(UltraPlonkComposerHelper const& other) noexcept = default; ~UltraPlonkComposerHelper() = default; - std::vector ultra_selector_properties() + std::vector ultra_selector_properties() { // When reading and writing the proving key from a buffer we must precompute the Lagrange form of certain // selector polynomials. In order to avoid a new selector type and definitions in the polynomial manifest, we @@ -63,7 +64,7 @@ template class UltraPlonkComposerHelper { // { "q_m", true }, { "q_c", true }, { "q_1", true }, { "q_2", true }, // { "q_3", true }, { "q_4", false }, { "q_arith", false }, { "q_sort", false }, // { "q_elliptic", false }, { "q_aux", false }, { "table_type", true }, - std::vector result{ + std::vector result{ { "q_m", true }, { "q_c", true }, { "q_1", true }, { "q_2", true }, { "q_3", true }, { "q_4", true }, { "q_arith", true }, { "q_sort", true }, { "q_elliptic", true }, { "q_aux", true }, { "table_type", true }, @@ -75,8 +76,8 @@ template class UltraPlonkComposerHelper { void finalize_circuit(CircuitConstructor& circuit_constructor) { circuit_constructor.finalize_circuit(); }; - std::shared_ptr compute_proving_key(const CircuitConstructor& circuit_constructor); - std::shared_ptr compute_verification_key(const CircuitConstructor& circuit_constructor); + std::shared_ptr compute_proving_key(const CircuitConstructor& circuit_constructor); + std::shared_ptr compute_verification_key(const CircuitConstructor& circuit_constructor); void compute_witness(CircuitConstructor& circuit_constructor); @@ -208,4 +209,4 @@ template class UltraPlonkComposerHelper { } }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp index c8571b94ee..34e51f92de 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.hpp @@ -16,7 +16,7 @@ namespace proof_system::plonk { */ class StandardPlonkComposer { public: - static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD; + static constexpr ComposerType type = ComposerType::STANDARD; static constexpr size_t UINT_LOG2_BASE = 2; // An instantiation of the circuit constructor that only depends on arithmetization, not on the proof system @@ -39,20 +39,18 @@ class StandardPlonkComposer { , variables(circuit_constructor.variables){}; StandardPlonkComposer(std::string const& crs_path, const size_t size_hint = 0) - : StandardPlonkComposer(std::unique_ptr( - new proof_system::FileReferenceStringFactory(crs_path)), - size_hint){}; + : StandardPlonkComposer( + std::unique_ptr(new proof_system::FileReferenceStringFactory(crs_path)), + size_hint){}; - StandardPlonkComposer(std::shared_ptr const& crs_factory, - const size_t size_hint = 0) + StandardPlonkComposer(std::shared_ptr const& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(crs_factory) , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables) {} - StandardPlonkComposer(std::unique_ptr&& crs_factory, - const size_t size_hint = 0) + StandardPlonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(std::move(crs_factory)) , num_gates(circuit_constructor.num_gates) diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp index fb9373f76b..0ff53d40b0 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/standard_plonk_composer.test.cpp @@ -13,7 +13,7 @@ auto& engine = numeric::random::get_debug_engine(); TEST(standard_plonk_composer_splitting_tmp, base_case) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); fr a = fr::one(); composer.add_public_variable(a); plonk::Prover prover = composer.create_prover(); @@ -27,7 +27,7 @@ TEST(standard_plonk_composer_splitting_tmp, base_case) TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); fr a = fr::one(); composer.add_public_variable(a); @@ -36,12 +36,12 @@ TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) auto pk_data = from_buffer(pk_buf); auto vk_data = from_buffer(vk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); - plonk::StandardPlonkComposer composer2 = proof_system::plonk::StandardPlonkComposer(proving_key, verification_key); + plonk::StandardPlonkComposer composer2 = plonk::StandardPlonkComposer(proving_key, verification_key); composer2.add_public_variable(a); plonk::Prover prover = composer2.create_prover(); @@ -55,7 +55,7 @@ TEST(standard_plonk_composer_splitting_tmp, composer_from_serialized_keys) TEST(standard_plonk_composer_splitting_tmp, test_add_gate_proofs) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); fr a = fr::one(); uint32_t a_idx = composer.add_public_variable(a); fr b = fr::one(); @@ -114,7 +114,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_add_gate_proofs) TEST(standard_plonk_composer_splitting_tmp, test_mul_gate_proofs) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); fr q[7]{ fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element(), fr::random_element() }; fr q_inv[7]{ @@ -193,7 +193,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_mul_gate_proofs) TEST(standard_plonk_composer_splitting_tmp, range_constraint) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); for (size_t i = 0; i < 10; ++i) { uint32_t value = engine.get_random_uint32(); @@ -236,7 +236,7 @@ TEST(standard_plonk_composer_splitting_tmp, range_constraint) TEST(standard_plonk_composer_splitting_tmp, range_constraint_fail) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); uint64_t value = 0xffffff; uint32_t witness_index = composer.add_variable(fr(value)); @@ -256,7 +256,7 @@ TEST(standard_plonk_composer_splitting_tmp, range_constraint_fail) TEST(standard_plonk_composer_splitting_tmp, and_constraint) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); for (size_t i = 0; i < /*10*/ 1; ++i) { uint32_t left_value = engine.get_random_uint32(); @@ -327,7 +327,7 @@ TEST(standard_plonk_composer_splitting_tmp, and_constraint) TEST(standard_plonk_composer_splitting_tmp, xor_constraint) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); for (size_t i = 0; i < /*10*/ 1; ++i) { uint32_t left_value = engine.get_random_uint32(); @@ -397,7 +397,7 @@ TEST(standard_plonk_composer_splitting_tmp, xor_constraint) TEST(standard_plonk_composer_splitting_tmp, big_add_gate_with_bit_extract) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); const auto generate_constraints = [&composer](uint32_t quad_value) { uint32_t quad_accumulator_left = @@ -441,7 +441,7 @@ TEST(standard_plonk_composer_splitting_tmp, big_add_gate_with_bit_extract) TEST(standard_plonk_composer_splitting_tmp, test_range_constraint_fail) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); uint32_t witness_index = composer.add_variable(fr::neg_one()); composer.decompose_into_base4_accumulators(witness_index, 32); @@ -458,7 +458,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_range_constraint_fail) TEST(standard_plonk_composer_splitting_tmp, test_check_circuit_correct) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); fr a = fr::one(); uint32_t a_idx = composer.add_public_variable(a); fr b = fr::one(); @@ -478,7 +478,7 @@ TEST(standard_plonk_composer_splitting_tmp, test_check_circuit_correct) TEST(standard_plonk_composer_splitting_tmp, test_check_circuit_broken) { - plonk::StandardPlonkComposer composer = proof_system::plonk::StandardPlonkComposer(); + plonk::StandardPlonkComposer composer = plonk::StandardPlonkComposer(); fr a = fr::one(); uint32_t a_idx = composer.add_public_variable(a); fr b = fr::one(); diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp index 93b7450c94..6019662bb5 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/turbo_plonk_composer.hpp @@ -12,7 +12,7 @@ namespace proof_system::plonk { */ class TurboPlonkComposer { public: - static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD; + static constexpr ComposerType type = ComposerType::STANDARD; static constexpr size_t UINT_LOG2_BASE = 2; @@ -38,18 +38,17 @@ class TurboPlonkComposer { , variables(circuit_constructor.variables){}; TurboPlonkComposer(std::string const& crs_path, const size_t size_hint = 0) - : TurboPlonkComposer(std::unique_ptr( - new proof_system::FileReferenceStringFactory(crs_path)), - size_hint){}; + : TurboPlonkComposer( + std::unique_ptr(new proof_system::FileReferenceStringFactory(crs_path)), + size_hint){}; - TurboPlonkComposer(std::shared_ptr const& crs_factory, - const size_t size_hint = 0) + TurboPlonkComposer(std::shared_ptr const& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(crs_factory) , num_gates(circuit_constructor.num_gates) , variables(circuit_constructor.variables){}; - TurboPlonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) + TurboPlonkComposer(std::unique_ptr&& crs_factory, const size_t size_hint = 0) : circuit_constructor(size_hint) , composer_helper(std::move(crs_factory)) , num_gates(circuit_constructor.num_gates) diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.hpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.hpp index 4c448818ad..d66c99aa1d 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.hpp @@ -6,9 +6,7 @@ #include "barretenberg/plonk/composer/splitting_tmp/composer_helper/ultra_plonk_composer_helper.hpp" #include -using namespace bonk; - -namespace plonk { +namespace proof_system::plonk { class UltraPlonkComposer { @@ -364,7 +362,7 @@ class UltraPlonkComposer { // std::array decompose_non_native_field_double_width_limb( // const uint32_t limb_idx, const size_t num_limb_bits = (2 * DEFAULT_NON_NATIVE_FIELD_LIMB_BITS)); std::array evaluate_non_native_field_multiplication( - const bonk::non_native_field_witnesses& input, const bool range_constrain_quotient_and_remainder = true) + const non_native_field_witnesses& input, const bool range_constrain_quotient_and_remainder = true) { return circuit_constructor.evaluate_non_native_field_multiplication(input, range_constrain_quotient_and_remainder); @@ -473,4 +471,4 @@ class UltraPlonkComposer { // std::vector recursive_proof_public_input_indices; // bool contains_recursive_proof = false; }; -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.test.cpp index 416cee213e..d5c2128e05 100644 --- a/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/splitting_tmp/ultra_plonk_composer.test.cpp @@ -9,9 +9,8 @@ #include "barretenberg/numeric/uintx/uintx.hpp" using namespace barretenberg; -using namespace bonk; -namespace plonk { +namespace proof_system::plonk { namespace { auto& engine = numeric::random::get_debug_engine(); @@ -780,7 +779,7 @@ TEST(ultra_plonk_composer_splitting_tmp, non_native_field_multiplication) const auto q_indices = get_limb_witness_indices(split_into_limbs(uint256_t(q))); const auto r_indices = get_limb_witness_indices(split_into_limbs(uint256_t(r))); - bonk::non_native_field_witnesses inputs{ + non_native_field_witnesses inputs{ a_indices, b_indices, q_indices, r_indices, modulus_limbs, fr(uint256_t(modulus)), }; const auto [lo_1_idx, hi_1_idx] = composer.evaluate_non_native_field_multiplication(inputs); @@ -914,4 +913,4 @@ TEST(ultra_plonk_composer_splitting_tmp, ram) EXPECT_EQ(result, true); } -} // namespace plonk +} // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.hpp b/cpp/src/barretenberg/plonk/composer/standard_composer.hpp index a4d3fc4bc7..f8ec645533 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.hpp @@ -16,7 +16,7 @@ inline std::vector standard_selector_propertie class StandardComposer : public ComposerBase { public: - static constexpr proof_system::ComposerType type = proof_system::ComposerType::STANDARD; + static constexpr ComposerType type = ComposerType::STANDARD; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; diff --git a/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp b/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp index d593040f21..c4413ce080 100644 --- a/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp +++ b/cpp/src/barretenberg/plonk/composer/standard_composer.test.cpp @@ -37,7 +37,7 @@ TEST(standard_composer, composer_from_serialized_keys) auto pk_data = from_buffer(pk_buf); auto vk_data = from_buffer(vk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); auto verification_key = std::make_shared(std::move(vk_data), crs->get_verifier_crs()); diff --git a/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp b/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp index 80087bb131..5f4ffda9af 100644 --- a/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/turbo_composer.hpp @@ -4,7 +4,7 @@ namespace proof_system::plonk { class TurboComposer : public ComposerBase { public: - static constexpr proof_system::ComposerType type = proof_system::ComposerType::TURBO; + static constexpr ComposerType type = ComposerType::TURBO; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::FIXED_BASE_PEDERSEN; static constexpr size_t UINT_LOG2_BASE = 2; enum TurboSelectors { QM, QC, Q1, Q2, Q3, Q4, Q5, QARITH, QFIXED, QRANGE, QLOGIC, NUM }; @@ -227,10 +227,8 @@ class CheckGetter { } }; -using TurboArithmeticChecker = - proof_system::plonk::widget::TurboArithmeticKernel; -using TurboRangeChecker = proof_system::plonk::widget::TurboRangeKernel; -using TurboLogicChecker = proof_system::plonk::widget::TurboLogicKernel; -using TurboFixedBaseChecker = - proof_system::plonk::widget::TurboFixedBaseKernel; +using TurboArithmeticChecker = widget::TurboArithmeticKernel; +using TurboRangeChecker = widget::TurboRangeKernel; +using TurboLogicChecker = widget::TurboLogicKernel; +using TurboFixedBaseChecker = widget::TurboFixedBaseKernel; } // namespace proof_system::plonk diff --git a/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp b/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp index 301e7a656c..7fa42ed939 100644 --- a/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp +++ b/cpp/src/barretenberg/plonk/composer/ultra_composer.hpp @@ -8,7 +8,7 @@ namespace proof_system::plonk { class UltraComposer : public ComposerBase { public: - static constexpr proof_system::ComposerType type = proof_system::ComposerType::PLOOKUP; + static constexpr ComposerType type = ComposerType::PLOOKUP; static constexpr MerkleHashType merkle_hash_type = MerkleHashType::LOOKUP_PEDERSEN; static constexpr size_t NUM_RESERVED_GATES = 4; // This must be >= num_roots_cut_out_of_vanishing_polynomial // See the comment in plonk/proof_system/prover/prover.cpp diff --git a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp index 51ba344e26..933de8cd5d 100644 --- a/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/commitment_scheme/commitment_scheme.test.cpp @@ -36,9 +36,9 @@ TEST(commitment_scheme, kate_open) plonk::KateCommitmentScheme newKate; // std::shared_ptr crs_factory = (new FileReferenceStringFactory("../srs_db/ignition")); - auto file_crs = std::make_shared("../srs_db/ignition"); + auto file_crs = std::make_shared("../srs_db/ignition"); auto crs = file_crs->get_prover_crs(n); - auto circuit_proving_key = std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD); + auto circuit_proving_key = std::make_shared(n, 0, crs, ComposerType::STANDARD); work_queue queue(circuit_proving_key.get(), &inp_tx); newKate.commit(&coeffs[0], "F_COMM", 0, queue); @@ -93,9 +93,9 @@ TEST(commitment_scheme, kate_batch_open) transcript::StandardTranscript inp_tx = transcript::StandardTranscript(transcript::Manifest()); plonk::KateCommitmentScheme newKate; - auto file_crs = std::make_shared("../srs_db/ignition"); + auto file_crs = std::make_shared("../srs_db/ignition"); auto crs = file_crs->get_prover_crs(n); - auto circuit_proving_key = std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD); + auto circuit_proving_key = std::make_shared(n, 0, crs, ComposerType::STANDARD); work_queue queue(circuit_proving_key.get(), &inp_tx); // commit to individual polynomials diff --git a/cpp/src/barretenberg/plonk/proof_system/constants.hpp b/cpp/src/barretenberg/plonk/proof_system/constants.hpp index 5c7336d49c..debf064c8f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/constants.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/constants.hpp @@ -9,7 +9,7 @@ namespace proof_system::plonk { #ifdef USE_TURBO static constexpr uint32_t SYSTEM_COMPOSER = ComposerType::TURBO; #else -static constexpr uint32_t SYSTEM_COMPOSER = proof_system::ComposerType::PLOOKUP; +static constexpr uint32_t SYSTEM_COMPOSER = ComposerType::PLOOKUP; #endif enum MerkleHashType { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp index 100ce79047..6cd4d4c7af 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind.cpp @@ -48,9 +48,8 @@ WASM_EXPORT void* test_env_load_prover_crs(size_t num_points) { return env_load_prover_crs(num_points); } -typedef std:: - conditional_t - WasmProver; +typedef std::conditional_t + WasmProver; WASM_EXPORT void prover_process_queue(WasmProver* prover) { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp index 3de3e3a02e..66cfdc7496 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/c_bind_unrolled.cpp @@ -8,9 +8,8 @@ using namespace barretenberg; extern "C" { // TODO(Cody): Removed "unrolled" here when the time comes, if it does. -typedef std:: - conditional_t - WasmUnrolledProver; +typedef std::conditional_t + WasmUnrolledProver; WASM_EXPORT void unrolled_prover_process_queue(WasmUnrolledProver* prover) { diff --git a/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp b/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp index 2f170b1e29..50a535f946 100644 --- a/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/prover/prover.test.cpp @@ -112,9 +112,8 @@ plonk::Prover generate_test_data(const size_t n) // even indices = mul gates, odd incides = add gates - auto reference_string = std::make_shared(n + 1, "../srs_db/ignition"); - std::shared_ptr key = - std::make_shared(n, 0, reference_string, proof_system::ComposerType::STANDARD); + auto reference_string = std::make_shared(n + 1, "../srs_db/ignition"); + std::shared_ptr key = std::make_shared(n, 0, reference_string, ComposerType::STANDARD); polynomial w_l(n); polynomial w_r(n); @@ -277,7 +276,7 @@ plonk::Prover generate_test_data(const size_t n) std::unique_ptr> kate_commitment_scheme = std::make_unique>(); - plonk::Prover state = proof_system::plonk::Prover(key, create_manifest()); + plonk::Prover state = plonk::Prover(key, create_manifest()); state.random_widgets.emplace_back(std::move(permutation_widget)); state.transition_widgets.emplace_back(std::move(widget)); state.commitment_scheme = std::move(kate_commitment_scheme); diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp index db4179c306..ea22d7f366 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.cpp @@ -22,11 +22,10 @@ namespace proof_system::plonk { * * Delegates to proving_key::init * */ -proving_key::proving_key( - const size_t num_gates, - const size_t num_inputs, - std::shared_ptr const& crs, - proof_system::ComposerType type = proof_system::ComposerType::STANDARD) // TODO(Cody): Don't use default for Honk +proving_key::proving_key(const size_t num_gates, + const size_t num_inputs, + std::shared_ptr const& crs, + ComposerType type = ComposerType::STANDARD) // TODO(Cody): Don't use default for Honk : composer_type(type) , circuit_size(num_gates) , log_circuit_size(numeric::get_msb(num_gates)) diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp index 6fef8bb861..f3198a5cbb 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.hpp @@ -20,7 +20,7 @@ struct proving_key_data { std::vector recursive_proof_public_input_indices; std::vector memory_read_records; std::vector memory_write_records; - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; }; struct proving_key { @@ -31,12 +31,12 @@ struct proving_key { RELATIVE_LOOKUP, }; - proving_key(proving_key_data&& data, std::shared_ptr const& crs); + proving_key(proving_key_data&& data, std::shared_ptr const& crs); proving_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, - proof_system::ComposerType type); + std::shared_ptr const& crs, + ComposerType type); proving_key(std::ostream& is, std::string const& crs_path); @@ -51,14 +51,14 @@ struct proving_key { std::vector memory_read_records; // Used by UltraComposer only; for ROM, RAM reads. std::vector memory_write_records; // Used by UltraComposer only, for RAM writes. - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; barretenberg::evaluation_domain small_domain; barretenberg::evaluation_domain large_domain; // The reference_string object contains the monomial SRS. We can access it using: // Monomial SRS: reference_string->get_monomial_points() - std::shared_ptr reference_string; + std::shared_ptr reference_string; barretenberg::polynomial quotient_polynomial_parts[plonk::NUM_QUOTIENT_PARTS]; diff --git a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp index 32a28fe96d..c3d2969fbf 100644 --- a/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/proving_key/proving_key.test.cpp @@ -15,14 +15,14 @@ using namespace proof_system; // Test proving key serialization/deserialization to/from buffer TEST(proving_key, proving_key_from_serialized_key) { - plonk::StandardComposer composer = proof_system::plonk::StandardComposer(); + plonk::StandardComposer composer = plonk::StandardComposer(); fr a = fr::one(); composer.add_public_variable(a); plonk::proving_key& p_key = *composer.compute_proving_key(); auto pk_buf = to_buffer(p_key); auto pk_data = from_buffer(pk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); @@ -51,14 +51,14 @@ TEST(proving_key, proving_key_from_serialized_key) // Test proving key serialization/deserialization to/from buffer using UltraComposer TEST(proving_key, proving_key_from_serialized_key_ultra) { - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = plonk::UltraComposer(); fr a = fr::one(); composer.add_public_variable(a); plonk::proving_key& p_key = *composer.compute_proving_key(); auto pk_buf = to_buffer(p_key); auto pk_data = from_buffer(pk_buf); - auto crs = std::make_unique("../srs_db/ignition"); + auto crs = std::make_unique("../srs_db/ignition"); auto proving_key = std::make_shared(std::move(pk_data), crs->get_prover_crs(pk_data.circuit_size + 1)); @@ -88,7 +88,7 @@ TEST(proving_key, proving_key_from_serialized_key_ultra) #ifndef __wasm__ TEST(proving_key, proving_key_from_mmaped_key) { - plonk::StandardComposer composer = proof_system::plonk::StandardComposer(); + plonk::StandardComposer composer = plonk::StandardComposer(); fr a = fr::one(); composer.add_public_variable(a); diff --git a/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp b/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp index c55cc9b13a..aefd348ff9 100644 --- a/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/types/polynomial_manifest.hpp @@ -4,8 +4,7 @@ #include #include #include "barretenberg/plonk/proof_system/constants.hpp" -// ToDo(Arijit): The below namespace should be plonk once all the honk related stuffs are moved out -// ToDo(Cody): This is now plonk-specific. + namespace proof_system::plonk { enum PolynomialSource { WITNESS, SELECTOR, PERMUTATION, OTHER }; @@ -176,19 +175,19 @@ class PolynomialManifest { PolynomialManifest(uint32_t composer_type) { switch (composer_type) { - case proof_system::ComposerType::STANDARD: { + case ComposerType::STANDARD: { std::copy(standard_polynomial_manifest, standard_polynomial_manifest + STANDARD_MANIFEST_SIZE, std::back_inserter(manifest)); break; }; - case proof_system::ComposerType::TURBO: { + case ComposerType::TURBO: { std::copy(turbo_polynomial_manifest, turbo_polynomial_manifest + TURBO_MANIFEST_SIZE, std::back_inserter(manifest)); break; }; - case proof_system::ComposerType::PLOOKUP: { + case ComposerType::PLOOKUP: { std::copy(ultra_polynomial_manifest, ultra_polynomial_manifest + ULTRA_MANIFEST_SIZE, std::back_inserter(manifest)); @@ -236,7 +235,7 @@ class PrecomputedPolyList { precomputed_poly_ids.emplace_back(label); precomputed_poly_ids.emplace_back(label + "_fft"); // Store all lagrange forms of selector polynomials for ultra - if (composer_type == proof_system::ComposerType::PLOOKUP) { + if (composer_type == ComposerType::PLOOKUP) { precomputed_poly_ids.emplace_back(label + "_lagrange"); } break; diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp index 9e549d212c..6342ea042f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/sol_gen.hpp @@ -5,7 +5,7 @@ namespace proof_system { * Uses StandardPlonk **/ inline void output_vk_sol_standard(std::ostream& os, - std::shared_ptr const& key, + std::shared_ptr const& key, std::string const& class_name) { const auto print_u256 = [&](const std::string& offset, const barretenberg::fr& element, const std::string& name) { @@ -65,7 +65,7 @@ inline void output_vk_sol_standard(std::ostream& os, * Write a solidity file containing the vk params to the given stream. * Uses UltraPlonk **/ -inline void output_vk_sol_ultra(std::ostream& os, std::shared_ptr const& key, std::string const& class_name) +inline void output_vk_sol_ultra(std::ostream& os, std::shared_ptr const& key, std::string const& class_name) { const auto print_u256 = [&](const std::string& offset, const barretenberg::fr& element, const std::string& name) { os << " mstore(add(_vk, " << offset << "), " << element << ") // " << name << std::endl; @@ -141,19 +141,19 @@ inline void output_vk_sol_ultra(std::ostream& os, std::shared_ptr const& key, std::string const& class_name) +inline void output_vk_sol(std::ostream& os, std::shared_ptr const& key, std::string const& class_name) { - proof_system::ComposerType composer_type = static_cast(key->composer_type); + ComposerType composer_type = static_cast(key->composer_type); switch (composer_type) { - case proof_system::ComposerType::STANDARD: { + case ComposerType::STANDARD: { return output_vk_sol_standard(os, key, class_name); break; } - // case proof_system::ComposerType::TURBO: { + // case ComposerType::TURBO: { // return output_vk_sol_turbo(os, key, class_name); // break; // } - case proof_system::ComposerType::PLOOKUP: { + case ComposerType::PLOOKUP: { return output_vk_sol_ultra(os, key, class_name); break; } diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp index aeccd3f70e..ef6913f184 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.cpp @@ -6,7 +6,7 @@ namespace proof_system::plonk { verification_key::verification_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, uint32_t composer_type_) : composer_type(composer_type_) , circuit_size(num_gates) @@ -17,8 +17,7 @@ verification_key::verification_key(const size_t num_gates, , polynomial_manifest(composer_type) {} -verification_key::verification_key(verification_key_data&& data, - std::shared_ptr const& crs) +verification_key::verification_key(verification_key_data&& data, std::shared_ptr const& crs) : composer_type(data.composer_type) , circuit_size(data.circuit_size) , log_circuit_size(numeric::get_msb(data.circuit_size)) diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp index 3b5e2ee36e..3d1a31a67f 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.hpp @@ -45,10 +45,10 @@ inline bool operator==(verification_key_data const& lhs, verification_key_data c } struct verification_key { - verification_key(verification_key_data&& data, std::shared_ptr const& crs); + verification_key(verification_key_data&& data, std::shared_ptr const& crs); verification_key(const size_t num_gates, const size_t num_inputs, - std::shared_ptr const& crs, + std::shared_ptr const& crs, uint32_t composer_type); verification_key(const verification_key& other); verification_key(verification_key&& other); @@ -65,7 +65,7 @@ struct verification_key { barretenberg::evaluation_domain domain; - std::shared_ptr reference_string; + std::shared_ptr reference_string; std::map commitments; diff --git a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp index 8f3fff05aa..bb049af011 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verification_key/verification_key.test.cpp @@ -10,7 +10,7 @@ namespace proof_system::plonk::test_verification_key { TEST(verification_key, buffer_serialization) { verification_key_data key; - key.composer_type = static_cast(proof_system::ComposerType::STANDARD); + key.composer_type = static_cast(ComposerType::STANDARD); key.circuit_size = 1234; key.num_public_inputs = 10; key.commitments["test1"] = g1::element::random_element(); @@ -27,7 +27,7 @@ TEST(verification_key, buffer_serialization) TEST(verification_key, stream_serialization) { verification_key_data key; - key.composer_type = static_cast(proof_system::ComposerType::STANDARD); + key.composer_type = static_cast(ComposerType::STANDARD); key.circuit_size = 1234; key.num_public_inputs = 10; key.commitments["test1"] = g1::element::random_element(); diff --git a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp index 9a5501a328..701a465189 100644 --- a/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp +++ b/cpp/src/barretenberg/plonk/proof_system/verifier/verifier.test.cpp @@ -40,7 +40,7 @@ plonk::Verifier generate_verifier(std::shared_ptr circuit_proving_k state)); } - auto crs = std::make_shared("../srs_db/ignition"); + auto crs = std::make_shared("../srs_db/ignition"); std::shared_ptr circuit_verification_key = std::make_shared(circuit_proving_key->circuit_size, circuit_proving_key->num_public_inputs, @@ -76,8 +76,8 @@ plonk::Prover generate_test_data(const size_t n) // even indices = mul gates, odd incides = add gates - auto crs = std::make_shared(n + 1, "../srs_db/ignition"); - std::shared_ptr key = std::make_shared(n, 0, crs, proof_system::ComposerType::STANDARD); + auto crs = std::make_shared(n + 1, "../srs_db/ignition"); + std::shared_ptr key = std::make_shared(n, 0, crs, ComposerType::STANDARD); polynomial w_l(n); polynomial w_r(n); @@ -232,7 +232,7 @@ plonk::Prover generate_test_data(const size_t n) std::unique_ptr> kate_commitment_scheme = std::make_unique>(); - plonk::Prover state = proof_system::plonk::Prover(std::move(key), plonk::StandardComposer::create_manifest(0)); + plonk::Prover state = plonk::Prover(std::move(key), plonk::StandardComposer::create_manifest(0)); state.random_widgets.emplace_back(std::move(permutation_widget)); state.transition_widgets.emplace_back(std::move(widget)); state.commitment_scheme = std::move(kate_commitment_scheme); diff --git a/cpp/src/barretenberg/proof_system/CMakeLists.txt b/cpp/src/barretenberg/proof_system/CMakeLists.txt index 99041b45c2..3cb2621334 100644 --- a/cpp/src/barretenberg/proof_system/CMakeLists.txt +++ b/cpp/src/barretenberg/proof_system/CMakeLists.txt @@ -1 +1 @@ -barretenberg_module(proof_system plonk) \ No newline at end of file +barretenberg_module(proof_system polynomials crypto_pedersen) \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp index 7479fbadb1..b627b17a9b 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/standard_circuit_constructor.hpp @@ -1,8 +1,8 @@ #pragma once #include #include "circuit_constructor_base.hpp" -#include "barretenberg/plonk/proof_system/constants.hpp" #include "barretenberg/proof_system/flavor/flavor.hpp" +#include "barretenberg/proof_system/types/composer_type.hpp" namespace proof_system { inline std::vector standard_selector_names() @@ -23,8 +23,7 @@ class StandardCircuitConstructor : public CircuitConstructorBase& q_3 = std::get<3>(selectors); std::vector& q_c = std::get<4>(selectors); - static constexpr proof_system::ComposerType type = - proof_system::ComposerType::STANDARD_HONK; // TODO(Cody): Get rid of this. + static constexpr ComposerType type = ComposerType::STANDARD_HONK; // TODO(Cody): Get rid of this. static constexpr size_t UINT_LOG2_BASE = 2; // These are variables that we have used a gate on, to enforce that they are diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp index aec533fca9..71dcca5c5e 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/turbo_circuit_constructor.hpp @@ -1,8 +1,8 @@ #pragma once #include #include "circuit_constructor_base.hpp" -#include "barretenberg/plonk/proof_system/constants.hpp" #include "barretenberg/proof_system/flavor/flavor.hpp" +#include "barretenberg/proof_system/types/composer_type.hpp" namespace proof_system { @@ -32,7 +32,7 @@ class TurboCircuitConstructor : public CircuitConstructorBase& q_range = std::get<9>(selectors); std::vector& q_logic = std::get<10>(selectors); - static constexpr proof_system::ComposerType type = proof_system::ComposerType::TURBO; + static constexpr ComposerType type = ComposerType::TURBO; static constexpr size_t UINT_LOG2_BASE = 2; TurboCircuitConstructor(const size_t size_hint = 0); diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.cpp b/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.cpp index c26a3380f5..d606ab173d 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.cpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.cpp @@ -4,7 +4,7 @@ using namespace barretenberg; -namespace bonk { +namespace proof_system { void UltraCircuitConstructor::finalize_circuit() { @@ -2321,4 +2321,4 @@ void UltraCircuitConstructor::process_RAM_arrays(const size_t gate_offset_from_p } } -} // namespace bonk \ No newline at end of file +} // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.hpp b/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.hpp index fe9d23830f..65f73f724d 100644 --- a/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.hpp +++ b/cpp/src/barretenberg/proof_system/circuit_constructors/ultra_circuit_constructor.hpp @@ -1,6 +1,6 @@ #pragma once #include "barretenberg/proof_system/arithmetization/arithmetization.hpp" -#include "barretenberg/proof_system/types/polynomial_manifest.hpp" +#include "barretenberg/plonk/proof_system/types/polynomial_manifest.hpp" #include "circuit_constructor_base.hpp" #include "barretenberg/plonk/proof_system/constants.hpp" #include "barretenberg/proof_system/flavor/flavor.hpp" @@ -10,9 +10,9 @@ #include "barretenberg/plonk/proof_system/types/prover_settings.hpp" #include -namespace bonk { +namespace proof_system { -static constexpr plonk::ComposerType type = plonk::ComposerType::PLOOKUP; +static constexpr ComposerType type = ComposerType::PLOOKUP; static constexpr plonk::MerkleHashType merkle_hash_type = plonk::MerkleHashType::LOOKUP_PEDERSEN; static constexpr size_t NUM_RESERVED_GATES = 4; // This must be >= num_roots_cut_out_of_vanishing_polynomial // See the comment in plonk/proof_system/prover/prover.cpp @@ -167,7 +167,7 @@ class UltraCircuitConstructor : public CircuitConstructorBase - */ -template -std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, - proof_system::ReferenceStringFactory* crs_factory, - const size_t minimum_circuit_size, - const size_t num_randomized_gates, - proof_system::ComposerType composer_type) -{ - const size_t num_gates = circuit_constructor.num_gates; - std::span public_inputs = circuit_constructor.public_inputs; - - const size_t num_public_inputs = public_inputs.size(); - const size_t num_constraints = num_gates + num_public_inputs; - const size_t total_num_constraints = std::max(minimum_circuit_size, num_constraints); - const size_t subgroup_size = - circuit_constructor.get_circuit_subgroup_size(total_num_constraints + num_randomized_gates); // next power of 2 - - auto crs = crs_factory->get_prover_crs(subgroup_size + 1); - - return std::make_shared(subgroup_size, num_public_inputs, crs, composer_type); -} - -/** - * @brief Construct lagrange selector polynomials from ciruit selector information and put into polynomial cache - * - * @tparam CircuitConstructor The class holding the circuit - * @param circuit_constructor The object holding the circuit - * @param key Pointer to the proving key - */ -template -void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constructor, - plonk::proving_key* circuit_proving_key) -{ - const size_t num_public_inputs = circuit_constructor.public_inputs.size(); - for (size_t j = 0; j < circuit_constructor.num_selectors; ++j) { - std::span selector_values = circuit_constructor.selectors[j]; - ASSERT(circuit_proving_key->circuit_size >= selector_values.size()); - - // Compute selector vector, initialized to 0. - // Copy the selector values for all gates, keeping the rows at which we store public inputs as 0. - // Initializing the polynomials in this way automatically applies 0-padding to the selectors. - barretenberg::polynomial selector_poly_lagrange(circuit_proving_key->circuit_size); - for (size_t i = 0; i < selector_values.size(); ++i) { - selector_poly_lagrange[num_public_inputs + i] = selector_values[i]; - } - // TODO(#217)(Adrian): We may want to add a unique value (e.g. j+1) in the last position of each selector - // polynomial to guard against some edge cases that may occur during the MSM. If we do so, we should ensure that - // this does not clash with any other values we want to place at the end of of the witness vectors. In later - // iterations of the Sumcheck, we will be able to efficiently cancel out any checks in the last 2^k rows, so any - // randomness or unique values should be placed there. - circuit_proving_key->polynomial_store.put(circuit_constructor.selector_names_[j] + "_lagrange", - std::move(selector_poly_lagrange)); - } -} - -/** - * @brief Fill the last index of each selector polynomial in lagrange form with a non-zero value - * - * @tparam CircuitConstructor The class holding the circuit - * @param circuit_constructor The object holding the circuit - * @param key Pointer to the proving key - */ -template -void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_constructor, - plonk::proving_key* circuit_proving_key) -{ - for (size_t j = 0; j < circuit_constructor.num_selectors; ++j) { - auto current_selector = - circuit_proving_key->polynomial_store.get(circuit_constructor.selector_names_[j] + "_lagrange"); - current_selector[current_selector.size() - 1] = j + 1; - circuit_proving_key->polynomial_store.put(circuit_constructor.selector_names_[j] + "_lagrange", - std::move(current_selector)); - } -} - -// /** -// * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into -// * cache -// * -// * @note This function also deletes the lagrange forms of the selectors from memory since they are not needed -// * for proof construction once the monomial and coset forms have been computed -// * -// * @param key Pointer to the proving key -// * @param selector_properties Names of selectors -// */ -// void compute_monomial_and_coset_selector_forms(plonk::proving_key* circuit_proving_key, -// std::vector selector_properties) -// { -// for (size_t i = 0; i < selector_properties.size(); i++) { -// // Compute monomial form of selector polynomial - -// auto& selector_poly_lagrange = -// circuit_proving_key->polynomial_store.get(selector_properties[i].name + "_lagrange"); -// barretenberg::polynomial selector_poly(circuit_proving_key->circuit_size); -// barretenberg::polynomial_arithmetic::ifft( -// &selector_poly_lagrange[0], &selector_poly[0], circuit_proving_key->small_domain); - -// // Compute coset FFT of selector polynomial -// barretenberg::polynomial selector_poly_fft(selector_poly, circuit_proving_key->circuit_size * 4 + 4); -// selector_poly_fft.coset_fft(circuit_proving_key->large_domain); - -// // Remove the selector lagrange forms since they will not be needed beyond this point -// circuit_proving_key->polynomial_store.remove(selector_properties[i].name + "_lagrange"); -// circuit_proving_key->polynomial_store.put(selector_properties[i].name, std::move(selector_poly)); -// circuit_proving_key->polynomial_store.put(selector_properties[i].name + "_fft", -// std::move(selector_poly_fft)); -// } -// } - -/** - * Compute witness polynomials (w_1, w_2, w_3, w_4) and put them into polynomial cache - * - * @details Fills 3 or 4 witness polynomials w_1, w_2, w_3, w_4 with the values of in-circuit variables. The beginning - * of w_1, w_2 polynomials is filled with public_input values. - * @return Witness with computed witness polynomials. - * - * @tparam Program settings needed to establish if w_4 is being used. - * */ -template -std::vector compute_witness_base(const CircuitConstructor& circuit_constructor, - const size_t minimum_circuit_size, - const size_t number_of_randomized_gates) -{ - const size_t program_width = CircuitConstructor::program_width; - const size_t num_gates = circuit_constructor.num_gates; - std::span public_inputs = circuit_constructor.public_inputs; - const size_t num_public_inputs = public_inputs.size(); - - const size_t num_constraints = std::max(minimum_circuit_size, num_gates + num_public_inputs); - // TODO(#216)(Adrian): Not a fan of specifying NUM_RANDOMIZED_GATES everywhere, - // Each flavor of Honk should have a "fixed" number of random places to add randomness to. - // It should be taken care of in as few places possible. - const size_t subgroup_size = - circuit_constructor.get_circuit_subgroup_size(num_constraints + number_of_randomized_gates); - - // construct a view over all the wire's variable indices - // w[j][i] is the index of the variable in the j-th wire, at gate i - // Each array should be of size `num_gates` - std::array, program_width> w; - w[0] = circuit_constructor.w_l; - w[1] = circuit_constructor.w_r; - w[2] = circuit_constructor.w_o; - if constexpr (program_width > 3) { - w[3] = circuit_constructor.w_4; - } - std::vector wires; - // Note: randomness is added to 3 of the last 4 positions in plonk/proof_system/prover/prover.cpp - // StandardProverBase::execute_preamble_round(). - for (size_t j = 0; j < program_width; ++j) { - // Initialize the polynomial with all the actual copies variable values - // Expect all values to be set to 0 initially - barretenberg::polynomial w_lagrange(subgroup_size); - - // Place all public inputs at the start of w_l and w_r. - // All selectors at these indices are set to 0 so these values are not constrained at all. - if ((j == 0) || (j == 1)) { - for (size_t i = 0; i < num_public_inputs; ++i) { - w_lagrange[i] = circuit_constructor.get_variable(public_inputs[i]); - } - } - - // Assign the variable values (which are pointed-to by the `w_` wires) to the wire witness polynomials - // `poly_w_`, shifted to make room for the public inputs at the beginning. - for (size_t i = 0; i < num_gates; ++i) { - w_lagrange[num_public_inputs + i] = circuit_constructor.get_variable(w[j][i]); - } - wires.push_back(std::move(w_lagrange)); - } - return wires; -} - -// /** -// * @brief Computes the verification key by computing the: -// * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, -// * (2) sets the polynomial manifest using the data from proving key. -// */ -// std::shared_ptr compute_verification_key_common( -// std::shared_ptr const& proving_key, std::shared_ptr -// const& vrs) -// { -// auto circuit_verification_key = std::make_shared( -// proving_key->circuit_size, proving_key->num_public_inputs, vrs, proving_key->composer_type); -// // TODO(kesha): Dirty hack for now. Need to actually make commitment-agnositc -// auto commitment_key = proof_system::honk::pcs::kzg::CommitmentKey(proving_key->circuit_size, -// "../srs_db/ignition"); - -// for (size_t i = 0; i < proving_key->polynomial_manifest.size(); ++i) { -// const auto& poly_info = proving_key->polynomial_manifest[i]; - -// const std::string poly_label(poly_info.polynomial_label); -// const std::string selector_commitment_label(poly_info.commitment_label); - -// if (poly_info.source == proof_system::PolynomialSource::SELECTOR || -// poly_info.source == proof_system::PolynomialSource::PERMUTATION || -// poly_info.source == proof_system::PolynomialSource::OTHER) { -// // Fetch the polynomial in its vector form. - -// // Commit to the constraint selector polynomial and insert the commitment in the verification key. - -// auto poly_commitment = commitment_key.commit(proving_key->polynomial_store.get(poly_label)); -// circuit_verification_key->commitments.insert({ selector_commitment_label, poly_commitment }); -// } -// } - -// // Set the polynomial manifest in verification key. -// circuit_verification_key->polynomial_manifest = -// proof_system::plonk::PolynomialManifest(proving_key->composer_type); - -// return circuit_verification_key; -// } - -// Ensure we compile all versions so that there are no issues during linkage -#define COMPILE_FOR_CIRCUIT_CONSTRUCTOR(circuit_constructor) \ - template std::shared_ptr initialize_proving_key( \ - const circuit_constructor&, \ - proof_system::ReferenceStringFactory*, \ - const size_t, \ - const size_t, \ - proof_system::ComposerType); \ - template void construct_lagrange_selector_forms(const circuit_constructor&, \ - plonk::proving_key*); \ - template std::vector compute_witness_base( \ - const circuit_constructor&, const size_t, const size_t); \ - template void enforce_nonzero_polynomial_selectors(const circuit_constructor& constructor, \ - plonk::proving_key* circuit_proving_key); - -COMPILE_FOR_CIRCUIT_CONSTRUCTOR(StandardCircuitConstructor) -COMPILE_FOR_CIRCUIT_CONSTRUCTOR(TurboCircuitConstructor) -COMPILE_FOR_CIRCUIT_CONSTRUCTOR(UltraCircuitConstructor) - -} // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp index d629fa79f0..c31dfe13b9 100644 --- a/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp +++ b/cpp/src/barretenberg/proof_system/composer/composer_helper_lib.hpp @@ -1,8 +1,6 @@ #pragma once +#include #include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" -#include "barretenberg/plonk/proof_system/verification_key/verification_key.hpp" -#include "barretenberg/polynomials/polynomial_arithmetic.hpp" -#include "barretenberg/polynomials/polynomial.hpp" namespace proof_system { @@ -18,20 +16,57 @@ namespace proof_system { */ template std::shared_ptr initialize_proving_key(const CircuitConstructor& circuit_constructor, - proof_system::ReferenceStringFactory* crs_factory, + ReferenceStringFactory* crs_factory, const size_t minimum_circuit_size, const size_t num_randomized_gates, - proof_system::ComposerType composer_type); + ComposerType composer_type) +{ + const size_t num_gates = circuit_constructor.num_gates; + std::span public_inputs = circuit_constructor.public_inputs; + + const size_t num_public_inputs = public_inputs.size(); + const size_t num_constraints = num_gates + num_public_inputs; + const size_t total_num_constraints = std::max(minimum_circuit_size, num_constraints); + const size_t subgroup_size = + circuit_constructor.get_circuit_subgroup_size(total_num_constraints + num_randomized_gates); // next power of 2 + + auto crs = crs_factory->get_prover_crs(subgroup_size + 1); + + return std::make_shared(subgroup_size, num_public_inputs, crs, composer_type); +} /** - * @brief Construct lagrange selector polynomials from circuit selector information and put into polynomial cache + * @brief Construct lagrange selector polynomials from ciruit selector information and put into polynomial cache * * @tparam CircuitConstructor The class holding the circuit * @param circuit_constructor The object holding the circuit * @param key Pointer to the proving key */ template -void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constructor, plonk::proving_key* key); +void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constructor, + plonk::proving_key* circuit_proving_key) +{ + const size_t num_public_inputs = circuit_constructor.public_inputs.size(); + for (size_t j = 0; j < circuit_constructor.num_selectors; ++j) { + std::span selector_values = circuit_constructor.selectors[j]; + ASSERT(circuit_proving_key->circuit_size >= selector_values.size()); + + // Compute selector vector, initialized to 0. + // Copy the selector values for all gates, keeping the rows at which we store public inputs as 0. + // Initializing the polynomials in this way automatically applies 0-padding to the selectors. + barretenberg::polynomial selector_poly_lagrange(circuit_proving_key->circuit_size); + for (size_t i = 0; i < selector_values.size(); ++i) { + selector_poly_lagrange[num_public_inputs + i] = selector_values[i]; + } + // TODO(#217)(Adrian): We may want to add a unique value (e.g. j+1) in the last position of each selector + // polynomial to guard against some edge cases that may occur during the MSM. If we do so, we should ensure that + // this does not clash with any other values we want to place at the end of of the witness vectors. In later + // iterations of the Sumcheck, we will be able to efficiently cancel out any checks in the last 2^k rows, so any + // randomness or unique values should be placed there. + circuit_proving_key->polynomial_store.put(circuit_constructor.selector_names_[j] + "_lagrange", + std::move(selector_poly_lagrange)); + } +} /** * @brief Fill the last index of each selector polynomial in lagrange form with a non-zero value @@ -41,17 +76,17 @@ void construct_lagrange_selector_forms(const CircuitConstructor& circuit_constru * @param key Pointer to the proving key */ template -void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_constructor, plonk::proving_key* key); - -// /** -// * @brief Retrieve lagrange forms of selector polynomials and compute monomial and coset-monomial forms and put into -// * cache -// * -// * @param key Pointer to the proving key -// * @param selector_properties Names of selectors -// */ -// void compute_monomial_and_coset_selector_forms(plonk::proving_key* key, -// std::vector selector_properties); +void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_constructor, + plonk::proving_key* circuit_proving_key) +{ + for (size_t j = 0; j < circuit_constructor.num_selectors; ++j) { + auto current_selector = + circuit_proving_key->polynomial_store.get(circuit_constructor.selector_names_[j] + "_lagrange"); + current_selector[current_selector.size() - 1] = j + 1; + circuit_proving_key->polynomial_store.put(circuit_constructor.selector_names_[j] + "_lagrange", + std::move(current_selector)); + } +} /** * Compute witness polynomials (w_1, w_2, w_3, w_4) and put them into polynomial cache @@ -65,15 +100,53 @@ void enforce_nonzero_polynomial_selectors(const CircuitConstructor& circuit_cons template std::vector compute_witness_base(const CircuitConstructor& circuit_constructor, const size_t minimum_circuit_size, - const size_t number_of_randomized_gates); + const size_t number_of_randomized_gates) +{ + const size_t program_width = CircuitConstructor::program_width; + const size_t num_gates = circuit_constructor.num_gates; + std::span public_inputs = circuit_constructor.public_inputs; + const size_t num_public_inputs = public_inputs.size(); + + const size_t num_constraints = std::max(minimum_circuit_size, num_gates + num_public_inputs); + // TODO(#216)(Adrian): Not a fan of specifying NUM_RANDOMIZED_GATES everywhere, + // Each flavor of Honk should have a "fixed" number of random places to add randomness to. + // It should be taken care of in as few places possible. + const size_t subgroup_size = + circuit_constructor.get_circuit_subgroup_size(num_constraints + number_of_randomized_gates); + + // construct a view over all the wire's variable indices + // w[j][i] is the index of the variable in the j-th wire, at gate i + // Each array should be of size `num_gates` + std::array, program_width> w; + w[0] = circuit_constructor.w_l; + w[1] = circuit_constructor.w_r; + w[2] = circuit_constructor.w_o; + if constexpr (program_width > 3) { + w[3] = circuit_constructor.w_4; + } + std::vector wires; + // Note: randomness is added to 3 of the last 4 positions in plonk/proof_system/prover/prover.cpp + // StandardProverBase::execute_preamble_round(). + for (size_t j = 0; j < program_width; ++j) { + // Initialize the polynomial with all the actual copies variable values + // Expect all values to be set to 0 initially + barretenberg::polynomial w_lagrange(subgroup_size); -// /** -// * @brief Computes the verification key by computing the: -// * (1) commitments to the selector, permutation, and lagrange (first/last) polynomials, -// * (2) sets the polynomial manifest using the data from proving key. -// */ -// std::shared_ptr compute_verification_key_common( -// std::shared_ptr const& proving_key, std::shared_ptr -// const& vrs); + // Place all public inputs at the start of w_l and w_r. + // All selectors at these indices are set to 0 so these values are not constrained at all. + if ((j == 0) || (j == 1)) { + for (size_t i = 0; i < num_public_inputs; ++i) { + w_lagrange[i] = circuit_constructor.get_variable(public_inputs[i]); + } + } + // Assign the variable values (which are pointed-to by the `w_` wires) to the wire witness polynomials + // `poly_w_`, shifted to make room for the public inputs at the beginning. + for (size_t i = 0; i < num_gates; ++i) { + w_lagrange[num_public_inputs + i] = circuit_constructor.get_variable(w[j][i]); + } + wires.push_back(std::move(w_lagrange)); + } + return wires; +} } // namespace proof_system diff --git a/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp b/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp index 6fb9de5540..793204ea11 100644 --- a/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp +++ b/cpp/src/barretenberg/proof_system/composer/permutation_helper.hpp @@ -453,7 +453,8 @@ inline void compute_first_and_last_lagrange_polynomials(auto key) // proving_key * @return std::array, program_width> */ template -void compute_plonk_generalized_sigma_permutations(const CircuitConstructor& circuit_constructor, bonk::proving_key* key) +void compute_plonk_generalized_sigma_permutations(const CircuitConstructor& circuit_constructor, + plonk::proving_key* key) { // Compute wire copy cycles for public and private variables auto wire_copy_cycles = compute_wire_copy_cycles(circuit_constructor); diff --git a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp index c0221dd22f..a068cce790 100644 --- a/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp +++ b/cpp/src/barretenberg/proof_system/polynomial_store/polynomial_store.test.cpp @@ -13,7 +13,7 @@ using Polynomial = barretenberg::Polynomial; // Test basic put and get functionality TEST(PolynomialStore, PutThenGet) { - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; // Instantiate a polynomial with random coefficients Polynomial poly(1024); @@ -34,7 +34,7 @@ TEST(PolynomialStore, PutThenGet) // Ensure that attempt to access non-existent key throws out_of_range exception TEST(PolynomialStore, NonexistentKey) { - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; polynomial_store.put("id_1", Polynomial(100)); @@ -46,7 +46,7 @@ TEST(PolynomialStore, NonexistentKey) // Ensure correct calculation of volume in bytes TEST(PolynomialStore, Volume) { - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; size_t size1 = 100; size_t size2 = 10; size_t size3 = 5000; @@ -69,7 +69,7 @@ TEST(PolynomialStore, Volume) // Ensure that the remove method erases entry and reduces memory TEST(PolynomialStore, Remove) { - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; size_t size1 = 100; size_t size2 = 500; Polynomial poly1(size1); @@ -93,7 +93,7 @@ TEST(PolynomialStore, Remove) // Check that PolynomialStore supports range based for loop TEST(PolynomialStore, RangeBasedFor) { - proof_system::PolynomialStore polynomial_store; + PolynomialStore polynomial_store; size_t size = 100; Polynomial poly1(size); Polynomial poly2(size); @@ -102,7 +102,7 @@ TEST(PolynomialStore, RangeBasedFor) polynomial_store.put("id_2", std::move(poly2)); // Check that PolynomialStore meets criteria for std::ranges::range - EXPECT_TRUE(std::ranges::range>); + EXPECT_TRUE(std::ranges::range>); // For example ... Polynomial polynomial_sum(size); diff --git a/cpp/src/barretenberg/proof_system/types/composer_type.hpp b/cpp/src/barretenberg/proof_system/types/composer_type.hpp index 6a19c8fe4d..3521715cd4 100644 --- a/cpp/src/barretenberg/proof_system/types/composer_type.hpp +++ b/cpp/src/barretenberg/proof_system/types/composer_type.hpp @@ -2,11 +2,5 @@ namespace proof_system { // This will go away, but we move it here has a temporary measure to make proof_system not depend on honk or plonk. -enum ComposerType { - STANDARD, - TURBO, - PLOOKUP, - STANDARD_HONK, // Todo(Arijit): We should replace STANDARD_HONK outside plonk or the namespace should be - // proof_system -}; +enum ComposerType { STANDARD, TURBO, PLOOKUP, STANDARD_HONK }; } // namespace proof_system \ No newline at end of file diff --git a/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp b/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp index ad0176723f..4cbf548149 100644 --- a/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp +++ b/cpp/src/barretenberg/proof_system/work_queue/work_queue.hpp @@ -4,7 +4,7 @@ #include "barretenberg/plonk/proof_system/proving_key/proving_key.hpp" namespace proof_system { -// TODO(Cody): Template by flavor +// TODO(Cody): Template by flavor? class work_queue { public: diff --git a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp index bfd5b43d2c..6e99674ba9 100644 --- a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.cpp @@ -16,8 +16,8 @@ namespace stdlib { namespace aes128 { constexpr uint32_t AES128_BASE = 9; -typedef proof_system::plonk::stdlib::field_t field_t; -typedef proof_system::plonk::stdlib::witness_t witness_t; +typedef stdlib::field_t field_t; +typedef stdlib::witness_t witness_t; typedef std::pair byte_pair; diff --git a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp index 1b315039c3..da1fc78a6d 100644 --- a/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/aes128/aes128.test.cpp @@ -11,8 +11,8 @@ using namespace proof_system::plonk; TEST(stdlib_aes128, encrypt_64_bytes) { - typedef proof_system::plonk::stdlib::field_t field_pt; - typedef proof_system::plonk::stdlib::witness_t witness_pt; + typedef stdlib::field_t field_pt; + typedef stdlib::witness_t witness_pt; uint8_t key[16]{ 0x2b, 0x7e, 0x15, 0x16, 0x28, 0xae, 0xd2, 0xa6, 0xab, 0xf7, 0x15, 0x88, 0x09, 0xcf, 0x4f, 0x3c }; uint8_t out[64]{ 0x76, 0x49, 0xab, 0xac, 0x81, 0x19, 0xb2, 0x46, 0xce, 0xe9, 0x8e, 0x9b, 0x12, 0xe9, 0x19, 0x7d, @@ -34,7 +34,7 @@ TEST(stdlib_aes128, encrypt_64_bytes) return converted; }; - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); std::vector in_field{ witness_pt(&composer, fr(convert_bytes(in))), @@ -50,7 +50,7 @@ TEST(stdlib_aes128, encrypt_64_bytes) convert_bytes(out), convert_bytes(out + 16), convert_bytes(out + 32), convert_bytes(out + 48) }; - const auto result = proof_system::plonk::stdlib::aes128::encrypt_buffer_cbc(in_field, iv_field, key_field); + const auto result = stdlib::aes128::encrypt_buffer_cbc(in_field, iv_field, key_field); for (size_t i = 0; i < 4; ++i) { EXPECT_EQ(result[i].get_value(), expected[i]); diff --git a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp index e0bb6ccb61..12355453d6 100644 --- a/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp +++ b/cpp/src/barretenberg/stdlib/encryption/ecdsa/ecdsa_impl.hpp @@ -33,7 +33,7 @@ bool_t verify_signature(const stdlib::byte_array& message, Fr u2 = r / s; G1 result; - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { ASSERT(Curve::type == proof_system::CurveType::SECP256K1); public_key.validate_on_curve(); result = G1::secp256k1_ecdsa_mul(public_key, u1, u2); diff --git a/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp b/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp index ac889f2bf9..86f419095c 100644 --- a/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp +++ b/cpp/src/barretenberg/stdlib/encryption/schnorr/schnorr.cpp @@ -119,12 +119,12 @@ point variable_base_mul(const point& pub_key, const field_t& low_bits, field_t zero_test = (low_bits * high_bits); zero_test.assert_is_not_zero(); - const auto low_wnaf = proof_system::plonk::stdlib::schnorr::convert_field_into_wnaf(context, low_bits); - const auto high_wnaf = proof_system::plonk::stdlib::schnorr::convert_field_into_wnaf(context, high_bits); + const auto low_wnaf = stdlib::schnorr::convert_field_into_wnaf(context, low_bits); + const auto high_wnaf = stdlib::schnorr::convert_field_into_wnaf(context, high_bits); // current_accumulator is pub_key, so init is true, so high_output is [high_wnaf]pub_key - point high_output = proof_system::plonk::stdlib::schnorr::variable_base_mul(pub_key, pub_key, high_wnaf); + point high_output = stdlib::schnorr::variable_base_mul(pub_key, pub_key, high_wnaf); // compute output = [low_wnaf]pub_key + [2^128]high_output. - point output = proof_system::plonk::stdlib::schnorr::variable_base_mul(pub_key, high_output, low_wnaf); + point output = stdlib::schnorr::variable_base_mul(pub_key, high_output, low_wnaf); return output; } diff --git a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp index 0197765143..dfbacf2baf 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.cpp @@ -119,7 +119,7 @@ template void blake2s(blake2s_state& S, byte_array template byte_array blake2s(const byte_array& input) { - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { return blake2s_plookup::blake2s(input); } diff --git a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp index 387b42ddf2..b61cbc305d 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake2s/blake2s.test.cpp @@ -39,7 +39,7 @@ TEST(stdlib_blake2s, test_single_block) TEST(stdlib_blake2s, test_single_block_plookup) { - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); std::string input = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz01"; std::vector input_v(input.begin(), input.end()); @@ -87,7 +87,7 @@ TEST(stdlib_blake2s, test_double_block) TEST(stdlib_blake2s, test_double_block_plookup) { - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); std::string input = "abcdefghijklmnopqrstuvwxyz0123456789abcdefghijklmnopqrstuvwxyz0123456789"; std::vector input_v(input.begin(), input.end()); diff --git a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp index a9e85132d0..dad4d64204 100644 --- a/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp +++ b/cpp/src/barretenberg/stdlib/hash/blake3s/blake3s.cpp @@ -246,7 +246,7 @@ using namespace blake3_internal; template byte_array blake3s(const byte_array& input) { - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { return blake3s_plookup::blake3s(input); } diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp index 39202840f3..d0ebf02f5a 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.cpp @@ -225,8 +225,8 @@ point pedersen::hash_single(const field_t& in, if (i > 0) { gates.create_fixed_group_add_gate(round_quad); } else { - if constexpr (C::type == proof_system::ComposerType::PLOOKUP && - C::merkle_hash_type == proof_system::plonk::MerkleHashType::FIXED_BASE_PEDERSEN) { + if constexpr (C::type == ComposerType::PLOOKUP && + C::merkle_hash_type == MerkleHashType::FIXED_BASE_PEDERSEN) { /* In TurboComposer, the selector q_5 is used to show that w_1 and w_2 are properly initialized to the * coordinates of P_s = (-s + 4^n)[g]. In UltraPlonK, we have removed q_5 for overall efficiency (it * would only be used here in this gate), but this presents us a cost in the present circuit: we must @@ -463,7 +463,7 @@ template void pedersen::validate_wnaf_is_in_field(C* ctx, const field_t y_lo = (-reconstructed_input).add_two(high_limb_with_skew * shift + (r_lo + shift), is_even); field_t y_overlap; - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { // carve out the 2 high bits from y_lo and instantiate as y_overlap const uint256_t y_lo_value = y_lo.get_value(); const uint256_t y_overlap_value = y_lo_value >> 126; diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp index d428cd8eab..c2cf7957ef 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.hpp @@ -12,10 +12,10 @@ constexpr uint64_t WNAF_MASK = crypto::pedersen::WNAF_MASK; template class pedersen { private: - typedef proof_system::plonk::stdlib::field_t field_t; - typedef proof_system::plonk::stdlib::point point; - typedef proof_system::plonk::stdlib::byte_array byte_array; - typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef stdlib::field_t field_t; + typedef stdlib::point point; + typedef stdlib::byte_array byte_array; + typedef stdlib::bool_t bool_t; static point hash_single(const field_t& in, const crypto::pedersen::generator_index_t hash_index, diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp index 1dc5d64192..5450ab5b8f 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen.test.cpp @@ -454,7 +454,7 @@ typedef stdlib::field_t field_ct; typedef stdlib::witness_t witness_ct; TEST(stdlib_pedersen, test_pedersen_plookup) { - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); fr left_in = fr::random_element(); fr right_in = fr::random_element(); @@ -481,7 +481,7 @@ TEST(stdlib_pedersen, test_pedersen_plookup) TEST(stdlib_pedersen, test_compress_many_plookup) { - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); std::vector input_values{ fr::random_element(), fr::random_element(), fr::random_element(), @@ -513,7 +513,7 @@ TEST(stdlib_pedersen, test_compress_many_plookup) TEST(stdlib_pedersen, test_merkle_damgard_compress_plookup) { - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); std::vector input_values{ fr::random_element(), fr::random_element(), fr::random_element(), diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp index 6f23139529..211b01e3fd 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_gates.hpp @@ -25,7 +25,6 @@ template class pedersen_gates { using fixed_group_add_quad = proof_system::fixed_group_add_quad; using fixed_group_init_quad = proof_system::fixed_group_init_quad; using add_quad = proof_system::add_quad; - using ComposerType = proof_system::ComposerType; Composer* context; fixed_group_add_quad previous_add_quad; @@ -36,7 +35,7 @@ template class pedersen_gates { void create_fixed_group_add_gate(const fixed_group_add_quad& in) { - if constexpr (Composer::type == proof_system::ComposerType::TURBO) { + if constexpr (Composer::type == ComposerType::TURBO) { context->create_fixed_group_add_gate(in); } else { @@ -229,7 +228,7 @@ template class pedersen_gates { void create_fixed_group_add_gate_with_init(const fixed_group_add_quad& in, const fixed_group_init_quad& init) { - if constexpr (Composer::type == proof_system::ComposerType::TURBO) { + if constexpr (Composer::type == ComposerType::TURBO) { context->create_fixed_group_add_gate_with_init(in, init); } else { uint32_t x_0_idx = in.a; @@ -295,7 +294,7 @@ template class pedersen_gates { void create_fixed_group_add_gate_final(const add_quad& in) { - if constexpr (Composer::type == proof_system::ComposerType::TURBO) { + if constexpr (Composer::type == ComposerType::TURBO) { context->create_fixed_group_add_gate_final(in); } else { diff --git a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp index 5b10abe606..2d14bf73cb 100644 --- a/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp +++ b/cpp/src/barretenberg/stdlib/hash/pedersen/pedersen_plookup.hpp @@ -9,10 +9,10 @@ namespace stdlib { template class pedersen_plookup { private: - typedef proof_system::plonk::stdlib::field_t field_t; - typedef proof_system::plonk::stdlib::point point; - typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array; - typedef proof_system::plonk::stdlib::bool_t bool_t; + typedef stdlib::field_t field_t; + typedef stdlib::point point; + typedef stdlib::packed_byte_array packed_byte_array; + typedef stdlib::bool_t bool_t; enum AddType { LAMBDA, diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp index 35863d05d2..22bc5ac9de 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.cpp @@ -139,7 +139,7 @@ template byte_array sha256_block(const byte_array< template packed_byte_array sha256(const packed_byte_array& input) { - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { return sha256_plookup::sha256(input); } typedef field_t field_pt; diff --git a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp index fae71f980c..9379e2382a 100644 --- a/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp +++ b/cpp/src/barretenberg/stdlib/hash/sha256/sha256.test.cpp @@ -16,6 +16,7 @@ auto& engine = numeric::random::get_debug_engine(); namespace test_stdlib_sha256 { using namespace barretenberg; +using namespace proof_system::plonk; using namespace proof_system::plonk::stdlib::types; constexpr uint64_t ror(uint64_t val, uint64_t shift) @@ -111,7 +112,7 @@ std::array inner_block(std::array& w) TEST(stdlib_sha256, test_duplicate_proving_key) { - plonk::StandardComposer first_composer = proof_system::plonk::StandardComposer(); + plonk::StandardComposer first_composer = StandardComposer(); stdlib::packed_byte_array input(&first_composer, "An 8 character password? Snow White and the 7 Dwarves.."); plonk::stdlib::sha256(input); auto prover = first_composer.create_prover(); @@ -124,8 +125,7 @@ TEST(stdlib_sha256, test_duplicate_proving_key) auto circuit_size = prover.circuit_size; // Test a second time with same keys and different input. - plonk::StandardComposer second_composer = - proof_system::plonk::StandardComposer(proving_key, verification_key, circuit_size); + plonk::StandardComposer second_composer = StandardComposer(proving_key, verification_key, circuit_size); stdlib::packed_byte_array input2(&second_composer, "An 8 character password? Snow White and the 9 Dwarves.."); plonk::stdlib::sha256(input2); auto second_prover = second_composer.create_prover(); @@ -138,14 +138,14 @@ TEST(stdlib_sha256, test_duplicate_proving_key) // TEST(stdlib_sha256_plookup, test_round) // { -// plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); +// plonk::UltraComposer composer = UltraComposer(); // std::array w_inputs; // std::array, 64> w_elements; // for (size_t i = 0; i < 64; ++i) { // w_inputs[i] = engine.get_random_uint32(); -// w_elements[i] = proof_system::plonk::stdlib::witness_t(&composer, +// w_elements[i] = stdlib::witness_t(&composer, // barretenberg::fr(w_inputs[i])); // } @@ -169,15 +169,15 @@ TEST(stdlib_sha256, test_duplicate_proving_key) TEST(stdlib_sha256, test_plookup_55_bytes) { - typedef proof_system::plonk::stdlib::field_t field_pt; - typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef stdlib::field_t field_pt; + typedef stdlib::packed_byte_array packed_byte_array_pt; // 55 bytes is the largest number of bytes that can be hashed in a single block, // accounting for the single padding bit, and the 64 size bits required by the SHA-256 standard. - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); packed_byte_array_pt input(&composer, "An 8 character password? Snow White and the 7 Dwarves.."); - packed_byte_array_pt output_bits = proof_system::plonk::stdlib::sha256(input); + packed_byte_array_pt output_bits = stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -208,7 +208,7 @@ TEST(stdlib_sha256, test_55_bytes) Composer composer = Composer(); packed_byte_array_ct input(&composer, "An 8 character password? Snow White and the 7 Dwarves.."); - packed_byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); + packed_byte_array_ct output_bits = stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -234,13 +234,13 @@ TEST(stdlib_sha256, test_55_bytes) TEST(stdlib_sha256, test_NIST_vector_one_packed_byte_array) { - typedef proof_system::plonk::stdlib::field_t field_pt; - typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef stdlib::field_t field_pt; + typedef stdlib::packed_byte_array packed_byte_array_pt; - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); packed_byte_array_pt input(&composer, "abc"); - packed_byte_array_pt output_bytes = proof_system::plonk::stdlib::sha256(input); + packed_byte_array_pt output_bytes = stdlib::sha256(input); std::vector output = output_bytes.to_unverified_byte_slices(4); EXPECT_EQ(uint256_t(output[0].get_value()).data[0], (uint64_t)0xBA7816BFU); EXPECT_EQ(uint256_t(output[1].get_value()).data[0], (uint64_t)0x8F01CFEAU); @@ -265,14 +265,14 @@ TEST(stdlib_sha256, test_NIST_vector_one_packed_byte_array) TEST(stdlib_sha256, test_NIST_vector_one) { - typedef proof_system::plonk::stdlib::field_t field_pt; - typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef stdlib::field_t field_pt; + typedef stdlib::packed_byte_array packed_byte_array_pt; - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); packed_byte_array_pt input(&composer, "abc"); - packed_byte_array_pt output_bits = proof_system::plonk::stdlib::sha256(input); + packed_byte_array_pt output_bits = stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -303,7 +303,7 @@ TEST(stdlib_sha256, test_NIST_vector_two) byte_array_ct input(&composer, "abcdbcdecdefdefgefghfghighijhijkijkljklmklmnlmnomnopnopq"); - byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); + byte_array_ct output_bits = stdlib::sha256(input); std::vector output = packed_byte_array_ct(output_bits).to_unverified_byte_slices(4); @@ -335,7 +335,7 @@ TEST(stdlib_sha256, test_NIST_vector_three) // one byte, 0xbd byte_array_ct input(&composer, std::vector{ 0xbd }); - byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); + byte_array_ct output_bits = stdlib::sha256(input); std::vector output = packed_byte_array_ct(output_bits).to_unverified_byte_slices(4); @@ -366,7 +366,7 @@ TEST(stdlib_sha256, test_NIST_vector_four) // 4 bytes, 0xc98c8e55 byte_array_ct input(&composer, std::vector{ 0xc9, 0x8c, 0x8e, 0x55 }); - byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); + byte_array_ct output_bits = stdlib::sha256(input); std::vector output = packed_byte_array_ct(output_bits).to_unverified_byte_slices(4); @@ -392,10 +392,10 @@ TEST(stdlib_sha256, test_NIST_vector_four) HEAVY_TEST(stdlib_sha256, test_NIST_vector_five) { - typedef proof_system::plonk::stdlib::field_t field_pt; - typedef proof_system::plonk::stdlib::packed_byte_array packed_byte_array_pt; + typedef stdlib::field_t field_pt; + typedef stdlib::packed_byte_array packed_byte_array_pt; - plonk::UltraComposer composer = proof_system::plonk::UltraComposer(); + plonk::UltraComposer composer = UltraComposer(); packed_byte_array_pt input( &composer, @@ -410,7 +410,7 @@ HEAVY_TEST(stdlib_sha256, test_NIST_vector_five) "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA" "AAAAAAAAAA"); - packed_byte_array_pt output_bits = proof_system::plonk::stdlib::sha256(input); + packed_byte_array_pt output_bits = stdlib::sha256(input); std::vector output = output_bits.to_unverified_byte_slices(4); @@ -444,7 +444,7 @@ TEST(stdlib_sha256, test_input_len_multiple) auto input_buf = std::vector(inp, 1); byte_array_ct input(&composer, input_buf); - byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); + byte_array_ct output_bits = stdlib::sha256(input); auto circuit_output = output_bits.get_value(); @@ -488,7 +488,7 @@ TEST(stdlib_sha256, test_input_str_len_multiple) auto input_buf = std::vector(input_str.begin(), input_str.end()); byte_array_ct input(&composer, input_buf); - byte_array_ct output_bits = proof_system::plonk::stdlib::sha256(input); + byte_array_ct output_bits = stdlib::sha256(input); auto circuit_output = output_bits.get_value(); diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp index 1640d10ec4..17c7879e0c 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp index 33879aa4d1..218576684e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp @@ -56,7 +56,7 @@ bigfield::bigfield(const field_t& low_bits_in, field_t limb_3(context); if (low_bits_in.witness_index != IS_CONSTANT) { std::vector low_accumulator; - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { // MERGE NOTE: this was the if constexpr block introduced in ecebe7643 const auto limb_witnesses = context->decompose_non_native_field_double_width_limb(low_bits_in.normalize().witness_index); @@ -107,7 +107,7 @@ bigfield::bigfield(const field_t& low_bits_in, if (high_bits_in.witness_index != IS_CONSTANT) { std::vector high_accumulator; - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { const auto limb_witnesses = context->decompose_non_native_field_double_width_limb( high_bits_in.normalize().witness_index, (size_t)num_high_limb_bits); limb_2.witness_index = limb_witnesses[0]; @@ -187,7 +187,7 @@ bigfield bigfield::create_from_u512_as_witness(C* ctx, limbs[2] = value.slice(NUM_LIMB_BITS * 2, NUM_LIMB_BITS * 3).lo; limbs[3] = value.slice(NUM_LIMB_BITS * 3, NUM_LIMB_BITS * 4).lo; - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { field_t limb_0(ctx); field_t limb_1(ctx); field_t limb_2(ctx); @@ -384,7 +384,7 @@ template bigfield bigfield::operator+(const result.binary_basis_limbs[3].maximum_value = binary_basis_limbs[3].maximum_value + other.binary_basis_limbs[3].maximum_value; - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { if (prime_basis_limb.multiplicative_constant == 1 && other.prime_basis_limb.multiplicative_constant == 1 && !is_constant() && !other.is_constant()) { bool limbconst = binary_basis_limbs[0].element.is_constant(); @@ -592,7 +592,7 @@ template bigfield bigfield::operator-(const result.binary_basis_limbs[2].element = binary_basis_limbs[2].element + barretenberg::fr(to_add_2); result.binary_basis_limbs[3].element = binary_basis_limbs[3].element + barretenberg::fr(to_add_3); - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { if (result.prime_basis_limb.multiplicative_constant == 1 && other.prime_basis_limb.multiplicative_constant == 1 && !result.is_constant() && !other.is_constant()) { bool limbconst = result.binary_basis_limbs[0].element.is_constant(); @@ -1645,7 +1645,7 @@ template void bigfield::assert_is_in_field() cons r1 = r1.normalize(); r2 = r2.normalize(); r3 = r3.normalize(); - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { context->decompose_into_default_range(r0.witness_index, static_cast(NUM_LIMB_BITS)); context->decompose_into_default_range(r1.witness_index, static_cast(NUM_LIMB_BITS)); context->decompose_into_default_range(r2.witness_index, static_cast(NUM_LIMB_BITS)); @@ -1778,7 +1778,7 @@ template void bigfield::self_reduce() const // TODO: implicit assumption here - NUM_LIMB_BITS large enough for all the quotient uint32_t quotient_limb_index = context->add_variable(barretenberg::fr(quotient_value.lo)); field_t quotient_limb = field_t::from_witness_index(context, quotient_limb_index); - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { context->decompose_into_default_range(quotient_limb.witness_index, static_cast(maximum_quotient_bits)); } else { context->decompose_into_base4_accumulators(quotient_limb.witness_index, @@ -1880,7 +1880,7 @@ void bigfield::unsafe_evaluate_multiply_add(const bigfield& input_left, ++max_hi_bits; } - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { // The plookup custom bigfield gate requires inputs are witnesses. // If we're using constant values, instantiate them as circuit variables const auto convert_constant_to_witness = [ctx](const bigfield& input) { @@ -2238,7 +2238,7 @@ void bigfield::unsafe_evaluate_multiple_multiply_add(const std::vector::unsafe_evaluate_multiple_multiply_add(const std::vectordecompose_into_default_range(lo.normalize().witness_index, carry_lo_msb); } /* NOTE TO AUDITOR: An extraneous block - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { carry_lo = carry_lo.normalize(); carry_hi = carry_hi.normalize(); ctx->decompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2604,7 +2604,7 @@ void bigfield::unsafe_evaluate_multiple_multiply_add(const std::vectordecompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); @@ -2643,7 +2643,7 @@ void bigfield::unsafe_evaluate_square_add(const bigfield& left, const bigfield& quotient, const bigfield& remainder) { - if (C::type == proof_system::ComposerType::PLOOKUP) { + if (C::type == ComposerType::PLOOKUP) { unsafe_evaluate_multiply_add(left, left, to_add, quotient, { remainder }); return; } @@ -2764,7 +2764,7 @@ void bigfield::unsafe_evaluate_square_add(const bigfield& left, const uint64_t carry_hi_msb = max_hi_bits - (2 * NUM_LIMB_BITS); const barretenberg::fr carry_lo_shift(uint256_t(uint256_t(1) << carry_lo_msb)); - if constexpr (C::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type == ComposerType::PLOOKUP) { carry_lo = carry_lo.normalize(); carry_hi = carry_hi.normalize(); ctx->decompose_into_default_range(carry_lo.witness_index, static_cast(carry_lo_msb)); diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp index ff5310e283..58cb089452 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp index 4b03fdb19b..246321c8f9 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "bigfield.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp index e0c68ce25d..29d8e472c1 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp @@ -393,17 +393,14 @@ template class element { std::array, 5> coordinates; }; - using twin_lookup_table = typename std::conditional, - lookup_table_base<2>>::type; + using twin_lookup_table = typename std:: + conditional, lookup_table_base<2>>::type; - using triple_lookup_table = typename std::conditional, - lookup_table_base<3>>::type; + using triple_lookup_table = typename std:: + conditional, lookup_table_base<3>>::type; - using quad_lookup_table = typename std::conditional, - lookup_table_base<4>>::type; + using quad_lookup_table = typename std:: + conditional, lookup_table_base<4>>::type; /** * Creates a pair of 4-bit lookup tables, the former corresponding to 4 input points, @@ -416,7 +413,7 @@ template class element { quad_lookup_table endo_table; uint256_t beta_val = barretenberg::field::cube_root_of_unity(); Fq beta(barretenberg::fr(beta_val.slice(0, 136)), barretenberg::fr(beta_val.slice(136, 256)), false); - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { for (size_t i = 0; i < 8; ++i) { endo_table.element_table[i + 8].x = base_table[7 - i].x * beta; endo_table.element_table[i + 8].y = base_table[7 - i].y; @@ -449,7 +446,7 @@ template class element { lookup_table_plookup<5> endo_table; uint256_t beta_val = barretenberg::field::cube_root_of_unity(); Fq beta(barretenberg::fr(beta_val.slice(0, 136)), barretenberg::fr(beta_val.slice(136, 256)), false); - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { for (size_t i = 0; i < 16; ++i) { endo_table.element_table[i + 16].x = base_table[15 - i].x * beta; endo_table.element_table[i + 16].y = base_table[15 - i].y; @@ -938,7 +935,7 @@ template class element { bool has_singleton; }; - using batch_lookup_table = typename std::conditional, batch_lookup_table_base>::type; }; diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp index 3ea4326238..32eb7d5b80 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp @@ -900,7 +900,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, double_montgomery_ladder) HEAVY_TYPED_TEST(stdlib_biggroup, compute_naf) { // ULTRATODO: make this work for secp curves - if constexpr (TypeParam::Curve::type == proof_system::CurveType::BN254) { + if constexpr (TypeParam::Curve::type == CurveType::BN254) { size_t num_repetitions = 1; for (size_t i = 0; i < num_repetitions; i++) { TestFixture::test_compute_naf(); @@ -913,7 +913,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, compute_naf) /* These tests only work for UltraComposer */ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_mul) { - if constexpr (TypeParam::Curve::Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (TypeParam::Curve::Composer::type == ComposerType::PLOOKUP) { TestFixture::test_compute_wnaf(); } else { GTEST_SKIP(); @@ -924,8 +924,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_mul) Fr is a bigfield. */ HEAVY_TYPED_TEST(stdlib_biggroup, compute_wnaf) { - if constexpr (TypeParam::Curve::Composer::type != proof_system::plonk::UltraComposer::type && - TypeParam::use_bigfield) { + if constexpr (TypeParam::Curve::Composer::type != UltraComposer::type && TypeParam::use_bigfield) { GTEST_SKIP(); } else { TestFixture::test_compute_wnaf(); @@ -962,7 +961,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_batch_4) /* The following tests are specific to BN254 and don't work when Fr is a bigfield */ HEAVY_TYPED_TEST(stdlib_biggroup, bn254_endo_batch_mul) { - if constexpr (TypeParam::Curve::type == proof_system::CurveType::BN254 && !TypeParam::use_bigfield) { + if constexpr (TypeParam::Curve::type == CurveType::BN254 && !TypeParam::use_bigfield) { TestFixture::test_bn254_endo_batch_mul(); } else { GTEST_SKIP(); @@ -970,7 +969,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, bn254_endo_batch_mul) } HEAVY_TYPED_TEST(stdlib_biggroup, mixed_mul_bn254_endo) { - if constexpr (TypeParam::Curve::type == proof_system::CurveType::BN254 && !TypeParam::use_bigfield) { + if constexpr (TypeParam::Curve::type == CurveType::BN254 && !TypeParam::use_bigfield) { TestFixture::test_mixed_mul_bn254_endo(); } else { GTEST_SKIP(); @@ -980,7 +979,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, mixed_mul_bn254_endo) /* The following tests are specific to SECP256k1 */ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_secp256k1) { - if constexpr (TypeParam::Curve::type == proof_system::CurveType::SECP256K1) { + if constexpr (TypeParam::Curve::type == CurveType::SECP256K1) { TestFixture::test_wnaf_secp256k1(); } else { GTEST_SKIP(); @@ -988,7 +987,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_secp256k1) } HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_8bit_secp256k1) { - if constexpr (TypeParam::Curve::type == proof_system::CurveType::SECP256K1) { + if constexpr (TypeParam::Curve::type == CurveType::SECP256K1) { TestFixture::test_wnaf_8bit_secp256k1(); } else { GTEST_SKIP(); @@ -996,7 +995,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, wnaf_8bit_secp256k1) } HEAVY_TYPED_TEST(stdlib_biggroup, ecdsa_mul_secp256k1) { - if constexpr (TypeParam::Curve::type == proof_system::CurveType::SECP256K1) { + if constexpr (TypeParam::Curve::type == CurveType::SECP256K1) { TestFixture::test_ecdsa_mul_secp256k1(); } else { GTEST_SKIP(); diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp index e0787df4b9..c237d0dfbb 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_batch_mul.hpp @@ -15,7 +15,7 @@ element element::wnaf_batch_mul(const std::vector element::bn254_endo_batch_mul_with_generator break; } } - if constexpr (C::type != proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type != ComposerType::PLOOKUP) { // MERGENOTE: these four lines don't have an equivalent in d-b-p std::vector modified_big_points = big_points; std::vector modified_big_scalars = big_scalars; diff --git a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp index a003cc18d2..7d510e2794 100644 --- a/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_secp256k1.hpp @@ -12,7 +12,7 @@ template template element element::secp256k1_ecdsa_mul(const element& pubkey, const Fr& u1, const Fr& u2) { - if constexpr (C::type != proof_system::ComposerType::PLOOKUP) { + if constexpr (C::type != ComposerType::PLOOKUP) { C* ctx = pubkey.get_context(); return batch_mul({ element::one(ctx), pubkey }, { u1, u2 }); } diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp index 3a86b2c975..b0c2dea8de 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp index c5bfb25570..ff0629b20c 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp index c79b7a7c64..a2bb62031e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bit_array/bit_array_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "bit_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp index bd0d877e45..d080f06f10 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool.test.cpp @@ -26,7 +26,7 @@ TEST(stdlib_bool, test_basic_operations) bool_t f = e ^ b; // f = 0 d = (!f) & a; // d = 1 auto prover = composer.create_prover(); - // if constexpr (Composer::type == proof_system::ComposerType::STANDARD_HONK) { + // if constexpr (Composer::type == ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[0][3], fr(1)); EXPECT_EQ(prover.wire_polynomials[1][3], fr(1)); EXPECT_EQ(prover.wire_polynomials[2][3], fr(1)); diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp index 252abe30ce..a4f7758fe3 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp index 718e749aaf..98c247431f 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp index a63b35aec6..800fd1059c 100644 --- a/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/bool/bool_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "bool.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp index 5c5abda2c1..d63356bc19 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array.cpp @@ -129,7 +129,7 @@ template byte_array::byte_array(const field_t y_lo = (-validator) + (s_lo + shift); field_t y_overlap; - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { // carve out the 2 high bits from (y_lo + shifted_high_limb) and instantiate as y_overlap const uint256_t y_lo_value = y_lo.get_value() + shifted_high_limb.get_value(); const uint256_t y_overlap_value = y_lo_value >> 128; diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp index a0cb861f86..6795867726 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp index 2d82c10698..c0e04755bc 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp index 1eca2596fb..b24568ea12 100644 --- a/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/byte_array/byte_array_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "byte_array.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field.cpp index 3debcc1824..2a76d24872 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.cpp @@ -739,7 +739,7 @@ void field_t::create_range_constraint(const size_t num_bits, st if (is_constant()) { ASSERT(uint256_t(get_value()).get_msb() < num_bits); } else { - if constexpr (ComposerContext::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (ComposerContext::type == ComposerType::PLOOKUP) { context->decompose_into_default_range( normalize().get_witness_index(), num_bits, plonk::UltraComposer::DEFAULT_PLOOKUP_RANGE_BITNUM, msg); } else { @@ -981,7 +981,7 @@ field_t field_t::accumulate(const std::vector< * * If num elements is not a multiple of 3, the final gate will be padded with zero_idx wires **/ - if constexpr (ComposerContext::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (ComposerContext::type == ComposerType::PLOOKUP) { ComposerContext* ctx = nullptr; std::vector accumulator; field_t constant_term = 0; @@ -1039,7 +1039,7 @@ field_t field_t::accumulate(const std::vector< accumulating_total = witness_t(ctx, new_total); } return total.normalize(); - } else if constexpr (ComposerContext::type == proof_system::ComposerType::TURBO) { + } else if constexpr (ComposerContext::type == ComposerType::TURBO) { field_t total(0); bool odd_number = (input.size() & 0x01UL) == 0x01ULL; diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp index 5a71f5e7ef..b78f492e3e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp @@ -192,7 +192,7 @@ template class stdlib_field : public testing::Test { uint64_t expected = fidget(composer); auto prover = composer.create_prover(); - if constexpr (Composer::type == proof_system::ComposerType::STANDARD_HONK) { + if constexpr (Composer::type == ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[2][20], fr(expected)); } else { EXPECT_EQ(prover.key->polynomial_store.get("w_3_lagrange")[18], fr(expected)); @@ -249,7 +249,7 @@ template class stdlib_field : public testing::Test { auto prover = composer.create_prover(); - if constexpr (Composer::type == proof_system::ComposerType::STANDARD_HONK) { + if constexpr (Composer::type == ComposerType::STANDARD_HONK) { EXPECT_EQ(prover.wire_polynomials[2][19], fr(4181)); } else { EXPECT_EQ(prover.key->polynomial_store.get("w_3_lagrange")[17], fr(4181)); diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp index 28ef5e5131..e38059c90e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp index fc72bfffdc..16c0b9a117 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp index 75cc1ab00e..47952895f8 100644 --- a/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/field/field_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "field.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/logic/logic.cpp b/cpp/src/barretenberg/stdlib/primitives/logic/logic.cpp index d3ae520aa8..47d1d848f0 100644 --- a/cpp/src/barretenberg/stdlib/primitives/logic/logic.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/logic/logic.cpp @@ -3,8 +3,7 @@ #include "../composers/composers.hpp" #include "../plookup/plookup.hpp" -namespace plonk { -namespace stdlib { +namespace proof_system::plonk::stdlib { /** * @brief A logical AND or XOR over a variable number of bits. @@ -90,5 +89,4 @@ field_t logic::create_logic_constraint(field_pt& a, field_pt } } INSTANTIATE_STDLIB_TYPE(logic); -} // namespace stdlib -} // namespace plonk +} // namespace proof_system::plonk::stdlib diff --git a/cpp/src/barretenberg/stdlib/primitives/logic/logic.hpp b/cpp/src/barretenberg/stdlib/primitives/logic/logic.hpp index 16423d3188..2b8b99d560 100644 --- a/cpp/src/barretenberg/stdlib/primitives/logic/logic.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/logic/logic.hpp @@ -1,14 +1,14 @@ #pragma once -#include "../composers/composers_fwd.hpp" -#include "../field/field.hpp" +#include "barretenberg/stdlib/primitives/composers/composers_fwd.hpp" +#include "barretenberg/stdlib/primitives/field/field.hpp" +#include "barretenberg/stdlib/primitives/witness/witness.hpp" -namespace plonk { -namespace stdlib { +namespace proof_system::plonk::stdlib { template class logic { private: - typedef field_t field_pt; - typedef witness_t witness_pt; + using field_pt = field_t; + using witness_pt = witness_t; public: static field_pt create_logic_constraint(field_pt& a, field_pt& b, size_t num_bits, bool is_xor_gate); @@ -16,5 +16,4 @@ template class logic { EXTERN_STDLIB_TYPE(logic); -} // namespace stdlib -} // namespace plonk \ No newline at end of file +} // namespace proof_system::plonk::stdlib \ No newline at end of file diff --git a/cpp/src/barretenberg/stdlib/primitives/logic/logic.test.cpp b/cpp/src/barretenberg/stdlib/primitives/logic/logic.test.cpp index 36f0384d2d..bf1dd73e5f 100644 --- a/cpp/src/barretenberg/stdlib/primitives/logic/logic.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/logic/logic.test.cpp @@ -8,8 +8,6 @@ #include "barretenberg/plonk/composer/turbo_composer.hpp" #include "barretenberg/numeric/random/engine.hpp" -using namespace bonk; - namespace test_stdlib_logic { namespace { @@ -19,7 +17,7 @@ auto& engine = numeric::random::get_debug_engine(); template void ignore_unused(T&) {} // use to ignore unused variables in lambdas using namespace barretenberg; -using namespace plonk; +using namespace proof_system::plonk; template class stdlib_logic : public testing::Test { typedef stdlib::bool_t bool_ct; diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp index af7111f8ff..66937a23ba 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/dynamic_array.cpp @@ -25,7 +25,7 @@ DynamicArray::DynamicArray(Composer* composer, const size_t maximum_si , _max_size(maximum_size) , _length(0) { - static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); + static_assert(Composer::type == ComposerType::PLOOKUP); ASSERT(_context != nullptr); _inner_table = ram_table(_context, maximum_size); // Initialize the ram table with all zeroes diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp index df8237b0cd..f68089e229 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/ram_table.cpp @@ -13,7 +13,7 @@ namespace stdlib { */ template ram_table::ram_table(Composer* composer, const size_t table_size) { - static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); + static_assert(Composer::type == ComposerType::PLOOKUP); _context = composer; _length = table_size; _index_initialized.resize(table_size); @@ -35,7 +35,7 @@ template ram_table::ram_table(Composer* composer, */ template ram_table::ram_table(const std::vector& table_entries) { - static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); + static_assert(Composer::type == ComposerType::PLOOKUP); // get the composer _context for (const auto& entry : table_entries) { if (entry.get_context() != nullptr) { diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp index 3d978b23dd..53ed2a80f4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/rom_table.cpp @@ -9,7 +9,7 @@ namespace stdlib { template rom_table::rom_table(const std::vector& table_entries) { - static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); + static_assert(Composer::type == ComposerType::PLOOKUP); // get the composer context for (const auto& entry : table_entries) { if (entry.get_context() != nullptr) { diff --git a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp index a890496e9d..e8aaff2af4 100644 --- a/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/memory/twin_rom_table.cpp @@ -10,7 +10,7 @@ namespace stdlib { template twin_rom_table::twin_rom_table(const std::vector>& table_entries) { - static_assert(Composer::type == proof_system::ComposerType::PLOOKUP); + static_assert(Composer::type == ComposerType::PLOOKUP); // get the composer context for (const auto& entry : table_entries) { if (entry[0].get_context() != nullptr) { diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp index d24c0f897a..d2f2ece246 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp index 085c24f0a0..8e1bd615f6 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp index f8b22f5540..1ff91bdcee 100644 --- a/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/safe_uint/safe_uint_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "safe_uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp index 196c9a5753..c471804804 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.cpp @@ -16,7 +16,7 @@ std::vector uint::constrain_accumulators(Composer* c const size_t num_bits, std::string const& msg) const { - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { // TODO: manage higher bit ranges const auto sequence = plookup_read::get_lookup_accumulators(plookup::MultiTableId::UINT32_XOR, @@ -317,7 +317,7 @@ template bool_t uintget_variable(right_idx)) - uint256_t(context->get_variable(left_idx)) * uint256_t(4); - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { uint256_t lo_bit = quad & 1; uint256_t hi_bit = (quad & 2) >> 1; // difference in quads = 0, 1, 2, 3 = delta diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp index 3b61778464..44f82f8b7b 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.hpp @@ -194,19 +194,19 @@ template inline std::ostream& operator<<(std::ostream& } template -using uint8 = typename std::conditional, uint>::type; template -using uint16 = typename std::conditional, uint>::type; template -using uint32 = typename std::conditional, uint>::type; template -using uint64 = typename std::conditional, uint>::type; diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp index 2c4b8b29b0..5b098ba4e5 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint.test.cpp @@ -76,7 +76,7 @@ uint_native rotate(uint_native value, size_t rotation) : value; } template class stdlib_uint : public testing::Test { - typedef typename std::conditional, stdlib::uint>::type uint_ct; typedef stdlib::bool_t bool_ct; diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp index 8d7ed88eba..4c8f6a70bc 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_all.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard | proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard | ComposerType::Turbo; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp index 42e8262e67..2326494030 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_standard.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Standard; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Standard; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp b/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp index 4f4b2100d3..c5a59d827e 100644 --- a/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp +++ b/cpp/src/barretenberg/stdlib/primitives/uint/uint_turbo.fuzzer.cpp @@ -1,3 +1,3 @@ #include "barretenberg/common/fuzzer_constants.hpp" -constexpr uint64_t FuzzerComposerTypes = proof_system::ComposerType::Turbo; +constexpr uint64_t FuzzerComposerTypes = ComposerType::Turbo; #include "uint.fuzzer.hpp" diff --git a/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp b/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp index 649415cd10..def7ead90a 100644 --- a/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/transcript/transcript.hpp @@ -246,7 +246,7 @@ template class Transcript { } field_pt T0; - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { T0 = stdlib::pedersen_plookup::compress(compression_buffer); } else { T0 = stdlib::pedersen::compress(compression_buffer); diff --git a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp index bc245ae699..4d6dc477c4 100644 --- a/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp +++ b/cpp/src/barretenberg/stdlib/recursion/verification_key/verification_key.hpp @@ -54,7 +54,7 @@ template struct evaluation_domain { field_t compress() const { - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { field_t out = pedersen_plookup::compress({ root, domain, @@ -74,7 +74,7 @@ template struct evaluation_domain { static barretenberg::fr compress_native(const barretenberg::evaluation_domain& input) { barretenberg::fr out; - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { out = crypto::pedersen::lookup::compress_native({ input.root, input.domain, @@ -155,7 +155,7 @@ template struct verification_key { const auto circuit_key_compressed = compress(); bool found = false; // if we're using Plookup, use a ROM table to index the keys - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { field_t key_index(witness_t(context, 0)); std::vector> compressed_keys; for (size_t i = 0; i < keys_in_set.size(); ++i) { @@ -205,7 +205,7 @@ template struct verification_key { } field_t compressed_key; - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { compressed_key = pedersen_plookup::compress(key_witnesses); } else { compressed_key = pedersen::compress(key_witnesses); @@ -245,7 +245,7 @@ template struct verification_key { key_witnesses.push_back(y_limbs[3]); } barretenberg::fr compressed_key; - if constexpr (Composer::type == proof_system::ComposerType::PLOOKUP) { + if constexpr (Composer::type == ComposerType::PLOOKUP) { compressed_key = crypto::pedersen::lookup::compress_native(key_witnesses); } else { compressed_key = crypto::pedersen::compress_native(key_witnesses); @@ -265,7 +265,7 @@ template struct verification_key { // Native data: - std::shared_ptr reference_string; + std::shared_ptr reference_string; PolynomialManifest polynomial_manifest; From 3f1b5a38c3e5d01be1a3b7b92214f03a5c28d884 Mon Sep 17 00:00:00 2001 From: codygunton Date: Wed, 5 Apr 2023 16:16:02 -0400 Subject: [PATCH 5/5] Add todos. --- cpp/src/barretenberg/honk/CMakeLists.txt | 1 + .../composer/composer_helper/standard_honk_composer_helper.hpp | 1 + cpp/src/barretenberg/proof_system/types/composer_type.hpp | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/cpp/src/barretenberg/honk/CMakeLists.txt b/cpp/src/barretenberg/honk/CMakeLists.txt index df60576b16..529a54878b 100644 --- a/cpp/src/barretenberg/honk/CMakeLists.txt +++ b/cpp/src/barretenberg/honk/CMakeLists.txt @@ -1,3 +1,4 @@ +# TODO(Cody): Remove plonk dependency barretenberg_module(honk numeric ecc srs proof_system transcript plonk) if(TESTING) diff --git a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp index 613daaf6a1..5b033996d5 100644 --- a/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp +++ b/cpp/src/barretenberg/honk/composer/composer_helper/standard_honk_composer_helper.hpp @@ -29,6 +29,7 @@ template class StandardHonkComposerHelper { // at all std::shared_ptr crs_factory_; bool computed_witness = false; + // TODO(Luke): use make_shared StandardHonkComposerHelper() : StandardHonkComposerHelper(std::shared_ptr( new proof_system::FileReferenceStringFactory("../srs_db/ignition"))) diff --git a/cpp/src/barretenberg/proof_system/types/composer_type.hpp b/cpp/src/barretenberg/proof_system/types/composer_type.hpp index 3521715cd4..295967e136 100644 --- a/cpp/src/barretenberg/proof_system/types/composer_type.hpp +++ b/cpp/src/barretenberg/proof_system/types/composer_type.hpp @@ -1,6 +1,6 @@ #pragma once namespace proof_system { -// This will go away, but we move it here has a temporary measure to make proof_system not depend on honk or plonk. +// TODO(Cody) Get rid of this. enum ComposerType { STANDARD, TURBO, PLOOKUP, STANDARD_HONK }; } // namespace proof_system \ No newline at end of file