diff --git a/barretenberg/cpp/src/barretenberg/circuit_checker/ultra_circuit_checker.cpp b/barretenberg/cpp/src/barretenberg/circuit_checker/ultra_circuit_checker.cpp index 4396802c7589..e54463359c2b 100644 --- a/barretenberg/cpp/src/barretenberg/circuit_checker/ultra_circuit_checker.cpp +++ b/barretenberg/cpp/src/barretenberg/circuit_checker/ultra_circuit_checker.cpp @@ -35,8 +35,6 @@ template bool UltraCircuitChecker::check(const Builder& build MemoryCheckData memory_data{ builder }; bool result = true; - // TODO(https://github.com/AztecProtocol/barretenberg/issues/870): Currently we check all relations for each block. - // Once sorting is complete, is will be sufficient to check only the relevant relation(s) per block. size_t block_idx = 0; for (auto& block : builder.blocks.get()) { result = result && check_block(builder, block, tag_data, memory_data, lookup_hash_table); diff --git a/barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp b/barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp index ec31de7ac8d7..c3d7151108ab 100644 --- a/barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp +++ b/barretenberg/cpp/src/barretenberg/commitment_schemes/ipa/ipa.hpp @@ -587,8 +587,6 @@ template class IPA { * *@remark The verification procedure documentation is in \link IPA::verify_internal verify_internal \endlink */ - // TODO(https://github.com/AztecProtocol/barretenberg/issues/912): Return the proper VerifierAccumulator once - // implemented static VerifierAccumulator reduce_verify(const OpeningClaim& opening_claim, const auto& transcript) requires(Curve::is_stdlib_type) diff --git a/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp b/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp index 53f8a39c9938..0e2350fb58f2 100644 --- a/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp +++ b/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp @@ -329,8 +329,6 @@ template class ZeroMorphProver_ { * @param multilinear_challenge Multilinear challenge point u * @param commitment_key * @param transcript - * - * @todo https://github.com/AztecProtocol/barretenberg/issues/1030: document concatenation trick */ template static OpeningClaim prove(FF circuit_size, diff --git a/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp b/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp index a7a63bc2a853..d12cab07fbc9 100644 --- a/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp +++ b/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp @@ -229,8 +229,6 @@ void build_constraints(Builder& builder, AcirProgram& program, const ProgramMeta } // RecursionConstraints - // TODO(https://github.com/AztecProtocol/barretenberg/issues/817): disable these for MegaHonk for now since we're - // not yet dealing with proper recursion if constexpr (IsMegaBuilder) { if (!constraint_system.recursion_constraints.empty()) { info("WARNING: this circuit contains unhandled recursion_constraints!"); diff --git a/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_integration.test.cpp b/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_integration.test.cpp index 30c6e41a987f..dc3a90c90680 100644 --- a/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_integration.test.cpp +++ b/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_integration.test.cpp @@ -308,7 +308,7 @@ INSTANTIATE_TEST_SUITE_P(AcirTests, "regression_4202", "regression_4449", "regression_4709", - //"regression_5045", + "regression_5045", "regression_capacity_tracker", "regression_mem_op_predicate", "regression_method_cannot_be_found", diff --git a/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_to_constraint_buf.cpp b/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_to_constraint_buf.cpp index 32953099687f..7a0921b55270 100644 --- a/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_to_constraint_buf.cpp +++ b/barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_to_constraint_buf.cpp @@ -25,12 +25,6 @@ using namespace bb; */ poly_triple serialize_arithmetic_gate(Program::Expression const& arg) { - // TODO(https://github.com/AztecProtocol/barretenberg/issues/816): The initialization of the witness indices a,b,c - // to 0 is implicitly assuming that (builder.zero_idx == 0) which is no longer the case. Now, witness idx 0 in - // general will correspond to some non-zero value and some witnesses which are not explicitly set below will be - // erroneously populated with this value. This does not cause failures however because the corresponding selector - // will indeed be 0 so the gate will be satisfied. Still, its a bad idea to have erroneous wire values - // even if they dont break the relation. They'll still add cost in commitments, for example. poly_triple pt{ .a = 0, .b = 0, @@ -67,9 +61,6 @@ poly_triple serialize_arithmetic_gate(Program::Expression const& arg) // If the witness index has not yet been set or if the corresponding linear term is active, set the witness // index and the corresponding selector value. - // TODO(https://github.com/AztecProtocol/barretenberg/issues/816): May need to adjust the pt.a == witness_idx - // check (and the others like it) since we initialize a,b,c with 0 but 0 is a valid witness index once the - // +1 offset is removed from noir. if (!a_set || pt.a == witness_idx) { // q_l * w_l pt.a = witness_idx; pt.q_l = selector_value; @@ -241,12 +232,6 @@ std::vector> split_into_mul_quad_gates(Program::Expression const& mul_quad_ serialize_mul_quad_gate(Program::Expression const& arg) { - // TODO(https://github.com/AztecProtocol/barretenberg/issues/816): The initialization of the witness indices a,b,c - // to 0 is implicitly assuming that (builder.zero_idx == 0) which is no longer the case. Now, witness idx 0 in - // general will correspond to some non-zero value and some witnesses which are not explicitly set below will be - // erroneously populated with this value. This does not cause failures however because the corresponding selector - // will indeed be 0 so the gate will be satisfied. Still, its a bad idea to have erroneous wire values - // even if they dont break the relation. They'll still add cost in commitments, for example. mul_quad_ quad{ .a = 0, .b = 0, .c = 0, @@ -280,9 +265,6 @@ mul_quad_ serialize_mul_quad_gate(Program::Expression const& arg) // If the witness index has not yet been set or if the corresponding linear term is active, set the witness // index and the corresponding selector value. - // TODO(https://github.com/AztecProtocol/barretenberg/issues/816): May need to adjust the quad.a == witness_idx - // check (and the others like it) since we initialize a,b,c with 0 but 0 is a valid witness index once the - // +1 offset is removed from noir. if (!a_set || quad.a == witness_idx) { quad.a = witness_idx; quad.a_scaling = selector_value; diff --git a/barretenberg/cpp/src/barretenberg/dsl/acir_format/ivc_recursion_constraint.hpp b/barretenberg/cpp/src/barretenberg/dsl/acir_format/ivc_recursion_constraint.hpp index c660f150bd92..2e83e99ca580 100644 --- a/barretenberg/cpp/src/barretenberg/dsl/acir_format/ivc_recursion_constraint.hpp +++ b/barretenberg/cpp/src/barretenberg/dsl/acir_format/ivc_recursion_constraint.hpp @@ -8,9 +8,6 @@ namespace acir_format { using namespace bb; -// TODO(https://github.com/AztecProtocol/barretenberg/issues/1148): logic in this file is incomplete. See issue for -// details. - std::shared_ptr create_mock_ivc_from_constraints(const std::vector& constraints, const TraceSettings& trace_settings); diff --git a/barretenberg/cpp/src/barretenberg/dsl/acir_proofs/c_bind.cpp b/barretenberg/cpp/src/barretenberg/dsl/acir_proofs/c_bind.cpp index 154248b6e87c..28b6171c4654 100644 --- a/barretenberg/cpp/src/barretenberg/dsl/acir_proofs/c_bind.cpp +++ b/barretenberg/cpp/src/barretenberg/dsl/acir_proofs/c_bind.cpp @@ -207,8 +207,6 @@ WASM_EXPORT void acir_prove_and_verify_aztec_client(uint8_t const* acir_stack, const acir_format::ProgramMetadata metadata{ ivc }; // Accumulate the entire program stack into the IVC - // TODO(https://github.com/AztecProtocol/barretenberg/issues/1116): remove manual setting of is_kernel once databus - // has been integrated into noir kernel programs bool is_kernel = false; auto start = std::chrono::steady_clock::now(); for (Program& program : folding_stack) { diff --git a/barretenberg/cpp/src/barretenberg/goblin/goblin.hpp b/barretenberg/cpp/src/barretenberg/goblin/goblin.hpp index ec62293ddb26..ae23d9c3a97b 100644 --- a/barretenberg/cpp/src/barretenberg/goblin/goblin.hpp +++ b/barretenberg/cpp/src/barretenberg/goblin/goblin.hpp @@ -241,8 +241,7 @@ class GoblinVerifier { bool accumulator_construction_verified = translator_verifier.verify_proof( proof.translator_proof, eccvm_verifier.evaluation_challenge_x, eccvm_verifier.batching_challenge_v); - // TODO(https://github.com/AztecProtocol/barretenberg/issues/799): Ensure translation_evaluations are passed - // correctly + bool translation_verified = translator_verifier.verify_translation( proof.translation_evaluations, eccvm_verifier.translation_masking_term_eval); diff --git a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/types/pedersen_commitment_type.hpp b/barretenberg/cpp/src/barretenberg/plonk_honk_shared/types/pedersen_commitment_type.hpp deleted file mode 100644 index 8e72d71d6bc0..000000000000 --- a/barretenberg/cpp/src/barretenberg/plonk_honk_shared/types/pedersen_commitment_type.hpp +++ /dev/null @@ -1,6 +0,0 @@ -#pragma once - -namespace bb::pedersen { -// TODO(https://github.com/AztecProtocol/barretenberg/issues/426) -enum CommitmentType { FIXED_BASE_PEDERSEN, LOOKUP_PEDERSEN }; -} // namespace bb::pedersen diff --git a/barretenberg/cpp/src/barretenberg/polynomials/barycentric.hpp b/barretenberg/cpp/src/barretenberg/polynomials/barycentric.hpp index dbad8cb56f03..f9c25d981fd4 100644 --- a/barretenberg/cpp/src/barretenberg/polynomials/barycentric.hpp +++ b/barretenberg/cpp/src/barretenberg/polynomials/barycentric.hpp @@ -8,7 +8,8 @@ // with the non-constexpr setting. Right now everything is more or less duplicated across BarycentricDataCompileTime and // BarycentricDataRunTime. There should be a way to share more of the logic. -/* IMPROVEMENT(Cody): This could or should be improved in various ways. In no particular order: +/* TODO(https://github.com/AztecProtocol/barretenberg/issues/10): This could or should be improved in various ways. In + no particular order: 1) Edge cases are not considered. One non-use case situation (I forget which) leads to a segfault. 2) Precomputing for all possible size pairs is probably feasible and might be a better solution than instantiating diff --git a/barretenberg/cpp/src/barretenberg/protogalaxy/folding_result.hpp b/barretenberg/cpp/src/barretenberg/protogalaxy/folding_result.hpp index cad8fcf7844f..1511234a8a8b 100644 --- a/barretenberg/cpp/src/barretenberg/protogalaxy/folding_result.hpp +++ b/barretenberg/cpp/src/barretenberg/protogalaxy/folding_result.hpp @@ -10,7 +10,6 @@ namespace bb { template struct FoldingResult { public: std::shared_ptr> accumulator; - // TODO(https://github.com/AztecProtocol/barretenberg/issues/656): turn folding data into a struct std::vector proof; }; -} // namespace bb \ No newline at end of file +} // namespace bb diff --git a/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp b/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp index aef9371ef621..d5b45f6968be 100644 --- a/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp +++ b/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp @@ -46,7 +46,6 @@ template class ProtogalaxyProver_ { ProtogalaxyProver_(const std::vector>& keys, ExecutionTraceUsageTracker trace_usage_tracker = ExecutionTraceUsageTracker{}) : keys_to_fold(DeciderProvingKeys_(keys)) - // TODO(https://github.com/AztecProtocol/barretenberg/issues/878) , commitment_key(keys_to_fold[1]->proving_key.commitment_key) , pg_internal(trace_usage_tracker){}; @@ -106,4 +105,4 @@ template class ProtogalaxyProver_ { */ BB_PROFILE FoldingResult prove(); }; -} // namespace bb \ No newline at end of file +} // namespace bb diff --git a/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover_impl.hpp b/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover_impl.hpp index 6fbd2e47dc0a..b45465dd6c33 100644 --- a/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover_impl.hpp +++ b/barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover_impl.hpp @@ -105,8 +105,6 @@ ProtogalaxyProver_::combiner_quotient_round(const std::vecto /** * @brief Given the challenge \gamma, compute Z(\gamma) and {L_0(\gamma),L_1(\gamma)} - * TODO(https://github.com/AztecProtocol/barretenberg/issues/764): Generalize the vanishing polynomial formula - * and the computation of Lagrange basis for k decider proving keys. */ template FoldingResult ProtogalaxyProver_::update_target_sum_and_fold( @@ -209,4 +207,4 @@ FoldingResult ProtogalaxyProver_ class ProtogalaxyProverInternal { /** * @brief Compute the combiner quotient defined as $K$ polynomial in the paper. - * - * TODO(https://github.com/AztecProtocol/barretenberg/issues/764): generalize the computation of vanishing - * polynomials and Lagrange basis and use batch_invert. - * */ static Univariate compute_combiner_quotient( FF perturbator_evaluation, ExtendedUnivariateWithRandomization combiner) diff --git a/barretenberg/cpp/src/barretenberg/relations/utils.hpp b/barretenberg/cpp/src/barretenberg/relations/utils.hpp index 905ddfe310f1..8ef8e8bec577 100644 --- a/barretenberg/cpp/src/barretenberg/relations/utils.hpp +++ b/barretenberg/cpp/src/barretenberg/relations/utils.hpp @@ -150,7 +150,6 @@ template class RelationUtils { * thesis). */ template - // TODO(#224)(Cody): Input should be an array? inline static void accumulate_relation_evaluations_without_skipping(const PolynomialEvaluations& evaluations, RelationEvaluations& relation_evaluations, const Parameters& relation_parameters, @@ -173,7 +172,6 @@ template class RelationUtils { * thesis). */ template - // TODO(#224)(Cody): Input should be an array? inline static RelationEvaluations accumulate_relation_evaluations(const PolynomialEvaluations& evaluations, const Parameters& relation_parameters, const FF& partial_evaluation_result) diff --git a/barretenberg/cpp/src/barretenberg/stdlib/client_ivc_verifier/client_ivc_recursive_verifier.cpp b/barretenberg/cpp/src/barretenberg/stdlib/client_ivc_verifier/client_ivc_recursive_verifier.cpp index ca351429ab07..6edbc452a030 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/client_ivc_verifier/client_ivc_recursive_verifier.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/client_ivc_verifier/client_ivc_recursive_verifier.cpp @@ -4,9 +4,6 @@ namespace bb::stdlib::recursion::honk { /** * @brief Performs recursive verification of the Client IVC proof. - * - * @todo (https://github.com/AztecProtocol/barretenberg/issues/934): Add logic for accumulating the pairing points - * produced by the verifiers (and potentially IPA accumulators for ECCVM verifier) */ ClientIVCRecursiveVerifier::Output ClientIVCRecursiveVerifier::verify(const ClientIVC::Proof& proof) { @@ -29,4 +26,4 @@ ClientIVCRecursiveVerifier::Output ClientIVCRecursiveVerifier::verify(const Clie return output; } -} // namespace bb::stdlib::recursion::honk \ No newline at end of file +} // namespace bb::stdlib::recursion::honk diff --git a/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.cpp b/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.cpp index deb50225a8da..d260c8e6ce8c 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/goblin_recursive_verifier.cpp @@ -4,9 +4,6 @@ namespace bb::stdlib::recursion::honk { /** * @brief Runs the Goblin recursive verifier consisting of ECCVM, Translator and Merge verifiers. - * - * @todo https://github.com/AztecProtocol/barretenberg/issues/934: Add logic for accumulating the pairing points - * produced by the translator and merge verifier (and potentially IPA accumulators for ECCVM verifier) */ GoblinRecursiveVerifierOutput GoblinRecursiveVerifier::verify(const GoblinProof& proof) { diff --git a/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/merge_verifier.test.cpp b/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/merge_verifier.test.cpp index 764ae5830280..c1fa8405d4ee 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/merge_verifier.test.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/goblin_verifier/merge_verifier.test.cpp @@ -89,9 +89,6 @@ template class RecursiveMergeVerifierTest : public test } }; -// Run the recursive verifier tests with Ultra and Mega builders -// TODO(https://github.com/AztecProtocol/barretenberg/issues/1024): Ultra fails, possibly due to repeated points in -// batch mul? using Builders = testing::Types; TYPED_TEST_SUITE(RecursiveMergeVerifierTest, Builders); diff --git a/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ipa_accumulator.hpp b/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ipa_accumulator.hpp index a89382865731..eb8b1b0e0099 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ipa_accumulator.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/honk_verifier/ipa_accumulator.hpp @@ -3,13 +3,11 @@ #include namespace bb::stdlib::recursion::honk { -// TODO(https://github.com/AztecProtocol/barretenberg/issues/1009): Make the us vector an array after we constify eccvm -// circuit size. template struct IpaAccumulator { typename Curve::ScalarField log_poly_length; std::vector - u_challenges_inv; // inverses of u challenges that represent the polynomial h + u_challenges_inv; // inverses of u challenges that represent the polynomial h; could be an array typename Curve::Group comm; // commitment to the polynomial h }; -} // namespace bb::stdlib::recursion::honk \ No newline at end of file +} // namespace bb::stdlib::recursion::honk diff --git a/barretenberg/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp b/barretenberg/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp index d756044298b5..9be01e8f94b0 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/primitives/bigfield/bigfield_impl.hpp @@ -1105,8 +1105,6 @@ bigfield bigfield::sqradd(const std::vector& t * @returns this ** (exponent) * * @todo TODO(https://github.com/AztecProtocol/barretenberg/issues/1014) Improve the efficiency of this function. - * @todo TODO(https://github.com/AztecProtocol/barretenberg/issues/1015) Security of this (as part of the whole - * class) */ template bigfield bigfield::pow(const size_t exponent) const @@ -1147,8 +1145,6 @@ template bigfield bigfield bigfield bigfield::pow(const field_t& exponent) const diff --git a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp index ee11b3b75e61..5e753df12552 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.hpp @@ -232,7 +232,7 @@ template class element { // i.e. for the bn254 curve, the template param is `typename = void` // for any other curve, there is no template param template ::value>> - requires(IsNotMegaBuilder) // TODO(https://github.com/AztecProtocol/barretenberg/issues/707) + requires(IsNotMegaBuilder) static element bn254_endo_batch_mul(const std::vector& big_points, const std::vector& big_scalars, const std::vector& small_points, @@ -240,7 +240,7 @@ template class element { const size_t max_num_small_bits); template ::value>> - requires(IsNotMegaBuilder) // TODO(https://github.com/AztecProtocol/barretenberg/issues/707) + requires(IsNotMegaBuilder) static element bn254_endo_batch_mul_with_generator(const std::vector& big_points, const std::vector& big_scalars, const std::vector& small_points, diff --git a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp index 6a96f54f7598..855d970fb951 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp @@ -1754,7 +1754,7 @@ TYPED_TEST(stdlib_biggroup, dbl) TYPED_TEST(stdlib_biggroup, montgomery_ladder) { if constexpr (HasGoblinBuilder) { - GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/707"; + GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/1290"; } else { TestFixture::test_montgomery_ladder(); }; @@ -1793,7 +1793,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, short_scalar_mul_infinity) HEAVY_TYPED_TEST(stdlib_biggroup, twin_mul) { if constexpr (HasGoblinBuilder) { - GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/707"; + GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/1290"; } else { TestFixture::test_twin_mul(); }; @@ -1801,7 +1801,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, twin_mul) HEAVY_TYPED_TEST(stdlib_biggroup, triple_mul) { if constexpr (HasGoblinBuilder) { - GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/707"; + GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/1290"; } else { TestFixture::test_triple_mul(); }; @@ -1809,7 +1809,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, triple_mul) HEAVY_TYPED_TEST(stdlib_biggroup, quad_mul) { if constexpr (HasGoblinBuilder) { - GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/707"; + GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/1290"; } else { TestFixture::test_quad_mul(); }; @@ -1844,7 +1844,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, chain_add) { if constexpr (HasGoblinBuilder) { - GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/707"; + GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/1290"; } else { TestFixture::test_chain_add(); }; @@ -1853,7 +1853,7 @@ HEAVY_TYPED_TEST(stdlib_biggroup, multiple_montgomery_ladder) { if constexpr (HasGoblinBuilder) { - GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/707"; + GTEST_SKIP() << "https://github.com/AztecProtocol/barretenberg/issues/1290"; } else { TestFixture::test_multiple_montgomery_ladder(); }; @@ -1997,4 +1997,4 @@ HEAVY_TYPED_TEST(stdlib_biggroup, ecdsa_mul_secp256k1) } else { GTEST_SKIP(); } -} \ No newline at end of file +} diff --git a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_goblin.hpp b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_goblin.hpp index 25ec35a8dce8..da4f10bcf933 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_goblin.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_goblin.hpp @@ -227,7 +227,7 @@ template class goblin_el goblin_element dbl() const { return batch_mul({ *this }, { 2 }); } - // TODO(https://github.com/AztecProtocol/barretenberg/issues/707) max_num_bits is unused; could implement and + // TODO(https://github.com/AztecProtocol/barretenberg/issues/1291) max_num_bits is unused; could implement and // use this to optimize other operations. interface compatible with biggroup.hpp, the final parameter // handle_edge_cases is not needed as this is always done in the eccvm static goblin_element batch_mul(const std::vector& points, diff --git a/barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field.cpp b/barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field.cpp index 51b4b726be58..b6e47a9f6ce4 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/primitives/field/field.cpp @@ -376,6 +376,7 @@ template field_t field_t::pow(const field_t } bool exponent_constant = exponent.is_constant(); + // TODO(https://github.com/AztecProtocol/barretenberg/issues/446): optimize by allowing smaller expoonent std::vector> exponent_bits(32); for (size_t i = 0; i < exponent_bits.size(); ++i) { uint256_t value_bit = exponent_value & 1; diff --git a/barretenberg/cpp/src/barretenberg/stdlib/protogalaxy_verifier/protogalaxy_recursive_verifier.test.cpp b/barretenberg/cpp/src/barretenberg/stdlib/protogalaxy_verifier/protogalaxy_recursive_verifier.test.cpp index 40f31064e90b..70e553199cdf 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/protogalaxy_verifier/protogalaxy_recursive_verifier.test.cpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/protogalaxy_verifier/protogalaxy_recursive_verifier.test.cpp @@ -267,8 +267,6 @@ template class ProtogalaxyRecursiveTests : public tes * make sure the verifer circuits pass check_circuit(). Ensure that the algorithm of the recursive and native * verifiers are identical by checking the manifests */ - // TODO(https://github.com/AztecProtocol/barretenberg/issues/844): Fold the recursive folding verifier in - // tests once we can fold keys of different sizes. static void test_full_protogalaxy_recursive() { // Create two arbitrary circuits for the first round of folding @@ -516,4 +514,4 @@ TYPED_TEST(ProtogalaxyRecursiveTests, ConstantVerifierCircuit) TestFixture::test_constant_pg_verifier_circuit(); } -} // namespace bb::stdlib::recursion::honk \ No newline at end of file +} // namespace bb::stdlib::recursion::honk diff --git a/barretenberg/cpp/src/barretenberg/stdlib/translator_vm_verifier/translator_recursive_verifier.hpp b/barretenberg/cpp/src/barretenberg/stdlib/translator_vm_verifier/translator_recursive_verifier.hpp index 3faf36e0d733..fa04078ff775 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib/translator_vm_verifier/translator_recursive_verifier.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib/translator_vm_verifier/translator_recursive_verifier.hpp @@ -42,8 +42,6 @@ template class TranslatorRecursiveVerifier_ { PairingPoints verify_proof(const HonkProof& proof, const BF& evaluation_input_x, const BF& batching_challenge_v); - // TODO(https://github.com/AztecProtocol/barretenberg/issues/986): Ensure the translation is also recursively - // verified somewhere bool verify_translation(const TranslationEvaluations& translation_evaluations, const BF& translation_masking_term_eval); }; diff --git a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_simulator.hpp b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_simulator.hpp index 5d8221ee15b8..aec21bd440ad 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_simulator.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/circuit_simulator.hpp @@ -6,7 +6,6 @@ #include "barretenberg/plonk_honk_shared/types/aggregation_object_type.hpp" #include "barretenberg/plonk_honk_shared/types/circuit_type.hpp" #include "barretenberg/plonk_honk_shared/types/merkle_hash_type.hpp" -#include "barretenberg/plonk_honk_shared/types/pedersen_commitment_type.hpp" #include "barretenberg/stdlib_circuit_builders/plookup_tables/plookup_tables.hpp" #include "barretenberg/stdlib_circuit_builders/plookup_tables/types.hpp" #include diff --git a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/mega_flavor.hpp b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/mega_flavor.hpp index bf3139d5e84f..1b7fcfbcb67a 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/mega_flavor.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/mega_flavor.hpp @@ -334,8 +334,6 @@ class MegaFlavor { // fully-formed constructor ProverPolynomials(size_t circuit_size) { - // TODO(https://github.com/AztecProtocol/barretenberg/issues/1072): Unexpected jump in time to allocate all - // of these polys (in client_ivc_bench only). PROFILE_THIS_NAME("ProverPolynomials(size_t)"); for (auto& poly : get_to_be_shifted()) { diff --git a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.hpp b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.hpp index 04b81d749440..ca527db663d9 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/standard_circuit_builder.hpp @@ -4,7 +4,6 @@ #include "barretenberg/plonk_honk_shared/execution_trace/standard_execution_trace.hpp" #include "barretenberg/plonk_honk_shared/types/circuit_type.hpp" #include "barretenberg/plonk_honk_shared/types/merkle_hash_type.hpp" -#include "barretenberg/plonk_honk_shared/types/pedersen_commitment_type.hpp" #include "barretenberg/trace_to_polynomials/trace_to_polynomials.hpp" #include "circuit_builder_base.hpp" #include @@ -24,7 +23,6 @@ template class StandardCircuitBuilder_ : public CircuitBuilderBase static constexpr std::string_view NAME_STRING = "StandardExecutionTrace"; static constexpr CircuitType CIRCUIT_TYPE = CircuitType::STANDARD; static constexpr merkle::HashType merkle_hash_type = merkle::HashType::FIXED_BASE_PEDERSEN; - static constexpr pedersen::CommitmentType commitment_type = pedersen::CommitmentType::FIXED_BASE_PEDERSEN; // Storage for wires and selectors for all gate types GateBlocks blocks; diff --git a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_circuit_builder.hpp b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_circuit_builder.hpp index 6fd2525607f7..59ead130ae27 100644 --- a/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_circuit_builder.hpp +++ b/barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/ultra_circuit_builder.hpp @@ -3,7 +3,6 @@ #include "barretenberg/plonk_honk_shared/execution_trace/ultra_execution_trace.hpp" #include "barretenberg/plonk_honk_shared/types/circuit_type.hpp" #include "barretenberg/plonk_honk_shared/types/merkle_hash_type.hpp" -#include "barretenberg/plonk_honk_shared/types/pedersen_commitment_type.hpp" #include "barretenberg/stdlib_circuit_builders/op_queue/ecc_op_queue.hpp" #include "barretenberg/stdlib_circuit_builders/plookup_tables/plookup_tables.hpp" #include "barretenberg/stdlib_circuit_builders/plookup_tables/types.hpp" @@ -44,7 +43,6 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase(size_hint) { - // TODO(https://github.com/AztecProtocol/barretenberg/issues/870): reserve space in blocks here somehow? this->zero_idx = put_constant_variable(FF::zero()); this->tau.insert({ DUMMY_TAG, DUMMY_TAG }); // TODO(luke): explain this }; @@ -363,8 +360,6 @@ class UltraCircuitBuilder_ : public CircuitBuilderBase(size_hint, witness_values.empty()) { - // TODO(https://github.com/AztecProtocol/barretenberg/issues/870): reserve space in blocks here somehow? - for (size_t idx = 0; idx < varnum; ++idx) { // Zeros are added for variables whose existence is known but whose values are not yet known. The values may // be "set" later on via the assert_equal mechanism. diff --git a/barretenberg/cpp/src/barretenberg/ultra_vanilla_client_ivc/ultra_vanilla_client_ivc.cpp b/barretenberg/cpp/src/barretenberg/ultra_vanilla_client_ivc/ultra_vanilla_client_ivc.cpp index c7d88a2795ff..168e2719122f 100644 --- a/barretenberg/cpp/src/barretenberg/ultra_vanilla_client_ivc/ultra_vanilla_client_ivc.cpp +++ b/barretenberg/cpp/src/barretenberg/ultra_vanilla_client_ivc/ultra_vanilla_client_ivc.cpp @@ -50,7 +50,7 @@ HonkProof UltraVanillaClientIVC::prove(CircuitSource& source, previous_proof = prover.construct_proof(); vinfo("constructed proof"); } else { - // TODO(https://github.com/AztecProtocol/barretenberg/issues/1176) Use UltraKeccakZKProver when it exists + // TODO(https://github.com/AztecProtocol/barretenberg/issues/1294) Use UltraKeccakZKProver when it exists UltraProver prover{ proving_key, commitment_key }; previous_proof = prover.construct_proof(); } diff --git a/barretenberg/scripts/find_github_issues.sh b/barretenberg/scripts/find_github_issues.sh new file mode 100755 index 000000000000..c1b960559217 --- /dev/null +++ b/barretenberg/scripts/find_github_issues.sh @@ -0,0 +1,6 @@ +RESULT=../issues +> $RESULT +find acir_tests/ -name "*.sh" -exec grep "barretenberg/issues/" {} + >> ../issues +find cpp/src/ -type f -exec grep "barretenberg/issues/" {} + >> ../issues +find ts/src -type f -exec grep "barretenberg/issues/" {} + >> ../issues +find sol/src -type f -exec grep "barretenberg/issues/" {} + >> ../issues