From a1f31330db90dd1e8e139f8e8b727c21c602ae0b Mon Sep 17 00:00:00 2001 From: saleel Date: Thu, 27 Feb 2025 06:01:50 +0000 Subject: [PATCH 1/2] feat: add logs to bb cli --- .../cpp/src/barretenberg/api/api_ultra_honk.cpp | 3 +++ .../cpp/src/barretenberg/api/write_prover_output.hpp | 4 ++++ .../barretenberg/ultra_honk/decider_proving_key.hpp | 10 +++++----- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp b/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp index 040c1f72c8a1..76b337eae74c 100644 --- a/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp +++ b/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp @@ -110,6 +110,8 @@ bool _verify(const bool honk_recursion_2, const std::filesystem::path& proof_pat verified = verifier.verify_proof(proof); } + verified ? info("Proof verified successfully") : info("Proof verification failed"); + return verified; } @@ -212,6 +214,7 @@ void UltraHonkAPI::write_contract(const Flags& flags, std::cout << contract; } else { write_file(output_path, { contract.begin(), contract.end() }); + info("Solidity verifier saved to ", output_path); } } diff --git a/barretenberg/cpp/src/barretenberg/api/write_prover_output.hpp b/barretenberg/cpp/src/barretenberg/api/write_prover_output.hpp index d410a2c3c358..35510c55729f 100644 --- a/barretenberg/cpp/src/barretenberg/api/write_prover_output.hpp +++ b/barretenberg/cpp/src/barretenberg/api/write_prover_output.hpp @@ -34,6 +34,7 @@ void write(const ProverOutput& prover_output, write_bytes_to_stdout(buf); } else { write_file(output_dir / "proof", buf); + info("Proof saved to ", output_dir / "proof"); } break; } @@ -43,6 +44,7 @@ void write(const ProverOutput& prover_output, write_bytes_to_stdout(buf); } else { write_file(output_dir / "vk", buf); + info("VK saved to ", output_dir / "vk"); } break; } @@ -57,6 +59,7 @@ void write(const ProverOutput& prover_output, std::cout << proof_json; } else { write_file(output_dir / "proof_fields.json", { proof_json.begin(), proof_json.end() }); + info("Proof fields saved to ", output_dir / "proof_fields.json"); } break; } @@ -66,6 +69,7 @@ void write(const ProverOutput& prover_output, std::cout << vk_json; } else { write_file(output_dir / "vk_fields.json", { vk_json.begin(), vk_json.end() }); + info("VK fields saved to ", output_dir / "vk_fields.json"); } break; } diff --git a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp index e2da9902b9bb..bf23c6f7a0e8 100644 --- a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp +++ b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp @@ -76,11 +76,11 @@ template class DeciderProvingKey_ { } } - info("Finalized circuit size: ", - circuit.num_gates, - ". Log dyadic circuit size: ", - numeric::get_msb(dyadic_circuit_size), - "."); + vinfo("Finalized circuit size: ", + circuit.num_gates, + ". Log dyadic circuit size: ", + numeric::get_msb(dyadic_circuit_size), + "."); circuit.blocks.compute_offsets(is_structured); // compute offset of each block within the trace // Find index of last non-trivial wire value in the trace From 2bef34a348d6ddf6b13ad1b024c3694a96166119 Mon Sep 17 00:00:00 2001 From: saleel Date: Fri, 28 Feb 2025 16:15:56 +0000 Subject: [PATCH 2/2] update logs --- barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp | 6 +++++- .../cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp | 6 +----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp b/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp index 76b337eae74c..1abd9759a2ef 100644 --- a/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp +++ b/barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp @@ -110,7 +110,11 @@ bool _verify(const bool honk_recursion_2, const std::filesystem::path& proof_pat verified = verifier.verify_proof(proof); } - verified ? info("Proof verified successfully") : info("Proof verification failed"); + if (verified) { + info("Proof verified successfully"); + } else { + info("Proof verification failed"); + } return verified; } diff --git a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp index bf23c6f7a0e8..8819ce408cec 100644 --- a/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp +++ b/barretenberg/cpp/src/barretenberg/ultra_honk/decider_proving_key.hpp @@ -76,11 +76,7 @@ template class DeciderProvingKey_ { } } - vinfo("Finalized circuit size: ", - circuit.num_gates, - ". Log dyadic circuit size: ", - numeric::get_msb(dyadic_circuit_size), - "."); + info("Finalized circuit size: ", circuit.num_gates); circuit.blocks.compute_offsets(is_structured); // compute offset of each block within the trace // Find index of last non-trivial wire value in the trace