From 0ff818a6bfa1313e4692c38c9e0db052bff48f96 Mon Sep 17 00:00:00 2001
From: lucasxia01 <lucasxia01@gmail.com>
Date: Wed, 22 Jan 2025 16:39:23 +0000
Subject: [PATCH 1/2] fix pub inputs

---
 .../cpp/src/barretenberg/vm/avm/trace/helper.hpp         | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp b/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
index 101487752f25..ade0ed0940d8 100644
--- a/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
+++ b/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
@@ -162,6 +162,15 @@ template <typename FF_> VmPublicInputs_<FF_> convert_public_inputs(std::vector<F
         ko_side_effect[dest_offset] = public_inputs_vec[pcpi_offset + 1];
         ko_metadata[dest_offset] = public_inputs_vec[pcpi_offset + 2];
     }
+    // // TODO(#11426): Fix public input columns.
+    // if constexpr (!std::same_as<FF_, field<Bn254FrParams>>) {
+    //     auto ctx = public_inputs_vec[0].get_context();
+    //     for (size_t i = 0; i < KERNEL_OUTPUTS_LENGTH; i++) {
+    //         ko_values[i] = FF_::from_witness(ctx, 0);
+    //         ko_side_effect[i] = FF_::from_witness(ctx, 0);
+    //         ko_metadata[i] = FF_::from_witness(ctx, 0);
+    //     }
+    // }
 
     return public_inputs;
 }

From 97305c90649c4615f9071780d2962e496981d5fe Mon Sep 17 00:00:00 2001
From: lucasxia01 <lucasxia01@gmail.com>
Date: Wed, 22 Jan 2025 16:43:43 +0000
Subject: [PATCH 2/2] uncomment

---
 .../src/barretenberg/vm/avm/trace/helper.hpp   | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp b/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
index ade0ed0940d8..c596d52d1979 100644
--- a/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
+++ b/barretenberg/cpp/src/barretenberg/vm/avm/trace/helper.hpp
@@ -162,15 +162,15 @@ template <typename FF_> VmPublicInputs_<FF_> convert_public_inputs(std::vector<F
         ko_side_effect[dest_offset] = public_inputs_vec[pcpi_offset + 1];
         ko_metadata[dest_offset] = public_inputs_vec[pcpi_offset + 2];
     }
-    // // TODO(#11426): Fix public input columns.
-    // if constexpr (!std::same_as<FF_, field<Bn254FrParams>>) {
-    //     auto ctx = public_inputs_vec[0].get_context();
-    //     for (size_t i = 0; i < KERNEL_OUTPUTS_LENGTH; i++) {
-    //         ko_values[i] = FF_::from_witness(ctx, 0);
-    //         ko_side_effect[i] = FF_::from_witness(ctx, 0);
-    //         ko_metadata[i] = FF_::from_witness(ctx, 0);
-    //     }
-    // }
+    // TODO(#11426): Fix public input columns.
+    if constexpr (!std::same_as<FF_, field<Bn254FrParams>>) {
+        auto ctx = public_inputs_vec[0].get_context();
+        for (size_t i = 0; i < KERNEL_OUTPUTS_LENGTH; i++) {
+            ko_values[i] = FF_::from_witness(ctx, 0);
+            ko_side_effect[i] = FF_::from_witness(ctx, 0);
+            ko_metadata[i] = FF_::from_witness(ctx, 0);
+        }
+    }
 
     return public_inputs;
 }