diff --git a/barretenberg/cpp/src/barretenberg/relations/utils.hpp b/barretenberg/cpp/src/barretenberg/relations/utils.hpp index 846fc1d5f9c8..905ddfe310f1 100644 --- a/barretenberg/cpp/src/barretenberg/relations/utils.hpp +++ b/barretenberg/cpp/src/barretenberg/relations/utils.hpp @@ -158,7 +158,7 @@ template class RelationUtils { { constexpr_for<0, NUM_RELATIONS, 1>([&]() { // FIXME: You wan't /*consider_skipping=*/false here, but tests need to be fixed. - accumulate_single_relation( + accumulate_single_relation( evaluations, relation_evaluations, relation_parameters, partial_evaluation_result); }); } diff --git a/barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.test.cpp b/barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.test.cpp index 4d8aeee3c962..b46df3cfa836 100644 --- a/barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.test.cpp +++ b/barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.test.cpp @@ -211,17 +211,22 @@ template class SumcheckTests : public ::testing::Test { auto r = FF::random_element(); std::array z_perm = { 0, 0, 0, 0, 0, 0, z_1, z_2 }; - std::array lookup_inverses = { 0, 0, 0, 0, 0, 0, r * r, r }; - + std::array lookup_inverses = { 0, 0, 0, 0, 0, r, r * r, r * r * r }; + // To avoid triggering the skipping mechanism in LogDerivativeRelation, we have to ensure + // that the condition (in.q_lookup.is_zero() && in.lookup_read_counts.is_zero()) is not satisfied in the + // blinded rows + std::array skipping_disabler = { 0, 0, 0, 0, 0, 1, 1, 1 }; full_polynomials.z_perm = bb::Polynomial(z_perm); full_polynomials.lookup_inverses = bb::Polynomial(lookup_inverses); - + full_polynomials.lookup_read_counts = bb::Polynomial(skipping_disabler); if constexpr (std::is_same::value) { - std::array ecc_op_wire = { 0, 0, 0, 0, 0, 0, r * r * r, w_4[6] }; - std::array return_data_inverses = { 0, 0, 0, 0, 0, 0, FF(7) * r * r, -r }; - - full_polynomials.ecc_op_wire_1 = bb::Polynomial(ecc_op_wire); + std::array return_data_inverses = { 0, 0, 0, 0, 0, 0, r * r, -r }; full_polynomials.return_data_inverses = bb::Polynomial(return_data_inverses); + + // To avoid triggering the skipping mechanism in DatabusLookupRelation, we have to ensure that the + // condition (in.calldata_read_counts.is_zero() && in.secondary_calldata_read_counts.is_zero() && + // in.return_data_read_counts.is_zero()) is not satisfied in the blinded rows + full_polynomials.calldata_read_counts = bb::Polynomial(skipping_disabler); } } full_polynomials.w_l = bb::Polynomial(w_l);