Closed
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
f6c3c47 to
c4c75ad
Compare
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
b97b0e3 to
440e035
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
c4c75ad to
1ac86e6
Compare
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
440e035 to
d9c7276
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
3 times, most recently
from
e16a87f to
88087d0
Compare
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
d9c7276 to
18a4dd2
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
88087d0 to
9bd4ea0
Compare
Thunkar
reviewed
Dec 9, 2024
| { | ||
| let target = call_interface.get_contract_address(); | ||
| let inputs = cheatcodes::get_private_context_inputs(get_block_number()); | ||
| let inputs = cheatcodes::get_private_context_inputs(get_block_number() - 1); |
Contributor
There was a problem hiding this comment.
Careful!
We used to do this because this.blockNumber in TXE means "the block I'm currently building" and we set the private context to "-1" so that we could do historical proofs.
Will this change break that flow?
Thunkar
reviewed
Dec 9, 2024
Contributor
Thunkar
left a comment
Thunkar
left a comment
There was a problem hiding this comment.
Nice job! However I think this shows we really need a refactor and have some sort of TXE state machine that keeps track of the (now a lot more realistic) execution model.
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
18a4dd2 to
c3063fe
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
9bd4ea0 to
1edc61a
Compare
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
c3063fe to
9b416fa
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
1edc61a to
e1e9691
Compare
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
9b416fa to
5f7d7a0
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
e1e9691 to
b5ca51b
Compare
sklppy88
force-pushed
the
ek/feat/txe-oracle-correct-log-emission-and-storage
branch
from
5f7d7a0 to
f68a7fc
Compare
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
b5ca51b to
e77b0f1
Compare
Base automatically changed from
ek/feat/txe-oracle-correct-log-emission-and-storage
to
master
December 12, 2024 08:25
sklppy88
force-pushed
the
ek/feat/txe-native-world-state-2
branch
from
e77b0f1 to
a1cf14c
Compare
sklppy88
added a commit
that referenced
this pull request
Jan 30, 2025
Please see [this](#10478) PR. Decided to start fresh as there was a bunch of conflicts after coming back from hols.
Contributor
Author
|
Closing in favor of #11226, will start working on the state model as well next. |
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Jan 31, 2025
Please see [this](AztecProtocol/aztec-packages#10478) PR. Decided to start fresh as there was a bunch of conflicts after coming back from hols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinging @Thunkar, the TXE (and generally)👨🔬.
The biggest difference between old world state and new world state is that during the synching of blocks, the changes made to the trees MUST match the block itself. This gave me a bit of pain because it now has to more accurately model the side effect emission / collection of what happens in a tx.
Particular things to pay attention to:
Continued in this PR due to starting fresh after hols.