chore(ts): replace tslint with eslint

Author: steabert

.eslintrc.json

@@ -0,0 +1,19 @@
+{
+  "extends": [
+    "plugin:@typescript-eslint/recommended",
+    "prettier",
+    "prettier/@typescript-eslint"
+  ],
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "project": "./tsconfig.json"
+  },
+  "plugins": ["@typescript-eslint"],
+  "rules": {
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/explicit-member-accessibility": "off",
+    "@typescript-eslint/camelcase": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "@typescript-eslint/array-type": ["error", "array-simple"]
+  }
+}

lib/components/auth/www-authenticate.ts

@@ -6,15 +6,15 @@ export interface Challenge {
 }
 
 export const parseWWWAuthenticate = (header: string): Challenge => {
-  const [dummy, type, ...challenge] = header.split(' ')
+  const [, type, ...challenge] = header.split(' ')
 
-  const pairs: [string, string][] = []
+  const pairs: Array<[string, string]> = []
   const re = /\s*([^=]+)=\"([^\"]*)\",?/gm
   let match
   do {
     match = re.exec(challenge.join(' '))
     if (match !== null) {
-      const [full, key, value] = match
+      const [, key, value] = match
       pairs.push([key, value])
     }
   } while (match !== null)

lib/components/component.ts

@@ -1,6 +1,6 @@
 import { Duplex, PassThrough, Readable, Stream, Writable } from 'stream'
 import StreamFactory from './helpers/stream-factory'
-import { Message, MessageHandler, GenericMessage } from './message'
+import { MessageHandler, GenericMessage } from './message'
 
 export type Component = Source | Tube | Sink
 

lib/components/mp4muxer/helpers/isom.ts

@@ -254,7 +254,7 @@ const createParameterSetArrayClass = function(sizeMask = 0x00) {
       }
     }
 
-    load: BufferMutation = (buffer, offset) => {
+    load: BufferMutation = () => {
       /** noop */
     }
   }
@@ -267,7 +267,7 @@ interface BoxSpec {
   mandatory?: boolean
   quantity?: string
   box: 'Box' | 'FullBox' | 'None'
-  body?: [string, any, any?][]
+  body?: Array<[string, any, any?]>
   config?: any
 }
 

lib/utils/config.ts

@@ -1,4 +1,4 @@
-export interface IConfigObject {
+export interface ConfigOptions {
   [key: string]: any
 }
 
@@ -8,20 +8,20 @@ export interface IConfigObject {
  * @param  {Object} override The object with override values.
  * @return {Object}          The template object with override merged in.
  */
-export const merge = <T extends IConfigObject>(template: T, override: T): T => {
+export const merge = <T extends ConfigOptions>(template: T, override: T): T => {
   let cleanOverride
   if (override !== undefined) {
     if (typeof override !== 'object') {
       throw new Error('merge expects override to be an object!')
     } else {
       cleanOverride = Object.keys(override).reduce(
-        (acc, key) => {
+        (acc: ConfigOptions, key) => {
           if (override[key] !== undefined) {
             acc[key] = override[key]
           }
           return acc
         },
-        {} as IConfigObject,
+        {},
       )
     }
   }

lib/utils/protocols/sdp.ts

@@ -1,3 +1,7 @@
+import { Session } from 'inspector'
+import { MessageType, SdpMessage } from '../../components/message'
+import { NtpSeconds, seconds } from './ntp'
+
 /**
  * The session description protocol (SDP).
  *
@@ -211,7 +215,7 @@ export interface AACMedia extends AudioMedia {
 
 export interface Sdp {
   readonly session: Session
-  readonly media: ReadonlyArray<MediaDescription>
+  readonly media: MediaDescription[]
 }
 
 const extractLineVals = (buffer: Buffer, lineStart: string, start = 0) => {
@@ -426,10 +430,6 @@ export const parse = (buffer: Buffer): Sdp => {
   return struct as Sdp
 }
 
-import { Session } from 'inspector'
-import { MessageType, SdpMessage } from '../../components/message'
-import { NtpSeconds, seconds } from './ntp'
-
 export const messageFromBuffer = (buffer: Buffer): SdpMessage => {
   return {
     type: MessageType.SDP,

lib/utils/scheduler.ts

@@ -1,4 +1,4 @@
-export interface IClock {
+export interface Clock {
   readonly currentTime: number
   readonly play: () => void
   readonly pause: () => void
@@ -35,7 +35,7 @@ const DEFAULT_TOLERANCE = 10
  */
 
 export default class Scheduler<T extends { readonly ntpTimestamp?: number }> {
-  private _clock: IClock
+  private _clock: Clock
   private _handler: (msg: T) => void
   private _tolerance: number
   private _nextRun: number
@@ -52,7 +52,7 @@ export default class Scheduler<T extends { readonly ntpTimestamp?: number }> {
    * @memberof Scheduler
    */
   constructor(
-    clock: IClock,
+    clock: Clock,
     handler: (msg: T) => void,
     tolerance = DEFAULT_TOLERANCE,
   ) {
@@ -148,10 +148,14 @@ export default class Scheduler<T extends { readonly ntpTimestamp?: number }> {
     }
     // There is at least one message in the FIFO queue, either
     // display it, or re-schedule the method for later execution
-    let timeToPresent: number = 0
+    let timeToPresent = 0
     let currentMessage: T
     do {
-      currentMessage = this._fifo.shift()!
+      const msg = this._fifo.shift()
+      if (msg === undefined) {
+        throw new Error('internal error: message should never be undefined')
+      }
+      currentMessage = msg
       const ntpTimestamp = currentMessage.ntpTimestamp
       if (ntpTimestamp === undefined) {
         continue

package.json

@@ -11,7 +11,7 @@
     "live": "examples/node/player.js"
   },
   "scripts": {
-    "lint": "tslint --project tsconfig.json --format stylish",
+    "lint": "eslint --ext '.ts,.js' lib/",
     "test": "jest --coverage",
     "verify": "yarn lint && yarn test",
     "build": "yarn build:esm && yarn build:cjs && yarn build:bundle",
@@ -47,18 +47,22 @@
     "@types/jest": "24.0.15",
     "@types/node": "12.0.10",
     "@types/ws": "6.0.1",
+    "@typescript-eslint/eslint-plugin": "1.10.2",
+    "@typescript-eslint/parser": "1.10.2",
     "babel-loader": "8.0.6",
     "core-js": "3.1.4",
     "cypress": "3.3.1",
+    "eslint": "5.0.0",
+    "eslint-config-prettier": "5.0.0",
+    "eslint-plugin-import": "^2.17.3",
+    "eslint-plugin-node": "^9.1.0",
+    "eslint-plugin-promise": "^4.1.1",
     "http-server": "0.11.1",
     "jest": "24.8.0",
     "md5.js": "1.3.5",
     "mock-socket": "8.0.5",
     "prettier": "1.18.2",
     "ts-jest": "24.0.2",
-    "tslint": "5.18.0",
-    "tslint-config-prettier": "1.18.0",
-    "tslint-config-standard": "8.0.1",
     "typescript": "3.5.2",
     "webpack": "4.35.0",
     "webpack-cli": "3.3.5"