fix: use union Message type for MessageHandler

Steven · Steven · commit bda70ef700d9 · 2020-02-06T20:17:45.000+01:00
diff --git a/lib/components/message.ts b/lib/components/message.ts
@@ -93,4 +93,4 @@ export type Message =
   | XmlMessage
   | JpegMessage
 
-export type MessageHandler = (msg: GenericMessage) => void
+export type MessageHandler = (msg: Message) => void
diff --git a/lib/pipelines/html5-video-metadata-pipeline.ts b/lib/pipelines/html5-video-metadata-pipeline.ts
@@ -24,7 +24,7 @@ export class Html5VideoMetadataPipeline extends Html5VideoPipeline {
 
     const onvifHandlerPipe = Tube.fromHandlers(msg => {
       if (msg.type === MessageType.XML) {
-        metadataHandler(msg as XmlMessage)
+        metadataHandler(msg)
       }
     }, undefined)
     this.insertAfter(onvifDepay, onvifHandlerPipe)
diff --git a/lib/pipelines/metadata-pipeline.ts b/lib/pipelines/metadata-pipeline.ts
@@ -36,7 +36,7 @@ export class MetadataPipeline extends RtspPipeline {
     this.append(onvifDepay)
     const handlerSink = Sink.fromHandler(msg => {
       if (msg.type === MessageType.XML) {
-        metadataHandler(msg as XmlMessage)
+        metadataHandler(msg)
       }
     })
     this.append(handlerSink)

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export class Html5VideoMetadataPipeline extends Html5VideoPipeline {`
`24`	`24`
`25`	`25`	`const onvifHandlerPipe = Tube.fromHandlers(msg => {`
`26`	`26`	`if (msg.type === MessageType.XML) {`
`27`		`- metadataHandler(msg as XmlMessage)`
	`27`	`+ metadataHandler(msg)`
`28`	`28`	`}`
`29`	`29`	`}, undefined)`
`30`	`30`	`this.insertAfter(onvifDepay, onvifHandlerPipe)`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export class MetadataPipeline extends RtspPipeline {`
`36`	`36`	`this.append(onvifDepay)`
`37`	`37`	`const handlerSink = Sink.fromHandler(msg => {`
`38`	`38`	`if (msg.type === MessageType.XML) {`
`39`		`- metadataHandler(msg as XmlMessage)`
	`39`	`+ metadataHandler(msg)`
`40`	`40`	`}`
`41`	`41`	`})`
`42`	`42`	`this.append(handlerSink)`