Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a distribution folder with minified version and sourcemap #80

Closed
Mintonne opened this issue Jan 10, 2019 · 5 comments
Closed

Add a distribution folder with minified version and sourcemap #80

Mintonne opened this issue Jan 10, 2019 · 5 comments
Assignees

Comments

@Mintonne
Copy link

Unminified Minified Compression
File size ~23.44 KB ~8.01 KB ~65%
Gzipped ~7.17 KB ~3.55 KB ~50%

Test here - https://mintonne.github.io/x2js/

annotation 2019-01-10 032435

I have an uglify-js script that creates the minified script and sourcemap.

"dist": "rm -rf dist && mkdir dist && npx uglifyjs x2js.js -o dist\\x2js.min.js -c -m --source-map \"includeSources='true',url='x2js.min.js.map'\""
@Maxouhell Maxouhell self-assigned this Jan 11, 2019
@Maxouhell
Copy link
Contributor

I'll check this ASAP (probably on monday)

@Mintonne
Copy link
Author

Hey @Maxouhell,

Any update on this?

@Maxouhell
Copy link
Contributor

Yep !
I will publish the Typescript version tomorrow.

Sorry for the delay, I had a problem with ES5 bundle.

@Maxouhell
Copy link
Contributor

Hi !
I didn't find out why there is a problem with the bundle...

If I didn't find it out before, tomorrow I will publish a version with uglifyjs, so you can work before I'm solving this.

Maxouhell pushed a commit that referenced this issue Jan 23, 2019
@Maxouhell
Copy link
Contributor

Maxouhell commented Jan 23, 2019

Ok,
According on your fork, I've published the dist/min files in the v3.2.5.

I can't publish the Typescript version for now, but I'll fix it as soon as possible, so expect to see another version happen in the next days.

Dont' hesitate to re-open if you have any problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants