Suggest ElementAt only if type implements IList or IReadOnlyList

[cbersch]

Fixes #51

[coveralls]

coverage: 93.624% (+1.5%) from 92.079%
when pulling cf7e587 on fix-elementat-if-class-implements-ilist
into 051ae44 on main.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ScarletKuro]

I feel weird about this

public IEnumerable<object[]> XYZ()
{
    ...
    yield return new object[] { oldAssertion, newAssertion }
        .Concat(AdditionalParameters)
        .ToArray();
}

We're materializing an IEnumerable into an array and then returning it as an IEnumerable. Why not just return an Array \ IReadOnlyList etc directly instead?

[cbersch]

We're materializing an IEnumerable into an array and then returning it as an IEnumerable. Why not just return an Array \ IReadOnlyList etc directly instead?

This is a bit weird, but note that we return an IEnumerable<object[]>, which is the required type for data-driven tests with MSTest.

The new object[] { oldAssertion, newAssertion }.Concat(AdditionalParameters) .ToArray() creates a single element of the IEnumerable, with content [oldAssertion, newAssertion, AdditionalParameters[0],...].

[ScarletKuro]

Ah, so it's part of the ITestDataSource contract, I didn’t see that from my phone. Okay, makes sense. Since it's just test data, I shouldn't really be concerned about allocation / performance here.