-
Notifications
You must be signed in to change notification settings - Fork 105
Add some missing control themes (SplitButton, DropDownButton, ManagedFileChooser), correct FlyoutPresenter #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TODO: |
Wont fix, its probably avaloniaUI view model issue which cannot hold selected items for view, but the weird thing is it can return result correctly |
|
Is it ready for review or still a draft? |
i set it to draft due to detected issues with ManagedFileChooser, but all source code is ready for use |
SKProCH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall fine
|
alright im going to make some changes to resolve questions |
|
alr any question else or im just merge it? |
Details
This PR will add missing control themes that avaloniaUI shipped new controls
SplitButton,DropDownButton, and a dialog themeManagedFileChooserthat mentioned in pinned issue #234, and correctFlyoutPresenterhad no background brush which should have background brush while other themes do that.Changes
SplitButton.axamlwith Raised (default) and Outline variant, usable Themes:MaterialSplitButton(default),MaterialOutlineSplitButton, both supports.up(default) and.downclasses to change arrow direction, also customise is allowed too by using some tricky style selector to override.DropDownButton.axamlwith Raised (default) and Outline variant, usable Themes:MaterialDropDownButton(default),MaterialOutlineDropDownButtonManagedFileChooser.axamlfrom AvaloniaUI Fluent theme with minor correction, redesigning would be required but it exists at least.<Setter Property="Background" Value="{DynamicResource MaterialPaperBrush}" />to FlyoutPresenterScreenshots