Skip to content

Conversation

@appleneko2001
Copy link
Collaborator

@appleneko2001 appleneko2001 commented May 14, 2025

Details

This PR will add missing control themes that avaloniaUI shipped new controls SplitButton, DropDownButton, and a dialog theme ManagedFileChooser that mentioned in pinned issue #234, and correct FlyoutPresenter had no background brush which should have background brush while other themes do that.

Changes

  • Add SplitButton.axaml with Raised (default) and Outline variant, usable Themes: MaterialSplitButton (default), MaterialOutlineSplitButton, both supports .up (default) and .down classes to change arrow direction, also customise is allowed too by using some tricky style selector to override.
  • Add DropDownButton.axaml with Raised (default) and Outline variant, usable Themes: MaterialDropDownButton (default), MaterialOutlineDropDownButton
  • Add ManagedFileChooser.axaml from AvaloniaUI Fluent theme with minor correction, redesigning would be required but it exists at least.
  • Update Demo buttons and Dialog section with a File Picker API usage (only one yet)
  • Add <Setter Property="Background" Value="{DynamicResource MaterialPaperBrush}" /> to FlyoutPresenter

Screenshots

image
image

@appleneko2001
Copy link
Collaborator Author

TODO: ManagedFileChooser doesn't highlight selected items visually, fix in progress

@appleneko2001
Copy link
Collaborator Author

TODO: ManagedFileChooser doesn't highlight selected items visually, fix in progress

Wont fix, its probably avaloniaUI view model issue which cannot hold selected items for view, but the weird thing is it can return result correctly

@appleneko2001 appleneko2001 requested a review from SKProCH May 14, 2025 23:59
@SKProCH
Copy link
Collaborator

SKProCH commented May 15, 2025

Is it ready for review or still a draft?

@appleneko2001
Copy link
Collaborator Author

Is it ready for review or still a draft?

i set it to draft due to detected issues with ManagedFileChooser, but all source code is ready for use

@appleneko2001 appleneko2001 marked this pull request as ready for review May 15, 2025 00:38
Copy link
Collaborator

@SKProCH SKProCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine

@appleneko2001
Copy link
Collaborator Author

alright im going to make some changes to resolve questions

@appleneko2001
Copy link
Collaborator Author

alr any question else or im just merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants