-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabular Data: support a callback to change unsupported data type to supported one #457
Comments
@FredLL-Avaiga to clarify, we're creating a user callback that alerts users of unsupported type errors and then suggests them to convert the data into a supported type as well? (which the user may accept or declineand fix the data by himself) |
That is not what I had in mind. |
New Quest!A new Quest has been launched in @Avaiga’s repo. Some loot has been stashed in this issue to reward the solver! 🗡 Comment ⚔️ When you submit a PR, comment Questions? Check out the docs. |
Can i work on this? |
@ScalarJerk Do you aim to work on this issue? @eleensmathew You have already been assigned to another issue. |
can i work on this issue? |
@Ujj1225, I am assigning you this issue. Thank you for your contribution! |
@FlorianJacta @FredLL-Avaiga In a file _data_manager.py Can you please provide me more insights on this? |
I will let the R&D answer you. Maybe, @FabienLelaquais can also jump on this discussion |
In the code you can check how we use data_accessors to transform different types of data into tabular data that is handled by our front end component. In that class, we return an _InvalidDataAccessor when we cannot handle the type of data. The aim of this issue is to add a callback to Gui (like on_change or on_action) to let the developer change an unsupported data into a supported data type. I would propose |
So, gui has to get a function where it should let developers set a custom function that defines how to handle and transform unsupported data types? |
Please create a PR and we can discuss on that base |
@quest-bot embark |
@Ujj1225 has embarked on their Quest. 🗡
This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR. Questions? Check out the docs. |
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines. |
This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity. |
What would that feature address
display unsupported data type
Description of the ideal solution
If a dataframe holds a column with unsupported data, we could handle a user callback that would transform that column to a supported type
Caveats
performance ?
Other options
Raise an error (as of today)
Acceptance Criteria
The text was updated successfully, but these errors were encountered: