Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default height for metrics property #2142

Open
1 of 4 tasks
FlorianJacta opened this issue Oct 24, 2024 · 9 comments
Open
1 of 4 tasks

Better default height for metrics property #2142

FlorianJacta opened this issue Oct 24, 2024 · 9 comments
Assignees
Labels
good first issue New-contributor friendly 🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 🥶Waiting for contributor Issues or PRs waiting for a long time

Comments

@FlorianJacta
Copy link
Member

FlorianJacta commented Oct 24, 2024

Description

The height of a metric is taking more than half the available height of my page. This will never be a correct value. (I would also argue the same for the width) A new default height should be defined.

from taipy.gui import Gui
import taipy.gui.builder as tgb

value = 50

with tgb.Page() as page:
    tgb.metric("{value}", type="none")

Gui(page=page).run(title="Frontend Demo")

image

Acceptance Criteria

  • Any new code is covered by a unit tested.
  • Check code coverage is at least 90%.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@FlorianJacta FlorianJacta added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed labels Oct 24, 2024
@sahilborse
Copy link

/attempt @FlorianJacta please assign me this issue i can work on it

@FlorianJacta FlorianJacta added the good first issue New-contributor friendly label Oct 25, 2024
@FlorianJacta
Copy link
Member Author

Here you go @sahilborse

@sahilborse
Copy link

sahilborse commented Oct 25, 2024

@FlorianJacta can you elaborate the issue
As should height be relative to the screen size

@FlorianJacta
Copy link
Member Author

See the other issue here too because it is related: #2141

The goal is to change the default height of the metric viz element

@naaa760
Copy link

naaa760 commented Oct 25, 2024

Hello @FlorianJacta
I want to assign for this issue!
THankyou!

@Manideep-Maddileti
Copy link

hello @FlorianJacta I want to work on this issue can you please assign this issue to me

@PentesterPriyanshu
Copy link

@FlorianJacta i am working on this issue assign to me

@FlorianJacta
Copy link
Member Author

@naaa760 you are assigned tooo

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New-contributor friendly 🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 🥶Waiting for contributor Issues or PRs waiting for a long time
Projects
None yet
Development

No branches or pull requests

5 participants