Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color outline to indicate task execution state in scenario dag #1389

Closed
1 of 2 tasks
AlexandreSajus opened this issue Jun 11, 2024 · 7 comments
Closed
1 of 2 tasks

Color outline to indicate task execution state in scenario dag #1389

AlexandreSajus opened this issue Jun 11, 2024 · 7 comments
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed

Comments

@AlexandreSajus
Copy link
Contributor

Description

The scenario dag tasks could have outline colors to indicate in which state they are in when the scenario is submitted:

  • yellow means "pending"
  • orange means "running"
  • green means "ran"
  • red means "errored"
  • nothing means "not pending"

image

For example, here it would mean that clean_data has ran without issue, predict is currently running and evaluate will be ran afterwards.

This is very similar to a product an INCREDIBLE engineer made (or Zerve):
flow_example

Solution Proposed

No response

Impact of Solution

No response

Additional Context

No response

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@AlexandreSajus AlexandreSajus added Core Related to Taipy Core 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed ✨New feature labels Jun 11, 2024
@jrobinAV
Copy link
Member

jrobinAV commented Jun 12, 2024

This feature is interesting, but I believe we need to have to put it into a global context. We need to redefine global requirements for the dag.

Examples of questions that need to be answered globally:

  • The Orange box is a Task, not a job. There is no such thing as a Task state. You can have a Job status (pending, running, failed, etc.). A Task can be linked to multiple jobs, submitted by multiple users, eventually running simultaneously. Which Job should be chosen to represent in the dag?
  • What is the added value, and for who?
    The two big differences I can see with the tool you showed are the multi-user context and the targeted user. In your picture, you are in a development environment (IDE or notebook). There is only one user concerned, a developer. The UX is easy. The dag control is for a web application for multiple end-users. What is exactly the end user's need related to the job status?

@FlorianJacta
Copy link
Member

You wanted to add features to the DAG. Who was the target of these features?

I agree that we must know what this is for and, most importantly, for whom. In my opinion, it is a better UX to show the progress of your scenario inside the DAG. It is more visual.

We could provide a selector of submissions, and when a submission on the scenario is created, the DAG represents the submission being run.

@FredLL-Avaiga
Copy link
Member

This is implemented. Can you comment on the current implementation?

@AlexandreSajus
Copy link
Contributor Author

What is implemented? I just ran a scenario with develop and the dag does not have color outlines:
image

@FredLL-Avaiga
Copy link
Member

FredLL-Avaiga commented Jul 8, 2024

The tasks change colors when the corresponding job change status

@jrobinAV jrobinAV added 💥Malfunction Addresses an identified problem. and removed ✨New feature labels Jul 26, 2024
@FabienLelaquais
Copy link
Member

@FlorianJacta @AlexandreSajus
Please come up with a (SHORT) code sample.

@FlorianJacta
Copy link
Member

I have not been able to reproduce the issue with different codes.

I guess it has to use the standalone mode for Core. I am closing this issue for now and we'll reopen if it comes back again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Related to Taipy Core 🖰 GUI Related to GUI 💥Malfunction Addresses an identified problem. 🟨 Priority: Medium Not blocking but should be addressed
Projects
None yet
Development

No branches or pull requests

5 participants