Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isolated block editor #56000

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Update isolated block editor #56000

merged 2 commits into from
Sep 10, 2021

Conversation

noahtallen
Copy link
Member

@noahtallen noahtallen commented Sep 3, 2021 •
edited
Loading

Changes proposed in this Pull Request

Update the isolated block editor package to 2.3.

Other required fixes:

Note: This breaks the "Gutenberg for reader" experiment until #54793 lands. I think the benefit of splitting this into a separate PR is better than having gutenberg for reader be broken for a week or two. It's nice to get individual reviews on more focused sets of changes. It's not used by anyone currently, though I do see it being useful to keep the dependency so we can ship it at some point in the future.

Testing instructions

  1. CI

@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2021 •
edited
Loading

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-14613
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-14613&env=jetpack

@noahtallen noahtallen mentioned this pull request Sep 3, 2021
Merged
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-d484542735438767f21015c720dbbb66c13d3e63
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-d484542735438767f21015c720dbbb66c13d3e63&env=jetpack
(These links may take a few minutes to be available)

@noahtallen noahtallen mentioned this pull request Sep 3, 2021
Merged
30 tasks
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit chore/update-isolated-block-editor on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@noahtallen noahtallen force-pushed the chore/update-isolated-block-editor branch from d484542 to a5abb2b Compare September 3, 2021 21:02
@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2021 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~43015 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-gutenboarding      -163128 B  (-8.0%)   -43061 B  (-7.7%)
entry-main                  -635 B  (-0.0%)      +24 B  (+0.0%)
entry-login                  +23 B  (+0.0%)      +71 B  (+0.0%)
entry-domains-landing        +23 B  (+0.0%)      +66 B  (+0.0%)
entry-browsehappy            +23 B  (+0.0%)      +66 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~5234 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
gutenberg-editor                  -6992 B  (-1.7%)    -1372 B  (-1.1%)
reader                            -1461 B  (-0.3%)     -155 B  (-0.1%)
account                           -1175 B  (-0.2%)    -2619 B  (-1.8%)
jetpack-cloud-partner-portal      +1066 B  (+0.5%)      +10 B  (+0.0%)
marketing                          +976 B  (+0.2%)      -56 B  (-0.0%)
email                              +976 B  (+0.2%)      -96 B  (-0.1%)
backup                             -888 B  (-0.1%)      -87 B  (-0.1%)
checkout                           +875 B  (+0.1%)     +656 B  (+0.2%)
plugins                            -825 B  (-0.2%)     -130 B  (-0.1%)
jetpack-connect                    -755 B  (-0.1%)     +252 B  (+0.1%)
hosting                            -735 B  (-0.2%)      -52 B  (-0.1%)
domains                            -672 B  (-0.0%)      +59 B  (+0.0%)
settings                           -545 B  (-0.1%)     +152 B  (+0.1%)
media                              -512 B  (-0.0%)      +50 B  (+0.0%)
marketplace                        -460 B  (-0.1%)      +57 B  (+0.0%)
site-blocks                        -425 B  (-0.1%)    -2295 B  (-2.1%)
privacy                            -425 B  (-0.1%)    -2295 B  (-2.4%)
notification-settings              -425 B  (-0.1%)    -2295 B  (-2.0%)
me                                 -425 B  (-0.1%)    -2295 B  (-2.4%)
help                               -425 B  (-0.1%)    -2295 B  (-1.6%)
happychat                          -425 B  (-0.1%)    -2295 B  (-2.2%)
account-close                      -425 B  (-0.1%)    -2295 B  (-2.2%)
concierge                          -366 B  (-0.1%)    -1989 B  (-2.3%)
security                           -272 B  (-0.1%)    -2218 B  (-1.5%)
settings-writing                   +255 B  (+0.0%)     +396 B  (+0.2%)
plans                              +241 B  (+0.0%)      -41 B  (-0.0%)
earn                               +216 B  (+0.1%)     +113 B  (+0.1%)
purchases                          -194 B  (-0.0%)    -1707 B  (-0.4%)
woocommerce                        +176 B  (+0.1%)       +0 B
people                             +153 B  (+0.0%)      +64 B  (+0.1%)
pages                              +153 B  (+0.0%)      +64 B  (+0.1%)
posts-custom                       +135 B  (+0.0%)      +33 B  (+0.0%)
posts                              +135 B  (+0.0%)      +33 B  (+0.0%)
site-purchases                      -83 B  (-0.0%)      -52 B  (-0.0%)
stats                               -74 B  (-0.0%)     -148 B  (-0.1%)
home                                -74 B  (-0.0%)     -171 B  (-0.1%)
settings-security                   +63 B  (+0.0%)      -16 B  (-0.0%)
settings-performance                +63 B  (+0.0%)      -14 B  (-0.0%)
settings-discussion                 +63 B  (+0.0%)      -13 B  (-0.0%)
jetpack-cloud-pricing               +63 B  (+0.0%)      -58 B  (-0.1%)
devdocs                             -56 B  (-0.0%)      -28 B  (-0.1%)
signup                              +40 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~292565 bytes added 📈 [gzipped])

name                                                      parsed_size            gzip_size
async-load-block-editor                                     +747090 B  (+38.4%)  +269645 B  (+52.3%)
async-load-design-wordpress-components-gallery                -2462 B   (-0.3%)    -1460 B   (-0.8%)
async-load-calypso-components-web-preview-component           -1742 B   (-0.3%)     -354 B   (-0.2%)
async-load-design-blocks                                      -1376 B   (-0.1%)     +170 B   (+0.0%)
async-load-signup-steps-domains                                -906 B   (-0.2%)     -122 B   (-0.1%)
async-load-automattic-search                                   -906 B   (-0.8%)     -120 B   (-0.4%)
async-load-signup-steps-user                                   -888 B   (-0.5%)     -116 B   (-0.2%)
async-load-signup-steps-theme-selection                        -888 B   (-0.7%)      +71 B   (+0.2%)
async-load-signup-steps-test-step                              -888 B   (-1.3%)     -116 B   (-0.6%)
async-load-signup-steps-survey                                 -888 B   (-1.1%)     -116 B   (-0.6%)
async-load-signup-steps-site-type                              -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-site-topic                             -888 B   (-1.0%)     -116 B   (-0.5%)
async-load-signup-steps-site-title                             -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-site-style                             -888 B   (-1.0%)     -116 B   (-0.4%)
async-load-signup-steps-site-picker                            -888 B   (-0.7%)     -116 B   (-0.3%)
async-load-signup-steps-site-or-domain                         -888 B   (-1.1%)     -116 B   (-0.5%)
async-load-signup-steps-site                                   -888 B   (-1.0%)     -116 B   (-0.5%)
async-load-signup-steps-rewind-were-backing                    -888 B   (-1.3%)     -116 B   (-0.6%)
async-load-signup-steps-rewind-migrate                         -888 B   (-1.0%)     -116 B   (-0.5%)
async-load-signup-steps-rewind-form-creds                      -888 B   (-0.8%)     -116 B   (-0.4%)
async-load-signup-steps-rebrand-cities-welcome                 -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-reader-landing                         -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-plans-atomic-store                     -888 B   (-0.4%)     -116 B   (-0.2%)
async-load-signup-steps-passwordless                           -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-p2-site                                -888 B   (-1.0%)     -116 B   (-0.5%)
async-load-signup-steps-p2-details                             -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-import-url-onboarding                  -888 B   (-0.8%)     -116 B   (-0.4%)
async-load-signup-steps-import-url                             -888 B   (-0.9%)     -116 B   (-0.4%)
async-load-signup-steps-import-preview                         -888 B   (-1.0%)     -116 B   (-0.5%)
async-load-signup-steps-emails                                 -888 B   (-1.0%)     -116 B   (-0.5%)
async-load-signup-steps-design-picker                          -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-creds-permission                       -888 B   (-0.9%)     -116 B   (-0.4%)
async-load-signup-steps-creds-confirm                          -888 B   (-0.9%)     -116 B   (-0.4%)
async-load-signup-steps-creds-complete                         -888 B   (-1.3%)     -116 B   (-0.6%)
async-load-signup-steps-clone-start                            -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-clone-ready                            -888 B   (-0.9%)     -116 B   (-0.5%)
async-load-signup-steps-clone-point                            -888 B   (-0.4%)     -116 B   (-0.2%)
async-load-signup-steps-clone-jetpack                          -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-clone-destination                      -888 B   (-1.1%)     -116 B   (-0.6%)
async-load-signup-steps-clone-credentials                      -888 B   (-0.7%)     -116 B   (-0.3%)
async-load-signup-steps-clone-cloning                          -888 B   (-1.2%)     -116 B   (-0.6%)
async-load-signup-steps-about                                  -888 B   (-0.7%)     -127 B   (-0.4%)
async-load-calypso-blocks-jitm-templates-modal                 -705 B   (-0.9%)     +338 B   (+1.5%)
async-load-quick-language-switcher                             -585 B   (-0.4%)       +3 B   (+0.0%)
async-load-calypso-post-editor-editor-media-modal              -512 B   (-0.0%)     +238 B   (+0.1%)
async-load-design-playground                                   -505 B   (-0.0%)      +80 B   (+0.0%)
async-load-design                                              -505 B   (-0.0%)      +80 B   (+0.0%)
async-load-calypso-post-editor-media-modal                     -414 B   (-0.0%)     +733 B   (+0.2%)
async-load-calypso-blocks-editor-checkout-modal                -196 B   (-0.0%)     +195 B   (+0.1%)
async-load-store-app-store-stats-listview                      +183 B   (+0.4%)     +732 B   (+5.7%)
async-load-calypso-my-sites-sidebar                            -183 B   (-0.1%)     -840 B   (-1.3%)
async-load-calypso-my-sites-current-site-domain-warnings       +153 B   (+0.3%)     +102 B   (+0.8%)
async-load-store-app-store-stats-referrers                     +109 B   (+0.1%)     +789 B   (+3.6%)
async-load-store-app-store-stats                               +109 B   (+0.1%)     +789 B   (+1.8%)
async-load-calypso-blocks-jitm                                 +108 B   (+1.1%)      +21 B   (+0.6%)
async-load-signup-steps-plans                                   +25 B   (+0.0%)     -188 B   (-0.2%)
async-load-calypso-reader-site-stream                           -18 B   (-0.0%)       -4 B   (-0.0%)
async-load-calypso-reader-search-stream                         -18 B   (-0.0%)       -4 B   (-0.0%)
async-load-calypso-reader-following-manage                      -18 B   (-0.0%)       -4 B   (-0.0%)
async-load-calypso-reader-feed-stream                           -18 B   (-0.0%)       -4 B   (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@noahtallen noahtallen requested a review from a team September 3, 2021 21:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2021
@fullofcaffeine
Copy link
Contributor

fullofcaffeine commented Sep 4, 2021 •
edited
Loading

Update the isolated block editor package to 2.3.

Were all the changes in .yarnrc.yml required for the isolated-block-editor upgrade to 2.3?

scinos
scinos reviewed Sep 6, 2021
View reviewed changes
client/webpack.config.js Outdated Show resolved Hide resolved
scinos
scinos reviewed Sep 6, 2021
View reviewed changes
.yarnrc.yml Outdated Show resolved Hide resolved
@noahtallen noahtallen force-pushed the chore/update-isolated-block-editor branch 2 times, most recently from 1b79695 to fdd73b9 Compare September 8, 2021 22:11
@noahtallen noahtallen force-pushed the chore/update-isolated-block-editor branch from fdd73b9 to 7c511df Compare September 10, 2021 21:06
@noahtallen noahtallen merged commit 87b4782 into trunk Sep 10, 2021
@noahtallen noahtallen deleted the chore/update-isolated-block-editor branch September 10, 2021 22:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scinos scinos scinos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noahtallen @matticbot @fullofcaffeine @scinos