Webpack: Reqire process.js for polyfills #55971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
In #54793, a dependency is introduced on
lib0
. This causes our webpack build to fail with the following error:Based on some investigation, this happens when
webpack
tries to alias theprocess
variable inlib0/environment.js
. Based on the errorThe extension in the request is mandatory for it to be fully specified
, I changedprocess/browser
polyfill toprocess/browser.js
in our webpack config. This fixed the error in the React 17 PR.Also, according to https://stackoverflow.com/a/65018686, it's helpful to add a dependency on
process
(though I'm not sure if this is needed), and we don't have to add the alias if we useProvidePlugin
.Testing instructions
CI should pass. Also try
yarn start
locally.