Test: Drop whitelist config for server and test folders #4673
Conversation
gziolo
force-pushed
the
test/drop-whitelist-files
branch
from
9097a62 to
8c453e8
Compare
|
I guess we can already take similar step for |
|
Hmm, client test failed. No idea why, I'll look into that tomorrow ;) |
gziolo
force-pushed
the
test/drop-whitelist-files
branch
from
8c453e8 to
6a41f78
Compare
|
Circle CI is green again, but I have no idea why those tests failed before. I couldn't reproduce locally. I dropped now also |
gziolo
force-pushed
the
test/drop-whitelist-files
branch
from
82469ab to
3659822
Compare
gziolo
changed the title
gziolo
added
[Status] Needs Review
| const sandbox = sinon.sandbox.create(); | ||
| let app, config, localRequest; | ||
|
|
||
| before( () => { |
There was a problem hiding this comment.
I prefer to be on a safe side and require all stuff here. I opened follow up #4697 to refactor this very desktop dependent test.
gziolo
force-pushed
the
test/drop-whitelist-files
branch
from
3659822 to
3b4dd45
Compare
| parallel: true | ||
| files: | ||
| - server/**/test/*.js | ||
| - server/**/test/*.jsx | ||
| - NODE_ENV=test make client/config/index.js && MOCHA_FILE=./test-results-tests.xml npm run test-tests -- --reporter=mocha-junit-reporter -w: | ||
| - NODE_ENV=test make client/config/index.js && MOCHA_FILE=./test-results-test.xml npm run test-test -- --reporter=mocha-junit-reporter: |
There was a problem hiding this comment.
can we make the building of the config an earlier part of the run and stop repeating it?
I feel like I tried it and circle did some weird things.. Might be worth trying again to DRY this up.
gziolo
force-pushed
the
test/drop-whitelist-files
branch
from
7dcefac to
eb863cc
Compare
|
I moved config generation to |
|
🚢 |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Part of #4596.
At the moment I removed
test.jsonwhitelist forserverandtestfolder. We need to keep whitelist forclientfolder until we migrate all remaining test folders. To make everything compatible I also changes the way we enabled whitelist. It's now always enabled forclientfolder only.I also renamed npm script for
testfolder fromtest-teststotest-testto align it with other subfolders.Testing
All test runs should pass:
npm run test-clientnpm run test-servernpm run test-testAlso for single test file:
npm run test-client client/lib/accept/test/index.jsnpm run test-test test/test/helpers/use-nock/test/index.jsAnd finally we need to make sure that on Circle CI test runner doesn't run any tests if no test files are provided. Locally it should always load all possible tests when no test files are specified in npm command.